* [PATCH] thermal:hisi_termal: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()
@ 2022-03-24 10:34 Hesham Almatary
2022-03-24 12:11 ` Paul Cercueil
0 siblings, 1 reply; 3+ messages in thread
From: Hesham Almatary @ 2022-03-24 10:34 UTC (permalink / raw)
To: linux-kernel
Cc: linuxarm, jonathan.cameron, paul, rafael, amitk, rui.zhang,
linux-pm, Hesham Almatary
Cleaning up the driver to use pm_sleep_ptr() macro instead of #ifdef
guards is simpler and allows the compiler to remove those functions
if built without CONFIG_PM_SLEEP support.
Signed-off-by: Hesham Almatary <hesham.almatary@huawei.com>
---
drivers/thermal/hisi_thermal.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index 9a21ac0ceb11..b29ab09040d5 100644
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -629,7 +629,6 @@ static int hisi_thermal_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM_SLEEP
static int hisi_thermal_suspend(struct device *dev)
{
struct hisi_thermal_data *data = dev_get_drvdata(dev);
@@ -651,15 +650,14 @@ static int hisi_thermal_resume(struct device *dev)
return ret;
}
-#endif
-static SIMPLE_DEV_PM_OPS(hisi_thermal_pm_ops,
+static DEFINE_SIMPLE_DEV_PM_OPS(hisi_thermal_pm_ops,
hisi_thermal_suspend, hisi_thermal_resume);
static struct platform_driver hisi_thermal_driver = {
.driver = {
.name = "hisi_thermal",
- .pm = &hisi_thermal_pm_ops,
+ .pm = pm_sleep_ptr(&hisi_thermal_pm_ops),
.of_match_table = of_hisi_thermal_match,
},
.probe = hisi_thermal_probe,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal:hisi_termal: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()
2022-03-24 10:34 [PATCH] thermal:hisi_termal: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() Hesham Almatary
@ 2022-03-24 12:11 ` Paul Cercueil
2022-04-13 14:38 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Paul Cercueil @ 2022-03-24 12:11 UTC (permalink / raw)
To: Hesham Almatary
Cc: linux-kernel, linuxarm, jonathan.cameron, rafael, amitk,
rui.zhang, linux-pm
Hi Hesham,
Le jeu., mars 24 2022 at 10:34:43 +0000, Hesham Almatary
<hesham.almatary@huawei.com> a écrit :
> Cleaning up the driver to use pm_sleep_ptr() macro instead of #ifdef
> guards is simpler and allows the compiler to remove those functions
> if built without CONFIG_PM_SLEEP support.
>
> Signed-off-by: Hesham Almatary <hesham.almatary@huawei.com>
Looks good.
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> drivers/thermal/hisi_thermal.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/hisi_thermal.c
> b/drivers/thermal/hisi_thermal.c
> index 9a21ac0ceb11..b29ab09040d5 100644
> --- a/drivers/thermal/hisi_thermal.c
> +++ b/drivers/thermal/hisi_thermal.c
> @@ -629,7 +629,6 @@ static int hisi_thermal_remove(struct
> platform_device *pdev)
> return 0;
> }
>
> -#ifdef CONFIG_PM_SLEEP
> static int hisi_thermal_suspend(struct device *dev)
> {
> struct hisi_thermal_data *data = dev_get_drvdata(dev);
> @@ -651,15 +650,14 @@ static int hisi_thermal_resume(struct device
> *dev)
>
> return ret;
> }
> -#endif
>
> -static SIMPLE_DEV_PM_OPS(hisi_thermal_pm_ops,
> +static DEFINE_SIMPLE_DEV_PM_OPS(hisi_thermal_pm_ops,
> hisi_thermal_suspend, hisi_thermal_resume);
>
> static struct platform_driver hisi_thermal_driver = {
> .driver = {
> .name = "hisi_thermal",
> - .pm = &hisi_thermal_pm_ops,
> + .pm = pm_sleep_ptr(&hisi_thermal_pm_ops),
> .of_match_table = of_hisi_thermal_match,
> },
> .probe = hisi_thermal_probe,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal:hisi_termal: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()
2022-03-24 12:11 ` Paul Cercueil
@ 2022-04-13 14:38 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2022-04-13 14:38 UTC (permalink / raw)
To: Paul Cercueil, Hesham Almatary
Cc: Linux Kernel Mailing List, Linuxarm, Jonathan Cameron,
Rafael J. Wysocki, Amit Kucheria, Zhang, Rui, Linux PM
On Thu, Mar 24, 2022 at 1:11 PM Paul Cercueil <paul@crapouillou.net> wrote:
>
> Hi Hesham,
>
> Le jeu., mars 24 2022 at 10:34:43 +0000, Hesham Almatary
> <hesham.almatary@huawei.com> a écrit :
> > Cleaning up the driver to use pm_sleep_ptr() macro instead of #ifdef
> > guards is simpler and allows the compiler to remove those functions
> > if built without CONFIG_PM_SLEEP support.
> >
> > Signed-off-by: Hesham Almatary <hesham.almatary@huawei.com>
>
> Looks good.
>
> Reviewed-by: Paul Cercueil <paul@crapouillou.net>
And applied as 5.19 material, thanks!
> > ---
> > drivers/thermal/hisi_thermal.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/thermal/hisi_thermal.c
> > b/drivers/thermal/hisi_thermal.c
> > index 9a21ac0ceb11..b29ab09040d5 100644
> > --- a/drivers/thermal/hisi_thermal.c
> > +++ b/drivers/thermal/hisi_thermal.c
> > @@ -629,7 +629,6 @@ static int hisi_thermal_remove(struct
> > platform_device *pdev)
> > return 0;
> > }
> >
> > -#ifdef CONFIG_PM_SLEEP
> > static int hisi_thermal_suspend(struct device *dev)
> > {
> > struct hisi_thermal_data *data = dev_get_drvdata(dev);
> > @@ -651,15 +650,14 @@ static int hisi_thermal_resume(struct device
> > *dev)
> >
> > return ret;
> > }
> > -#endif
> >
> > -static SIMPLE_DEV_PM_OPS(hisi_thermal_pm_ops,
> > +static DEFINE_SIMPLE_DEV_PM_OPS(hisi_thermal_pm_ops,
> > hisi_thermal_suspend, hisi_thermal_resume);
> >
> > static struct platform_driver hisi_thermal_driver = {
> > .driver = {
> > .name = "hisi_thermal",
> > - .pm = &hisi_thermal_pm_ops,
> > + .pm = pm_sleep_ptr(&hisi_thermal_pm_ops),
> > .of_match_table = of_hisi_thermal_match,
> > },
> > .probe = hisi_thermal_probe,
> > --
> > 2.25.1
> >
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-13 14:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-24 10:34 [PATCH] thermal:hisi_termal: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() Hesham Almatary
2022-03-24 12:11 ` Paul Cercueil
2022-04-13 14:38 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.