* [PATCH] cpufreq: sc520_freq: add 'fallthrough' to one case
@ 2021-05-03 16:18 Randy Dunlap
2021-05-04 6:22 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-05-03 16:18 UTC (permalink / raw)
Cc: Randy Dunlap, Rafael J. Wysocki, Viresh Kumar, linux-pm
Quieten an implicit-fallthrough warning in sc520_freq.c:
../drivers/cpufreq/sc520_freq.c: In function 'sc520_freq_get_cpu_frequency':
../include/linux/printk.h:343:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
../drivers/cpufreq/sc520_freq.c:43:3: note: in expansion of macro 'pr_err'
pr_err("error: cpuctl register has unexpected value %02x\n",
../drivers/cpufreq/sc520_freq.c:45:2: note: here
case 0x01:
Fixes: bf6fc9fd2d848 ("[CPUFREQ] AMD Elan SC520 cpufreq driver.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org
---
Found in linux-next but applies to mainline.
drivers/cpufreq/sc520_freq.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210503.orig/drivers/cpufreq/sc520_freq.c
+++ linux-next-20210503/drivers/cpufreq/sc520_freq.c
@@ -42,6 +42,7 @@ static unsigned int sc520_freq_get_cpu_f
default:
pr_err("error: cpuctl register has unexpected value %02x\n",
clockspeed_reg);
+ fallthrough;
case 0x01:
return 100000;
case 0x02:
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: sc520_freq: add 'fallthrough' to one case
2021-05-03 16:18 [PATCH] cpufreq: sc520_freq: add 'fallthrough' to one case Randy Dunlap
@ 2021-05-04 6:22 ` Viresh Kumar
2021-05-18 22:19 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2021-05-04 6:22 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Rafael J. Wysocki, linux-pm
On 03-05-21, 09:18, Randy Dunlap wrote:
> Quieten an implicit-fallthrough warning in sc520_freq.c:
>
> ../drivers/cpufreq/sc520_freq.c: In function 'sc520_freq_get_cpu_frequency':
> ../include/linux/printk.h:343:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
> printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> ../drivers/cpufreq/sc520_freq.c:43:3: note: in expansion of macro 'pr_err'
> pr_err("error: cpuctl register has unexpected value %02x\n",
> ../drivers/cpufreq/sc520_freq.c:45:2: note: here
> case 0x01:
>
> Fixes: bf6fc9fd2d848 ("[CPUFREQ] AMD Elan SC520 cpufreq driver.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: linux-pm@vger.kernel.org
> ---
> Found in linux-next but applies to mainline.
>
> drivers/cpufreq/sc520_freq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210503.orig/drivers/cpufreq/sc520_freq.c
> +++ linux-next-20210503/drivers/cpufreq/sc520_freq.c
> @@ -42,6 +42,7 @@ static unsigned int sc520_freq_get_cpu_f
> default:
> pr_err("error: cpuctl register has unexpected value %02x\n",
> clockspeed_reg);
> + fallthrough;
> case 0x01:
> return 100000;
> case 0x02:
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: sc520_freq: add 'fallthrough' to one case
2021-05-04 6:22 ` Viresh Kumar
@ 2021-05-18 22:19 ` Randy Dunlap
2021-05-21 16:53 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-05-18 22:19 UTC (permalink / raw)
To: Viresh Kumar; +Cc: Rafael J. Wysocki, linux-pm
On 5/3/21 11:22 PM, Viresh Kumar wrote:
> On 03-05-21, 09:18, Randy Dunlap wrote:
>> Quieten an implicit-fallthrough warning in sc520_freq.c:
>>
>> ../drivers/cpufreq/sc520_freq.c: In function 'sc520_freq_get_cpu_frequency':
>> ../include/linux/printk.h:343:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>> ../drivers/cpufreq/sc520_freq.c:43:3: note: in expansion of macro 'pr_err'
>> pr_err("error: cpuctl register has unexpected value %02x\n",
>> ../drivers/cpufreq/sc520_freq.c:45:2: note: here
>> case 0x01:
>>
>> Fixes: bf6fc9fd2d848 ("[CPUFREQ] AMD Elan SC520 cpufreq driver.")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>> Cc: Viresh Kumar <viresh.kumar@linaro.org>
>> Cc: linux-pm@vger.kernel.org
>> ---
>> Found in linux-next but applies to mainline.
>>
>> drivers/cpufreq/sc520_freq.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20210503.orig/drivers/cpufreq/sc520_freq.c
>> +++ linux-next-20210503/drivers/cpufreq/sc520_freq.c
>> @@ -42,6 +42,7 @@ static unsigned int sc520_freq_get_cpu_f
>> default:
>> pr_err("error: cpuctl register has unexpected value %02x\n",
>> clockspeed_reg);
>> + fallthrough;
>> case 0x01:
>> return 100000;
>> case 0x02:
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
Rafael, ping?
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: sc520_freq: add 'fallthrough' to one case
2021-05-18 22:19 ` Randy Dunlap
@ 2021-05-21 16:53 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2021-05-21 16:53 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Viresh Kumar, Rafael J. Wysocki, Linux PM
On Wed, May 19, 2021 at 12:19 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 5/3/21 11:22 PM, Viresh Kumar wrote:
> > On 03-05-21, 09:18, Randy Dunlap wrote:
> >> Quieten an implicit-fallthrough warning in sc520_freq.c:
> >>
> >> ../drivers/cpufreq/sc520_freq.c: In function 'sc520_freq_get_cpu_frequency':
> >> ../include/linux/printk.h:343:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >> printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> >> ../drivers/cpufreq/sc520_freq.c:43:3: note: in expansion of macro 'pr_err'
> >> pr_err("error: cpuctl register has unexpected value %02x\n",
> >> ../drivers/cpufreq/sc520_freq.c:45:2: note: here
> >> case 0x01:
> >>
> >> Fixes: bf6fc9fd2d848 ("[CPUFREQ] AMD Elan SC520 cpufreq driver.")
> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> >> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> >> Cc: linux-pm@vger.kernel.org
> >> ---
> >> Found in linux-next but applies to mainline.
> >>
> >> drivers/cpufreq/sc520_freq.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> --- linux-next-20210503.orig/drivers/cpufreq/sc520_freq.c
> >> +++ linux-next-20210503/drivers/cpufreq/sc520_freq.c
> >> @@ -42,6 +42,7 @@ static unsigned int sc520_freq_get_cpu_f
> >> default:
> >> pr_err("error: cpuctl register has unexpected value %02x\n",
> >> clockspeed_reg);
> >> + fallthrough;
> >> case 0x01:
> >> return 100000;
> >> case 0x02:
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
>
> Rafael, ping?
Applied as 5.14 material, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-21 16:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-03 16:18 [PATCH] cpufreq: sc520_freq: add 'fallthrough' to one case Randy Dunlap
2021-05-04 6:22 ` Viresh Kumar
2021-05-18 22:19 ` Randy Dunlap
2021-05-21 16:53 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.