* [PATCH] acpi/sbshc: Add header file macro definition
@ 2022-07-06 1:32 Li zeming
2022-07-06 10:31 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Li zeming @ 2022-07-06 1:32 UTC (permalink / raw)
To: rafael, lenb; +Cc: linux-acpi, linux-kernel, kernel, Li zeming
Add header file macro definition.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
drivers/acpi/sbshc.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/acpi/sbshc.h b/drivers/acpi/sbshc.h
index 695c390e2884..22b11a1655d2 100644
--- a/drivers/acpi/sbshc.h
+++ b/drivers/acpi/sbshc.h
@@ -1,4 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _SBSHC_H
+#define _SBSHC_H
+
struct acpi_smb_hc;
enum acpi_smb_protocol {
SMBUS_WRITE_QUICK = 2,
@@ -30,3 +33,4 @@ extern int acpi_smbus_write(struct acpi_smb_hc *hc, u8 protocol, u8 slave_addres
extern int acpi_smbus_register_callback(struct acpi_smb_hc *hc,
smbus_alarm_callback callback, void *context);
extern int acpi_smbus_unregister_callback(struct acpi_smb_hc *hc);
+#endif
--
2.18.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] acpi/sbshc: Add header file macro definition
2022-07-06 1:32 [PATCH] acpi/sbshc: Add header file macro definition Li zeming
@ 2022-07-06 10:31 ` Rafael J. Wysocki
2022-07-07 1:17 ` Li zeming
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2022-07-06 10:31 UTC (permalink / raw)
To: Li zeming
Cc: Rafael J. Wysocki, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List, kernel
On Wed, Jul 6, 2022 at 3:34 AM Li zeming <zeming@nfschina.com> wrote:
>
> Add header file macro definition.
Please explain why you want to make this change.
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> drivers/acpi/sbshc.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/acpi/sbshc.h b/drivers/acpi/sbshc.h
> index 695c390e2884..22b11a1655d2 100644
> --- a/drivers/acpi/sbshc.h
> +++ b/drivers/acpi/sbshc.h
> @@ -1,4 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _SBSHC_H
> +#define _SBSHC_H
> +
> struct acpi_smb_hc;
> enum acpi_smb_protocol {
> SMBUS_WRITE_QUICK = 2,
> @@ -30,3 +33,4 @@ extern int acpi_smbus_write(struct acpi_smb_hc *hc, u8 protocol, u8 slave_addres
> extern int acpi_smbus_register_callback(struct acpi_smb_hc *hc,
> smbus_alarm_callback callback, void *context);
> extern int acpi_smbus_unregister_callback(struct acpi_smb_hc *hc);
> +#endif
> --
> 2.18.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] acpi/sbshc: Add header file macro definition
2022-07-06 10:31 ` Rafael J. Wysocki
@ 2022-07-07 1:17 ` Li zeming
0 siblings, 0 replies; 3+ messages in thread
From: Li zeming @ 2022-07-07 1:17 UTC (permalink / raw)
To: rafael; +Cc: kernel, lenb, linux-acpi, linux-kernel, zeming
I think the header file could avoid redefinition errors.
at compile time by adding macro definitions.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-07 1:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 1:32 [PATCH] acpi/sbshc: Add header file macro definition Li zeming
2022-07-06 10:31 ` Rafael J. Wysocki
2022-07-07 1:17 ` Li zeming
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.