From: "Rafael J. Wysocki" <rafael@kernel.org> To: Andy Shevchenko <andy.shevchenko@gmail.com>, Daniel Scally <djrscally@gmail.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Tomasz Figa <tfiga@chromium.org>, Sakari Ailus <sakari.ailus@linux.intel.com>, Rajmohan Mani <rajmohan.mani@intel.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>, Mika Westerberg <mika.westerberg@linux.intel.com>, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Wolfram Sang <wsa@kernel.org>, Lee Jones <lee.jones@linaro.org>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans de Goede <hdegoede@redhat.com>, Mark Gross <mgross@linux.intel.com>, Maximilian Luz <luzmaximilian@gmail.com>, Robert Moore <robert.moore@intel.com>, Erik Kaneda <erik.kaneda@intel.com>, me@fabwu.ch, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, linux-i2c <linux-i2c@vger.kernel.org>, Platform Driver <platform-driver-x86@vger.kernel.org>, "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@acpica.org>, "Rafael J . Wysocki" <rafael@kernel.org> Subject: Re: [PATCH v3 1/6] ACPI: scan: Extend acpi_walk_dep_device_list() Date: Mon, 8 Mar 2021 14:36:27 +0100 [thread overview] Message-ID: <CAJZ5v0ijOhT3PVm6-gqnqycE-YZhD00dGbtK1UEV5nfrOF5Obw@mail.gmail.com> (raw) In-Reply-To: <CAHp75Vc2iwvh1RiYmQDPSvgNvGT_gBcGTK67F+MhWgXyoxqn0A@mail.gmail.com> On Sun, Mar 7, 2021 at 9:39 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sun, Mar 7, 2021 at 3:36 PM Daniel Scally <djrscally@gmail.com> wrote: > > On 22/02/2021 13:34, Andy Shevchenko wrote: > > > On Mon, Feb 22, 2021 at 3:12 PM Daniel Scally <djrscally@gmail.com> wrote: > > >> The acpi_walk_dep_device_list() is not as generalisable as its name > > >> implies, serving only to decrement the dependency count for each > > >> dependent device of the input. Extend the function to instead accept > > >> a callback which can be applied to all the dependencies in acpi_dep_list. > > >> Replace all existing calls to the function with calls to a wrapper, passing > > >> a callback that applies the same dependency reduction. > > > The code looks okay to me, if it was the initial idea, feel free to add > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > > > > > Thank you! > > > > > > >> + */ > > >> +void acpi_dev_flag_dependency_met(acpi_handle handle) > > >> +{ > > > Since it's acpi_dev_* namespace, perhaps it should take struct acpi_device here? > > > > > > I can do this, but I avoided it because in most of the uses in the > > kernel currently there's no struct acpi_device, they're just passing > > ACPI_HANDLE(dev) instead, so I'd need to get the adev with > > ACPI_COMPANION() in each place. It didn't seem worth it... It may not even be possible sometimes, because that function may be called before creating all of the struct acpi_device objects (like in the case of deferred enumeration). > > but happy to > > do it if you'd prefer it that way? > > I see, let Rafael decide then. I'm not pushing here. Well, it's a matter of correctness.
WARNING: multiple messages have this Message-ID (diff)
From: Rafael J. Wysocki <rafael at kernel.org> To: devel@acpica.org Subject: [Devel] Re: [PATCH v3 1/6] ACPI: scan: Extend acpi_walk_dep_device_list() Date: Mon, 08 Mar 2021 14:36:27 +0100 [thread overview] Message-ID: <CAJZ5v0ijOhT3PVm6-gqnqycE-YZhD00dGbtK1UEV5nfrOF5Obw@mail.gmail.com> (raw) In-Reply-To: CAHp75Vc2iwvh1RiYmQDPSvgNvGT_gBcGTK67F+MhWgXyoxqn0A@mail.gmail.com [-- Attachment #1: Type: text/plain, Size: 1730 bytes --] On Sun, Mar 7, 2021 at 9:39 PM Andy Shevchenko <andy.shevchenko(a)gmail.com> wrote: > > On Sun, Mar 7, 2021 at 3:36 PM Daniel Scally <djrscally(a)gmail.com> wrote: > > On 22/02/2021 13:34, Andy Shevchenko wrote: > > > On Mon, Feb 22, 2021 at 3:12 PM Daniel Scally <djrscally(a)gmail.com> wrote: > > >> The acpi_walk_dep_device_list() is not as generalisable as its name > > >> implies, serving only to decrement the dependency count for each > > >> dependent device of the input. Extend the function to instead accept > > >> a callback which can be applied to all the dependencies in acpi_dep_list. > > >> Replace all existing calls to the function with calls to a wrapper, passing > > >> a callback that applies the same dependency reduction. > > > The code looks okay to me, if it was the initial idea, feel free to add > > > Reviewed-by: Andy Shevchenko <andy.shevchenko(a)gmail.com> > > > > > > Thank you! > > > > > > >> + */ > > >> +void acpi_dev_flag_dependency_met(acpi_handle handle) > > >> +{ > > > Since it's acpi_dev_* namespace, perhaps it should take struct acpi_device here? > > > > > > I can do this, but I avoided it because in most of the uses in the > > kernel currently there's no struct acpi_device, they're just passing > > ACPI_HANDLE(dev) instead, so I'd need to get the adev with > > ACPI_COMPANION() in each place. It didn't seem worth it... It may not even be possible sometimes, because that function may be called before creating all of the struct acpi_device objects (like in the case of deferred enumeration). > > but happy to > > do it if you'd prefer it that way? > > I see, let Rafael decide then. I'm not pushing here. Well, it's a matter of correctness.
next prev parent reply other threads:[~2021-03-08 13:37 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-22 13:07 [PATCH v3 0/6] Introduce intel_skl_int3472 module Daniel Scally 2021-02-22 13:07 ` [PATCH v3 1/6] ACPI: scan: Extend acpi_walk_dep_device_list() Daniel Scally 2021-02-22 13:34 ` Andy Shevchenko 2021-02-22 13:34 ` [Devel] " Andy Shevchenko 2021-03-07 13:36 ` Daniel Scally 2021-03-07 20:39 ` Andy Shevchenko 2021-03-07 20:39 ` [Devel] " Andy Shevchenko 2021-03-08 13:36 ` Rafael J. Wysocki [this message] 2021-03-08 13:36 ` Rafael J. Wysocki 2021-03-08 13:57 ` Andy Shevchenko 2021-03-08 13:57 ` [Devel] " Andy Shevchenko 2021-03-08 15:45 ` Rafael J. Wysocki 2021-03-08 15:45 ` [Devel] " Rafael J. Wysocki 2021-03-08 17:23 ` Rafael J. Wysocki 2021-03-08 17:23 ` [Devel] " Rafael J. Wysocki 2021-03-08 20:49 ` Daniel Scally 2021-02-22 13:38 ` Wolfram Sang 2021-03-08 17:46 ` Rafael J. Wysocki 2021-03-08 17:46 ` [Devel] " Rafael J. Wysocki 2021-03-08 20:40 ` Daniel Scally 2021-02-22 13:07 ` [PATCH v3 2/6] ACPI: scan: Add function to fetch dependent of acpi device Daniel Scally 2021-02-22 13:41 ` Andy Shevchenko 2021-02-22 13:41 ` [Devel] " Andy Shevchenko 2021-02-22 13:07 ` [PATCH v3 3/6] i2c: core: Add a format macro for I2C device names Daniel Scally 2021-02-22 13:38 ` Wolfram Sang 2021-02-22 13:07 ` [PATCH v3 4/6] gpiolib: acpi: Export acpi_get_gpiod() Daniel Scally 2021-02-22 13:54 ` Andy Shevchenko 2021-02-22 13:54 ` [Devel] " Andy Shevchenko 2021-02-22 13:07 ` [PATCH v3 5/6] platform/x86: Add intel_skl_int3472 driver Daniel Scally 2021-02-22 13:19 ` Daniel Scally 2021-02-22 13:27 ` Hans de Goede 2021-02-22 22:50 ` Daniel Scally 2021-02-22 14:58 ` Andy Shevchenko 2021-02-22 14:58 ` [Devel] " Andy Shevchenko 2021-02-22 22:35 ` Daniel Scally 2021-02-23 12:01 ` Andy Shevchenko 2021-02-23 12:01 ` [Devel] " Andy Shevchenko 2021-02-23 13:06 ` Daniel Scally 2021-05-17 21:43 ` Daniel Scally 2021-05-17 21:47 ` Andy Shevchenko 2021-05-17 21:47 ` [Devel] " Andy Shevchenko 2021-02-23 20:04 ` Laurent Pinchart 2021-02-23 22:36 ` Daniel Scally 2021-02-24 10:13 ` Laurent Pinchart 2021-02-24 10:18 ` Andy Shevchenko 2021-02-24 10:18 ` [Devel] " Andy Shevchenko 2021-02-24 10:20 ` Daniel Scally 2021-02-22 13:07 ` [PATCH v3 6/6] mfd: tps68470: Remove tps68470 MFD driver Daniel Scally 2021-02-22 14:12 ` Andy Shevchenko 2021-02-22 14:12 ` [Devel] " Andy Shevchenko 2021-02-22 22:37 ` Daniel Scally 2021-03-10 9:33 ` Lee Jones 2021-02-22 13:11 ` [PATCH v3 0/6] Introduce intel_skl_int3472 module Daniel Scally 2021-02-22 14:15 ` Andy Shevchenko 2021-02-22 14:15 ` [Devel] " Andy Shevchenko 2021-03-04 13:37 ` Hans de Goede 2021-03-04 13:49 ` Daniel Scally 2021-03-29 15:03 ` Andy Shevchenko 2021-03-29 20:37 ` Daniel Scally
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJZ5v0ijOhT3PVm6-gqnqycE-YZhD00dGbtK1UEV5nfrOF5Obw@mail.gmail.com \ --to=rafael@kernel.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=andy.shevchenko@gmail.com \ --cc=bgolaszewski@baylibre.com \ --cc=devel@acpica.org \ --cc=djrscally@gmail.com \ --cc=erik.kaneda@intel.com \ --cc=hdegoede@redhat.com \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=lee.jones@linaro.org \ --cc=lenb@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luzmaximilian@gmail.com \ --cc=me@fabwu.ch \ --cc=mgross@linux.intel.com \ --cc=mika.westerberg@linux.intel.com \ --cc=platform-driver-x86@vger.kernel.org \ --cc=rajmohan.mani@intel.com \ --cc=rjw@rjwysocki.net \ --cc=robert.moore@intel.com \ --cc=sakari.ailus@linux.intel.com \ --cc=tfiga@chromium.org \ --cc=wsa@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.