* [PATCH] PM: replace S_IRUGO with octal numbers
@ 2020-02-09 8:34 peng.fan
2020-02-10 0:00 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: peng.fan @ 2020-02-09 8:34 UTC (permalink / raw)
To: rjw, khilman, ulf.hansson, pavel, len.brown
Cc: linux-pm, linux-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Per commit f90774e1fd27 ("checkpatch: look for symbolic permissions
and suggest octal instead"), octal numbers is preferred, so replace
S_IRUGO with octal numbers.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/base/power/domain.c | 2 +-
drivers/base/power/wakeup.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 959d6d5eb000..0a2d0360c014 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -3054,7 +3054,7 @@ static int __init genpd_debug_init(void)
genpd_debugfs_dir = debugfs_create_dir("pm_genpd", NULL);
- debugfs_create_file("pm_genpd_summary", S_IRUGO, genpd_debugfs_dir,
+ debugfs_create_file("pm_genpd_summary", 0444, genpd_debugfs_dir,
NULL, &summary_fops);
list_for_each_entry(genpd, &gpd_list, gpd_list_node) {
diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
index 27f3e60608e5..7970797ad8f6 100644
--- a/drivers/base/power/wakeup.c
+++ b/drivers/base/power/wakeup.c
@@ -1174,7 +1174,7 @@ static const struct file_operations wakeup_sources_stats_fops = {
static int __init wakeup_sources_debugfs_init(void)
{
- debugfs_create_file("wakeup_sources", S_IRUGO, NULL, NULL,
+ debugfs_create_file("wakeup_sources", 0444, NULL, NULL,
&wakeup_sources_stats_fops);
return 0;
}
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PM: replace S_IRUGO with octal numbers
2020-02-09 8:34 [PATCH] PM: replace S_IRUGO with octal numbers peng.fan
@ 2020-02-10 0:00 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-02-10 0:00 UTC (permalink / raw)
To: Peng Fan
Cc: Rafael J. Wysocki, Kevin Hilman, Ulf Hansson, Pavel Machek,
Len Brown, Linux PM, Linux Kernel Mailing List
On Sun, Feb 9, 2020 at 9:39 AM <peng.fan@nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Per commit f90774e1fd27 ("checkpatch: look for symbolic permissions
> and suggest octal instead"),
This applies to new patches.
> octal numbers is preferred, so replace S_IRUGO with octal numbers.
Not really.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-10 0:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-09 8:34 [PATCH] PM: replace S_IRUGO with octal numbers peng.fan
2020-02-10 0:00 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.