* [PATCH][next] ACPICA: iASL: Replace zero-length array with flexible-array member
@ 2022-02-16 20:32 Gustavo A. R. Silva
2022-02-16 20:36 ` Kees Cook
0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2022-02-16 20:32 UTC (permalink / raw)
To: Robert Moore, Rafael J. Wysocki, Len Brown
Cc: linux-acpi, devel, linux-kernel, Gustavo A. R. Silva, linux-hardening
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use “flexible array members”[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/78
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
include/acpi/actbl2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
index 16847c8d9d5f..9ee4d1b39125 100644
--- a/include/acpi/actbl2.h
+++ b/include/acpi/actbl2.h
@@ -2319,7 +2319,7 @@ struct acpi_table_rgrt {
u16 version;
u8 image_type;
u8 reserved;
- u8 image[0];
+ u8 image[];
};
/* image_type values */
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ACPICA: iASL: Replace zero-length array with flexible-array member
2022-02-16 20:32 [PATCH][next] ACPICA: iASL: Replace zero-length array with flexible-array member Gustavo A. R. Silva
@ 2022-02-16 20:36 ` Kees Cook
2022-02-18 19:47 ` [Devel] " Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Kees Cook @ 2022-02-16 20:36 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Robert Moore, Rafael J. Wysocki, Len Brown, linux-acpi, devel,
linux-kernel, linux-hardening
On Wed, Feb 16, 2022 at 02:32:40PM -0600, Gustavo A. R. Silva wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use “flexible array members”[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
>
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
>
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ACPICA: iASL: Replace zero-length array with flexible-array member
@ 2022-02-18 19:47 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2022-02-18 19:47 UTC (permalink / raw)
To: Kees Cook, Gustavo A. R. Silva
Cc: Robert Moore, Rafael J. Wysocki, Len Brown,
ACPI Devel Maling List,
open list:ACPI COMPONENT ARCHITECTURE (ACPICA),
Linux Kernel Mailing List, linux-hardening
On Wed, Feb 16, 2022 at 9:36 PM Kees Cook <keescook@chromium.org> wrote:
>
> On Wed, Feb 16, 2022 at 02:32:40PM -0600, Gustavo A. R. Silva wrote:
> > There is a regular need in the kernel to provide a way to declare
> > having a dynamically sized set of trailing elements in a structure.
> > Kernel code should always use “flexible array members”[1] for these
> > cases. The older style of one-element or zero-length arrays should
> > no longer be used[2].
> >
> > [1] https://en.wikipedia.org/wiki/Flexible_array_member
> > [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
> >
> > Link: https://github.com/KSPP/linux/issues/78
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
I've created an upstream ACPICA pull request for this change, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Devel] Re: [PATCH][next] ACPICA: iASL: Replace zero-length array with flexible-array member
@ 2022-02-18 19:47 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2022-02-18 19:47 UTC (permalink / raw)
To: devel
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
On Wed, Feb 16, 2022 at 9:36 PM Kees Cook <keescook(a)chromium.org> wrote:
>
> On Wed, Feb 16, 2022 at 02:32:40PM -0600, Gustavo A. R. Silva wrote:
> > There is a regular need in the kernel to provide a way to declare
> > having a dynamically sized set of trailing elements in a structure.
> > Kernel code should always use “flexible array members”[1] for these
> > cases. The older style of one-element or zero-length arrays should
> > no longer be used[2].
> >
> > [1] https://en.wikipedia.org/wiki/Flexible_array_member
> > [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
> >
> > Link: https://github.com/KSPP/linux/issues/78
> > Signed-off-by: Gustavo A. R. Silva <gustavoars(a)kernel.org>
>
> Reviewed-by: Kees Cook <keescook(a)chromium.org>
I've created an upstream ACPICA pull request for this change, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ACPICA: iASL: Replace zero-length array with flexible-array member
2022-02-18 19:47 ` [Devel] " Rafael J. Wysocki
(?)
@ 2022-02-18 21:45 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2022-02-18 21:45 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Kees Cook, Robert Moore, Rafael J. Wysocki, Len Brown,
ACPI Devel Maling List,
open list:ACPI COMPONENT ARCHITECTURE (ACPICA),
Linux Kernel Mailing List, linux-hardening
On Fri, Feb 18, 2022 at 08:47:15PM +0100, Rafael J. Wysocki wrote:
> On Wed, Feb 16, 2022 at 9:36 PM Kees Cook <keescook@chromium.org> wrote:
>
> I've created an upstream ACPICA pull request for this change, thanks!
Great.
Thanks, Rafael.
--
Gustavo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-18 21:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 20:32 [PATCH][next] ACPICA: iASL: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2022-02-16 20:36 ` Kees Cook
2022-02-18 19:47 ` Rafael J. Wysocki
2022-02-18 19:47 ` [Devel] " Rafael J. Wysocki
2022-02-18 21:45 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.