* [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS
@ 2021-09-16 17:00 Krzysztof Kozlowski
2021-09-16 17:00 ` [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries Krzysztof Kozlowski
2021-09-21 12:50 ` [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS Hans de Goede
0 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-16 17:00 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Matan Ziv-Av, Hans de Goede,
Mark Gross, linux-acpi, linux-kernel, platform-driver-x86
Cc: Krzysztof Kozlowski
The MODULE_DEVICE_TABLE already creates proper alias for ACPI driver.
Having another MODULE_ALIAS causes the alias to be duplicated.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/platform/x86/lg-laptop.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c
index 3e520d5bca07..4f3ece819f4c 100644
--- a/drivers/platform/x86/lg-laptop.c
+++ b/drivers/platform/x86/lg-laptop.c
@@ -60,7 +60,6 @@ MODULE_ALIAS("wmi:" WMI_EVENT_GUID2);
MODULE_ALIAS("wmi:" WMI_EVENT_GUID3);
MODULE_ALIAS("wmi:" WMI_METHOD_WMAB);
MODULE_ALIAS("wmi:" WMI_METHOD_WMBB);
-MODULE_ALIAS("acpi*:LGEX0815:*");
static struct platform_device *pf_device;
static struct input_dev *wmi_input_dev;
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries
2021-09-16 17:00 [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
@ 2021-09-16 17:00 ` Krzysztof Kozlowski
2021-09-21 12:51 ` Hans de Goede
2021-09-21 12:50 ` [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS Hans de Goede
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-16 17:00 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Matan Ziv-Av, Hans de Goede,
Mark Gross, linux-acpi, linux-kernel, platform-driver-x86
Cc: Krzysztof Kozlowski
BRI0A49 and BDP3336 are already on the list.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/acpi/acpi_pnp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
index 8f2dc176bb41..ffdcfcd4a10d 100644
--- a/drivers/acpi/acpi_pnp.c
+++ b/drivers/acpi/acpi_pnp.c
@@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
{"BRI0A49"}, /* Boca Complete Ofc Communicator 14.4 Data-FAX */
{"BRI1400"}, /* Boca Research 33,600 ACF Modem */
{"BRI3400"}, /* Boca 33.6 Kbps Internal FD34FSVD */
- {"BRI0A49"}, /* Boca 33.6 Kbps Internal FD34FSVD */
- {"BDP3336"}, /* Best Data Products Inc. Smart One 336F PnP Modem */
{"CPI4050"}, /* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */
{"CTL3001"}, /* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */
{"CTL3011"}, /* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS
2021-09-16 17:00 [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2021-09-16 17:00 ` [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries Krzysztof Kozlowski
@ 2021-09-21 12:50 ` Hans de Goede
1 sibling, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2021-09-21 12:50 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rafael J. Wysocki, Len Brown, Matan Ziv-Av,
Mark Gross, linux-acpi, linux-kernel, platform-driver-x86
Hi,
On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote:
> The MODULE_DEVICE_TABLE already creates proper alias for ACPI driver.
> Having another MODULE_ALIAS causes the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/lg-laptop.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c
> index 3e520d5bca07..4f3ece819f4c 100644
> --- a/drivers/platform/x86/lg-laptop.c
> +++ b/drivers/platform/x86/lg-laptop.c
> @@ -60,7 +60,6 @@ MODULE_ALIAS("wmi:" WMI_EVENT_GUID2);
> MODULE_ALIAS("wmi:" WMI_EVENT_GUID3);
> MODULE_ALIAS("wmi:" WMI_METHOD_WMAB);
> MODULE_ALIAS("wmi:" WMI_METHOD_WMBB);
> -MODULE_ALIAS("acpi*:LGEX0815:*");
>
> static struct platform_device *pf_device;
> static struct input_dev *wmi_input_dev;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries
2021-09-16 17:00 ` [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries Krzysztof Kozlowski
@ 2021-09-21 12:51 ` Hans de Goede
2021-09-21 13:08 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2021-09-21 12:51 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rafael J. Wysocki, Len Brown, Matan Ziv-Av,
Mark Gross, linux-acpi, linux-kernel, platform-driver-x86
Hi,
On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote:
> BRI0A49 and BDP3336 are already on the list.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Rafael, I've picked up 1/2 since that applies to a drivers/platform/x86
driver. I'll leave picking this one up to you.
Regards,
Hans
> ---
> drivers/acpi/acpi_pnp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> index 8f2dc176bb41..ffdcfcd4a10d 100644
> --- a/drivers/acpi/acpi_pnp.c
> +++ b/drivers/acpi/acpi_pnp.c
> @@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
> {"BRI0A49"}, /* Boca Complete Ofc Communicator 14.4 Data-FAX */
> {"BRI1400"}, /* Boca Research 33,600 ACF Modem */
> {"BRI3400"}, /* Boca 33.6 Kbps Internal FD34FSVD */
> - {"BRI0A49"}, /* Boca 33.6 Kbps Internal FD34FSVD */
> - {"BDP3336"}, /* Best Data Products Inc. Smart One 336F PnP Modem */
> {"CPI4050"}, /* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */
> {"CTL3001"}, /* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */
> {"CTL3011"}, /* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries
2021-09-21 12:51 ` Hans de Goede
@ 2021-09-21 13:08 ` Rafael J. Wysocki
2021-09-24 16:13 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2021-09-21 13:08 UTC (permalink / raw)
To: Hans de Goede
Cc: Krzysztof Kozlowski, Rafael J. Wysocki, Len Brown, Matan Ziv-Av,
Mark Gross, ACPI Devel Maling List, Linux Kernel Mailing List,
Platform Driver
On Tue, Sep 21, 2021 at 2:52 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote:
> > BRI0A49 and BDP3336 are already on the list.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Rafael, I've picked up 1/2 since that applies to a drivers/platform/x86
> driver. I'll leave picking this one up to you.
I'll pick it up, thanks!
> > ---
> > drivers/acpi/acpi_pnp.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> > index 8f2dc176bb41..ffdcfcd4a10d 100644
> > --- a/drivers/acpi/acpi_pnp.c
> > +++ b/drivers/acpi/acpi_pnp.c
> > @@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
> > {"BRI0A49"}, /* Boca Complete Ofc Communicator 14.4 Data-FAX */
> > {"BRI1400"}, /* Boca Research 33,600 ACF Modem */
> > {"BRI3400"}, /* Boca 33.6 Kbps Internal FD34FSVD */
> > - {"BRI0A49"}, /* Boca 33.6 Kbps Internal FD34FSVD */
> > - {"BDP3336"}, /* Best Data Products Inc. Smart One 336F PnP Modem */
> > {"CPI4050"}, /* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */
> > {"CTL3001"}, /* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */
> > {"CTL3011"}, /* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries
2021-09-21 13:08 ` Rafael J. Wysocki
@ 2021-09-24 16:13 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2021-09-24 16:13 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Hans de Goede, Krzysztof Kozlowski, Rafael J. Wysocki, Len Brown,
Matan Ziv-Av, Mark Gross, ACPI Devel Maling List,
Linux Kernel Mailing List, Platform Driver
On Tue, Sep 21, 2021 at 3:08 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, Sep 21, 2021 at 2:52 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > Hi,
> >
> > On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote:
> > > BRI0A49 and BDP3336 are already on the list.
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >
> > Thanks, patch looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Rafael, I've picked up 1/2 since that applies to a drivers/platform/x86
> > driver. I'll leave picking this one up to you.
>
> I'll pick it up, thanks!
Applied as 5.16 material now, thanks!
> > > ---
> > > drivers/acpi/acpi_pnp.c | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> > > index 8f2dc176bb41..ffdcfcd4a10d 100644
> > > --- a/drivers/acpi/acpi_pnp.c
> > > +++ b/drivers/acpi/acpi_pnp.c
> > > @@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
> > > {"BRI0A49"}, /* Boca Complete Ofc Communicator 14.4 Data-FAX */
> > > {"BRI1400"}, /* Boca Research 33,600 ACF Modem */
> > > {"BRI3400"}, /* Boca 33.6 Kbps Internal FD34FSVD */
> > > - {"BRI0A49"}, /* Boca 33.6 Kbps Internal FD34FSVD */
> > > - {"BDP3336"}, /* Best Data Products Inc. Smart One 336F PnP Modem */
> > > {"CPI4050"}, /* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */
> > > {"CTL3001"}, /* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */
> > > {"CTL3011"}, /* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */
> > >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-24 16:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 17:00 [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2021-09-16 17:00 ` [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries Krzysztof Kozlowski
2021-09-21 12:51 ` Hans de Goede
2021-09-21 13:08 ` Rafael J. Wysocki
2021-09-24 16:13 ` Rafael J. Wysocki
2021-09-21 12:50 ` [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.