All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: okaya@kernel.org
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	"Hunter, Adrian" <adrian.hunter@intel.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	faiz_abbas@ti.com, chunyan.zhang@unisoc.com,
	Jisheng.Zhang@synaptics.com, ludovic.barre@st.com,
	Arnd Bergmann <arnd@arndb.de>,
	alex.smith@imgtec.com, chris.brandt@renesas.com,
	linux-mmc <linux-mmc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI
Date: Wed, 26 Dec 2018 10:40:48 +0100	[thread overview]
Message-ID: <CAJZ5v0jFXvGJH_V9gJ8c3T5x80yYHQmk=0WfJi=vvkSJ_aShwg@mail.gmail.com> (raw)
In-Reply-To: <20181223232521.11320-10-okaya@kernel.org>

On Mon, Dec 24, 2018 at 12:26 AM Sinan Kaya <okaya@kernel.org> wrote:
>
> Select IOSF_MBI only when PCI is set.
>
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
>  drivers/mmc/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index e26b8145efb3..4c5f037b246d 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -117,7 +117,7 @@ config MMC_RICOH_MMC
>  config MMC_SDHCI_ACPI
>         tristate "SDHCI support for ACPI enumerated SDHCI controllers"
>         depends on MMC_SDHCI && ACPI

It should depend on PCI as well, shouldn't it?

As it stands with the patch applied, randconfig can still select it if
PCI is unset AFAICS, can't it?

> -       select IOSF_MBI if X86
> +       select IOSF_MBI if (X86 && PCI)
>         help
>           This selects support for ACPI enumerated SDHCI controllers,
>           identified by ACPI Compatibility ID PNP0D40 or specific
> --

  reply	other threads:[~2018-12-26  9:40 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181223232521.11320-1-okaya@kernel.org>
2018-12-23 23:25 ` [PATCH v3 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 02/11] ata: make PCI dependency explicit for PATA_ACPI Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 03/11] vga-switcheroo: make PCI dependency explicit Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 04/11] platform/x86: intel_ips: " Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 06/11] apple-gmux: " Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 08/11] ASoC: Intel: atom: " Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-26 17:35   ` Pierre-Louis Bossart
2018-12-26 20:07     ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-26  9:40   ` Rafael J. Wysocki [this message]
2018-12-30 18:56     ` Sinan Kaya
2018-12-31  9:40       ` Rafael J. Wysocki
2019-01-02 14:03         ` Adrian Hunter
2019-01-02 14:15           ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-25  9:13   ` Rafael J. Wysocki
2018-12-30 19:04     ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 11/11] drivers: thermal: int340x_thermal: Make PCI dependency explicit Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJZ5v0jFXvGJH_V9gJ8c3T5x80yYHQmk=0WfJi=vvkSJ_aShwg@mail.gmail.com' \
    --to=rafael@kernel.org \
    --cc=Jisheng.Zhang@synaptics.com \
    --cc=adrian.hunter@intel.com \
    --cc=alex.smith@imgtec.com \
    --cc=arnd@arndb.de \
    --cc=chris.brandt@renesas.com \
    --cc=chunyan.zhang@unisoc.com \
    --cc=faiz_abbas@ti.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=ludovic.barre@st.com \
    --cc=okaya@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.