All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@kernel.org>
To: linux-next@vger.kernel.org
Cc: linux-acpi@vger.kernel.org, Sinan Kaya <okaya@kernel.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Jie Yang <yang.jie@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	"moderated list:INTEL ASoC DRIVERS" <alsa-devel@alsa-project.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH v3 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Date: Sun, 23 Dec 2018 23:25:17 +0000	[thread overview]
Message-ID: <20181223232521.11320-9-okaya@kernel.org> (raw)
In-Reply-To: <20181223232521.11320-1-okaya@kernel.org>

Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
CONFIG_PCI set but this is not specified anywhere.

Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
 sound/soc/intel/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 2fd1b61e8331..b0764b2fe001 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
 config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
 	tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
 	default ACPI
-	depends on X86 && ACPI
+	depends on X86 && ACPI && PCI
 	select SND_SST_IPC_ACPI
 	select SND_SST_ATOM_HIFI2_PLATFORM
 	select SND_SOC_ACPI_INTEL_MATCH
-- 
2.19.0

WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@kernel.org>
To: linux-next@vger.kernel.org
Cc: linux-acpi@vger.kernel.org, Sinan Kaya <okaya@kernel.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Jie Yang <yang.jie@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org (moderated list:INTEL ASoC DRIVERS),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Date: Sun, 23 Dec 2018 23:25:17 +0000	[thread overview]
Message-ID: <20181223232521.11320-9-okaya@kernel.org> (raw)
In-Reply-To: <20181223232521.11320-1-okaya@kernel.org>

Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
CONFIG_PCI set but this is not specified anywhere.

Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
 sound/soc/intel/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 2fd1b61e8331..b0764b2fe001 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
 config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
 	tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
 	default ACPI
-	depends on X86 && ACPI
+	depends on X86 && ACPI && PCI
 	select SND_SST_IPC_ACPI
 	select SND_SST_ATOM_HIFI2_PLATFORM
 	select SND_SOC_ACPI_INTEL_MATCH
-- 
2.19.0


  parent reply	other threads:[~2018-12-23 23:25 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181223232521.11320-1-okaya@kernel.org>
2018-12-23 23:25 ` [PATCH v3 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 02/11] ata: make PCI dependency explicit for PATA_ACPI Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 03/11] vga-switcheroo: make PCI dependency explicit Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 04/11] platform/x86: intel_ips: " Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 06/11] apple-gmux: " Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya [this message]
2018-12-23 23:25   ` [PATCH v3 08/11] ASoC: Intel: atom: " Sinan Kaya
2018-12-26 17:35   ` Pierre-Louis Bossart
2018-12-26 20:07     ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-26  9:40   ` Rafael J. Wysocki
2018-12-30 18:56     ` Sinan Kaya
2018-12-31  9:40       ` Rafael J. Wysocki
2019-01-02 14:03         ` Adrian Hunter
2019-01-02 14:15           ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya
2018-12-25  9:13   ` Rafael J. Wysocki
2018-12-30 19:04     ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 11/11] drivers: thermal: int340x_thermal: Make PCI dependency explicit Sinan Kaya
2018-12-23 23:25   ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181223232521.11320-9-okaya@kernel.org \
    --to=okaya@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.