* [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi @ 2021-06-07 17:31 ` Mario Limonciello 0 siblings, 0 replies; 22+ messages in thread From: Mario Limonciello @ 2021-06-07 17:31 UTC (permalink / raw) To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki Cc: open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang, Mario Limonciello, Rafael J . Wysocki Although first implemented for NVME, this check may be usable by other drivers as well. Microsoft's specification explicitly mentions that is may be usable by SATA and AHCI devices. Google also indicates that they have used this with SDHCI in a downstream kernel tree that a user can plug a storage device into. Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro Suggested-by: Keith Busch <kbusch@kernel.org> CC: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com> CC: Alexander Deucher <Alexander.Deucher@amd.com> CC: Rafael J. Wysocki <rjw@rjwysocki.net> CC: Prike Liang <prike.liang@amd.com> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Acked-by: Raul E Rangel <rrangel@chromium.org> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Keith Busch <kbusch@kernel.org> --- drivers/acpi/device_pm.c | 25 +++++++++++++++++++++++++ drivers/nvme/host/pci.c | 28 +--------------------------- include/linux/acpi.h | 5 +++++ 3 files changed, 31 insertions(+), 27 deletions(-) Changes from v4->v5: * Correct extra "Link:" word in commit message Changes from v5->v6: * Add in commit message tags from Raul, Rafael and Keith diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c index d260bc1f3e6e..1edb68d00b8e 100644 --- a/drivers/acpi/device_pm.c +++ b/drivers/acpi/device_pm.c @@ -1340,4 +1340,29 @@ int acpi_dev_pm_attach(struct device *dev, bool power_on) return 1; } EXPORT_SYMBOL_GPL(acpi_dev_pm_attach); + +/** + * acpi_storage_d3 - Check if a storage device should use D3. + * @dev: Device to check + * + * Returns %true if @dev should be put into D3 when the ->suspend method is + * called, else %false. The name of this function is somewhat misleading + * as it has nothing to do with storage except for the name of the ACPI + * property. On some platforms resume will not work if this hint is ignored. + * + */ +bool acpi_storage_d3(struct device *dev) +{ + struct acpi_device *adev = ACPI_COMPANION(dev); + u8 val; + + if (!adev) + return false; + if (fwnode_property_read_u8(acpi_fwnode_handle(adev), "StorageD3Enable", + &val)) + return false; + return val == 1; +} +EXPORT_SYMBOL_GPL(acpi_storage_d3); + #endif /* CONFIG_PM */ diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 3aa7245a505f..8fbc4c87a0d8 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2828,32 +2828,6 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev) return 0; } -#ifdef CONFIG_ACPI -static bool nvme_acpi_storage_d3(struct pci_dev *dev) -{ - struct acpi_device *adev = ACPI_COMPANION(&dev->dev); - u8 val; - - /* - * Look for _DSD property specifying that the storage device on the port - * must use D3 to support deep platform power savings during - * suspend-to-idle. - */ - - if (!adev) - return false; - if (fwnode_property_read_u8(acpi_fwnode_handle(adev), "StorageD3Enable", - &val)) - return false; - return val == 1; -} -#else -static inline bool nvme_acpi_storage_d3(struct pci_dev *dev) -{ - return false; -} -#endif /* CONFIG_ACPI */ - static void nvme_async_probe(void *data, async_cookie_t cookie) { struct nvme_dev *dev = data; @@ -2903,7 +2877,7 @@ static int nvme_probe(struct pci_dev *pdev, const struct pci_device_id *id) quirks |= check_vendor_combination_bug(pdev); - if (!noacpi && nvme_acpi_storage_d3(pdev)) { + if (!noacpi && acpi_storage_d3(&pdev->dev)) { /* * Some systems use a bios work around to ask for D3 on * platforms that support kernel managed suspend. diff --git a/include/linux/acpi.h b/include/linux/acpi.h index c60745f657e9..dd0dafd21e33 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -1004,6 +1004,7 @@ int acpi_dev_resume(struct device *dev); int acpi_subsys_runtime_suspend(struct device *dev); int acpi_subsys_runtime_resume(struct device *dev); int acpi_dev_pm_attach(struct device *dev, bool power_on); +bool acpi_storage_d3(struct device *dev); #else static inline int acpi_subsys_runtime_suspend(struct device *dev) { return 0; } static inline int acpi_subsys_runtime_resume(struct device *dev) { return 0; } @@ -1011,6 +1012,10 @@ static inline int acpi_dev_pm_attach(struct device *dev, bool power_on) { return 0; } +static inline bool acpi_storage_d3(struct device *dev) +{ + return false; +} #endif #if defined(CONFIG_ACPI) && defined(CONFIG_PM_SLEEP) -- 2.25.1 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi @ 2021-06-07 17:31 ` Mario Limonciello 0 siblings, 0 replies; 22+ messages in thread From: Mario Limonciello @ 2021-06-07 17:31 UTC (permalink / raw) To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki Cc: open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang, Mario Limonciello, Rafael J . Wysocki Although first implemented for NVME, this check may be usable by other drivers as well. Microsoft's specification explicitly mentions that is may be usable by SATA and AHCI devices. Google also indicates that they have used this with SDHCI in a downstream kernel tree that a user can plug a storage device into. Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro Suggested-by: Keith Busch <kbusch@kernel.org> CC: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com> CC: Alexander Deucher <Alexander.Deucher@amd.com> CC: Rafael J. Wysocki <rjw@rjwysocki.net> CC: Prike Liang <prike.liang@amd.com> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Acked-by: Raul E Rangel <rrangel@chromium.org> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Keith Busch <kbusch@kernel.org> --- drivers/acpi/device_pm.c | 25 +++++++++++++++++++++++++ drivers/nvme/host/pci.c | 28 +--------------------------- include/linux/acpi.h | 5 +++++ 3 files changed, 31 insertions(+), 27 deletions(-) Changes from v4->v5: * Correct extra "Link:" word in commit message Changes from v5->v6: * Add in commit message tags from Raul, Rafael and Keith diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c index d260bc1f3e6e..1edb68d00b8e 100644 --- a/drivers/acpi/device_pm.c +++ b/drivers/acpi/device_pm.c @@ -1340,4 +1340,29 @@ int acpi_dev_pm_attach(struct device *dev, bool power_on) return 1; } EXPORT_SYMBOL_GPL(acpi_dev_pm_attach); + +/** + * acpi_storage_d3 - Check if a storage device should use D3. + * @dev: Device to check + * + * Returns %true if @dev should be put into D3 when the ->suspend method is + * called, else %false. The name of this function is somewhat misleading + * as it has nothing to do with storage except for the name of the ACPI + * property. On some platforms resume will not work if this hint is ignored. + * + */ +bool acpi_storage_d3(struct device *dev) +{ + struct acpi_device *adev = ACPI_COMPANION(dev); + u8 val; + + if (!adev) + return false; + if (fwnode_property_read_u8(acpi_fwnode_handle(adev), "StorageD3Enable", + &val)) + return false; + return val == 1; +} +EXPORT_SYMBOL_GPL(acpi_storage_d3); + #endif /* CONFIG_PM */ diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 3aa7245a505f..8fbc4c87a0d8 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2828,32 +2828,6 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev) return 0; } -#ifdef CONFIG_ACPI -static bool nvme_acpi_storage_d3(struct pci_dev *dev) -{ - struct acpi_device *adev = ACPI_COMPANION(&dev->dev); - u8 val; - - /* - * Look for _DSD property specifying that the storage device on the port - * must use D3 to support deep platform power savings during - * suspend-to-idle. - */ - - if (!adev) - return false; - if (fwnode_property_read_u8(acpi_fwnode_handle(adev), "StorageD3Enable", - &val)) - return false; - return val == 1; -} -#else -static inline bool nvme_acpi_storage_d3(struct pci_dev *dev) -{ - return false; -} -#endif /* CONFIG_ACPI */ - static void nvme_async_probe(void *data, async_cookie_t cookie) { struct nvme_dev *dev = data; @@ -2903,7 +2877,7 @@ static int nvme_probe(struct pci_dev *pdev, const struct pci_device_id *id) quirks |= check_vendor_combination_bug(pdev); - if (!noacpi && nvme_acpi_storage_d3(pdev)) { + if (!noacpi && acpi_storage_d3(&pdev->dev)) { /* * Some systems use a bios work around to ask for D3 on * platforms that support kernel managed suspend. diff --git a/include/linux/acpi.h b/include/linux/acpi.h index c60745f657e9..dd0dafd21e33 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -1004,6 +1004,7 @@ int acpi_dev_resume(struct device *dev); int acpi_subsys_runtime_suspend(struct device *dev); int acpi_subsys_runtime_resume(struct device *dev); int acpi_dev_pm_attach(struct device *dev, bool power_on); +bool acpi_storage_d3(struct device *dev); #else static inline int acpi_subsys_runtime_suspend(struct device *dev) { return 0; } static inline int acpi_subsys_runtime_resume(struct device *dev) { return 0; } @@ -1011,6 +1012,10 @@ static inline int acpi_dev_pm_attach(struct device *dev, bool power_on) { return 0; } +static inline bool acpi_storage_d3(struct device *dev) +{ + return false; +} #endif #if defined(CONFIG_ACPI) && defined(CONFIG_PM_SLEEP) -- 2.25.1 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v6 2/2] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint 2021-06-07 17:31 ` Mario Limonciello @ 2021-06-07 17:31 ` Mario Limonciello -1 siblings, 0 replies; 22+ messages in thread From: Mario Limonciello @ 2021-06-07 17:31 UTC (permalink / raw) To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki Cc: open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang, Mario Limonciello, Julian Sikorski AMD systems from Renoir and Lucienne require that the NVME controller is put into D3 over a Modern Standby / suspend-to-idle cycle. This is "typically" accomplished using the `StorageD3Enable` property in the _DSD, but this property was introduced after many of these systems launched and most OEM systems don't have it in their BIOS. On AMD Renoir without these drives going into D3 over suspend-to-idle the resume will fail with the NVME controller being reset and a trace like this in the kernel logs: ``` [ 83.556118] nvme nvme0: I/O 161 QID 2 timeout, aborting [ 83.556178] nvme nvme0: I/O 162 QID 2 timeout, aborting [ 83.556187] nvme nvme0: I/O 163 QID 2 timeout, aborting [ 83.556196] nvme nvme0: I/O 164 QID 2 timeout, aborting [ 95.332114] nvme nvme0: I/O 25 QID 0 timeout, reset controller [ 95.332843] nvme nvme0: Abort status: 0x371 [ 95.332852] nvme nvme0: Abort status: 0x371 [ 95.332856] nvme nvme0: Abort status: 0x371 [ 95.332859] nvme nvme0: Abort status: 0x371 [ 95.332909] PM: dpm_run_callback(): pci_pm_resume+0x0/0xe0 returns -16 [ 95.332936] nvme 0000:03:00.0: PM: failed to resume async: error -16 ``` The Microsoft documentation for StorageD3Enable mentioned that Windows has a hardcoded allowlist for D3 support, which was used for these platforms. Introduce quirks to hardcode them for Linux as well. As this property is now "standardized", OEM systems using AMD Cezanne and newer APU's have adopted this property, and quirks like this should not be necessary. CC: Julian Sikorski <belegdol@gmail.com> CC: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com> CC: Alexander Deucher <Alexander.Deucher@amd.com> CC: Rafael J. Wysocki <rjw@rjwysocki.net> CC: Prike Liang <prike.liang@amd.com> Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/acpi/device_pm.c | 3 +++ drivers/acpi/x86/utils.c | 27 +++++++++++++++++++++++++++ include/acpi/acpi_bus.h | 5 +++++ 3 files changed, 35 insertions(+) Changes from v4->v5: * Add this patch back in as it's been made apparent that the system needs to be hardcoded for these. Changes: - Drop Cezanne - it's now covered by StorageD3Enable - Rebase ontop of acpi_storage_d3 outside of NVME Changes from v5->v6: * Move the quirk check into drivers/acpi/x86/ as suggested by Rafael. diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c index 1edb68d00b8e..985c17384192 100644 --- a/drivers/acpi/device_pm.c +++ b/drivers/acpi/device_pm.c @@ -1356,6 +1356,9 @@ bool acpi_storage_d3(struct device *dev) struct acpi_device *adev = ACPI_COMPANION(dev); u8 val; + if (force_storage_d3()) + return true; + if (!adev) return false; if (fwnode_property_read_u8(acpi_fwnode_handle(adev), "StorageD3Enable", diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c index bdc1ba00aee9..2b8d5b3c876f 100644 --- a/drivers/acpi/x86/utils.c +++ b/drivers/acpi/x86/utils.c @@ -135,3 +135,30 @@ bool acpi_device_always_present(struct acpi_device *adev) return ret; } + +/* + * AMD systems from Renoir and Lucienne *require* that the NVME controller + * is put into D3 over a Modern Standby / suspend-to-idle cycle. + * + * This is "typically" accomplished using the `StorageD3Enable` + * property in the _DSD that is checked via the `acpi_storage_d3` function + * but this property was introduced after many of these systems launched + * and most OEM systems don't have it in their BIOS. + * + * The Microsoft documentation for StorageD3Enable mentioned that Windows has + * a hardcoded allowlist for D3 support, which was used for these platforms. + * + * This allows quirking on Linux in a similar fashion. + */ +const struct x86_cpu_id storage_d3_cpu_ids[] = { + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL), /* Renoir */ + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL), /* Lucienne */ + {} +}; + +bool force_storage_d3(void) +{ + if (x86_match_cpu(storage_d3_cpu_ids)) + return true; + return false; +} diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index 3a82faac5767..9b0ddbae5617 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -607,11 +607,16 @@ int acpi_disable_wakeup_device_power(struct acpi_device *dev); #ifdef CONFIG_X86 bool acpi_device_always_present(struct acpi_device *adev); +bool force_storage_d3(void); #else static inline bool acpi_device_always_present(struct acpi_device *adev) { return false; } +static inline bool force_storage_d3(void) +{ + return false; +} #endif #ifdef CONFIG_PM -- 2.25.1 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v6 2/2] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint @ 2021-06-07 17:31 ` Mario Limonciello 0 siblings, 0 replies; 22+ messages in thread From: Mario Limonciello @ 2021-06-07 17:31 UTC (permalink / raw) To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki Cc: open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang, Mario Limonciello, Julian Sikorski AMD systems from Renoir and Lucienne require that the NVME controller is put into D3 over a Modern Standby / suspend-to-idle cycle. This is "typically" accomplished using the `StorageD3Enable` property in the _DSD, but this property was introduced after many of these systems launched and most OEM systems don't have it in their BIOS. On AMD Renoir without these drives going into D3 over suspend-to-idle the resume will fail with the NVME controller being reset and a trace like this in the kernel logs: ``` [ 83.556118] nvme nvme0: I/O 161 QID 2 timeout, aborting [ 83.556178] nvme nvme0: I/O 162 QID 2 timeout, aborting [ 83.556187] nvme nvme0: I/O 163 QID 2 timeout, aborting [ 83.556196] nvme nvme0: I/O 164 QID 2 timeout, aborting [ 95.332114] nvme nvme0: I/O 25 QID 0 timeout, reset controller [ 95.332843] nvme nvme0: Abort status: 0x371 [ 95.332852] nvme nvme0: Abort status: 0x371 [ 95.332856] nvme nvme0: Abort status: 0x371 [ 95.332859] nvme nvme0: Abort status: 0x371 [ 95.332909] PM: dpm_run_callback(): pci_pm_resume+0x0/0xe0 returns -16 [ 95.332936] nvme 0000:03:00.0: PM: failed to resume async: error -16 ``` The Microsoft documentation for StorageD3Enable mentioned that Windows has a hardcoded allowlist for D3 support, which was used for these platforms. Introduce quirks to hardcode them for Linux as well. As this property is now "standardized", OEM systems using AMD Cezanne and newer APU's have adopted this property, and quirks like this should not be necessary. CC: Julian Sikorski <belegdol@gmail.com> CC: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com> CC: Alexander Deucher <Alexander.Deucher@amd.com> CC: Rafael J. Wysocki <rjw@rjwysocki.net> CC: Prike Liang <prike.liang@amd.com> Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/acpi/device_pm.c | 3 +++ drivers/acpi/x86/utils.c | 27 +++++++++++++++++++++++++++ include/acpi/acpi_bus.h | 5 +++++ 3 files changed, 35 insertions(+) Changes from v4->v5: * Add this patch back in as it's been made apparent that the system needs to be hardcoded for these. Changes: - Drop Cezanne - it's now covered by StorageD3Enable - Rebase ontop of acpi_storage_d3 outside of NVME Changes from v5->v6: * Move the quirk check into drivers/acpi/x86/ as suggested by Rafael. diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c index 1edb68d00b8e..985c17384192 100644 --- a/drivers/acpi/device_pm.c +++ b/drivers/acpi/device_pm.c @@ -1356,6 +1356,9 @@ bool acpi_storage_d3(struct device *dev) struct acpi_device *adev = ACPI_COMPANION(dev); u8 val; + if (force_storage_d3()) + return true; + if (!adev) return false; if (fwnode_property_read_u8(acpi_fwnode_handle(adev), "StorageD3Enable", diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c index bdc1ba00aee9..2b8d5b3c876f 100644 --- a/drivers/acpi/x86/utils.c +++ b/drivers/acpi/x86/utils.c @@ -135,3 +135,30 @@ bool acpi_device_always_present(struct acpi_device *adev) return ret; } + +/* + * AMD systems from Renoir and Lucienne *require* that the NVME controller + * is put into D3 over a Modern Standby / suspend-to-idle cycle. + * + * This is "typically" accomplished using the `StorageD3Enable` + * property in the _DSD that is checked via the `acpi_storage_d3` function + * but this property was introduced after many of these systems launched + * and most OEM systems don't have it in their BIOS. + * + * The Microsoft documentation for StorageD3Enable mentioned that Windows has + * a hardcoded allowlist for D3 support, which was used for these platforms. + * + * This allows quirking on Linux in a similar fashion. + */ +const struct x86_cpu_id storage_d3_cpu_ids[] = { + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL), /* Renoir */ + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL), /* Lucienne */ + {} +}; + +bool force_storage_d3(void) +{ + if (x86_match_cpu(storage_d3_cpu_ids)) + return true; + return false; +} diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index 3a82faac5767..9b0ddbae5617 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -607,11 +607,16 @@ int acpi_disable_wakeup_device_power(struct acpi_device *dev); #ifdef CONFIG_X86 bool acpi_device_always_present(struct acpi_device *adev); +bool force_storage_d3(void); #else static inline bool acpi_device_always_present(struct acpi_device *adev) { return false; } +static inline bool force_storage_d3(void) +{ + return false; +} #endif #ifdef CONFIG_PM -- 2.25.1 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH v6 2/2] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint 2021-06-07 17:31 ` Mario Limonciello @ 2021-06-07 17:38 ` Raul Rangel -1 siblings, 0 replies; 22+ messages in thread From: Raul Rangel @ 2021-06-07 17:38 UTC (permalink / raw) To: Mario Limonciello Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, linux-acpi, david.e.box, Shyam Sundar S K, Shah, Nehal-bakulchandra, Alex Deucher, Prike Liang, Julian Sikorski On Mon, Jun 7, 2021 at 11:32 AM Mario Limonciello <mario.limonciello@amd.com> wrote: > > AMD systems from Renoir and Lucienne require that the NVME controller > is put into D3 over a Modern Standby / suspend-to-idle > cycle. This is "typically" accomplished using the `StorageD3Enable` > property in the _DSD, but this property was introduced after many > of these systems launched and most OEM systems don't have it in > their BIOS. > > On AMD Renoir without these drives going into D3 over suspend-to-idle > the resume will fail with the NVME controller being reset and a trace > like this in the kernel logs: > ``` > [ 83.556118] nvme nvme0: I/O 161 QID 2 timeout, aborting > [ 83.556178] nvme nvme0: I/O 162 QID 2 timeout, aborting > [ 83.556187] nvme nvme0: I/O 163 QID 2 timeout, aborting > [ 83.556196] nvme nvme0: I/O 164 QID 2 timeout, aborting > [ 95.332114] nvme nvme0: I/O 25 QID 0 timeout, reset controller > [ 95.332843] nvme nvme0: Abort status: 0x371 > [ 95.332852] nvme nvme0: Abort status: 0x371 > [ 95.332856] nvme nvme0: Abort status: 0x371 > [ 95.332859] nvme nvme0: Abort status: 0x371 > [ 95.332909] PM: dpm_run_callback(): pci_pm_resume+0x0/0xe0 returns -16 > [ 95.332936] nvme 0000:03:00.0: PM: failed to resume async: error -16 > ``` > > The Microsoft documentation for StorageD3Enable mentioned that Windows has > a hardcoded allowlist for D3 support, which was used for these platforms. > Introduce quirks to hardcode them for Linux as well. > > As this property is now "standardized", OEM systems using AMD Cezanne and > newer APU's have adopted this property, and quirks like this should not be > necessary. > > CC: Julian Sikorski <belegdol@gmail.com> > CC: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com> > CC: Alexander Deucher <Alexander.Deucher@amd.com> > CC: Rafael J. Wysocki <rjw@rjwysocki.net> > CC: Prike Liang <prike.liang@amd.com> > Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- It's unfortunate these systems have already shipped. I'm guessing they can't have their firmware updated either. So I guess it's the best option for now. Acked-by: Raul E Rangel <rrangel@chromium.org> ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 2/2] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint @ 2021-06-07 17:38 ` Raul Rangel 0 siblings, 0 replies; 22+ messages in thread From: Raul Rangel @ 2021-06-07 17:38 UTC (permalink / raw) To: Mario Limonciello Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, linux-acpi, david.e.box, Shyam Sundar S K, Shah, Nehal-bakulchandra, Alex Deucher, Prike Liang, Julian Sikorski On Mon, Jun 7, 2021 at 11:32 AM Mario Limonciello <mario.limonciello@amd.com> wrote: > > AMD systems from Renoir and Lucienne require that the NVME controller > is put into D3 over a Modern Standby / suspend-to-idle > cycle. This is "typically" accomplished using the `StorageD3Enable` > property in the _DSD, but this property was introduced after many > of these systems launched and most OEM systems don't have it in > their BIOS. > > On AMD Renoir without these drives going into D3 over suspend-to-idle > the resume will fail with the NVME controller being reset and a trace > like this in the kernel logs: > ``` > [ 83.556118] nvme nvme0: I/O 161 QID 2 timeout, aborting > [ 83.556178] nvme nvme0: I/O 162 QID 2 timeout, aborting > [ 83.556187] nvme nvme0: I/O 163 QID 2 timeout, aborting > [ 83.556196] nvme nvme0: I/O 164 QID 2 timeout, aborting > [ 95.332114] nvme nvme0: I/O 25 QID 0 timeout, reset controller > [ 95.332843] nvme nvme0: Abort status: 0x371 > [ 95.332852] nvme nvme0: Abort status: 0x371 > [ 95.332856] nvme nvme0: Abort status: 0x371 > [ 95.332859] nvme nvme0: Abort status: 0x371 > [ 95.332909] PM: dpm_run_callback(): pci_pm_resume+0x0/0xe0 returns -16 > [ 95.332936] nvme 0000:03:00.0: PM: failed to resume async: error -16 > ``` > > The Microsoft documentation for StorageD3Enable mentioned that Windows has > a hardcoded allowlist for D3 support, which was used for these platforms. > Introduce quirks to hardcode them for Linux as well. > > As this property is now "standardized", OEM systems using AMD Cezanne and > newer APU's have adopted this property, and quirks like this should not be > necessary. > > CC: Julian Sikorski <belegdol@gmail.com> > CC: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com> > CC: Alexander Deucher <Alexander.Deucher@amd.com> > CC: Rafael J. Wysocki <rjw@rjwysocki.net> > CC: Prike Liang <prike.liang@amd.com> > Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- It's unfortunate these systems have already shipped. I'm guessing they can't have their firmware updated either. So I guess it's the best option for now. Acked-by: Raul E Rangel <rrangel@chromium.org> _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 2/2] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint 2021-06-07 17:31 ` Mario Limonciello @ 2021-06-08 6:01 ` Julian Sikorski -1 siblings, 0 replies; 22+ messages in thread From: Julian Sikorski @ 2021-06-08 6:01 UTC (permalink / raw) To: Mario Limonciello, Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki Cc: open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang W dniu 07.06.2021 o 19:31, Mario Limonciello pisze: > AMD systems from Renoir and Lucienne require that the NVME controller > is put into D3 over a Modern Standby / suspend-to-idle > cycle. This is "typically" accomplished using the `StorageD3Enable` > property in the _DSD, but this property was introduced after many > of these systems launched and most OEM systems don't have it in > their BIOS. > > On AMD Renoir without these drives going into D3 over suspend-to-idle > the resume will fail with the NVME controller being reset and a trace > like this in the kernel logs: > ``` > [ 83.556118] nvme nvme0: I/O 161 QID 2 timeout, aborting > [ 83.556178] nvme nvme0: I/O 162 QID 2 timeout, aborting > [ 83.556187] nvme nvme0: I/O 163 QID 2 timeout, aborting > [ 83.556196] nvme nvme0: I/O 164 QID 2 timeout, aborting > [ 95.332114] nvme nvme0: I/O 25 QID 0 timeout, reset controller > [ 95.332843] nvme nvme0: Abort status: 0x371 > [ 95.332852] nvme nvme0: Abort status: 0x371 > [ 95.332856] nvme nvme0: Abort status: 0x371 > [ 95.332859] nvme nvme0: Abort status: 0x371 > [ 95.332909] PM: dpm_run_callback(): pci_pm_resume+0x0/0xe0 returns -16 > [ 95.332936] nvme 0000:03:00.0: PM: failed to resume async: error -16 > ``` > > The Microsoft documentation for StorageD3Enable mentioned that Windows has > a hardcoded allowlist for D3 support, which was used for these platforms. > Introduce quirks to hardcode them for Linux as well. > > As this property is now "standardized", OEM systems using AMD Cezanne and > newer APU's have adopted this property, and quirks like this should not be > necessary. > > CC: Julian Sikorski <belegdol@gmail.com> > CC: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com> > CC: Alexander Deucher <Alexander.Deucher@amd.com> > CC: Rafael J. Wysocki <rjw@rjwysocki.net> > CC: Prike Liang <prike.liang@amd.com> > Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- Tested-by: Julian Sikorski <belegdol@gmail.com> ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 2/2] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint @ 2021-06-08 6:01 ` Julian Sikorski 0 siblings, 0 replies; 22+ messages in thread From: Julian Sikorski @ 2021-06-08 6:01 UTC (permalink / raw) To: Mario Limonciello, Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki Cc: open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang W dniu 07.06.2021 o 19:31, Mario Limonciello pisze: > AMD systems from Renoir and Lucienne require that the NVME controller > is put into D3 over a Modern Standby / suspend-to-idle > cycle. This is "typically" accomplished using the `StorageD3Enable` > property in the _DSD, but this property was introduced after many > of these systems launched and most OEM systems don't have it in > their BIOS. > > On AMD Renoir without these drives going into D3 over suspend-to-idle > the resume will fail with the NVME controller being reset and a trace > like this in the kernel logs: > ``` > [ 83.556118] nvme nvme0: I/O 161 QID 2 timeout, aborting > [ 83.556178] nvme nvme0: I/O 162 QID 2 timeout, aborting > [ 83.556187] nvme nvme0: I/O 163 QID 2 timeout, aborting > [ 83.556196] nvme nvme0: I/O 164 QID 2 timeout, aborting > [ 95.332114] nvme nvme0: I/O 25 QID 0 timeout, reset controller > [ 95.332843] nvme nvme0: Abort status: 0x371 > [ 95.332852] nvme nvme0: Abort status: 0x371 > [ 95.332856] nvme nvme0: Abort status: 0x371 > [ 95.332859] nvme nvme0: Abort status: 0x371 > [ 95.332909] PM: dpm_run_callback(): pci_pm_resume+0x0/0xe0 returns -16 > [ 95.332936] nvme 0000:03:00.0: PM: failed to resume async: error -16 > ``` > > The Microsoft documentation for StorageD3Enable mentioned that Windows has > a hardcoded allowlist for D3 support, which was used for these platforms. > Introduce quirks to hardcode them for Linux as well. > > As this property is now "standardized", OEM systems using AMD Cezanne and > newer APU's have adopted this property, and quirks like this should not be > necessary. > > CC: Julian Sikorski <belegdol@gmail.com> > CC: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com> > CC: Alexander Deucher <Alexander.Deucher@amd.com> > CC: Rafael J. Wysocki <rjw@rjwysocki.net> > CC: Prike Liang <prike.liang@amd.com> > Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- Tested-by: Julian Sikorski <belegdol@gmail.com> _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 2/2] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint 2021-06-07 17:31 ` Mario Limonciello @ 2021-06-08 11:27 ` Rafael J. Wysocki -1 siblings, 0 replies; 22+ messages in thread From: Rafael J. Wysocki @ 2021-06-08 11:27 UTC (permalink / raw) To: Mario Limonciello Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, ACPI Devel Maling List, rrangel, David Box, Shyam Sundar S K, Nehal-bakulchandra.Shah, Alex Deucher, Prike Liang, Julian Sikorski On Mon, Jun 7, 2021 at 7:32 PM Mario Limonciello <mario.limonciello@amd.com> wrote: > > AMD systems from Renoir and Lucienne require that the NVME controller > is put into D3 over a Modern Standby / suspend-to-idle > cycle. This is "typically" accomplished using the `StorageD3Enable` > property in the _DSD, but this property was introduced after many > of these systems launched and most OEM systems don't have it in > their BIOS. > > On AMD Renoir without these drives going into D3 over suspend-to-idle > the resume will fail with the NVME controller being reset and a trace > like this in the kernel logs: > ``` > [ 83.556118] nvme nvme0: I/O 161 QID 2 timeout, aborting > [ 83.556178] nvme nvme0: I/O 162 QID 2 timeout, aborting > [ 83.556187] nvme nvme0: I/O 163 QID 2 timeout, aborting > [ 83.556196] nvme nvme0: I/O 164 QID 2 timeout, aborting > [ 95.332114] nvme nvme0: I/O 25 QID 0 timeout, reset controller > [ 95.332843] nvme nvme0: Abort status: 0x371 > [ 95.332852] nvme nvme0: Abort status: 0x371 > [ 95.332856] nvme nvme0: Abort status: 0x371 > [ 95.332859] nvme nvme0: Abort status: 0x371 > [ 95.332909] PM: dpm_run_callback(): pci_pm_resume+0x0/0xe0 returns -16 > [ 95.332936] nvme 0000:03:00.0: PM: failed to resume async: error -16 > ``` > > The Microsoft documentation for StorageD3Enable mentioned that Windows has > a hardcoded allowlist for D3 support, which was used for these platforms. > Introduce quirks to hardcode them for Linux as well. > > As this property is now "standardized", OEM systems using AMD Cezanne and > newer APU's have adopted this property, and quirks like this should not be > necessary. > > CC: Julian Sikorski <belegdol@gmail.com> > CC: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com> > CC: Alexander Deucher <Alexander.Deucher@amd.com> > CC: Rafael J. Wysocki <rjw@rjwysocki.net> > CC: Prike Liang <prike.liang@amd.com> > Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/acpi/device_pm.c | 3 +++ > drivers/acpi/x86/utils.c | 27 +++++++++++++++++++++++++++ > include/acpi/acpi_bus.h | 5 +++++ > 3 files changed, 35 insertions(+) > > Changes from v4->v5: > * Add this patch back in as it's been made apparent that the > system needs to be hardcoded for these. > Changes: > - Drop Cezanne - it's now covered by StorageD3Enable > - Rebase ontop of acpi_storage_d3 outside of NVME > Changes from v5->v6: > * Move the quirk check into drivers/acpi/x86/ as suggested by > Rafael. > > diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c > index 1edb68d00b8e..985c17384192 100644 > --- a/drivers/acpi/device_pm.c > +++ b/drivers/acpi/device_pm.c > @@ -1356,6 +1356,9 @@ bool acpi_storage_d3(struct device *dev) > struct acpi_device *adev = ACPI_COMPANION(dev); > u8 val; > > + if (force_storage_d3()) > + return true; > + > if (!adev) > return false; > if (fwnode_property_read_u8(acpi_fwnode_handle(adev), "StorageD3Enable", > diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c > index bdc1ba00aee9..2b8d5b3c876f 100644 > --- a/drivers/acpi/x86/utils.c > +++ b/drivers/acpi/x86/utils.c > @@ -135,3 +135,30 @@ bool acpi_device_always_present(struct acpi_device *adev) > > return ret; > } > + > +/* > + * AMD systems from Renoir and Lucienne *require* that the NVME controller > + * is put into D3 over a Modern Standby / suspend-to-idle cycle. > + * > + * This is "typically" accomplished using the `StorageD3Enable` > + * property in the _DSD that is checked via the `acpi_storage_d3` function > + * but this property was introduced after many of these systems launched > + * and most OEM systems don't have it in their BIOS. > + * > + * The Microsoft documentation for StorageD3Enable mentioned that Windows has > + * a hardcoded allowlist for D3 support, which was used for these platforms. > + * > + * This allows quirking on Linux in a similar fashion. > + */ > +const struct x86_cpu_id storage_d3_cpu_ids[] = { > + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL), /* Renoir */ > + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL), /* Lucienne */ > + {} > +}; > + > +bool force_storage_d3(void) > +{ > + if (x86_match_cpu(storage_d3_cpu_ids)) > + return true; > + return false; Well, what about doing return x86_match_cpu(storage_d3_cpu_ids); instead? > +} > diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h > index 3a82faac5767..9b0ddbae5617 100644 > --- a/include/acpi/acpi_bus.h > +++ b/include/acpi/acpi_bus.h > @@ -607,11 +607,16 @@ int acpi_disable_wakeup_device_power(struct acpi_device *dev); > > #ifdef CONFIG_X86 > bool acpi_device_always_present(struct acpi_device *adev); > +bool force_storage_d3(void); This doesn't need to go into acpi_bus.h, because it will only be used in device_pm.c. You may as well put it into drivers/acpi/internal.h. > #else > static inline bool acpi_device_always_present(struct acpi_device *adev) > { > return false; > } > +static inline bool force_storage_d3(void) > +{ > + return false; > +} > #endif > > #ifdef CONFIG_PM > -- ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 2/2] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint @ 2021-06-08 11:27 ` Rafael J. Wysocki 0 siblings, 0 replies; 22+ messages in thread From: Rafael J. Wysocki @ 2021-06-08 11:27 UTC (permalink / raw) To: Mario Limonciello Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, ACPI Devel Maling List, rrangel, David Box, Shyam Sundar S K, Nehal-bakulchandra.Shah, Alex Deucher, Prike Liang, Julian Sikorski On Mon, Jun 7, 2021 at 7:32 PM Mario Limonciello <mario.limonciello@amd.com> wrote: > > AMD systems from Renoir and Lucienne require that the NVME controller > is put into D3 over a Modern Standby / suspend-to-idle > cycle. This is "typically" accomplished using the `StorageD3Enable` > property in the _DSD, but this property was introduced after many > of these systems launched and most OEM systems don't have it in > their BIOS. > > On AMD Renoir without these drives going into D3 over suspend-to-idle > the resume will fail with the NVME controller being reset and a trace > like this in the kernel logs: > ``` > [ 83.556118] nvme nvme0: I/O 161 QID 2 timeout, aborting > [ 83.556178] nvme nvme0: I/O 162 QID 2 timeout, aborting > [ 83.556187] nvme nvme0: I/O 163 QID 2 timeout, aborting > [ 83.556196] nvme nvme0: I/O 164 QID 2 timeout, aborting > [ 95.332114] nvme nvme0: I/O 25 QID 0 timeout, reset controller > [ 95.332843] nvme nvme0: Abort status: 0x371 > [ 95.332852] nvme nvme0: Abort status: 0x371 > [ 95.332856] nvme nvme0: Abort status: 0x371 > [ 95.332859] nvme nvme0: Abort status: 0x371 > [ 95.332909] PM: dpm_run_callback(): pci_pm_resume+0x0/0xe0 returns -16 > [ 95.332936] nvme 0000:03:00.0: PM: failed to resume async: error -16 > ``` > > The Microsoft documentation for StorageD3Enable mentioned that Windows has > a hardcoded allowlist for D3 support, which was used for these platforms. > Introduce quirks to hardcode them for Linux as well. > > As this property is now "standardized", OEM systems using AMD Cezanne and > newer APU's have adopted this property, and quirks like this should not be > necessary. > > CC: Julian Sikorski <belegdol@gmail.com> > CC: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com> > CC: Alexander Deucher <Alexander.Deucher@amd.com> > CC: Rafael J. Wysocki <rjw@rjwysocki.net> > CC: Prike Liang <prike.liang@amd.com> > Link: https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/power-management-for-storage-hardware-devices-intro > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/acpi/device_pm.c | 3 +++ > drivers/acpi/x86/utils.c | 27 +++++++++++++++++++++++++++ > include/acpi/acpi_bus.h | 5 +++++ > 3 files changed, 35 insertions(+) > > Changes from v4->v5: > * Add this patch back in as it's been made apparent that the > system needs to be hardcoded for these. > Changes: > - Drop Cezanne - it's now covered by StorageD3Enable > - Rebase ontop of acpi_storage_d3 outside of NVME > Changes from v5->v6: > * Move the quirk check into drivers/acpi/x86/ as suggested by > Rafael. > > diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c > index 1edb68d00b8e..985c17384192 100644 > --- a/drivers/acpi/device_pm.c > +++ b/drivers/acpi/device_pm.c > @@ -1356,6 +1356,9 @@ bool acpi_storage_d3(struct device *dev) > struct acpi_device *adev = ACPI_COMPANION(dev); > u8 val; > > + if (force_storage_d3()) > + return true; > + > if (!adev) > return false; > if (fwnode_property_read_u8(acpi_fwnode_handle(adev), "StorageD3Enable", > diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c > index bdc1ba00aee9..2b8d5b3c876f 100644 > --- a/drivers/acpi/x86/utils.c > +++ b/drivers/acpi/x86/utils.c > @@ -135,3 +135,30 @@ bool acpi_device_always_present(struct acpi_device *adev) > > return ret; > } > + > +/* > + * AMD systems from Renoir and Lucienne *require* that the NVME controller > + * is put into D3 over a Modern Standby / suspend-to-idle cycle. > + * > + * This is "typically" accomplished using the `StorageD3Enable` > + * property in the _DSD that is checked via the `acpi_storage_d3` function > + * but this property was introduced after many of these systems launched > + * and most OEM systems don't have it in their BIOS. > + * > + * The Microsoft documentation for StorageD3Enable mentioned that Windows has > + * a hardcoded allowlist for D3 support, which was used for these platforms. > + * > + * This allows quirking on Linux in a similar fashion. > + */ > +const struct x86_cpu_id storage_d3_cpu_ids[] = { > + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL), /* Renoir */ > + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL), /* Lucienne */ > + {} > +}; > + > +bool force_storage_d3(void) > +{ > + if (x86_match_cpu(storage_d3_cpu_ids)) > + return true; > + return false; Well, what about doing return x86_match_cpu(storage_d3_cpu_ids); instead? > +} > diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h > index 3a82faac5767..9b0ddbae5617 100644 > --- a/include/acpi/acpi_bus.h > +++ b/include/acpi/acpi_bus.h > @@ -607,11 +607,16 @@ int acpi_disable_wakeup_device_power(struct acpi_device *dev); > > #ifdef CONFIG_X86 > bool acpi_device_always_present(struct acpi_device *adev); > +bool force_storage_d3(void); This doesn't need to go into acpi_bus.h, because it will only be used in device_pm.c. You may as well put it into drivers/acpi/internal.h. > #else > static inline bool acpi_device_always_present(struct acpi_device *adev) > { > return false; > } > +static inline bool force_storage_d3(void) > +{ > + return false; > +} > #endif > > #ifdef CONFIG_PM > -- _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi 2021-06-07 17:31 ` Mario Limonciello @ 2021-06-08 5:35 ` Christoph Hellwig -1 siblings, 0 replies; 22+ messages in thread From: Christoph Hellwig @ 2021-06-08 5:35 UTC (permalink / raw) To: Mario Limonciello Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang, Rafael J . Wysocki On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: > +/** > + * acpi_storage_d3 - Check if a storage device should use D3. > + * @dev: Device to check > + * > + * Returns %true if @dev should be put into D3 when the ->suspend method is > + * called, else %false. The name of this function is somewhat misleading > + * as it has nothing to do with storage except for the name of the ACPI > + * property. On some platforms resume will not work if this hint is ignored. > + * > + */ I still do not like this comment. There is nothing about only using this for storage devices. It is specific to a PCIe slot, and if I plug something that is not a storage device into it the same restrictions still apply. Also no need for the empty-ish line at the end. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi @ 2021-06-08 5:35 ` Christoph Hellwig 0 siblings, 0 replies; 22+ messages in thread From: Christoph Hellwig @ 2021-06-08 5:35 UTC (permalink / raw) To: Mario Limonciello Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang, Rafael J . Wysocki On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: > +/** > + * acpi_storage_d3 - Check if a storage device should use D3. > + * @dev: Device to check > + * > + * Returns %true if @dev should be put into D3 when the ->suspend method is > + * called, else %false. The name of this function is somewhat misleading > + * as it has nothing to do with storage except for the name of the ACPI > + * property. On some platforms resume will not work if this hint is ignored. > + * > + */ I still do not like this comment. There is nothing about only using this for storage devices. It is specific to a PCIe slot, and if I plug something that is not a storage device into it the same restrictions still apply. Also no need for the empty-ish line at the end. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi 2021-06-08 5:35 ` Christoph Hellwig @ 2021-06-08 11:20 ` Rafael J. Wysocki -1 siblings, 0 replies; 22+ messages in thread From: Rafael J. Wysocki @ 2021-06-08 11:20 UTC (permalink / raw) To: Christoph Hellwig, Mario Limonciello Cc: Keith Busch, Jens Axboe, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, ACPI Devel Maling List, rrangel, David Box, Shyam Sundar S K, Nehal-bakulchandra.Shah, Alex Deucher, Prike Liang, Rafael J . Wysocki On Tue, Jun 8, 2021 at 7:35 AM Christoph Hellwig <hch@lst.de> wrote: > > On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: > > +/** > > + * acpi_storage_d3 - Check if a storage device should use D3. Let's be specific about what D3 means here in the first place and that's D3hot AFAICS. And the comment should be something like "Check whether or not to use D3hot in the suspend path". > > + * @dev: Device to check > > + * > > + * Returns %true if @dev should be put into D3 when the ->suspend method is > > + * called, else %false. The name of this function is somewhat misleading > > + * as it has nothing to do with storage except for the name of the ACPI > > + * property. On some platforms resume will not work if this hint is ignored. I would write it this way: "Return %true if the platform firmware wants @dev to be programmed into D3hot in the suspend path, or %false when there is no specific preference. On some platforms, if this hint is ignored, @dev may remain unresponsive after suspending the platform as a whole." And I'm not sure if it is necessary to mention "storage" in this comment at all. > > + * > > + */ > > I still do not like this comment. There is nothing about only using this > for storage devices. It is specific to a PCIe slot, and if I plug > something that is not a storage device into it the same restrictions > still apply. Originally, it was about storage devices IIUC (and that's why the property name is what it is). IIRC PCIe link management was broken in some NVMe drives and putting them into D3hot would allow the link to go down later and it would never go up again. So you-know-who decided to avoid using D3hot for all NVMe drives and they were generally characterized as "storage". Alas, that turned out to break other things depending on the devices being put into D3hot (like PS_ON) so the property was invented to allow OEMs to mark the configurations including the devices that actually worked (and Linux was/is on the receiving end). And originally the property applied to the endpoint device under the root port it was present for (my personal opinion about this doesn't really matter, so let me avoid wasting time on expressing it). Now, it evidently has been re-purposed to mark PCIe root ports that require devices under them to be put into D3hot in the suspend path (and it now means any device under the root port with this property, at least in some cases). > Also no need for the empty-ish line at the end. Right. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi @ 2021-06-08 11:20 ` Rafael J. Wysocki 0 siblings, 0 replies; 22+ messages in thread From: Rafael J. Wysocki @ 2021-06-08 11:20 UTC (permalink / raw) To: Christoph Hellwig, Mario Limonciello Cc: Keith Busch, Jens Axboe, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, ACPI Devel Maling List, rrangel, David Box, Shyam Sundar S K, Nehal-bakulchandra.Shah, Alex Deucher, Prike Liang, Rafael J . Wysocki On Tue, Jun 8, 2021 at 7:35 AM Christoph Hellwig <hch@lst.de> wrote: > > On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: > > +/** > > + * acpi_storage_d3 - Check if a storage device should use D3. Let's be specific about what D3 means here in the first place and that's D3hot AFAICS. And the comment should be something like "Check whether or not to use D3hot in the suspend path". > > + * @dev: Device to check > > + * > > + * Returns %true if @dev should be put into D3 when the ->suspend method is > > + * called, else %false. The name of this function is somewhat misleading > > + * as it has nothing to do with storage except for the name of the ACPI > > + * property. On some platforms resume will not work if this hint is ignored. I would write it this way: "Return %true if the platform firmware wants @dev to be programmed into D3hot in the suspend path, or %false when there is no specific preference. On some platforms, if this hint is ignored, @dev may remain unresponsive after suspending the platform as a whole." And I'm not sure if it is necessary to mention "storage" in this comment at all. > > + * > > + */ > > I still do not like this comment. There is nothing about only using this > for storage devices. It is specific to a PCIe slot, and if I plug > something that is not a storage device into it the same restrictions > still apply. Originally, it was about storage devices IIUC (and that's why the property name is what it is). IIRC PCIe link management was broken in some NVMe drives and putting them into D3hot would allow the link to go down later and it would never go up again. So you-know-who decided to avoid using D3hot for all NVMe drives and they were generally characterized as "storage". Alas, that turned out to break other things depending on the devices being put into D3hot (like PS_ON) so the property was invented to allow OEMs to mark the configurations including the devices that actually worked (and Linux was/is on the receiving end). And originally the property applied to the endpoint device under the root port it was present for (my personal opinion about this doesn't really matter, so let me avoid wasting time on expressing it). Now, it evidently has been re-purposed to mark PCIe root ports that require devices under them to be put into D3hot in the suspend path (and it now means any device under the root port with this property, at least in some cases). > Also no need for the empty-ish line at the end. Right. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi 2021-06-08 11:20 ` Rafael J. Wysocki @ 2021-06-08 14:18 ` Limonciello, Mario -1 siblings, 0 replies; 22+ messages in thread From: Limonciello, Mario @ 2021-06-08 14:18 UTC (permalink / raw) To: Rafael J. Wysocki, Christoph Hellwig Cc: Keith Busch, Jens Axboe, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, ACPI Devel Maling List, rrangel, David Box, Shyam Sundar S K, Nehal-bakulchandra.Shah, Alex Deucher, Prike Liang, Rafael J . Wysocki On 6/8/2021 06:20, Rafael J. Wysocki wrote: > On Tue, Jun 8, 2021 at 7:35 AM Christoph Hellwig <hch@lst.de> wrote: >> >> On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: >>> +/** >>> + * acpi_storage_d3 - Check if a storage device should use D3. > > Let's be specific about what D3 means here in the first place and > that's D3hot AFAICS. > > And the comment should be something like "Check whether or not to use > D3hot in the suspend path". Actually it can be D3hot or D3cold. Microsoft's documentation doesn't indicate it's D3hot. On the AMD platforms that prompted some of these changes it's D3cold. > >>> + * @dev: Device to check >>> + * >>> + * Returns %true if @dev should be put into D3 when the ->suspend method is >>> + * called, else %false. The name of this function is somewhat misleading >>> + * as it has nothing to do with storage except for the name of the ACPI >>> + * property. On some platforms resume will not work if this hint is ignored. > > I would write it this way: > > "Return %true if the platform firmware wants @dev to be programmed > into D3hot in the suspend path, or %false when there is no specific > preference. On some platforms, if this hint is ignored, @dev may > remain unresponsive after suspending the platform as a whole." > > And I'm not sure if it is necessary to mention "storage" in this comment at all. > Is your thought here in not mentioning "storage" that this symbol may be overloaded in the future to look at more than just the StorageD3Enable property and used for other things too? >>> + * >>> + */ >> >> I still do not like this comment. There is nothing about only using this >> for storage devices. It is specific to a PCIe slot, and if I plug >> something that is not a storage device into it the same restrictions >> still apply. > > Originally, it was about storage devices IIUC (and that's why the > property name is what it is). > > IIRC PCIe link management was broken in some NVMe drives and putting > them into D3hot would allow the link to go down later and it would > never go up again. So you-know-who decided to avoid using D3hot for > all NVMe drives and they were generally characterized as "storage". > Alas, that turned out to break other things depending on the devices > being put into D3hot (like PS_ON) so the property was invented to > allow OEMs to mark the configurations including the devices that > actually worked (and Linux was/is on the receiving end). And > originally the property applied to the endpoint device under the root > port it was present for (my personal opinion about this doesn't really > matter, so let me avoid wasting time on expressing it). > > Now, it evidently has been re-purposed to mark PCIe root ports that > require devices under them to be put into D3hot in the suspend path > (and it now means any device under the root port with this property, > at least in some cases). > >> Also no need for the empty-ish line at the end. > > Right. > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi @ 2021-06-08 14:18 ` Limonciello, Mario 0 siblings, 0 replies; 22+ messages in thread From: Limonciello, Mario @ 2021-06-08 14:18 UTC (permalink / raw) To: Rafael J. Wysocki, Christoph Hellwig Cc: Keith Busch, Jens Axboe, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, ACPI Devel Maling List, rrangel, David Box, Shyam Sundar S K, Nehal-bakulchandra.Shah, Alex Deucher, Prike Liang, Rafael J . Wysocki On 6/8/2021 06:20, Rafael J. Wysocki wrote: > On Tue, Jun 8, 2021 at 7:35 AM Christoph Hellwig <hch@lst.de> wrote: >> >> On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: >>> +/** >>> + * acpi_storage_d3 - Check if a storage device should use D3. > > Let's be specific about what D3 means here in the first place and > that's D3hot AFAICS. > > And the comment should be something like "Check whether or not to use > D3hot in the suspend path". Actually it can be D3hot or D3cold. Microsoft's documentation doesn't indicate it's D3hot. On the AMD platforms that prompted some of these changes it's D3cold. > >>> + * @dev: Device to check >>> + * >>> + * Returns %true if @dev should be put into D3 when the ->suspend method is >>> + * called, else %false. The name of this function is somewhat misleading >>> + * as it has nothing to do with storage except for the name of the ACPI >>> + * property. On some platforms resume will not work if this hint is ignored. > > I would write it this way: > > "Return %true if the platform firmware wants @dev to be programmed > into D3hot in the suspend path, or %false when there is no specific > preference. On some platforms, if this hint is ignored, @dev may > remain unresponsive after suspending the platform as a whole." > > And I'm not sure if it is necessary to mention "storage" in this comment at all. > Is your thought here in not mentioning "storage" that this symbol may be overloaded in the future to look at more than just the StorageD3Enable property and used for other things too? >>> + * >>> + */ >> >> I still do not like this comment. There is nothing about only using this >> for storage devices. It is specific to a PCIe slot, and if I plug >> something that is not a storage device into it the same restrictions >> still apply. > > Originally, it was about storage devices IIUC (and that's why the > property name is what it is). > > IIRC PCIe link management was broken in some NVMe drives and putting > them into D3hot would allow the link to go down later and it would > never go up again. So you-know-who decided to avoid using D3hot for > all NVMe drives and they were generally characterized as "storage". > Alas, that turned out to break other things depending on the devices > being put into D3hot (like PS_ON) so the property was invented to > allow OEMs to mark the configurations including the devices that > actually worked (and Linux was/is on the receiving end). And > originally the property applied to the endpoint device under the root > port it was present for (my personal opinion about this doesn't really > matter, so let me avoid wasting time on expressing it). > > Now, it evidently has been re-purposed to mark PCIe root ports that > require devices under them to be put into D3hot in the suspend path > (and it now means any device under the root port with this property, > at least in some cases). > >> Also no need for the empty-ish line at the end. > > Right. > _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi 2021-06-08 14:18 ` Limonciello, Mario @ 2021-06-08 15:27 ` Rafael J. Wysocki -1 siblings, 0 replies; 22+ messages in thread From: Rafael J. Wysocki @ 2021-06-08 15:27 UTC (permalink / raw) To: Limonciello, Mario Cc: Rafael J. Wysocki, Christoph Hellwig, Keith Busch, Jens Axboe, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, ACPI Devel Maling List, rrangel, David Box, Shyam Sundar S K, Nehal-bakulchandra.Shah, Alex Deucher, Prike Liang, Rafael J . Wysocki On Tue, Jun 8, 2021 at 4:18 PM Limonciello, Mario <mario.limonciello@amd.com> wrote: > > On 6/8/2021 06:20, Rafael J. Wysocki wrote: > > On Tue, Jun 8, 2021 at 7:35 AM Christoph Hellwig <hch@lst.de> wrote: > >> > >> On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: > >>> +/** > >>> + * acpi_storage_d3 - Check if a storage device should use D3. > > > > Let's be specific about what D3 means here in the first place and > > that's D3hot AFAICS. > > > > And the comment should be something like "Check whether or not to use > > D3hot in the suspend path". > > Actually it can be D3hot or D3cold. Microsoft's documentation doesn't > indicate it's D3hot. On the AMD platforms that prompted some of these > changes it's D3cold. So say "D3" in the one-line description above and "D3hot or D3cold (if supported)" in the more detailed comment below. > > > >>> + * @dev: Device to check > >>> + * > >>> + * Returns %true if @dev should be put into D3 when the ->suspend method is > >>> + * called, else %false. The name of this function is somewhat misleading > >>> + * as it has nothing to do with storage except for the name of the ACPI > >>> + * property. On some platforms resume will not work if this hint is ignored. > > > > I would write it this way: > > > > "Return %true if the platform firmware wants @dev to be programmed > > into D3hot in the suspend path, or %false when there is no specific > > preference. On some platforms, if this hint is ignored, @dev may > > remain unresponsive after suspending the platform as a whole." > > > > And I'm not sure if it is necessary to mention "storage" in this comment at all. > > > > Is your thought here in not mentioning "storage" that this symbol may be > overloaded in the future to look at more than just the StorageD3Enable > property and used for other things too? Well, the property itself is not about storage any more anyway. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi @ 2021-06-08 15:27 ` Rafael J. Wysocki 0 siblings, 0 replies; 22+ messages in thread From: Rafael J. Wysocki @ 2021-06-08 15:27 UTC (permalink / raw) To: Limonciello, Mario Cc: Rafael J. Wysocki, Christoph Hellwig, Keith Busch, Jens Axboe, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, ACPI Devel Maling List, rrangel, David Box, Shyam Sundar S K, Nehal-bakulchandra.Shah, Alex Deucher, Prike Liang, Rafael J . Wysocki On Tue, Jun 8, 2021 at 4:18 PM Limonciello, Mario <mario.limonciello@amd.com> wrote: > > On 6/8/2021 06:20, Rafael J. Wysocki wrote: > > On Tue, Jun 8, 2021 at 7:35 AM Christoph Hellwig <hch@lst.de> wrote: > >> > >> On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: > >>> +/** > >>> + * acpi_storage_d3 - Check if a storage device should use D3. > > > > Let's be specific about what D3 means here in the first place and > > that's D3hot AFAICS. > > > > And the comment should be something like "Check whether or not to use > > D3hot in the suspend path". > > Actually it can be D3hot or D3cold. Microsoft's documentation doesn't > indicate it's D3hot. On the AMD platforms that prompted some of these > changes it's D3cold. So say "D3" in the one-line description above and "D3hot or D3cold (if supported)" in the more detailed comment below. > > > >>> + * @dev: Device to check > >>> + * > >>> + * Returns %true if @dev should be put into D3 when the ->suspend method is > >>> + * called, else %false. The name of this function is somewhat misleading > >>> + * as it has nothing to do with storage except for the name of the ACPI > >>> + * property. On some platforms resume will not work if this hint is ignored. > > > > I would write it this way: > > > > "Return %true if the platform firmware wants @dev to be programmed > > into D3hot in the suspend path, or %false when there is no specific > > preference. On some platforms, if this hint is ignored, @dev may > > remain unresponsive after suspending the platform as a whole." > > > > And I'm not sure if it is necessary to mention "storage" in this comment at all. > > > > Is your thought here in not mentioning "storage" that this symbol may be > overloaded in the future to look at more than just the StorageD3Enable > property and used for other things too? Well, the property itself is not about storage any more anyway. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi 2021-06-08 5:35 ` Christoph Hellwig @ 2021-06-08 20:01 ` Keith Busch -1 siblings, 0 replies; 22+ messages in thread From: Keith Busch @ 2021-06-08 20:01 UTC (permalink / raw) To: Christoph Hellwig Cc: Mario Limonciello, Jens Axboe, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang, Rafael J . Wysocki On Tue, Jun 08, 2021 at 07:35:46AM +0200, Christoph Hellwig wrote: > On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: > > +/** > > + * acpi_storage_d3 - Check if a storage device should use D3. > > + * @dev: Device to check > > + * > > + * Returns %true if @dev should be put into D3 when the ->suspend method is > > + * called, else %false. The name of this function is somewhat misleading > > + * as it has nothing to do with storage except for the name of the ACPI > > + * property. On some platforms resume will not work if this hint is ignored. > > + * > > + */ > > I still do not like this comment. There is nothing about only using this > for storage devices. It is specific to a PCIe slot, and if I plug > something that is not a storage device into it the same restrictions > still apply. Hm, I thought this comment was good. Despite the dupious connection to storage, the function name matches the ACPI property, so an explanation for this misnomer seems appropriate. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi @ 2021-06-08 20:01 ` Keith Busch 0 siblings, 0 replies; 22+ messages in thread From: Keith Busch @ 2021-06-08 20:01 UTC (permalink / raw) To: Christoph Hellwig Cc: Mario Limonciello, Jens Axboe, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang, Rafael J . Wysocki On Tue, Jun 08, 2021 at 07:35:46AM +0200, Christoph Hellwig wrote: > On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: > > +/** > > + * acpi_storage_d3 - Check if a storage device should use D3. > > + * @dev: Device to check > > + * > > + * Returns %true if @dev should be put into D3 when the ->suspend method is > > + * called, else %false. The name of this function is somewhat misleading > > + * as it has nothing to do with storage except for the name of the ACPI > > + * property. On some platforms resume will not work if this hint is ignored. > > + * > > + */ > > I still do not like this comment. There is nothing about only using this > for storage devices. It is specific to a PCIe slot, and if I plug > something that is not a storage device into it the same restrictions > still apply. Hm, I thought this comment was good. Despite the dupious connection to storage, the function name matches the ACPI property, so an explanation for this misnomer seems appropriate. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi 2021-06-08 20:01 ` Keith Busch @ 2021-06-09 13:00 ` Christoph Hellwig -1 siblings, 0 replies; 22+ messages in thread From: Christoph Hellwig @ 2021-06-09 13:00 UTC (permalink / raw) To: Keith Busch Cc: Christoph Hellwig, Mario Limonciello, Jens Axboe, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang, Rafael J . Wysocki On Tue, Jun 08, 2021 at 01:01:01PM -0700, Keith Busch wrote: > On Tue, Jun 08, 2021 at 07:35:46AM +0200, Christoph Hellwig wrote: > > On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: > > > +/** > > > + * acpi_storage_d3 - Check if a storage device should use D3. > > > + * @dev: Device to check > > > + * > > > + * Returns %true if @dev should be put into D3 when the ->suspend method is > > > + * called, else %false. The name of this function is somewhat misleading > > > + * as it has nothing to do with storage except for the name of the ACPI > > > + * property. On some platforms resume will not work if this hint is ignored. > > > + * > > > + */ > > > > I still do not like this comment. There is nothing about only using this > > for storage devices. It is specific to a PCIe slot, and if I plug > > something that is not a storage device into it the same restrictions > > still apply. > > Hm, I thought this comment was good. Despite the dupious connection to > storage, the function name matches the ACPI property, so an explanation > for this misnomer seems appropriate. I suggested a comment earlier that explains the connection without being completely misleading. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi @ 2021-06-09 13:00 ` Christoph Hellwig 0 siblings, 0 replies; 22+ messages in thread From: Christoph Hellwig @ 2021-06-09 13:00 UTC (permalink / raw) To: Keith Busch Cc: Christoph Hellwig, Mario Limonciello, Jens Axboe, Sagi Grimberg, Rafael J . Wysocki, open list:NVM EXPRESS DRIVER, linux-acpi, rrangel, david.e.box, Shyam-sundar.S-k, Nehal-bakulchandra.Shah, Alexander.Deucher, prike.liang, Rafael J . Wysocki On Tue, Jun 08, 2021 at 01:01:01PM -0700, Keith Busch wrote: > On Tue, Jun 08, 2021 at 07:35:46AM +0200, Christoph Hellwig wrote: > > On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote: > > > +/** > > > + * acpi_storage_d3 - Check if a storage device should use D3. > > > + * @dev: Device to check > > > + * > > > + * Returns %true if @dev should be put into D3 when the ->suspend method is > > > + * called, else %false. The name of this function is somewhat misleading > > > + * as it has nothing to do with storage except for the name of the ACPI > > > + * property. On some platforms resume will not work if this hint is ignored. > > > + * > > > + */ > > > > I still do not like this comment. There is nothing about only using this > > for storage devices. It is specific to a PCIe slot, and if I plug > > something that is not a storage device into it the same restrictions > > still apply. > > Hm, I thought this comment was good. Despite the dupious connection to > storage, the function name matches the ACPI property, so an explanation > for this misnomer seems appropriate. I suggested a comment earlier that explains the connection without being completely misleading. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2021-06-09 13:27 UTC | newest] Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-07 17:31 [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi Mario Limonciello 2021-06-07 17:31 ` Mario Limonciello 2021-06-07 17:31 ` [PATCH v6 2/2] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint Mario Limonciello 2021-06-07 17:31 ` Mario Limonciello 2021-06-07 17:38 ` Raul Rangel 2021-06-07 17:38 ` Raul Rangel 2021-06-08 6:01 ` Julian Sikorski 2021-06-08 6:01 ` Julian Sikorski 2021-06-08 11:27 ` Rafael J. Wysocki 2021-06-08 11:27 ` Rafael J. Wysocki 2021-06-08 5:35 ` [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi Christoph Hellwig 2021-06-08 5:35 ` Christoph Hellwig 2021-06-08 11:20 ` Rafael J. Wysocki 2021-06-08 11:20 ` Rafael J. Wysocki 2021-06-08 14:18 ` Limonciello, Mario 2021-06-08 14:18 ` Limonciello, Mario 2021-06-08 15:27 ` Rafael J. Wysocki 2021-06-08 15:27 ` Rafael J. Wysocki 2021-06-08 20:01 ` Keith Busch 2021-06-08 20:01 ` Keith Busch 2021-06-09 13:00 ` Christoph Hellwig 2021-06-09 13:00 ` Christoph Hellwig
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.