From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Matthias Brugger <mbrugger@suse.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI / tables: Return error from table parse handler
Date: Thu, 19 May 2016 23:17:58 +0200 [thread overview]
Message-ID: <CAJZ5v0jSt-q6tKOSLMmJGLzqpHzLDvyDNoKR2fMmzS4wVW5oFg@mail.gmail.com> (raw)
In-Reply-To: <1463676667-17945-1-git-send-email-mbrugger@suse.com>
On Thu, May 19, 2016 at 6:51 PM, Matthias Brugger <mbrugger@suse.com> wrote:
> The handler called in acpi_table_parse may return an error.
> This patch returns this error instead of ignoring it.
And does it address any particular practical problem or is it just a
code cleanup?
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
> drivers/acpi/tables.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index a372f9e..fb5cd80 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -394,6 +394,7 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler)
> {
> struct acpi_table_header *table = NULL;
> acpi_size tbl_size;
> + int ret;
>
> if (acpi_disabled)
> return -ENODEV;
> @@ -407,9 +408,9 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler)
> acpi_get_table_with_size(id, 0, &table, &tbl_size);
>
> if (table) {
> - handler(table);
> + ret = handler(table);
> early_acpi_os_unmap_memory(table, tbl_size);
> - return 0;
> + return ret;
> } else
> return -ENODEV;
> }
> --
next prev parent reply other threads:[~2016-05-19 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 16:51 [PATCH] ACPI / tables: Return error from table parse handler Matthias Brugger
2016-05-19 21:17 ` Rafael J. Wysocki [this message]
2016-05-20 8:11 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jSt-q6tKOSLMmJGLzqpHzLDvyDNoKR2fMmzS4wVW5oFg@mail.gmail.com \
--to=rafael@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.