* [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets.
@ 2011-07-31 20:09 Jason Cooper
2011-08-04 15:19 ` Jason
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jason Cooper @ 2011-07-31 20:09 UTC (permalink / raw)
To: u-boot
If you take a look at 96820a35, you'll see the original timeout was
CONFIG_SYS_HZ. Which is 1000. After the mentioned change, non-bulk timeout
was changed to 100. This causes timeout failures on the dreamplug platform
when trying to initialize the usb microsd reader.
Signed-off-by: Jason Cooper <u-boot@lakedaemon.net>
---
Changes since v1:
- Further research identified the commit (96820a35) causing the problem
and revealed the former timeout of 1000. Adjusted patch to use former
timeout.
- Removed RFC.
include/usb.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/usb.h b/include/usb.h
index 53603a5..06170cd 100644
--- a/include/usb.h
+++ b/include/usb.h
@@ -46,7 +46,7 @@
* This is the timeout to allow for submitting an urb in ms. We allow more
* time for a BULK device to react - some are slow.
*/
-#define USB_TIMEOUT_MS(pipe) (usb_pipebulk(pipe) ? 5000 : 100)
+#define USB_TIMEOUT_MS(pipe) (usb_pipebulk(pipe) ? 5000 : 1000)
/* device request (setup) */
struct devrequest {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets.
2011-07-31 20:09 [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets Jason Cooper
@ 2011-08-04 15:19 ` Jason
2011-08-08 20:36 ` Remy Bohmer
2011-08-06 11:47 ` Mike Frysinger
2011-08-08 20:35 ` Remy Bohmer
2 siblings, 1 reply; 5+ messages in thread
From: Jason @ 2011-08-04 15:19 UTC (permalink / raw)
To: u-boot
Remy,
I neglected to include you in my original submission, could you please
take a look at this for u-boot-usb? Original email is here [1]. And
the commit I'm referring to is here [2].
The dreamplug platform must pull it's uImage from a usb attached microSD
card. They are completely unbootable without this patch. However, this
is a u-boot-wide change and I'm not familiar enough to say this won't
break something else. Your insight would be appreciated.
thx,
Jason.
[1] http://patchwork.ozlabs.org/patch/107645/
[2]
http://git.denx.de/?p=u-boot.git;a=commit;h=96820a35873b4c005f732432c6a168decc9d22b9
On Sun, Jul 31, 2011 at 08:09:58PM +0000, Jason Cooper wrote:
> If you take a look at 96820a35, you'll see the original timeout was
> CONFIG_SYS_HZ. Which is 1000. After the mentioned change, non-bulk timeout
> was changed to 100. This causes timeout failures on the dreamplug platform
> when trying to initialize the usb microsd reader.
>
> Signed-off-by: Jason Cooper <u-boot@lakedaemon.net>
> ---
> Changes since v1:
> - Further research identified the commit (96820a35) causing the problem
> and revealed the former timeout of 1000. Adjusted patch to use former
> timeout.
> - Removed RFC.
>
> include/usb.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/usb.h b/include/usb.h
> index 53603a5..06170cd 100644
> --- a/include/usb.h
> +++ b/include/usb.h
> @@ -46,7 +46,7 @@
> * This is the timeout to allow for submitting an urb in ms. We allow more
> * time for a BULK device to react - some are slow.
> */
> -#define USB_TIMEOUT_MS(pipe) (usb_pipebulk(pipe) ? 5000 : 100)
> +#define USB_TIMEOUT_MS(pipe) (usb_pipebulk(pipe) ? 5000 : 1000)
>
> /* device request (setup) */
> struct devrequest {
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets.
2011-07-31 20:09 [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets Jason Cooper
2011-08-04 15:19 ` Jason
@ 2011-08-06 11:47 ` Mike Frysinger
2011-08-08 20:35 ` Remy Bohmer
2 siblings, 0 replies; 5+ messages in thread
From: Mike Frysinger @ 2011-08-06 11:47 UTC (permalink / raw)
To: u-boot
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets.
2011-07-31 20:09 [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets Jason Cooper
2011-08-04 15:19 ` Jason
2011-08-06 11:47 ` Mike Frysinger
@ 2011-08-08 20:35 ` Remy Bohmer
2 siblings, 0 replies; 5+ messages in thread
From: Remy Bohmer @ 2011-08-08 20:35 UTC (permalink / raw)
To: u-boot
Hi,
2011/7/31 Jason Cooper <u-boot@lakedaemon.net>:
> If you take a look at 96820a35, you'll see the original timeout was
> CONFIG_SYS_HZ. ?Which is 1000. ?After the mentioned change, non-bulk timeout
> was changed to 100. ?This causes timeout failures on the dreamplug platform
> when trying to initialize the usb microsd reader.
>
> Signed-off-by: Jason Cooper <u-boot@lakedaemon.net>
Applied to u-boot-usb
Kind regards,
Remy
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets.
2011-08-04 15:19 ` Jason
@ 2011-08-08 20:36 ` Remy Bohmer
0 siblings, 0 replies; 5+ messages in thread
From: Remy Bohmer @ 2011-08-08 20:36 UTC (permalink / raw)
To: u-boot
Hi,
2011/8/4 Jason <u-boot@lakedaemon.net>:
> Remy,
>
> I neglected to include you in my original submission, could you please
> take a look at this for u-boot-usb? ?Original email is here [1]. ?And
> the commit I'm referring to is here [2].
No problem...
I am subscribed to the list, and I have seen it already.
(I am a bit slow lately due to summer vacation, but I am catching up...)
Kind regards,
Remy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-08 20:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-31 20:09 [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets Jason Cooper
2011-08-04 15:19 ` Jason
2011-08-08 20:36 ` Remy Bohmer
2011-08-06 11:47 ` Mike Frysinger
2011-08-08 20:35 ` Remy Bohmer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.