All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Garnier <thgarnie@google.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	Ingo Molnar <mingo@kernel.org>, Baoquan He <bhe@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: KASLR causes intermittent boot failures on some systems
Date: Wed, 19 Apr 2017 07:56:36 -0700	[thread overview]
Message-ID: <CAJcbSZH5BrK_ip8DxQd5vxrtckcbZ8vaQhf5h9qsQ+tzakhvKw@mail.gmail.com> (raw)
In-Reply-To: <CAPcyv4jGvy8b8KUb1Pg+h+5c6FVH2H7fbF3hM8wXp8Z=SUYtBw@mail.gmail.com>

On Wed, Apr 19, 2017 at 7:34 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> Does the randomization ever cross a pgd boundary?

Yes, it can cross a pgd boundary. The original physical memory mapping
might as well but you would need almost 550Gb of memory.

>
> These crashes look very similar to the crashes caused by
> arch_add_memory() racing itself. This issue was fixed in:
>
>     f931ab479dd2 mm: fix devm_memremap_pages crash, use
> mem_hotplug_{begin, done}
>
> ...but that only helps users that call mem_hotplug_begin() to prevent
> concurrent updates.
>

It could be related to page table changes done concurrently or just
done with certain expectations.


-- 
Thomas
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Garnier <thgarnie@google.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Baoquan He <bhe@redhat.com>, Jeff Moyer <jmoyer@redhat.com>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>
Subject: Re: KASLR causes intermittent boot failures on some systems
Date: Wed, 19 Apr 2017 07:56:36 -0700	[thread overview]
Message-ID: <CAJcbSZH5BrK_ip8DxQd5vxrtckcbZ8vaQhf5h9qsQ+tzakhvKw@mail.gmail.com> (raw)
In-Reply-To: <CAPcyv4jGvy8b8KUb1Pg+h+5c6FVH2H7fbF3hM8wXp8Z=SUYtBw@mail.gmail.com>

On Wed, Apr 19, 2017 at 7:34 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> Does the randomization ever cross a pgd boundary?

Yes, it can cross a pgd boundary. The original physical memory mapping
might as well but you would need almost 550Gb of memory.

>
> These crashes look very similar to the crashes caused by
> arch_add_memory() racing itself. This issue was fixed in:
>
>     f931ab479dd2 mm: fix devm_memremap_pages crash, use
> mem_hotplug_{begin, done}
>
> ...but that only helps users that call mem_hotplug_begin() to prevent
> concurrent updates.
>

It could be related to page table changes done concurrently or just
done with certain expectations.


-- 
Thomas

  parent reply	other threads:[~2017-04-19 14:56 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07 14:41 KASLR causes intermittent boot failures on some systems Jeff Moyer
2017-04-07 14:41 ` Jeff Moyer
2017-04-07 14:49 ` Thomas Garnier
2017-04-07 14:49   ` Thomas Garnier
2017-04-07 14:51   ` Jeff Moyer
2017-04-07 14:51     ` Jeff Moyer
2017-04-07 21:25 ` Kees Cook
2017-04-07 21:25   ` Kees Cook
2017-04-10 15:49   ` Jeff Moyer
2017-04-10 15:49     ` Jeff Moyer
2017-04-10 18:13     ` Kees Cook
2017-04-10 18:13       ` Kees Cook
2017-04-10 18:22       ` Jeff Moyer
2017-04-10 18:22         ` Jeff Moyer
2017-04-10 19:03         ` Kees Cook
2017-04-10 19:03           ` Kees Cook
2017-04-10 19:18           ` Jeff Moyer
2017-04-10 19:18             ` Jeff Moyer
2017-04-08  2:51 ` Baoquan He
2017-04-08  2:51   ` Baoquan He
2017-04-08  4:08 ` Baoquan He
2017-04-08  4:08   ` Baoquan He
2017-04-08  7:02   ` Dan Williams
2017-04-08  7:02     ` Dan Williams
2017-04-08  7:52     ` Baoquan He
2017-04-08  7:52       ` Baoquan He
2017-04-10 15:57   ` Jeff Moyer
2017-04-10 15:57     ` Jeff Moyer
2017-04-12  8:24 ` Dave Young
2017-04-12  8:24   ` Dave Young
2017-04-12  8:24   ` Dave Young
2017-04-12  8:27   ` Dave Young
2017-04-12  8:27     ` Dave Young
2017-04-12  8:27     ` Dave Young
2017-04-12  8:40   ` Dave Young
2017-04-12  8:40     ` Dave Young
2017-04-12  8:40     ` Dave Young
2017-04-12 12:52     ` Jeff Moyer
2017-04-12 12:52       ` Jeff Moyer
2017-04-12 12:52       ` Jeff Moyer
2017-04-19 13:36 ` Baoquan He
2017-04-19 13:36   ` Baoquan He
2017-04-19 14:27   ` Thomas Garnier
2017-04-19 14:27     ` Thomas Garnier
2017-04-19 14:34     ` Dan Williams
2017-04-19 14:34       ` Dan Williams
2017-04-19 14:56       ` Baoquan He
2017-04-19 14:56         ` Baoquan He
2017-04-19 14:56       ` Thomas Garnier [this message]
2017-04-19 14:56         ` Thomas Garnier
2017-04-19 14:55     ` Baoquan He
2017-04-19 14:55       ` Baoquan He
2017-04-20 13:26     ` Baoquan He
2017-04-20 13:26       ` Baoquan He
2017-04-24 20:37       ` Thomas Garnier
2017-04-24 20:37         ` Thomas Garnier
2017-04-24 20:52         ` Dan Williams
2017-04-24 20:52           ` Dan Williams
2017-04-24 23:07           ` Baoquan He
2017-04-24 23:07             ` Baoquan He
2017-04-24 23:18             ` Dan Williams
2017-04-24 23:18               ` Dan Williams
2017-04-24 23:56               ` Baoquan He
2017-04-24 23:56                 ` Baoquan He
2017-04-25  0:41             ` Thomas Garnier
2017-04-25  0:41               ` Thomas Garnier
2017-04-25  1:18               ` Baoquan He
2017-04-25  1:18                 ` Baoquan He
2017-05-01 11:32 ` Baoquan He
2017-05-01 11:32   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJcbSZH5BrK_ip8DxQd5vxrtckcbZ8vaQhf5h9qsQ+tzakhvKw@mail.gmail.com \
    --to=thgarnie@google.com \
    --cc=bhe@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.