[PATCH BlueZ] mgmtops: Fix endianness conversion

[PATCH BlueZ] mgmtops: Fix endianness conversion

[Anderson Lizardo]

Flags field has 32-bit size. Same issue was fixed for mgmtops in
1801a4d45d74c29cebacaab79a07e9961300be41.
---
 monitor/control.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/control.c b/monitor/control.c
index 159ba9d..54b249d 100644
--- a/monitor/control.c
+++ b/monitor/control.c
@@ -210,7 +210,7 @@ static void mgmt_device_connected(uint16_t len, const void *buf)
 		return;
 	}
 
-	flags = btohs(ev->flags);
+	flags = btohl(ev->flags);
 	ba2str(&ev->addr.bdaddr, str);
 
 	printf("@ Device Connected: %s (%d) flags 0x%4.4x\n",
-- 
1.7.9.5

[PATCH v2 BlueZ] monitor: Fix endianness conversion

[Anderson Lizardo]

Flags field has 32-bit size. Same issue was fixed for mgmtops in
1801a4d45d74c29cebacaab79a07e9961300be41.
---

Fix subject: mgmtops -> monitor

 monitor/control.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/control.c b/monitor/control.c
index 159ba9d..54b249d 100644
--- a/monitor/control.c
+++ b/monitor/control.c
@@ -210,7 +210,7 @@ static void mgmt_device_connected(uint16_t len, const void *buf)
 		return;
 	}
 
-	flags = btohs(ev->flags);
+	flags = btohl(ev->flags);
 	ba2str(&ev->addr.bdaddr, str);
 
 	printf("@ Device Connected: %s (%d) flags 0x%4.4x\n",
-- 
1.7.9.5

Re: [PATCH BlueZ] mgmtops: Fix endianness conversion

[Anderson Lizardo]

Hi,

On Mon, Jul 30, 2012 at 2:13 PM, Anderson Lizardo
<anderson.lizardo@openbossa.org> wrote:
> Flags field has 32-bit size. Same issue was fixed for mgmtops in
> 1801a4d45d74c29cebacaab79a07e9961300be41.
> ---

I make a mistake on the subject prefix, please apply v3 instead.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

[PATCH v3 BlueZ] monitor: Fix endianness conversion

[Anderson Lizardo]

Flags field has 32-bit size. Same issue was fixed for mgmtops in
1801a4d45d74c29cebacaab79a07e9961300be41.
---

v2 -> v3: Fix another occurrence of same bug.

 monitor/control.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/monitor/control.c b/monitor/control.c
index 159ba9d..3f5b990 100644
--- a/monitor/control.c
+++ b/monitor/control.c
@@ -210,7 +210,7 @@ static void mgmt_device_connected(uint16_t len, const void *buf)
 		return;
 	}
 
-	flags = btohs(ev->flags);
+	flags = btohl(ev->flags);
 	ba2str(&ev->addr.bdaddr, str);
 
 	printf("@ Device Connected: %s (%d) flags 0x%4.4x\n",
@@ -357,7 +357,7 @@ static void mgmt_device_found(uint16_t len, const void *buf)
 		return;
 	}
 
-	flags = btohs(ev->flags);
+	flags = btohl(ev->flags);
 	ba2str(&ev->addr.bdaddr, str);
 
 	printf("@ Device Found: %s (%d) rssi %d flags 0x%4.4x\n",
-- 
1.7.9.5

Re: [PATCH v3 BlueZ] monitor: Fix endianness conversion

[Johan Hedberg]

Hi Lizardo,

On Tue, Jul 31, 2012, Anderson Lizardo wrote:
> Flags field has 32-bit size. Same issue was fixed for mgmtops in
> 1801a4d45d74c29cebacaab79a07e9961300be41.
> ---
> 
> v2 -> v3: Fix another occurrence of same bug.
> 
>  monitor/control.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied. Thanks.

Johan

Re: [PATCH BlueZ] mgmtops: Fix endianness conversion

[Johan Hedberg]

Hi Jefferson,

On Fri, Jun 01, 2012, Jefferson Delfes wrote:
> Flags field has 32-bit size.
> ---
>  plugins/mgmtops.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied. Thanks.

Johan

[PATCH BlueZ] mgmtops: Fix endianness conversion

[Jefferson Delfes]

Flags field has 32-bit size.
---
 plugins/mgmtops.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/mgmtops.c b/plugins/mgmtops.c
index 22fa329..cedfbd4 100644
--- a/plugins/mgmtops.c
+++ b/plugins/mgmtops.c
@@ -1550,7 +1550,7 @@ static void mgmt_device_found(int sk, uint16_t index, void *buf, size_t len)
 	else
 		eir = ev->eir;
 
-	flags = btohs(ev->flags);
+	flags = btohl(ev->flags);
 
 	ba2str(&ev->addr.bdaddr, addr);
 	DBG("hci%u addr %s, rssi %d flags 0x%04x eir_len %u",
-- 
1.7.10.2