From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: chen.ganir@ti.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 0/5] Add DeviceInformationService plugin
Date: Mon, 26 Mar 2012 11:09:56 -0400 [thread overview]
Message-ID: <CAJdJm_O1yiniHrn3kZNSPCdY=SMuX_FNuf66QJCCYqv9wLjHAg@mail.gmail.com> (raw)
In-Reply-To: <1332765928-6251-1-git-send-email-chen.ganir@ti.com>
Hi Chen,
On Mon, Mar 26, 2012 at 8:45 AM, <chen.ganir@ti.com> wrote:
> From: Chen Ganir <chen.ganir@ti.com>
>
> Add Device Information Service GATT Client for reading peer
> device PNP_ID and store it.
>
> Chen Ganir (5):
> Add DeviceInformation GATT Client
> DeviceInfo: Add connection logic
> DeviceInfo: Discover Characteristics
> Fix device version in GetProperties
> DeviceInfo: Read PNP ID
>
> Makefile.am | 9 ++-
> deviceinfo/deviceinfo.c | 218 +++++++++++++++++++++++++++++++++++++++++++++++
> deviceinfo/deviceinfo.h | 24 +++++
> deviceinfo/main.c | 55 ++++++++++++
> deviceinfo/manager.c | 82 ++++++++++++++++++
> deviceinfo/manager.h | 24 +++++
> src/device.c | 35 +++++++-
> src/device.h | 3 +
> 8 files changed, 446 insertions(+), 4 deletions(-)
> create mode 100644 deviceinfo/deviceinfo.c
> create mode 100644 deviceinfo/deviceinfo.h
> create mode 100644 deviceinfo/main.c
> create mode 100644 deviceinfo/manager.c
> create mode 100644 deviceinfo/manager.h
Except for the build error, I see no other issues on the GATT part of
these patches. Someone else needs to review/comment on the part
touching src/device.c though (maybe Johan himself?)
Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
prev parent reply other threads:[~2012-03-26 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 12:45 [PATCH 0/5] Add DeviceInformationService plugin chen.ganir
2012-03-26 12:45 ` [PATCH 1/5] Add DeviceInformation GATT Client chen.ganir
2012-03-26 12:45 ` [PATCH 2/5] DeviceInfo: Add connection logic chen.ganir
2012-03-26 12:45 ` [PATCH 3/5] DeviceInfo: Discover Characteristics chen.ganir
2012-03-26 14:29 ` Anderson Lizardo
2012-03-26 12:45 ` [PATCH 4/5] Fix device version in GetProperties chen.ganir
2012-03-26 12:45 ` [PATCH 5/5] DeviceInfo: Read PNP ID chen.ganir
2012-03-26 15:09 ` Anderson Lizardo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJdJm_O1yiniHrn3kZNSPCdY=SMuX_FNuf66QJCCYqv9wLjHAg@mail.gmail.com' \
--to=anderson.lizardo@openbossa.org \
--cc=chen.ganir@ti.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.