From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: chen.ganir@ti.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/5] DeviceInfo: Discover Characteristics
Date: Mon, 26 Mar 2012 10:29:29 -0400 [thread overview]
Message-ID: <CAJdJm_OA0x2pZG4OsUwCd0s+tBzyfzQf-U4Ws6Qc__uwXXLK-A@mail.gmail.com> (raw)
In-Reply-To: <1332765928-6251-4-git-send-email-chen.ganir@ti.com>
Hi Chen,
On Mon, Mar 26, 2012 at 8:45 AM, <chen.ganir@ti.com> wrote:
> From: Chen Ganir <chen.ganir@ti.com>
>
> Add logic to discover all characteristics and build a
> characteristic list.
> ---
> deviceinfo/deviceinfo.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++-
> deviceinfo/deviceinfo.h | 2 +-
> deviceinfo/manager.c | 5 +++-
> 3 files changed, 71 insertions(+), 3 deletions(-)
This patch introduces a build failure:
deviceinfo/deviceinfo.c: In function ‘configure_deviceinfo_cb’:
deviceinfo/deviceinfo.c:108:19: error: variable ‘end’ set but not used
[-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
Please make sure every patch on the series is buildable (when applied
on order). In this case, you should introduce the variable only on the
commit where it is used.
Regards,
--
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
next prev parent reply other threads:[~2012-03-26 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 12:45 [PATCH 0/5] Add DeviceInformationService plugin chen.ganir
2012-03-26 12:45 ` [PATCH 1/5] Add DeviceInformation GATT Client chen.ganir
2012-03-26 12:45 ` [PATCH 2/5] DeviceInfo: Add connection logic chen.ganir
2012-03-26 12:45 ` [PATCH 3/5] DeviceInfo: Discover Characteristics chen.ganir
2012-03-26 14:29 ` Anderson Lizardo [this message]
2012-03-26 12:45 ` [PATCH 4/5] Fix device version in GetProperties chen.ganir
2012-03-26 12:45 ` [PATCH 5/5] DeviceInfo: Read PNP ID chen.ganir
2012-03-26 15:09 ` [PATCH 0/5] Add DeviceInformationService plugin Anderson Lizardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJdJm_OA0x2pZG4OsUwCd0s+tBzyfzQf-U4Ws6Qc__uwXXLK-A@mail.gmail.com \
--to=anderson.lizardo@openbossa.org \
--cc=chen.ganir@ti.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.