Re: [meta-mingw][PATCH] expat: Switch platform to Windows in CMake toolchain file

Re: [meta-mingw][PATCH] expat: Switch platform to Windows in CMake toolchain file

[Joshua Watt]

On Sat, Jul 18, 2020 at 11:03 AM Oleksandr Popovych
<oleksandr.s.popovych@globallogic.com> wrote:
>
> GNU Autotools build system is considered in upstream as potentially
> deprecated (https://github.com/libexpat/libexpat/issues/330), and
> expat library will be switched to use CMake.
>
> So this patch depends on "expat: Added ptest" patch for 'meta' layer,
> and fixes CMake toolchain file to work correctly with 'meta-mingw'
> layer.
> ---
>  recipes-core/expat/expat_%.bbappend | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/recipes-core/expat/expat_%.bbappend b/recipes-core/expat/expat_%.bbappend
> index 626ea5b..0fe3aa0 100644
> --- a/recipes-core/expat/expat_%.bbappend
> +++ b/recipes-core/expat/expat_%.bbappend
> @@ -1,3 +1,9 @@
>
>  FILES_${PN}-bin_mingw32 = "${bindir}/*.exe ${sbindir}/*.exe"
>
> +cmake_do_generate_toolchain_file_append_mingw32() {
> +    cat >> ${WORKDIR}/toolchain.cmake <<EOF
> +set( CMAKE_SYSTEM_NAME Windows )
> +EOF
> +}
> +

Hmm, this seems like the kind of thing that should be set for all
mingw32 builds....

> --
> 2.17.1
>

Re: [meta-mingw][PATCH] expat: Switch platform to Windows in CMake toolchain file

[Oleksandr]

Hello Joshua,

On Mon, Jul 20, 2020 at 8:47 PM Joshua Watt <jpewhacker@gmail.com> wrote:
>
> Hmm, this seems like the kind of thing that should be set for all
> mingw32 builds....
>

Do you mean "set for all CMake-based recipes by default"? Maybe this is a better
option than adding the same function manually.

But then next question appears:
Should this be done by duplicating already existing "cmake.bbclass"
file to "meta-mingw"
layer and making changes there, or creating new class that inherits
"cmake.bbclass" and
adds necessary changes?
If there is a better way to achieve this goal, I`ll be glad to check it out.

Thanks for your attention.

[meta-mingw][PATCH] expat: Switch platform to Windows in CMake toolchain file

[Oleksandr]

GNU Autotools build system is considered in upstream as potentially 
deprecated (https://github.com/libexpat/libexpat/issues/330), and
expat library will be switched to use CMake.

So this patch depends on "expat: Added ptest" patch for 'meta' layer, 
and fixes CMake toolchain file to work correctly with 'meta-mingw' 
layer.
---
 recipes-core/expat/expat_%.bbappend | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/recipes-core/expat/expat_%.bbappend b/recipes-core/expat/expat_%.bbappend
index 626ea5b..0fe3aa0 100644
--- a/recipes-core/expat/expat_%.bbappend
+++ b/recipes-core/expat/expat_%.bbappend
@@ -1,3 +1,9 @@
 
 FILES_${PN}-bin_mingw32 = "${bindir}/*.exe ${sbindir}/*.exe"
 
+cmake_do_generate_toolchain_file_append_mingw32() {
+    cat >> ${WORKDIR}/toolchain.cmake <<EOF
+set( CMAKE_SYSTEM_NAME Windows )
+EOF
+}
+
-- 
2.17.1