From: Zheng Hacker <hackerzheng666@gmail.com>
To: Zheng Wang <zyytlz.wz@163.com>
Cc: stable@vger.kernel.org, sashal@kernel.org,
gregkh@linuxfoundation.org, patches@lists.linux.dev,
amergnat@baylibre.com, wenst@chromium.org,
angelogioacchino.delregno@collabora.com,
hverkuil-cisco@xs4all.nl
Subject: Re: [PATCH] media: mtk-jpeg: Fix use after free bug due to uncanceled work
Date: Sun, 15 Oct 2023 22:53:35 +0800 [thread overview]
Message-ID: <CAJedcCxQbRrOm7gCx95GSxWBG3SOp0bS-ORHWR2n969e9wOViA@mail.gmail.com> (raw)
In-Reply-To: <20231015144242.723743-1-zyytlz.wz@163.com>
This patch has some mistakes in the typo. Please ignore it.
Zheng Wang <zyytlz.wz@163.com> 于2023年10月15日周日 22:44写道:
>
> This is a security bug that has been reported to google.
> It affected all platforms on chrome-os. Please apply this
> patch to 5.10.
>
> Due to the directory structure change, the file path to
> be be patched is different from that in upstream.
>
> [ Upstream commit c677d7ae83141d390d1253abebafa49c962afb52 ]
>
> In mtk_jpeg_probe, &jpeg->job_timeout_work is bound with
> mtk_jpeg_job_timeout_work. Then mtk_jpeg_dec_device_run
> and mtk_jpeg_enc_device_run may be called to start the
> work.
>
> If we remove the module which will call mtk_jpeg_remove
> to make cleanup, there may be a unfinished work. The
> possible sequence is as follows, which will cause a
> typical UAF bug.
>
> Fix it by canceling the work before cleanup in the mtk_jpeg_remove
>
> CPU0 CPU1
>
> |mtk_jpeg_job_timeout_work
> mtk_jpeg_remove |
> v4l2_m2m_release |
> kfree(m2m_dev); |
> |
> | v4l2_m2m_get_curr_priv
> | m2m_dev->curr_ctx //use
> Fixes: b2f0d2724ba4 ("[media] vcodec: mediatek: Add Mediatek JPEG Decoder Driver")
> Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> Cc: stable@vger.kernel.org
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index ee802fc3bcdf..67c9ca4cfcd2 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -1189,6 +1189,7 @@ static int mtk_jpeg_remove(struct platform_device *pdev)
> {
> struct mtk_jpeg_dev *jpeg = platform_get_drvdata(pdev);
>
> + ancel_delayed_work_sync(&jpeg->job_timeout_work);
> pm_runtime_disable(&pdev->dev);
> video_unregister_device(jpeg->dec_vdev);
> video_device_release(jpeg->dec_vdev);
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-10-15 14:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 14:42 [PATCH] media: mtk-jpeg: Fix use after free bug due to uncanceled work Zheng Wang
2023-10-15 14:53 ` Zheng Hacker [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-15 14:50 Zheng Wang
2023-10-15 14:47 Zheng Wang
2023-10-15 17:48 ` Greg KH
2023-03-02 9:37 Zheng Wang
2023-03-02 9:37 ` Zheng Wang
2023-03-09 0:27 ` Guenter Roeck
2023-03-09 0:27 ` Guenter Roeck
2023-03-09 3:58 ` Zheng Hacker
2023-03-09 3:58 ` Zheng Hacker
2023-03-09 5:30 ` Guenter Roeck
2023-03-09 5:30 ` Guenter Roeck
2023-03-09 7:18 ` Zheng Hacker
2023-03-09 7:18 ` Zheng Hacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJedcCxQbRrOm7gCx95GSxWBG3SOp0bS-ORHWR2n969e9wOViA@mail.gmail.com \
--to=hackerzheng666@gmail.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=patches@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wenst@chromium.org \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.