From: Guenter Roeck <linux@roeck-us.net> To: Zheng Hacker <hackerzheng666@gmail.com> Cc: Zheng Wang <zyytlz.wz@163.com>, mchehab@kernel.org, bin.liu@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, 1395428693sheep@gmail.com, alex000young@gmail.com Subject: Re: [PATCH] media: mtk-jpeg: Fix use after free bug due to uncanceled work Date: Wed, 8 Mar 2023 21:30:33 -0800 [thread overview] Message-ID: <e03134f9-9433-ab6b-170a-8ce752fccdeb@roeck-us.net> (raw) In-Reply-To: <CAJedcCxYQYmORfnqcdudFKwy9hhU=mZh_d9MM7x+37ies2S-MA@mail.gmail.com> On 3/8/23 19:58, Zheng Hacker wrote: > Hi, > > Thanks for your reply. I think you're right. I don't know if there is > other method to stop new work from enqueing. Could you please give me > some advice about the fix? > Top-posting is discouraged. Anyway - I don't know the code well enough to suggest a solution. It all depends on the driver architecture. The maintainers might have a better idea. A worse problem appears to be that the worker is also canceled from mtk_jpeg_enc_irq() and mtk_jpeg_dec_irq(). Those are non-threaded interrupt handlers which, as far as I know, must not sleep and thus can not call cancel_delayed_work_sync(). I have no idea how to solve that problem either. Guenter > Regards, > Zheng > > Guenter Roeck <linux@roeck-us.net> 于2023年3月9日周四 08:27写道: >> >> On Thu, Mar 02, 2023 at 05:37:15PM +0800, Zheng Wang wrote: >>> In mtk_jpeg_probe, &jpeg->job_timeout_work is bound with >>> mtk_jpeg_job_timeout_work. Then mtk_jpeg_dec_device_run >>> and mtk_jpeg_enc_device_run may be called to start the >>> work. >>> If we remove the module which will call mtk_jpeg_remove >>> to make cleanup, there may be a unfinished work. The >>> possible sequence is as follows, which will cause a >>> typical UAF bug. >>> >>> Fix it by canceling the work before cleanup in the mtk_jpeg_remove >>> >>> CPU0 CPU1 >>> >>> |mtk_jpeg_job_timeout_work >>> mtk_jpeg_remove | >>> v4l2_m2m_release | >>> kfree(m2m_dev); | >>> | >>> | v4l2_m2m_get_curr_priv >>> | m2m_dev->curr_ctx //use >>> >>> Signed-off-by: Zheng Wang <zyytlz.wz@163.com> >>> --- >>> drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c >>> index 969516a940ba..364513e7897e 100644 >>> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c >>> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c >>> @@ -1793,7 +1793,7 @@ static int mtk_jpeg_probe(struct platform_device *pdev) >>> static int mtk_jpeg_remove(struct platform_device *pdev) >>> { >>> struct mtk_jpeg_dev *jpeg = platform_get_drvdata(pdev); >>> - >>> + cancel_delayed_work(&jpeg->job_timeout_work); >> >> The empty line is needed (coding style). Also, this doesn't cancel >> the worker if it is already running. This should probably be >> cancel_delayed_work_sync(). Even then the question is if it is >> possible that new work is queued before the device is unregistered. >> >> Guenter >> >>> pm_runtime_disable(&pdev->dev); >>> video_unregister_device(jpeg->vdev); >>> v4l2_m2m_release(jpeg->m2m_dev); >>> -- >>> 2.25.1 >>>
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net> To: Zheng Hacker <hackerzheng666@gmail.com> Cc: Zheng Wang <zyytlz.wz@163.com>, mchehab@kernel.org, bin.liu@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, 1395428693sheep@gmail.com, alex000young@gmail.com Subject: Re: [PATCH] media: mtk-jpeg: Fix use after free bug due to uncanceled work Date: Wed, 8 Mar 2023 21:30:33 -0800 [thread overview] Message-ID: <e03134f9-9433-ab6b-170a-8ce752fccdeb@roeck-us.net> (raw) In-Reply-To: <CAJedcCxYQYmORfnqcdudFKwy9hhU=mZh_d9MM7x+37ies2S-MA@mail.gmail.com> On 3/8/23 19:58, Zheng Hacker wrote: > Hi, > > Thanks for your reply. I think you're right. I don't know if there is > other method to stop new work from enqueing. Could you please give me > some advice about the fix? > Top-posting is discouraged. Anyway - I don't know the code well enough to suggest a solution. It all depends on the driver architecture. The maintainers might have a better idea. A worse problem appears to be that the worker is also canceled from mtk_jpeg_enc_irq() and mtk_jpeg_dec_irq(). Those are non-threaded interrupt handlers which, as far as I know, must not sleep and thus can not call cancel_delayed_work_sync(). I have no idea how to solve that problem either. Guenter > Regards, > Zheng > > Guenter Roeck <linux@roeck-us.net> 于2023年3月9日周四 08:27写道: >> >> On Thu, Mar 02, 2023 at 05:37:15PM +0800, Zheng Wang wrote: >>> In mtk_jpeg_probe, &jpeg->job_timeout_work is bound with >>> mtk_jpeg_job_timeout_work. Then mtk_jpeg_dec_device_run >>> and mtk_jpeg_enc_device_run may be called to start the >>> work. >>> If we remove the module which will call mtk_jpeg_remove >>> to make cleanup, there may be a unfinished work. The >>> possible sequence is as follows, which will cause a >>> typical UAF bug. >>> >>> Fix it by canceling the work before cleanup in the mtk_jpeg_remove >>> >>> CPU0 CPU1 >>> >>> |mtk_jpeg_job_timeout_work >>> mtk_jpeg_remove | >>> v4l2_m2m_release | >>> kfree(m2m_dev); | >>> | >>> | v4l2_m2m_get_curr_priv >>> | m2m_dev->curr_ctx //use >>> >>> Signed-off-by: Zheng Wang <zyytlz.wz@163.com> >>> --- >>> drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c >>> index 969516a940ba..364513e7897e 100644 >>> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c >>> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c >>> @@ -1793,7 +1793,7 @@ static int mtk_jpeg_probe(struct platform_device *pdev) >>> static int mtk_jpeg_remove(struct platform_device *pdev) >>> { >>> struct mtk_jpeg_dev *jpeg = platform_get_drvdata(pdev); >>> - >>> + cancel_delayed_work(&jpeg->job_timeout_work); >> >> The empty line is needed (coding style). Also, this doesn't cancel >> the worker if it is already running. This should probably be >> cancel_delayed_work_sync(). Even then the question is if it is >> possible that new work is queued before the device is unregistered. >> >> Guenter >> >>> pm_runtime_disable(&pdev->dev); >>> video_unregister_device(jpeg->vdev); >>> v4l2_m2m_release(jpeg->m2m_dev); >>> -- >>> 2.25.1 >>> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-09 5:31 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-02 9:37 [PATCH] media: mtk-jpeg: Fix use after free bug due to uncanceled work Zheng Wang 2023-03-02 9:37 ` Zheng Wang 2023-03-09 0:27 ` Guenter Roeck 2023-03-09 0:27 ` Guenter Roeck 2023-03-09 3:58 ` Zheng Hacker 2023-03-09 3:58 ` Zheng Hacker 2023-03-09 5:30 ` Guenter Roeck [this message] 2023-03-09 5:30 ` Guenter Roeck 2023-03-09 7:18 ` Zheng Hacker 2023-03-09 7:18 ` Zheng Hacker 2023-10-15 14:42 Zheng Wang 2023-10-15 14:53 ` Zheng Hacker 2023-10-15 14:47 Zheng Wang 2023-10-15 17:48 ` Greg KH 2023-10-15 14:50 Zheng Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e03134f9-9433-ab6b-170a-8ce752fccdeb@roeck-us.net \ --to=linux@roeck-us.net \ --cc=1395428693sheep@gmail.com \ --cc=alex000young@gmail.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=bin.liu@mediatek.com \ --cc=hackerzheng666@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=mchehab@kernel.org \ --cc=zyytlz.wz@163.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.