* [RFC PATCH] ovl: do not copy attr several times
@ 2021-02-26 9:24 Chengguang Xu
2021-03-24 16:00 ` Miklos Szeredi
0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2021-02-26 9:24 UTC (permalink / raw)
To: miklos; +Cc: linux-unionfs, Chengguang Xu
In ovl_xattr_set() we have already copied attr of real inode
so no need to copy it again in ovl_posix_acl_xattr_set().
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/overlayfs/super.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index d58b8f2bf9d0..c61f42c901d1 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -1035,9 +1035,6 @@ ovl_posix_acl_xattr_set(const struct xattr_handler *handler,
}
err = ovl_xattr_set(dentry, inode, handler->name, value, size, flags);
- if (!err)
- ovl_copyattr(ovl_inode_real(inode), inode);
-
return err;
out_acl_release:
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH] ovl: do not copy attr several times
2021-02-26 9:24 [RFC PATCH] ovl: do not copy attr several times Chengguang Xu
@ 2021-03-24 16:00 ` Miklos Szeredi
0 siblings, 0 replies; 2+ messages in thread
From: Miklos Szeredi @ 2021-03-24 16:00 UTC (permalink / raw)
To: Chengguang Xu; +Cc: overlayfs
On Fri, Feb 26, 2021 at 10:25 AM Chengguang Xu <cgxu519@mykernel.net> wrote:
>
> In ovl_xattr_set() we have already copied attr of real inode
> so no need to copy it again in ovl_posix_acl_xattr_set().
Thanks, applied.
Miklos
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-24 16:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-26 9:24 [RFC PATCH] ovl: do not copy attr several times Chengguang Xu
2021-03-24 16:00 ` Miklos Szeredi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.