All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pranith Kumar <bobby.prani@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Anton Blanchard <anton@samba.org>,
	Fabian Frederick <fabf@skynet.be>,
	Andrew Morton <akpm@linux-foundation.org>,
	"open list:LINUX FOR POWERPC..." <linuxppc-dev@lists.ozlabs.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] powerpc: Wire up three syscalls
Date: Sun, 31 Aug 2014 08:52:04 -0400	[thread overview]
Message-ID: <CAJhHMCDaSAzU3zvhY2FRFoBaQH4oQBTsUsYMU6pvBbCXydROZQ@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdV_naTfQOLwOshWq1Q15kSE39a8GWChsjt3RrWRcd6peg@mail.gmail.com>

Hi Geert,

On Sun, Aug 31, 2014 at 4:53 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Pranith,
>
> On Sat, Aug 30, 2014 at 5:36 AM, Pranith Kumar <bobby.prani@gmail.com> wrote:
>> I see that the three syscalls seccomp, getrandom and memfd_create are not wired
>> because of which we get a warning while compilation.
>>
>> So I wired them up in this patch. What else needs to be done? I tried the
>> memfd_test after compiling this kernel, but it is failing. What am I missing for
>> this to work? Any advice is really appreciated! :)
>
> Did it fail due to the (silly) "ifeq ($(ARCH),X86)" checks in
> tools/testing/selftests/memfd/Makefile?
>

I removed that check and compiled memfd_test.c by hand. This is the
following error which I get when I run the test:

$ ./memfd_test
memfd: CREATE
memfd: BASIC
10 != 0 = GET_SEALS(3)
Aborted

This is basically when checking the seals which we already added. It
should return 10 (F_SEAL_SHRINK | F_SEAL_WRITE), instead it is returning 0.

What else needs to be done for this to properly work? I see that for
m68k, you just wired it up like in this patch. Did it work after that?

-- 
Pranith

WARNING: multiple messages have this Message-ID (diff)
From: Pranith Kumar <bobby.prani@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: open list <linux-kernel@vger.kernel.org>,
	Fabian Frederick <fabf@skynet.be>,
	Paul Mackerras <paulus@samba.org>,
	Anton Blanchard <anton@samba.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"open list:LINUX FOR POWERPC..." <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [RFC PATCH] powerpc: Wire up three syscalls
Date: Sun, 31 Aug 2014 08:52:04 -0400	[thread overview]
Message-ID: <CAJhHMCDaSAzU3zvhY2FRFoBaQH4oQBTsUsYMU6pvBbCXydROZQ@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdV_naTfQOLwOshWq1Q15kSE39a8GWChsjt3RrWRcd6peg@mail.gmail.com>

Hi Geert,

On Sun, Aug 31, 2014 at 4:53 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Pranith,
>
> On Sat, Aug 30, 2014 at 5:36 AM, Pranith Kumar <bobby.prani@gmail.com> wrote:
>> I see that the three syscalls seccomp, getrandom and memfd_create are not wired
>> because of which we get a warning while compilation.
>>
>> So I wired them up in this patch. What else needs to be done? I tried the
>> memfd_test after compiling this kernel, but it is failing. What am I missing for
>> this to work? Any advice is really appreciated! :)
>
> Did it fail due to the (silly) "ifeq ($(ARCH),X86)" checks in
> tools/testing/selftests/memfd/Makefile?
>

I removed that check and compiled memfd_test.c by hand. This is the
following error which I get when I run the test:

$ ./memfd_test
memfd: CREATE
memfd: BASIC
10 != 0 = GET_SEALS(3)
Aborted

This is basically when checking the seals which we already added. It
should return 10 (F_SEAL_SHRINK | F_SEAL_WRITE), instead it is returning 0.

What else needs to be done for this to properly work? I see that for
m68k, you just wired it up like in this patch. Did it work after that?

-- 
Pranith

  reply	other threads:[~2014-08-31 12:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-30  3:36 [RFC PATCH] powerpc: Wire up three syscalls Pranith Kumar
2014-08-31  8:53 ` Geert Uytterhoeven
2014-08-31  8:53   ` Geert Uytterhoeven
2014-08-31 12:52   ` Pranith Kumar [this message]
2014-08-31 12:52     ` Pranith Kumar
2014-08-31 14:14     ` Geert Uytterhoeven
2014-08-31 14:14       ` Geert Uytterhoeven
2014-08-31 14:34     ` David Herrmann
2014-08-31 14:34       ` David Herrmann
2014-08-31 17:51       ` Pranith Kumar
2014-08-31 17:51         ` Pranith Kumar
2014-09-01 11:33         ` David Herrmann
2014-09-01 11:33           ` David Herrmann
2014-09-01 15:21           ` Pranith Kumar
2014-09-01 15:21             ` Pranith Kumar
2014-09-01 15:31             ` David Herrmann
2014-09-01 15:31               ` David Herrmann
2014-09-01 17:16               ` Pranith Kumar
2014-09-01 17:16                 ` Pranith Kumar
2014-09-01 17:28                 ` David Herrmann
2014-09-01 17:28                   ` David Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJhHMCDaSAzU3zvhY2FRFoBaQH4oQBTsUsYMU6pvBbCXydROZQ@mail.gmail.com \
    --to=bobby.prani@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=fabf@skynet.be \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.