All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Clément Péron" <peron.clem@gmail.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: netdev@vger.kernel.org
Subject: Re: Ethernet on my CycloneV broke since 4.9.124
Date: Wed, 31 Oct 2018 16:36:28 +0100	[thread overview]
Message-ID: <CAJiuCccpJwa+Png72Lg6wp0NrXWUQDOWuDBRP=RwtHF_yKyxEg@mail.gmail.com> (raw)
In-Reply-To: <61e0ddf2-a2b5-189a-06bc-ee0cd7bfd8b5@kernel.org>

Hi Dinh,

On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen <dinguyen@kernel.org> wrote:
>
> Hi Clement,
>
> On 10/31/2018 08:01 AM, Clément Péron wrote:
> > Hi,
> >
> > The patch "net: stmmac: socfpga: add additional ocp reset line for
> > Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV
> > board.
> >
> > When I boot i have this issue :
> >
> > socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2
> > socfpga-dwmac: probe of ff702000.ethernet failed with error -2
> >
> > Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the issue.
> >
>
> Are you sure? I just booted v4.9.124 and did not see any errors. The
> error should not appear because the commit is using
> devm_reset_control_get_optional().

I'm booting on 4.9.130 actually, Agree with you that
devm_reset_control_get_optional should not failed but checking other
usage of this helper
https://elixir.bootlin.com/linux/v4.9.135/source/drivers/i2c/busses/i2c-mv64xxx.c#L824
https://elixir.bootlin.com/linux/v4.9.135/source/drivers/crypto/sunxi-ss/sun4i-ss-core.c#L259
Show that they don't check for errors except for PROBE_DEFER

Thanks,
Clement

>
> Dinh

  reply	other threads:[~2018-11-01  0:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 13:01 Ethernet on my CycloneV broke since 4.9.124 Clément Péron
2018-10-31 14:42 ` Dinh Nguyen
2018-10-31 15:36   ` Clément Péron [this message]
2018-10-31 22:01     ` Dinh Nguyen
2018-11-02 10:02       ` Clément Péron
2018-11-15 15:50         ` Clément Péron
2018-11-15 16:21           ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJiuCccpJwa+Png72Lg6wp0NrXWUQDOWuDBRP=RwtHF_yKyxEg@mail.gmail.com' \
    --to=peron.clem@gmail.com \
    --cc=dinguyen@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.