All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [meta-arm] [PATCH] [RFC] gator: Add new package
       [not found] <167925D13277D687.1887@lists.yoctoproject.org>
@ 2021-04-25 16:16 ` Clément Péron
  2021-04-26 15:01   ` Diego Sueiro
  2021-04-26 21:07   ` Ross Burton
  0 siblings, 2 replies; 5+ messages in thread
From: Clément Péron @ 2021-04-25 16:16 UTC (permalink / raw)
  To: Clément Péron; +Cc: meta-arm

Hi,

On Sun, 25 Apr 2021 at 18:12, Clément Péron via lists.yoctoproject.org
<peron.clem=gmail.com@lists.yoctoproject.org> wrote:
>
> To communicate with the target device, Streamline requires the
> gator daemon, gatord, to be running on the device.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>

As suggested on meta-openembedded, i'm reposting this patch here.
https://lists.openembedded.org/g/openembedded-devel/topic/82331135

> ---
>  .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
>  .../recipes-devtools/gator/gator_7.5.0.bb     | 22 +++++++++++++++++
>  2 files changed, 46 insertions(+)
>  create mode 100644 meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
>  create mode 100644 meta-arm/recipes-devtools/gator/gator_7.5.0.bb
>
> diff --git a/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> new file mode 100644
> index 000000000000..8e59fffa1fc2
> --- /dev/null
> +++ b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> @@ -0,0 +1,24 @@
> +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
> +Date: Fri, 16 Apr 2021 15:27:16 +0200
> +Subject: [PATCH] gator: don't strip debug
> +
> +---
> + daemon/Makefile | 2 --
> + 1 file changed, 2 deletions(-)
> +
> +diff --git a/daemon/Makefile b/daemon/Makefile
> +index ba5f29cfeb10..6807948310f9 100644
> +--- a/daemon/Makefile
> ++++ b/daemon/Makefile
> +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1 -d.` \>= 5),1)
> +       CXXFLAGS += -fno-sized-deallocation
> + endif
> +
> +-# -s strips the binary of debug info
> +-LDFLAGS     += -s
> + LDLIBS      += -lrt -lm -pthread
> + TARGET      := $(OBJ_DIR)gatord
> + ESCAPE_EXE  := $(OBJ_DIR)escape/escape
> +--
> +2.25.1
> diff --git a/meta-arm/recipes-devtools/gator/gator_7.5.0.bb b/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
> new file mode 100644
> index 000000000000..8e15b1ca5fc5
> --- /dev/null
> +++ b/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
> @@ -0,0 +1,22 @@
> +SUMMARY = "DS-5 Streamine Gator daemon"
> +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline Performance Analyzer."
> +
> +LICENSE = "GPL-2.0-only"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +LICENSE_libsensors = "LGPL-2.1-or-later"

The gator github specifies that:

- libsensors source code in daemon/libsensors licensed under LGPL-2.1-or-later
- mxml source code in daemon/mxml licensed under APACHE-2.0 WITH
Mini-XML-exception
- perf_event.h from Linux userspace kernel headers in daemon/k
licensed under GPL-2.0-only WITH Linux-syscall-note

I'm not sure how to properly describe that in the recipe.

Regards,
Clement


> +
> +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
> +SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
> +          file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
> +         "
> +
> +S = "${WORKDIR}/git/daemon"
> +
> +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
> +    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}' 'CROSS_COMPILE=${TARGET_PREFIX}' \
> +    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}' CXX='${CXX}'"
> +
> +do_install() {
> +       install -d ${D}${sbindir}
> +       install -m 0755 ${S}/gatord ${D}${sbindir}/gatord
> +}
> --
> 2.25.1
>
>
> 
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-arm] [PATCH] [RFC] gator: Add new package
  2021-04-25 16:16 ` [meta-arm] [PATCH] [RFC] gator: Add new package Clément Péron
@ 2021-04-26 15:01   ` Diego Sueiro
  2021-04-26 15:11     ` Clément Péron
  2021-04-26 21:07   ` Ross Burton
  1 sibling, 1 reply; 5+ messages in thread
From: Diego Sueiro @ 2021-04-26 15:01 UTC (permalink / raw)
  To: peron.clem; +Cc: meta-arm, nd

Hi Clement,

Thanks for sending this patch.

Please find my comments inline.

Cheers,
--
Diego Sueiro

>-----Original Message-----
>From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
>On Behalf Of Clément Péron via lists.yoctoproject.org
>Sent: 25 April 2021 17:16
>To: Clément Péron <peron.clem@gmail.com>
>Cc: meta-arm@lists.yoctoproject.org
>Subject: Re: [meta-arm] [PATCH] [RFC] gator: Add new package
>
>Hi,
>
>On Sun, 25 Apr 2021 at 18:12, Clément Péron via lists.yoctoproject.org
><peron.clem=gmail.com@lists.yoctoproject.org> wrote:
>>
>> To communicate with the target device, Streamline requires the gator
>> daemon, gatord, to be running on the device.
>>
>> Signed-off-by: Clément Péron <peron.clem@gmail.com>
>
>As suggested on meta-openembedded, i'm reposting this patch here.
>https://lists.openembedded.org/g/openembedded-devel/topic/82331135
>
>> ---
>>  .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
>>  .../recipes-devtools/gator/gator_7.5.0.bb     | 22 +++++++++++++++++
>>  2 files changed, 46 insertions(+)
>>  create mode 100644
>> meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.pat
>> ch  create mode 100644 meta-arm/recipes-devtools/gator/gator_7.5.0.bb
>>
>> diff --git
>> a/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.p
>> atch
>> b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.p
>> atch
>> new file mode 100644
>> index 000000000000..8e59fffa1fc2
>> --- /dev/null
>> +++ b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-deb
>> +++ ug.patch
>> @@ -0,0 +1,24 @@
>> +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17
>00:00:00
>> +2001
>> +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
>> +Date: Fri, 16 Apr 2021 15:27:16 +0200
>> +Subject: [PATCH] gator: don't strip debug
>> +

Upstream-Status and Signed-off-by tags are missing in this patch.

>> +---
>> + daemon/Makefile | 2 --
>> + 1 file changed, 2 deletions(-)
>> +
>> +diff --git a/daemon/Makefile b/daemon/Makefile index
>> +ba5f29cfeb10..6807948310f9 100644
>> +--- a/daemon/Makefile
>> ++++ b/daemon/Makefile
>> +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1 -d.`
>\>= 5),1)
>> +       CXXFLAGS += -fno-sized-deallocation  endif
>> +
>> +-# -s strips the binary of debug info
>> +-LDFLAGS     += -s
>> + LDLIBS      += -lrt -lm -pthread
>> + TARGET      := $(OBJ_DIR)gatord
>> + ESCAPE_EXE  := $(OBJ_DIR)escape/escape
>> +--
>> +2.25.1
>> diff --git a/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
>> b/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
>> new file mode 100644
>> index 000000000000..8e15b1ca5fc5
>> --- /dev/null
>> +++ b/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
>> @@ -0,0 +1,22 @@
>> +SUMMARY = "DS-5 Streamine Gator daemon"
>> +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline
>Performance Analyzer."
>> +
>> +LICENSE = "GPL-2.0-only"
>> +LIC_FILES_CHKSUM =
>"file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> +LICENSE_libsensors = "LGPL-2.1-or-later"
>
>The gator github specifies that:
>
>- libsensors source code in daemon/libsensors licensed under LGPL-2.1-or-later
>- mxml source code in daemon/mxml licensed under APACHE-2.0 WITH Mini-
>XML-exception
>- perf_event.h from Linux userspace kernel headers in daemon/k licensed
>under GPL-2.0-only WITH Linux-syscall-note
>
>I'm not sure how to properly describe that in the recipe.
>
>Regards,
>Clement
>
>
>> +
>> +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"

There is a more recent version (7.6.0) released 10 days ago. Can you please
send the recipe for this newer version instead?

Also, as documented in the README.md, there are couple of kernel configs
required for gator. Can you mention in the recipe the need of the kernel configs
and point to the https://github.com/ARM-software/gator#kernel-configuration link?


>> +SRC_URI = "git://github.com/ARM-
>software/gator.git;protocol=http;branch=master \
>> +          file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
>> +         "
>> +
>> +S = "${WORKDIR}/git/daemon"
>> +
>> +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -
>D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
>> +    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}'
>'CROSS_COMPILE=${TARGET_PREFIX}' \
>> +    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}'
>CXX='${CXX}'"
>> +
>> +do_install() {
>> +       install -d ${D}${sbindir}
>> +       install -m 0755 ${S}/gatord ${D}${sbindir}/gatord }
>> --
>> 2.25.1
>>
>>
>>
>>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-arm] [PATCH] [RFC] gator: Add new package
  2021-04-26 15:01   ` Diego Sueiro
@ 2021-04-26 15:11     ` Clément Péron
  2021-04-26 15:38       ` Diego Sueiro
  0 siblings, 1 reply; 5+ messages in thread
From: Clément Péron @ 2021-04-26 15:11 UTC (permalink / raw)
  To: Diego Sueiro; +Cc: meta-arm, nd

Hi Diego,

On Mon, 26 Apr 2021 at 17:01, Diego Sueiro <Diego.Sueiro@arm.com> wrote:
>
> Hi Clement,
>
> Thanks for sending this patch.
>
> Please find my comments inline.
>
> Cheers,
> --
> Diego Sueiro
>
> >-----Original Message-----
> >From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
> >On Behalf Of Clément Péron via lists.yoctoproject.org
> >Sent: 25 April 2021 17:16
> >To: Clément Péron <peron.clem@gmail.com>
> >Cc: meta-arm@lists.yoctoproject.org
> >Subject: Re: [meta-arm] [PATCH] [RFC] gator: Add new package
> >
> >Hi,
> >
> >On Sun, 25 Apr 2021 at 18:12, Clément Péron via lists.yoctoproject.org
> ><peron.clem=gmail.com@lists.yoctoproject.org> wrote:
> >>
> >> To communicate with the target device, Streamline requires the gator
> >> daemon, gatord, to be running on the device.
> >>
> >> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> >
> >As suggested on meta-openembedded, i'm reposting this patch here.
> >https://lists.openembedded.org/g/openembedded-devel/topic/82331135
> >
> >> ---
> >>  .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
> >>  .../recipes-devtools/gator/gator_7.5.0.bb     | 22 +++++++++++++++++
> >>  2 files changed, 46 insertions(+)
> >>  create mode 100644
> >> meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.pat
> >> ch  create mode 100644 meta-arm/recipes-devtools/gator/gator_7.5.0.bb
> >>
> >> diff --git
> >> a/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.p
> >> atch
> >> b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.p
> >> atch
> >> new file mode 100644
> >> index 000000000000..8e59fffa1fc2
> >> --- /dev/null
> >> +++ b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-deb
> >> +++ ug.patch
> >> @@ -0,0 +1,24 @@
> >> +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17
> >00:00:00
> >> +2001
> >> +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
> >> +Date: Fri, 16 Apr 2021 15:27:16 +0200
> >> +Subject: [PATCH] gator: don't strip debug
> >> +
>
> Upstream-Status and Signed-off-by tags are missing in this patch.
Ok,
>
> >> +---
> >> + daemon/Makefile | 2 --
> >> + 1 file changed, 2 deletions(-)
> >> +
> >> +diff --git a/daemon/Makefile b/daemon/Makefile index
> >> +ba5f29cfeb10..6807948310f9 100644
> >> +--- a/daemon/Makefile
> >> ++++ b/daemon/Makefile
> >> +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1 -d.`
> >\>= 5),1)
> >> +       CXXFLAGS += -fno-sized-deallocation  endif
> >> +
> >> +-# -s strips the binary of debug info
> >> +-LDFLAGS     += -s
> >> + LDLIBS      += -lrt -lm -pthread
> >> + TARGET      := $(OBJ_DIR)gatord
> >> + ESCAPE_EXE  := $(OBJ_DIR)escape/escape
> >> +--
> >> +2.25.1
> >> diff --git a/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
> >> b/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
> >> new file mode 100644
> >> index 000000000000..8e15b1ca5fc5
> >> --- /dev/null
> >> +++ b/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
> >> @@ -0,0 +1,22 @@
> >> +SUMMARY = "DS-5 Streamine Gator daemon"
> >> +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline
> >Performance Analyzer."
> >> +
> >> +LICENSE = "GPL-2.0-only"
> >> +LIC_FILES_CHKSUM =
> >"file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >> +LICENSE_libsensors = "LGPL-2.1-or-later"
> >
> >The gator github specifies that:
> >
> >- libsensors source code in daemon/libsensors licensed under LGPL-2.1-or-later
> >- mxml source code in daemon/mxml licensed under APACHE-2.0 WITH Mini-
> >XML-exception
> >- perf_event.h from Linux userspace kernel headers in daemon/k licensed
> >under GPL-2.0-only WITH Linux-syscall-note
> >
> >I'm not sure how to properly describe that in the recipe.
> >
> >Regards,
> >Clement
> >
> >
> >> +
> >> +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
>
> There is a more recent version (7.6.0) released 10 days ago. Can you please
> send the recipe for this newer version instead?
>
> Also, as documented in the README.md, there are couple of kernel configs
> required for gator. Can you mention in the recipe the need of the kernel configs
> and point to the https://github.com/ARM-software/gator#kernel-configuration link?

Do you want to add this in the Description package or a comment in the recipe?

Thanks for your feebacks,
Clement

>
>
> >> +SRC_URI = "git://github.com/ARM-
> >software/gator.git;protocol=http;branch=master \
> >> +          file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
> >> +         "
> >> +
> >> +S = "${WORKDIR}/git/daemon"
> >> +
> >> +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -
> >D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
> >> +    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}'
> >'CROSS_COMPILE=${TARGET_PREFIX}' \
> >> +    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}'
> >CXX='${CXX}'"
> >> +
> >> +do_install() {
> >> +       install -d ${D}${sbindir}
> >> +       install -m 0755 ${S}/gatord ${D}${sbindir}/gatord }
> >> --
> >> 2.25.1
> >>
> >>
> >>
> >>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-arm] [PATCH] [RFC] gator: Add new package
  2021-04-26 15:11     ` Clément Péron
@ 2021-04-26 15:38       ` Diego Sueiro
  0 siblings, 0 replies; 5+ messages in thread
From: Diego Sueiro @ 2021-04-26 15:38 UTC (permalink / raw)
  To: peron.clem; +Cc: meta-arm, nd

>-----Original Message-----
>From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
>On Behalf Of Clément Péron via lists.yoctoproject.org
>Sent: 26 April 2021 16:11
>To: Diego Sueiro <Diego.Sueiro@arm.com>
>Cc: meta-arm@lists.yoctoproject.org; nd <nd@arm.com>
>Subject: Re: [meta-arm] [PATCH] [RFC] gator: Add new package
>
>Hi Diego,
>
>On Mon, 26 Apr 2021 at 17:01, Diego Sueiro <Diego.Sueiro@arm.com> wrote:
>>
>> Hi Clement,
>>
>> Thanks for sending this patch.
>>
>> Please find my comments inline.
>>
>> Cheers,
>> --
>> Diego Sueiro
>>
>> >-----Original Message-----
>> >From: meta-arm@lists.yoctoproject.org
>> ><meta-arm@lists.yoctoproject.org> On Behalf Of Clément Péron via
>> >lists.yoctoproject.org
>> >Sent: 25 April 2021 17:16
>> >To: Clément Péron <peron.clem@gmail.com>
>> >Cc: meta-arm@lists.yoctoproject.org
>> >Subject: Re: [meta-arm] [PATCH] [RFC] gator: Add new package
>> >
>> >Hi,
>> >
>> >On Sun, 25 Apr 2021 at 18:12, Clément Péron via
>> >lists.yoctoproject.org <peron.clem=gmail.com@lists.yoctoproject.org>
>wrote:
>> >>
>> >> To communicate with the target device, Streamline requires the
>> >> gator daemon, gatord, to be running on the device.
>> >>
>> >> Signed-off-by: Clément Péron <peron.clem@gmail.com>
>> >
>> >As suggested on meta-openembedded, i'm reposting this patch here.
>> >https://lists.openembedded.org/g/openembedded-devel/topic/82331135
>> >
>> >> ---
>> >>  .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
>> >>  .../recipes-devtools/gator/gator_7.5.0.bb     | 22 +++++++++++++++++
>> >>  2 files changed, 46 insertions(+)
>> >>  create mode 100644
>> >> meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.
>> >> pat ch  create mode 100644
>> >> meta-arm/recipes-devtools/gator/gator_7.5.0.bb
>> >>
>> >> diff --git
>> >> a/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debu
>> >> g.p
>> >> atch
>> >> b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debu
>> >> g.p
>> >> atch
>> >> new file mode 100644
>> >> index 000000000000..8e59fffa1fc2
>> >> --- /dev/null
>> >> +++ b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-
>> >> +++ deb
>> >> +++ ug.patch
>> >> @@ -0,0 +1,24 @@
>> >> +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17
>> >00:00:00
>> >> +2001
>> >> +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
>> >> +Date: Fri, 16 Apr 2021 15:27:16 +0200
>> >> +Subject: [PATCH] gator: don't strip debug
>> >> +
>>
>> Upstream-Status and Signed-off-by tags are missing in this patch.
>Ok,
>>
>> >> +---
>> >> + daemon/Makefile | 2 --
>> >> + 1 file changed, 2 deletions(-)
>> >> +
>> >> +diff --git a/daemon/Makefile b/daemon/Makefile index
>> >> +ba5f29cfeb10..6807948310f9 100644
>> >> +--- a/daemon/Makefile
>> >> ++++ b/daemon/Makefile
>> >> +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut
>> >> +-f1 -d.`
>> >\>= 5),1)
>> >> +       CXXFLAGS += -fno-sized-deallocation  endif
>> >> +
>> >> +-# -s strips the binary of debug info
>> >> +-LDFLAGS     += -s
>> >> + LDLIBS      += -lrt -lm -pthread
>> >> + TARGET      := $(OBJ_DIR)gatord
>> >> + ESCAPE_EXE  := $(OBJ_DIR)escape/escape
>> >> +--
>> >> +2.25.1
>> >> diff --git a/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
>> >> b/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
>> >> new file mode 100644
>> >> index 000000000000..8e15b1ca5fc5
>> >> --- /dev/null
>> >> +++ b/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
>> >> @@ -0,0 +1,22 @@
>> >> +SUMMARY = "DS-5 Streamine Gator daemon"
>> >> +DESCRIPTION = "Target-side daemon gathering data for ARM
>> >> +Streamline
>> >Performance Analyzer."
>> >> +
>> >> +LICENSE = "GPL-2.0-only"
>> >> +LIC_FILES_CHKSUM =
>> >"file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> >> +LICENSE_libsensors = "LGPL-2.1-or-later"
>> >
>> >The gator github specifies that:
>> >
>> >- libsensors source code in daemon/libsensors licensed under
>> >LGPL-2.1-or-later
>> >- mxml source code in daemon/mxml licensed under APACHE-2.0 WITH
>> >Mini- XML-exception
>> >- perf_event.h from Linux userspace kernel headers in daemon/k
>> >licensed under GPL-2.0-only WITH Linux-syscall-note
>> >
>> >I'm not sure how to properly describe that in the recipe.
>> >
>> >Regards,
>> >Clement
>> >
>> >
>> >> +
>> >> +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
>>
>> There is a more recent version (7.6.0) released 10 days ago. Can you
>> please send the recipe for this newer version instead?
>>
>> Also, as documented in the README.md, there are couple of kernel
>> configs required for gator. Can you mention in the recipe the need of
>> the kernel configs and point to the https://github.com/ARM-
>software/gator#kernel-configuration link?
>
>Do you want to add this in the Description package or a comment in the recipe?
>

TBH, I don't have a preference for this.

Cheers,
Diego Sueiro

>Thanks for your feebacks,
>Clement
>
>>
>>
>> >> +SRC_URI = "git://github.com/ARM-
>> >software/gator.git;protocol=http;branch=master \
>> >> +          file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
>> >> +         "
>> >> +
>> >> +S = "${WORKDIR}/git/daemon"
>> >> +
>> >> +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -
>> >D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
>> >> +    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}'
>> >'CROSS_COMPILE=${TARGET_PREFIX}' \
>> >> +    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}'
>> >CXX='${CXX}'"
>> >> +
>> >> +do_install() {
>> >> +       install -d ${D}${sbindir}
>> >> +       install -m 0755 ${S}/gatord ${D}${sbindir}/gatord }
>> >> --
>> >> 2.25.1
>> >>
>> >>
>> >>
>> >>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-arm] [PATCH] [RFC] gator: Add new package
  2021-04-25 16:16 ` [meta-arm] [PATCH] [RFC] gator: Add new package Clément Péron
  2021-04-26 15:01   ` Diego Sueiro
@ 2021-04-26 21:07   ` Ross Burton
  1 sibling, 0 replies; 5+ messages in thread
From: Ross Burton @ 2021-04-26 21:07 UTC (permalink / raw)
  To: Clément Péron; +Cc: meta-arm

On Sun, 25 Apr 2021 at 17:16, Clément Péron <peron.clem@gmail.com> wrote:
> The gator github specifies that:
>
> - libsensors source code in daemon/libsensors licensed under LGPL-2.1-or-later
> - mxml source code in daemon/mxml licensed under APACHE-2.0 WITH
> Mini-XML-exception
> - perf_event.h from Linux userspace kernel headers in daemon/k
> licensed under GPL-2.0-only WITH Linux-syscall-note
>
> I'm not sure how to properly describe that in the recipe.

Two parts:

1) Set LIC_FILES_CHKSUM to the list of files that define those
licenses, eg the libsensors license file, and the mxml license file,
and the top-level license file.
2) Set LICENSE to the union of all of the licenses: LGPLv2.1+ & APACHE-2 & ...

Ross

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-04-26 21:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <167925D13277D687.1887@lists.yoctoproject.org>
2021-04-25 16:16 ` [meta-arm] [PATCH] [RFC] gator: Add new package Clément Péron
2021-04-26 15:01   ` Diego Sueiro
2021-04-26 15:11     ` Clément Péron
2021-04-26 15:38       ` Diego Sueiro
2021-04-26 21:07   ` Ross Burton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.