From: "Clément Péron" <peron.clem@gmail.com> To: "Clément Péron" <peron.clem@gmail.com>, "Mauro Carvalho Chehab" <mchehab@kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "Maxime Ripard" <maxime.ripard@bootlin.com>, "Chen-Yu Tsai" <wens@csie.org>, devicetree <devicetree@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-sunxi <linux-sunxi@googlegroups.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-media@vger.kernel.org Subject: Re: [PATCH v3 10/12] arm64: dts: allwinner: h6: Add IR receiver node Date: Fri, 31 May 2019 00:25:32 +0200 [thread overview] Message-ID: <CAJiuCce7nHSktVsDKcR8GLRpD3WrN5yP3Nb_Hbu_Q9NjUQbSMw@mail.gmail.com> (raw) In-Reply-To: <20190530145550.amalnxmx7kpokykv@core.my.home> Hi Ondrej, On Thu, 30 May 2019 at 16:55, Ondřej Jirman <megous@megous.com> wrote: > > Hello Clément, > > On Tue, May 28, 2019 at 06:14:38PM +0200, Clément Péron wrote: > > Allwinner H6 IR is similar to A31 and can use same driver. > > > > Add support for it. > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > index 16c5c3d0fd81..649cbdfe452e 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -647,6 +647,25 @@ > > pins = "PL0", "PL1"; > > function = "s_i2c"; > > }; > > + > > + r_ir_rx_pin: r-ir-rx-pin { > > + pins = "PL9"; > > + function = "s_cir_rx"; > > + }; > > + }; > > + > > + r_ir: ir@7040000 { > > + compatible = "allwinner,sun50i-h6-ir", > > + "allwinner,sun6i-a31-ir"; > > + reg = <0x07040000 0x400>; > > + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&r_ccu CLK_R_APB1_IR>, > > + <&r_ccu CLK_IR>; > > + clock-names = "apb", "ir"; > > + resets = <&r_ccu RST_R_APB1_IR>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&r_ir_rx_pin>; > > + status = "disabled"; > > }; > > Please make a comment here, that this is known broken on some boards and may > result IRQ flood if enabled. Otherwise noone will know. I'm planning to send a v4 next week with the IRQ_NONE return as Maxime suggested it. https://github.com/clementperon/linux/tree/h6_ir_v4 But maybe we could also use the bit 5 of the IRQ status. Regards, Clement > > thanks, > o. > > > r_i2c: i2c@7081400 { > > -- > > 2.20.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Clément Péron" <peron.clem@gmail.com> To: "Clément Péron" <peron.clem@gmail.com>, "Mauro Carvalho Chehab" <mchehab@kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "Maxime Ripard" <maxime.ripard@bootlin.com>, "Chen-Yu Tsai" <wens@csie.org>, devicetree <devicetree@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-sunxi <linux-sunxi@googlegroups.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-media@vger.kernel.org Subject: Re: [PATCH v3 10/12] arm64: dts: allwinner: h6: Add IR receiver node Date: Fri, 31 May 2019 00:25:32 +0200 [thread overview] Message-ID: <CAJiuCce7nHSktVsDKcR8GLRpD3WrN5yP3Nb_Hbu_Q9NjUQbSMw@mail.gmail.com> (raw) In-Reply-To: <20190530145550.amalnxmx7kpokykv@core.my.home> Hi Ondrej, On Thu, 30 May 2019 at 16:55, Ondřej Jirman <megous@megous.com> wrote: > > Hello Clément, > > On Tue, May 28, 2019 at 06:14:38PM +0200, Clément Péron wrote: > > Allwinner H6 IR is similar to A31 and can use same driver. > > > > Add support for it. > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > index 16c5c3d0fd81..649cbdfe452e 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -647,6 +647,25 @@ > > pins = "PL0", "PL1"; > > function = "s_i2c"; > > }; > > + > > + r_ir_rx_pin: r-ir-rx-pin { > > + pins = "PL9"; > > + function = "s_cir_rx"; > > + }; > > + }; > > + > > + r_ir: ir@7040000 { > > + compatible = "allwinner,sun50i-h6-ir", > > + "allwinner,sun6i-a31-ir"; > > + reg = <0x07040000 0x400>; > > + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&r_ccu CLK_R_APB1_IR>, > > + <&r_ccu CLK_IR>; > > + clock-names = "apb", "ir"; > > + resets = <&r_ccu RST_R_APB1_IR>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&r_ir_rx_pin>; > > + status = "disabled"; > > }; > > Please make a comment here, that this is known broken on some boards and may > result IRQ flood if enabled. Otherwise noone will know. I'm planning to send a v4 next week with the IRQ_NONE return as Maxime suggested it. https://github.com/clementperon/linux/tree/h6_ir_v4 But maybe we could also use the bit 5 of the IRQ status. Regards, Clement > > thanks, > o. > > > r_i2c: i2c@7081400 { > > -- > > 2.20.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-30 22:25 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-28 16:14 [PATCH v3 00/12] Allwinner A64/H6 IR support Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` [PATCH v3 01/12] dt-bindings: media: sunxi-ir: add A31 compatible Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-06-14 20:18 ` Rob Herring 2019-06-14 20:18 ` Rob Herring 2019-06-14 20:18 ` Rob Herring 2019-05-28 16:14 ` [PATCH v3 02/12] media: rc: Introduce sunxi_ir_quirks Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` [PATCH v3 03/12] media: rc: sunxi: Add A31 compatible Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-06-04 14:54 ` Ondřej Jirman 2019-06-04 14:54 ` Ondřej Jirman 2019-06-04 15:07 ` Clément Péron 2019-06-04 15:07 ` Clément Péron 2019-05-28 16:14 ` [PATCH v3 04/12] ARM: dts: sunxi: Prefer A31 bindings for IR Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` [PATCH v3 05/12] " Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` [PATCH v3 06/12] dt-bindings: media: sunxi-ir: Add A64 compatible Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` [PATCH v3 07/12] arm64: dts: allwinner: a64: Add IR node Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` [PATCH v3 08/12] arm64: dts: allwinner: a64: Enable IR on Orange Pi Win Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` [PATCH v3 09/12] dt-bindings: media: sunxi-ir: Add H6 compatible Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` [PATCH v3 10/12] arm64: dts: allwinner: h6: Add IR receiver node Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-30 14:55 ` Ondřej Jirman 2019-05-30 14:55 ` Ondřej Jirman 2019-05-30 14:55 ` 'Ondřej Jirman' via linux-sunxi 2019-05-30 22:25 ` Clément Péron [this message] 2019-05-30 22:25 ` Clément Péron 2019-05-31 12:46 ` [linux-sunxi] " Ondřej Jirman 2019-05-31 12:46 ` Ondřej Jirman 2019-05-31 12:46 ` 'Ondřej Jirman' via linux-sunxi 2019-06-03 19:58 ` [linux-sunxi] " Clément Péron 2019-06-03 19:58 ` Clément Péron 2019-06-03 19:58 ` Clément Péron 2019-06-04 12:33 ` [linux-sunxi] " Ondřej Jirman 2019-06-04 12:33 ` Ondřej Jirman 2019-06-04 12:33 ` 'Ondřej Jirman' via linux-sunxi 2019-06-04 14:47 ` [linux-sunxi] " Ondřej Jirman 2019-06-04 14:47 ` Ondřej Jirman 2019-06-04 14:47 ` 'Ondřej Jirman' via linux-sunxi 2019-06-04 15:04 ` [linux-sunxi] " Clément Péron 2019-06-04 15:04 ` Clément Péron 2019-06-04 15:30 ` Ondřej Jirman 2019-06-04 15:30 ` Ondřej Jirman 2019-06-04 15:30 ` 'Ondřej Jirman' via linux-sunxi 2019-06-04 16:12 ` [linux-sunxi] " Clément Péron 2019-06-04 16:12 ` Clément Péron 2019-06-04 16:12 ` Clément Péron 2019-05-28 16:14 ` [PATCH v3 11/12] arm64: dts: allwinner: h6: Enable IR on Beelink GS1 Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-28 16:14 ` [PATCH v3 12/12] arm64: defconfig: enable IR SUNXI option Clément Péron 2019-05-28 16:14 ` Clément Péron 2019-05-30 12:55 ` [PATCH v3 00/12] Allwinner A64/H6 IR support Sean Young 2019-05-30 12:55 ` Sean Young
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJiuCce7nHSktVsDKcR8GLRpD3WrN5yP3Nb_Hbu_Q9NjUQbSMw@mail.gmail.com \ --to=peron.clem@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@bootlin.com \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.