All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [RFC] gator: Add new package
@ 2021-04-24 10:24 Clément Péron
  2021-04-24 10:28 ` Clément Péron
  0 siblings, 1 reply; 11+ messages in thread
From: Clément Péron @ 2021-04-24 10:24 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Clément Péron

To communicate with the target device, Streamline requires the
gator daemon, gatord, to be running on the device.

Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
 meta-oe/recipes-devtools/gator/gator_7.5.0.bb | 22 +++++++++++++++++
 2 files changed, 46 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
 create mode 100644 meta-oe/recipes-devtools/gator/gator_7.5.0.bb

diff --git a/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
new file mode 100644
index 000000000000..8e59fffa1fc2
--- /dev/null
+++ b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
@@ -0,0 +1,24 @@
+From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
+Date: Fri, 16 Apr 2021 15:27:16 +0200
+Subject: [PATCH] gator: don't strip debug
+
+---
+ daemon/Makefile | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/daemon/Makefile b/daemon/Makefile
+index ba5f29cfeb10..6807948310f9 100644
+--- a/daemon/Makefile
++++ b/daemon/Makefile
+@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1 -d.` \>= 5),1)
+ 	CXXFLAGS += -fno-sized-deallocation
+ endif
+ 
+-# -s strips the binary of debug info
+-LDFLAGS     += -s
+ LDLIBS      += -lrt -lm -pthread
+ TARGET      := $(OBJ_DIR)gatord
+ ESCAPE_EXE  := $(OBJ_DIR)escape/escape
+-- 
+2.25.1
diff --git a/meta-oe/recipes-devtools/gator/gator_7.5.0.bb b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
new file mode 100644
index 000000000000..8e15b1ca5fc5
--- /dev/null
+++ b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
@@ -0,0 +1,22 @@
+SUMMARY = "DS-5 Streamine Gator daemon"
+DESCRIPTION = "Target-side daemon gathering data for ARM Streamline Performance Analyzer."
+
+LICENSE = "GPL-2.0-only"
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+LICENSE_libsensors = "LGPL-2.1-or-later"
+
+SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
+SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
+	   file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
+	  "
+
+S = "${WORKDIR}/git/daemon"
+
+EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
+    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}' 'CROSS_COMPILE=${TARGET_PREFIX}' \
+    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}' CXX='${CXX}'"
+
+do_install() {
+	install -d ${D}${sbindir}
+	install -m 0755 ${S}/gatord ${D}${sbindir}/gatord
+}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PATCH] [RFC] gator: Add new package
  2021-04-24 10:24 [PATCH] [RFC] gator: Add new package Clément Péron
@ 2021-04-24 10:28 ` Clément Péron
  2021-04-24 10:45   ` [oe] " Martin Jansa
  0 siblings, 1 reply; 11+ messages in thread
From: Clément Péron @ 2021-04-24 10:28 UTC (permalink / raw)
  To: openembeded-devel

Hi,

I have some questions regarding my patch.

On Sat, 24 Apr 2021 at 12:24, Clément Péron <peron.clem@gmail.com> wrote:
>
> To communicate with the target device, Streamline requires the
> gator daemon, gatord, to be running on the device.

Is gator the correct name for this package? or would gatord be better?

>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
>  .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
>  meta-oe/recipes-devtools/gator/gator_7.5.0.bb | 22 +++++++++++++++++
>  2 files changed, 46 insertions(+)
>  create mode 100644 meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
>  create mode 100644 meta-oe/recipes-devtools/gator/gator_7.5.0.bb
>
> diff --git a/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> new file mode 100644
> index 000000000000..8e59fffa1fc2
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> @@ -0,0 +1,24 @@
> +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
> +Date: Fri, 16 Apr 2021 15:27:16 +0200
> +Subject: [PATCH] gator: don't strip debug
> +
> +---
> + daemon/Makefile | 2 --
> + 1 file changed, 2 deletions(-)
> +
> +diff --git a/daemon/Makefile b/daemon/Makefile
> +index ba5f29cfeb10..6807948310f9 100644
> +--- a/daemon/Makefile
> ++++ b/daemon/Makefile
> +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1 -d.` \>= 5),1)
> +       CXXFLAGS += -fno-sized-deallocation
> + endif
> +
> +-# -s strips the binary of debug info
> +-LDFLAGS     += -s
> + LDLIBS      += -lrt -lm -pthread
> + TARGET      := $(OBJ_DIR)gatord
> + ESCAPE_EXE  := $(OBJ_DIR)escape/escape
> +--
> +2.25.1
> diff --git a/meta-oe/recipes-devtools/gator/gator_7.5.0.bb b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> new file mode 100644
> index 000000000000..8e15b1ca5fc5
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> @@ -0,0 +1,22 @@
> +SUMMARY = "DS-5 Streamine Gator daemon"
> +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline Performance Analyzer."
> +
> +LICENSE = "GPL-2.0-only"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +LICENSE_libsensors = "LGPL-2.1-or-later"

Gator git specifies that:

-libsensors source code in daemon/libsensors licensed under LGPL-2.1-or-later
-mxml source code in daemon/mxml licensed under APACHE-2.0 WITH
Mini-XML-exception
-perf_event.h from Linux userspace kernel headers in daemon/k licensed
under GPL-2.0-only WITH Linux-syscall-note.

I'm not sure how to properly reflect this in the recipe.

Thanks for your help,
Clement

> +
> +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
> +SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
> +          file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
> +         "
> +
> +S = "${WORKDIR}/git/daemon"
> +
> +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
> +    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}' 'CROSS_COMPILE=${TARGET_PREFIX}' \
> +    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}' CXX='${CXX}'"
> +
> +do_install() {
> +       install -d ${D}${sbindir}
> +       install -m 0755 ${S}/gatord ${D}${sbindir}/gatord
> +}
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [oe] [PATCH] [RFC] gator: Add new package
  2021-04-24 10:28 ` Clément Péron
@ 2021-04-24 10:45   ` Martin Jansa
  2021-04-24 11:24     ` Clément Péron
  0 siblings, 1 reply; 11+ messages in thread
From: Martin Jansa @ 2021-04-24 10:45 UTC (permalink / raw)
  To: Clément Péron; +Cc: openembeded-devel

[-- Attachment #1: Type: text/plain, Size: 5049 bytes --]

Why do you want to build only the daemon?

There are already 4 variants of this recipe in various layers (at least by
what's reported on layerindex):
http://git.linaro.org/openembedded/meta-linaro.git/tree/meta-linaro/recipes-kernel/gator/gator_git.bb?h=master
https://github.com/webosose/meta-webosose/blob/master/meta-webos/recipes-core/gator/gator_git.bb
https://github.com/kratsg/meta-l1calo/blob/master/recipes-kernel/gator/gator_git.bb
https://github.com/robseb/meta-intelfpga/blob/master/recipes-devtools/gator/gator_git.bb

so sharing some recipe which would suit most of these needs in meta-oe is
definitely welcome, but starting with just a daemon will just complicate
things to these layers.

But I understand that building the kernel modules for wider range of
kernels in different MACHINEs is quite pain (been there:
https://github.com/shr-project/meta-webosose/commit/f4674ac6fa18a0a96cefefa49ebf397a383a88f1
and given up shortly after:
https://github.com/shr-project/meta-webosose/commit/d4bc575623dfbfad780fc39fef47d55d4d6e698d
as I don't really use gator, it was just one of many build issues in
'bitbake world' I was looking at).

Regards,

On Sat, Apr 24, 2021 at 3:29 AM Clément Péron <peron.clem@gmail.com> wrote:

> Hi,
>
> I have some questions regarding my patch.
>
> On Sat, 24 Apr 2021 at 12:24, Clément Péron <peron.clem@gmail.com> wrote:
> >
> > To communicate with the target device, Streamline requires the
> > gator daemon, gatord, to be running on the device.
>
> Is gator the correct name for this package? or would gatord be better?
>
> >
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> >  .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
> >  meta-oe/recipes-devtools/gator/gator_7.5.0.bb | 22 +++++++++++++++++
> >  2 files changed, 46 insertions(+)
> >  create mode 100644
> meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> >  create mode 100644 meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> >
> > diff --git
> a/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> > new file mode 100644
> > index 000000000000..8e59fffa1fc2
> > --- /dev/null
> > +++
> b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> > @@ -0,0 +1,24 @@
> > +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17 00:00:00 2001
> > +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
> > +Date: Fri, 16 Apr 2021 15:27:16 +0200
> > +Subject: [PATCH] gator: don't strip debug
> > +
> > +---
> > + daemon/Makefile | 2 --
> > + 1 file changed, 2 deletions(-)
> > +
> > +diff --git a/daemon/Makefile b/daemon/Makefile
> > +index ba5f29cfeb10..6807948310f9 100644
> > +--- a/daemon/Makefile
> > ++++ b/daemon/Makefile
> > +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1
> -d.` \>= 5),1)
> > +       CXXFLAGS += -fno-sized-deallocation
> > + endif
> > +
> > +-# -s strips the binary of debug info
> > +-LDFLAGS     += -s
> > + LDLIBS      += -lrt -lm -pthread
> > + TARGET      := $(OBJ_DIR)gatord
> > + ESCAPE_EXE  := $(OBJ_DIR)escape/escape
> > +--
> > +2.25.1
> > diff --git a/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> > new file mode 100644
> > index 000000000000..8e15b1ca5fc5
> > --- /dev/null
> > +++ b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> > @@ -0,0 +1,22 @@
> > +SUMMARY = "DS-5 Streamine Gator daemon"
> > +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline
> Performance Analyzer."
> > +
> > +LICENSE = "GPL-2.0-only"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> > +LICENSE_libsensors = "LGPL-2.1-or-later"
>
> Gator git specifies that:
>
> -libsensors source code in daemon/libsensors licensed under
> LGPL-2.1-or-later
> -mxml source code in daemon/mxml licensed under APACHE-2.0 WITH
> Mini-XML-exception
> -perf_event.h from Linux userspace kernel headers in daemon/k licensed
> under GPL-2.0-only WITH Linux-syscall-note.
>
> I'm not sure how to properly reflect this in the recipe.
>
> Thanks for your help,
> Clement
>
> > +
> > +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
> > +SRC_URI = "git://
> github.com/ARM-software/gator.git;protocol=http;branch=master \
> > +          file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
> > +         "
> > +
> > +S = "${WORKDIR}/git/daemon"
> > +
> > +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE
> -DETCDIR=\"${sysconfdir}\"' \
> > +    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}'
> 'CROSS_COMPILE=${TARGET_PREFIX}' \
> > +    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}'
> CXX='${CXX}'"
> > +
> > +do_install() {
> > +       install -d ${D}${sbindir}
> > +       install -m 0755 ${S}/gatord ${D}${sbindir}/gatord
> > +}
> > --
> > 2.25.1
> >
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 7353 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [oe] [PATCH] [RFC] gator: Add new package
  2021-04-24 10:45   ` [oe] " Martin Jansa
@ 2021-04-24 11:24     ` Clément Péron
  2021-04-24 11:28       ` Martin Jansa
  0 siblings, 1 reply; 11+ messages in thread
From: Clément Péron @ 2021-04-24 11:24 UTC (permalink / raw)
  To: Martin Jansa; +Cc: openembeded-devel

Hi Martin,

On Sat, 24 Apr 2021 at 12:45, Martin Jansa <martin.jansa@gmail.com> wrote:
>
> Why do you want to build only the daemon?
>
> There are already 4 variants of this recipe in various layers (at least by what's reported on layerindex):
> http://git.linaro.org/openembedded/meta-linaro.git/tree/meta-linaro/recipes-kernel/gator/gator_git.bb?h=master
> https://github.com/webosose/meta-webosose/blob/master/meta-webos/recipes-core/gator/gator_git.bb
> https://github.com/kratsg/meta-l1calo/blob/master/recipes-kernel/gator/gator_git.bb
> https://github.com/robseb/meta-intelfpga/blob/master/recipes-devtools/gator/gator_git.bb
>
> so sharing some recipe which would suit most of these needs in meta-oe is definitely welcome, but starting with just a daemon will just complicate things to these layers.

New gator daemon doesn't need a kernel module anymore, it's now fully userspace.

Regards,
Clement

>
> But I understand that building the kernel modules for wider range of kernels in different MACHINEs is quite pain (been there:
> https://github.com/shr-project/meta-webosose/commit/f4674ac6fa18a0a96cefefa49ebf397a383a88f1
> and given up shortly after:
> https://github.com/shr-project/meta-webosose/commit/d4bc575623dfbfad780fc39fef47d55d4d6e698d
> as I don't really use gator, it was just one of many build issues in 'bitbake world' I was looking at).
>
> Regards,
>
> On Sat, Apr 24, 2021 at 3:29 AM Clément Péron <peron.clem@gmail.com> wrote:
>>
>> Hi,
>>
>> I have some questions regarding my patch.
>>
>> On Sat, 24 Apr 2021 at 12:24, Clément Péron <peron.clem@gmail.com> wrote:
>> >
>> > To communicate with the target device, Streamline requires the
>> > gator daemon, gatord, to be running on the device.
>>
>> Is gator the correct name for this package? or would gatord be better?
>>
>> >
>> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
>> > ---
>> >  .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
>> >  meta-oe/recipes-devtools/gator/gator_7.5.0.bb | 22 +++++++++++++++++
>> >  2 files changed, 46 insertions(+)
>> >  create mode 100644 meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
>> >  create mode 100644 meta-oe/recipes-devtools/gator/gator_7.5.0.bb
>> >
>> > diff --git a/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
>> > new file mode 100644
>> > index 000000000000..8e59fffa1fc2
>> > --- /dev/null
>> > +++ b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
>> > @@ -0,0 +1,24 @@
>> > +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17 00:00:00 2001
>> > +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
>> > +Date: Fri, 16 Apr 2021 15:27:16 +0200
>> > +Subject: [PATCH] gator: don't strip debug
>> > +
>> > +---
>> > + daemon/Makefile | 2 --
>> > + 1 file changed, 2 deletions(-)
>> > +
>> > +diff --git a/daemon/Makefile b/daemon/Makefile
>> > +index ba5f29cfeb10..6807948310f9 100644
>> > +--- a/daemon/Makefile
>> > ++++ b/daemon/Makefile
>> > +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1 -d.` \>= 5),1)
>> > +       CXXFLAGS += -fno-sized-deallocation
>> > + endif
>> > +
>> > +-# -s strips the binary of debug info
>> > +-LDFLAGS     += -s
>> > + LDLIBS      += -lrt -lm -pthread
>> > + TARGET      := $(OBJ_DIR)gatord
>> > + ESCAPE_EXE  := $(OBJ_DIR)escape/escape
>> > +--
>> > +2.25.1
>> > diff --git a/meta-oe/recipes-devtools/gator/gator_7.5.0.bb b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
>> > new file mode 100644
>> > index 000000000000..8e15b1ca5fc5
>> > --- /dev/null
>> > +++ b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
>> > @@ -0,0 +1,22 @@
>> > +SUMMARY = "DS-5 Streamine Gator daemon"
>> > +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline Performance Analyzer."
>> > +
>> > +LICENSE = "GPL-2.0-only"
>> > +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> > +LICENSE_libsensors = "LGPL-2.1-or-later"
>>
>> Gator git specifies that:
>>
>> -libsensors source code in daemon/libsensors licensed under LGPL-2.1-or-later
>> -mxml source code in daemon/mxml licensed under APACHE-2.0 WITH
>> Mini-XML-exception
>> -perf_event.h from Linux userspace kernel headers in daemon/k licensed
>> under GPL-2.0-only WITH Linux-syscall-note.
>>
>> I'm not sure how to properly reflect this in the recipe.
>>
>> Thanks for your help,
>> Clement
>>
>> > +
>> > +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
>> > +SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
>> > +          file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
>> > +         "
>> > +
>> > +S = "${WORKDIR}/git/daemon"
>> > +
>> > +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
>> > +    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}' 'CROSS_COMPILE=${TARGET_PREFIX}' \
>> > +    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}' CXX='${CXX}'"
>> > +
>> > +do_install() {
>> > +       install -d ${D}${sbindir}
>> > +       install -m 0755 ${S}/gatord ${D}${sbindir}/gatord
>> > +}
>> > --
>> > 2.25.1
>> >
>>
>> 
>>

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [oe] [PATCH] [RFC] gator: Add new package
  2021-04-24 11:24     ` Clément Péron
@ 2021-04-24 11:28       ` Martin Jansa
  2021-04-24 21:47         ` Ross Burton
  0 siblings, 1 reply; 11+ messages in thread
From: Martin Jansa @ 2021-04-24 11:28 UTC (permalink / raw)
  To: Clément Péron; +Cc: openembeded-devel

[-- Attachment #1: Type: text/plain, Size: 5910 bytes --]

Ah, even better than, but I would keep the recipe name as gator, if it's
going to completely replace these older gator versions in other layers.

On Sat, Apr 24, 2021 at 1:24 PM Clément Péron <peron.clem@gmail.com> wrote:

> Hi Martin,
>
> On Sat, 24 Apr 2021 at 12:45, Martin Jansa <martin.jansa@gmail.com> wrote:
> >
> > Why do you want to build only the daemon?
> >
> > There are already 4 variants of this recipe in various layers (at least
> by what's reported on layerindex):
> >
> http://git.linaro.org/openembedded/meta-linaro.git/tree/meta-linaro/recipes-kernel/gator/gator_git.bb?h=master
> >
> https://github.com/webosose/meta-webosose/blob/master/meta-webos/recipes-core/gator/gator_git.bb
> >
> https://github.com/kratsg/meta-l1calo/blob/master/recipes-kernel/gator/gator_git.bb
> >
> https://github.com/robseb/meta-intelfpga/blob/master/recipes-devtools/gator/gator_git.bb
> >
> > so sharing some recipe which would suit most of these needs in meta-oe
> is definitely welcome, but starting with just a daemon will just complicate
> things to these layers.
>
> New gator daemon doesn't need a kernel module anymore, it's now fully
> userspace.
>
> Regards,
> Clement
>
> >
> > But I understand that building the kernel modules for wider range of
> kernels in different MACHINEs is quite pain (been there:
> >
> https://github.com/shr-project/meta-webosose/commit/f4674ac6fa18a0a96cefefa49ebf397a383a88f1
> > and given up shortly after:
> >
> https://github.com/shr-project/meta-webosose/commit/d4bc575623dfbfad780fc39fef47d55d4d6e698d
> > as I don't really use gator, it was just one of many build issues in
> 'bitbake world' I was looking at).
> >
> > Regards,
> >
> > On Sat, Apr 24, 2021 at 3:29 AM Clément Péron <peron.clem@gmail.com>
> wrote:
> >>
> >> Hi,
> >>
> >> I have some questions regarding my patch.
> >>
> >> On Sat, 24 Apr 2021 at 12:24, Clément Péron <peron.clem@gmail.com>
> wrote:
> >> >
> >> > To communicate with the target device, Streamline requires the
> >> > gator daemon, gatord, to be running on the device.
> >>
> >> Is gator the correct name for this package? or would gatord be better?
> >>
> >> >
> >> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> >> > ---
> >> >  .../gator/0001-gator-don-t-strip-debug.patch  | 24
> +++++++++++++++++++
> >> >  meta-oe/recipes-devtools/gator/gator_7.5.0.bb | 22 +++++++++++++++++
> >> >  2 files changed, 46 insertions(+)
> >> >  create mode 100644
> meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> >> >  create mode 100644 meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> >> >
> >> > diff --git
> a/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> >> > new file mode 100644
> >> > index 000000000000..8e59fffa1fc2
> >> > --- /dev/null
> >> > +++
> b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> >> > @@ -0,0 +1,24 @@
> >> > +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17 00:00:00
> 2001
> >> > +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
> >> > +Date: Fri, 16 Apr 2021 15:27:16 +0200
> >> > +Subject: [PATCH] gator: don't strip debug
> >> > +
> >> > +---
> >> > + daemon/Makefile | 2 --
> >> > + 1 file changed, 2 deletions(-)
> >> > +
> >> > +diff --git a/daemon/Makefile b/daemon/Makefile
> >> > +index ba5f29cfeb10..6807948310f9 100644
> >> > +--- a/daemon/Makefile
> >> > ++++ b/daemon/Makefile
> >> > +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1
> -d.` \>= 5),1)
> >> > +       CXXFLAGS += -fno-sized-deallocation
> >> > + endif
> >> > +
> >> > +-# -s strips the binary of debug info
> >> > +-LDFLAGS     += -s
> >> > + LDLIBS      += -lrt -lm -pthread
> >> > + TARGET      := $(OBJ_DIR)gatord
> >> > + ESCAPE_EXE  := $(OBJ_DIR)escape/escape
> >> > +--
> >> > +2.25.1
> >> > diff --git a/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> >> > new file mode 100644
> >> > index 000000000000..8e15b1ca5fc5
> >> > --- /dev/null
> >> > +++ b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> >> > @@ -0,0 +1,22 @@
> >> > +SUMMARY = "DS-5 Streamine Gator daemon"
> >> > +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline
> Performance Analyzer."
> >> > +
> >> > +LICENSE = "GPL-2.0-only"
> >> > +LIC_FILES_CHKSUM =
> "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >> > +LICENSE_libsensors = "LGPL-2.1-or-later"
> >>
> >> Gator git specifies that:
> >>
> >> -libsensors source code in daemon/libsensors licensed under
> LGPL-2.1-or-later
> >> -mxml source code in daemon/mxml licensed under APACHE-2.0 WITH
> >> Mini-XML-exception
> >> -perf_event.h from Linux userspace kernel headers in daemon/k licensed
> >> under GPL-2.0-only WITH Linux-syscall-note.
> >>
> >> I'm not sure how to properly reflect this in the recipe.
> >>
> >> Thanks for your help,
> >> Clement
> >>
> >> > +
> >> > +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
> >> > +SRC_URI = "git://
> github.com/ARM-software/gator.git;protocol=http;branch=master \
> >> > +          file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
> >> > +         "
> >> > +
> >> > +S = "${WORKDIR}/git/daemon"
> >> > +
> >> > +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH}
> -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
> >> > +    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}'
> 'CROSS_COMPILE=${TARGET_PREFIX}' \
> >> > +    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}'
> CXX='${CXX}'"
> >> > +
> >> > +do_install() {
> >> > +       install -d ${D}${sbindir}
> >> > +       install -m 0755 ${S}/gatord ${D}${sbindir}/gatord
> >> > +}
> >> > --
> >> > 2.25.1
> >> >
> >>
> >> 
> >>
>

[-- Attachment #2: Type: text/html, Size: 9030 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [oe] [PATCH] [RFC] gator: Add new package
  2021-04-24 11:28       ` Martin Jansa
@ 2021-04-24 21:47         ` Ross Burton
  2021-04-24 22:11           ` Khem Raj
  0 siblings, 1 reply; 11+ messages in thread
From: Ross Burton @ 2021-04-24 21:47 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Clément Péron, openembeded-devel

To be honest, as this is Arm-specific I'd encourage adding it to
meta-arm instead of meta-oe.

(speaking as the meta-arm co-maintainer)

Ross

On Sat, 24 Apr 2021 at 12:29, Martin Jansa <Martin.Jansa@gmail.com> wrote:
>
> Ah, even better than, but I would keep the recipe name as gator, if it's going to completely replace these older gator versions in other layers.
>
> On Sat, Apr 24, 2021 at 1:24 PM Clément Péron <peron.clem@gmail.com> wrote:
>>
>> Hi Martin,
>>
>> On Sat, 24 Apr 2021 at 12:45, Martin Jansa <martin.jansa@gmail.com> wrote:
>> >
>> > Why do you want to build only the daemon?
>> >
>> > There are already 4 variants of this recipe in various layers (at least by what's reported on layerindex):
>> > http://git.linaro.org/openembedded/meta-linaro.git/tree/meta-linaro/recipes-kernel/gator/gator_git.bb?h=master
>> > https://github.com/webosose/meta-webosose/blob/master/meta-webos/recipes-core/gator/gator_git.bb
>> > https://github.com/kratsg/meta-l1calo/blob/master/recipes-kernel/gator/gator_git.bb
>> > https://github.com/robseb/meta-intelfpga/blob/master/recipes-devtools/gator/gator_git.bb
>> >
>> > so sharing some recipe which would suit most of these needs in meta-oe is definitely welcome, but starting with just a daemon will just complicate things to these layers.
>>
>> New gator daemon doesn't need a kernel module anymore, it's now fully userspace.
>>
>> Regards,
>> Clement
>>
>> >
>> > But I understand that building the kernel modules for wider range of kernels in different MACHINEs is quite pain (been there:
>> > https://github.com/shr-project/meta-webosose/commit/f4674ac6fa18a0a96cefefa49ebf397a383a88f1
>> > and given up shortly after:
>> > https://github.com/shr-project/meta-webosose/commit/d4bc575623dfbfad780fc39fef47d55d4d6e698d
>> > as I don't really use gator, it was just one of many build issues in 'bitbake world' I was looking at).
>> >
>> > Regards,
>> >
>> > On Sat, Apr 24, 2021 at 3:29 AM Clément Péron <peron.clem@gmail.com> wrote:
>> >>
>> >> Hi,
>> >>
>> >> I have some questions regarding my patch.
>> >>
>> >> On Sat, 24 Apr 2021 at 12:24, Clément Péron <peron.clem@gmail.com> wrote:
>> >> >
>> >> > To communicate with the target device, Streamline requires the
>> >> > gator daemon, gatord, to be running on the device.
>> >>
>> >> Is gator the correct name for this package? or would gatord be better?
>> >>
>> >> >
>> >> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
>> >> > ---
>> >> >  .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
>> >> >  meta-oe/recipes-devtools/gator/gator_7.5.0.bb | 22 +++++++++++++++++
>> >> >  2 files changed, 46 insertions(+)
>> >> >  create mode 100644 meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
>> >> >  create mode 100644 meta-oe/recipes-devtools/gator/gator_7.5.0.bb
>> >> >
>> >> > diff --git a/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
>> >> > new file mode 100644
>> >> > index 000000000000..8e59fffa1fc2
>> >> > --- /dev/null
>> >> > +++ b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
>> >> > @@ -0,0 +1,24 @@
>> >> > +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17 00:00:00 2001
>> >> > +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
>> >> > +Date: Fri, 16 Apr 2021 15:27:16 +0200
>> >> > +Subject: [PATCH] gator: don't strip debug
>> >> > +
>> >> > +---
>> >> > + daemon/Makefile | 2 --
>> >> > + 1 file changed, 2 deletions(-)
>> >> > +
>> >> > +diff --git a/daemon/Makefile b/daemon/Makefile
>> >> > +index ba5f29cfeb10..6807948310f9 100644
>> >> > +--- a/daemon/Makefile
>> >> > ++++ b/daemon/Makefile
>> >> > +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1 -d.` \>= 5),1)
>> >> > +       CXXFLAGS += -fno-sized-deallocation
>> >> > + endif
>> >> > +
>> >> > +-# -s strips the binary of debug info
>> >> > +-LDFLAGS     += -s
>> >> > + LDLIBS      += -lrt -lm -pthread
>> >> > + TARGET      := $(OBJ_DIR)gatord
>> >> > + ESCAPE_EXE  := $(OBJ_DIR)escape/escape
>> >> > +--
>> >> > +2.25.1
>> >> > diff --git a/meta-oe/recipes-devtools/gator/gator_7.5.0.bb b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
>> >> > new file mode 100644
>> >> > index 000000000000..8e15b1ca5fc5
>> >> > --- /dev/null
>> >> > +++ b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
>> >> > @@ -0,0 +1,22 @@
>> >> > +SUMMARY = "DS-5 Streamine Gator daemon"
>> >> > +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline Performance Analyzer."
>> >> > +
>> >> > +LICENSE = "GPL-2.0-only"
>> >> > +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> >> > +LICENSE_libsensors = "LGPL-2.1-or-later"
>> >>
>> >> Gator git specifies that:
>> >>
>> >> -libsensors source code in daemon/libsensors licensed under LGPL-2.1-or-later
>> >> -mxml source code in daemon/mxml licensed under APACHE-2.0 WITH
>> >> Mini-XML-exception
>> >> -perf_event.h from Linux userspace kernel headers in daemon/k licensed
>> >> under GPL-2.0-only WITH Linux-syscall-note.
>> >>
>> >> I'm not sure how to properly reflect this in the recipe.
>> >>
>> >> Thanks for your help,
>> >> Clement
>> >>
>> >> > +
>> >> > +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
>> >> > +SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
>> >> > +          file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
>> >> > +         "
>> >> > +
>> >> > +S = "${WORKDIR}/git/daemon"
>> >> > +
>> >> > +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
>> >> > +    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}' 'CROSS_COMPILE=${TARGET_PREFIX}' \
>> >> > +    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}' CXX='${CXX}'"
>> >> > +
>> >> > +do_install() {
>> >> > +       install -d ${D}${sbindir}
>> >> > +       install -m 0755 ${S}/gatord ${D}${sbindir}/gatord
>> >> > +}
>> >> > --
>> >> > 2.25.1
>> >> >
>> >>
>> >>
>> >>
>
>
> 
>

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [oe] [PATCH] [RFC] gator: Add new package
  2021-04-24 21:47         ` Ross Burton
@ 2021-04-24 22:11           ` Khem Raj
  2021-04-25 15:57             ` Clément Péron
  2021-04-26 11:18             ` Ross Burton
  0 siblings, 2 replies; 11+ messages in thread
From: Khem Raj @ 2021-04-24 22:11 UTC (permalink / raw)
  To: Ross Burton; +Cc: Martin Jansa, Clément Péron, openembeded-devel

On Sat, Apr 24, 2021 at 2:48 PM Ross Burton <ross@burtonini.com> wrote:
>
> To be honest, as this is Arm-specific I'd encourage adding it to
> meta-arm instead of meta-oe.

I would tend to agree, although there is something to consider it also
means all arm SOCs will have to depend on meta-arm for this recipe
which may not be a bad thing but some BSP layers for ARM based SOCs
are independent

>
> (speaking as the meta-arm co-maintainer)
>
> Ross
>
> On Sat, 24 Apr 2021 at 12:29, Martin Jansa <Martin.Jansa@gmail.com> wrote:
> >
> > Ah, even better than, but I would keep the recipe name as gator, if it's going to completely replace these older gator versions in other layers.
> >
> > On Sat, Apr 24, 2021 at 1:24 PM Clément Péron <peron.clem@gmail.com> wrote:
> >>
> >> Hi Martin,
> >>
> >> On Sat, 24 Apr 2021 at 12:45, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> >
> >> > Why do you want to build only the daemon?
> >> >
> >> > There are already 4 variants of this recipe in various layers (at least by what's reported on layerindex):
> >> > http://git.linaro.org/openembedded/meta-linaro.git/tree/meta-linaro/recipes-kernel/gator/gator_git.bb?h=master
> >> > https://github.com/webosose/meta-webosose/blob/master/meta-webos/recipes-core/gator/gator_git.bb
> >> > https://github.com/kratsg/meta-l1calo/blob/master/recipes-kernel/gator/gator_git.bb
> >> > https://github.com/robseb/meta-intelfpga/blob/master/recipes-devtools/gator/gator_git.bb
> >> >
> >> > so sharing some recipe which would suit most of these needs in meta-oe is definitely welcome, but starting with just a daemon will just complicate things to these layers.
> >>
> >> New gator daemon doesn't need a kernel module anymore, it's now fully userspace.
> >>
> >> Regards,
> >> Clement
> >>
> >> >
> >> > But I understand that building the kernel modules for wider range of kernels in different MACHINEs is quite pain (been there:
> >> > https://github.com/shr-project/meta-webosose/commit/f4674ac6fa18a0a96cefefa49ebf397a383a88f1
> >> > and given up shortly after:
> >> > https://github.com/shr-project/meta-webosose/commit/d4bc575623dfbfad780fc39fef47d55d4d6e698d
> >> > as I don't really use gator, it was just one of many build issues in 'bitbake world' I was looking at).
> >> >
> >> > Regards,
> >> >
> >> > On Sat, Apr 24, 2021 at 3:29 AM Clément Péron <peron.clem@gmail.com> wrote:
> >> >>
> >> >> Hi,
> >> >>
> >> >> I have some questions regarding my patch.
> >> >>
> >> >> On Sat, 24 Apr 2021 at 12:24, Clément Péron <peron.clem@gmail.com> wrote:
> >> >> >
> >> >> > To communicate with the target device, Streamline requires the
> >> >> > gator daemon, gatord, to be running on the device.
> >> >>
> >> >> Is gator the correct name for this package? or would gatord be better?
> >> >>
> >> >> >
> >> >> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> >> >> > ---
> >> >> >  .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
> >> >> >  meta-oe/recipes-devtools/gator/gator_7.5.0.bb | 22 +++++++++++++++++
> >> >> >  2 files changed, 46 insertions(+)
> >> >> >  create mode 100644 meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> >> >> >  create mode 100644 meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> >> >> >
> >> >> > diff --git a/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> >> >> > new file mode 100644
> >> >> > index 000000000000..8e59fffa1fc2
> >> >> > --- /dev/null
> >> >> > +++ b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> >> >> > @@ -0,0 +1,24 @@
> >> >> > +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17 00:00:00 2001
> >> >> > +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
> >> >> > +Date: Fri, 16 Apr 2021 15:27:16 +0200
> >> >> > +Subject: [PATCH] gator: don't strip debug
> >> >> > +
> >> >> > +---
> >> >> > + daemon/Makefile | 2 --
> >> >> > + 1 file changed, 2 deletions(-)
> >> >> > +
> >> >> > +diff --git a/daemon/Makefile b/daemon/Makefile
> >> >> > +index ba5f29cfeb10..6807948310f9 100644
> >> >> > +--- a/daemon/Makefile
> >> >> > ++++ b/daemon/Makefile
> >> >> > +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1 -d.` \>= 5),1)
> >> >> > +       CXXFLAGS += -fno-sized-deallocation
> >> >> > + endif
> >> >> > +
> >> >> > +-# -s strips the binary of debug info
> >> >> > +-LDFLAGS     += -s
> >> >> > + LDLIBS      += -lrt -lm -pthread
> >> >> > + TARGET      := $(OBJ_DIR)gatord
> >> >> > + ESCAPE_EXE  := $(OBJ_DIR)escape/escape
> >> >> > +--
> >> >> > +2.25.1
> >> >> > diff --git a/meta-oe/recipes-devtools/gator/gator_7.5.0.bb b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> >> >> > new file mode 100644
> >> >> > index 000000000000..8e15b1ca5fc5
> >> >> > --- /dev/null
> >> >> > +++ b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> >> >> > @@ -0,0 +1,22 @@
> >> >> > +SUMMARY = "DS-5 Streamine Gator daemon"
> >> >> > +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline Performance Analyzer."
> >> >> > +
> >> >> > +LICENSE = "GPL-2.0-only"
> >> >> > +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >> >> > +LICENSE_libsensors = "LGPL-2.1-or-later"
> >> >>
> >> >> Gator git specifies that:
> >> >>
> >> >> -libsensors source code in daemon/libsensors licensed under LGPL-2.1-or-later
> >> >> -mxml source code in daemon/mxml licensed under APACHE-2.0 WITH
> >> >> Mini-XML-exception
> >> >> -perf_event.h from Linux userspace kernel headers in daemon/k licensed
> >> >> under GPL-2.0-only WITH Linux-syscall-note.
> >> >>
> >> >> I'm not sure how to properly reflect this in the recipe.
> >> >>
> >> >> Thanks for your help,
> >> >> Clement
> >> >>
> >> >> > +
> >> >> > +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
> >> >> > +SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
> >> >> > +          file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
> >> >> > +         "
> >> >> > +
> >> >> > +S = "${WORKDIR}/git/daemon"
> >> >> > +
> >> >> > +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
> >> >> > +    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}' 'CROSS_COMPILE=${TARGET_PREFIX}' \
> >> >> > +    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}' CXX='${CXX}'"
> >> >> > +
> >> >> > +do_install() {
> >> >> > +       install -d ${D}${sbindir}
> >> >> > +       install -m 0755 ${S}/gatord ${D}${sbindir}/gatord
> >> >> > +}
> >> >> > --
> >> >> > 2.25.1
> >> >> >
> >> >>
> >> >>
> >> >>
> >
> >
> >
> >
>
> 
>

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [oe] [PATCH] [RFC] gator: Add new package
  2021-04-24 22:11           ` Khem Raj
@ 2021-04-25 15:57             ` Clément Péron
  2021-04-26 11:18             ` Ross Burton
  1 sibling, 0 replies; 11+ messages in thread
From: Clément Péron @ 2021-04-25 15:57 UTC (permalink / raw)
  To: Khem Raj; +Cc: Ross Burton, Martin Jansa, openembeded-devel

Hi,

On Sun, 25 Apr 2021 at 00:12, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Sat, Apr 24, 2021 at 2:48 PM Ross Burton <ross@burtonini.com> wrote:
> >
> > To be honest, as this is Arm-specific I'd encourage adding it to
> > meta-arm instead of meta-oe.
>
> I would tend to agree, although there is something to consider it also
> means all arm SOCs will have to depend on meta-arm for this recipe
> which may not be a bad thing but some BSP layers for ARM based SOCs
> are independent

Ok, so I will submit this patch to meta-arm.

Clement

>
> >
> > (speaking as the meta-arm co-maintainer)
> >
> > Ross
> >
> > On Sat, 24 Apr 2021 at 12:29, Martin Jansa <Martin.Jansa@gmail.com> wrote:
> > >
> > > Ah, even better than, but I would keep the recipe name as gator, if it's going to completely replace these older gator versions in other layers.
> > >
> > > On Sat, Apr 24, 2021 at 1:24 PM Clément Péron <peron.clem@gmail.com> wrote:
> > >>
> > >> Hi Martin,
> > >>
> > >> On Sat, 24 Apr 2021 at 12:45, Martin Jansa <martin.jansa@gmail.com> wrote:
> > >> >
> > >> > Why do you want to build only the daemon?
> > >> >
> > >> > There are already 4 variants of this recipe in various layers (at least by what's reported on layerindex):
> > >> > http://git.linaro.org/openembedded/meta-linaro.git/tree/meta-linaro/recipes-kernel/gator/gator_git.bb?h=master
> > >> > https://github.com/webosose/meta-webosose/blob/master/meta-webos/recipes-core/gator/gator_git.bb
> > >> > https://github.com/kratsg/meta-l1calo/blob/master/recipes-kernel/gator/gator_git.bb
> > >> > https://github.com/robseb/meta-intelfpga/blob/master/recipes-devtools/gator/gator_git.bb
> > >> >
> > >> > so sharing some recipe which would suit most of these needs in meta-oe is definitely welcome, but starting with just a daemon will just complicate things to these layers.
> > >>
> > >> New gator daemon doesn't need a kernel module anymore, it's now fully userspace.
> > >>
> > >> Regards,
> > >> Clement
> > >>
> > >> >
> > >> > But I understand that building the kernel modules for wider range of kernels in different MACHINEs is quite pain (been there:
> > >> > https://github.com/shr-project/meta-webosose/commit/f4674ac6fa18a0a96cefefa49ebf397a383a88f1
> > >> > and given up shortly after:
> > >> > https://github.com/shr-project/meta-webosose/commit/d4bc575623dfbfad780fc39fef47d55d4d6e698d
> > >> > as I don't really use gator, it was just one of many build issues in 'bitbake world' I was looking at).
> > >> >
> > >> > Regards,
> > >> >
> > >> > On Sat, Apr 24, 2021 at 3:29 AM Clément Péron <peron.clem@gmail.com> wrote:
> > >> >>
> > >> >> Hi,
> > >> >>
> > >> >> I have some questions regarding my patch.
> > >> >>
> > >> >> On Sat, 24 Apr 2021 at 12:24, Clément Péron <peron.clem@gmail.com> wrote:
> > >> >> >
> > >> >> > To communicate with the target device, Streamline requires the
> > >> >> > gator daemon, gatord, to be running on the device.
> > >> >>
> > >> >> Is gator the correct name for this package? or would gatord be better?
> > >> >>
> > >> >> >
> > >> >> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > >> >> > ---
> > >> >> >  .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
> > >> >> >  meta-oe/recipes-devtools/gator/gator_7.5.0.bb | 22 +++++++++++++++++
> > >> >> >  2 files changed, 46 insertions(+)
> > >> >> >  create mode 100644 meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> > >> >> >  create mode 100644 meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> > >> >> >
> > >> >> > diff --git a/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> > >> >> > new file mode 100644
> > >> >> > index 000000000000..8e59fffa1fc2
> > >> >> > --- /dev/null
> > >> >> > +++ b/meta-oe/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
> > >> >> > @@ -0,0 +1,24 @@
> > >> >> > +From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17 00:00:00 2001
> > >> >> > +From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
> > >> >> > +Date: Fri, 16 Apr 2021 15:27:16 +0200
> > >> >> > +Subject: [PATCH] gator: don't strip debug
> > >> >> > +
> > >> >> > +---
> > >> >> > + daemon/Makefile | 2 --
> > >> >> > + 1 file changed, 2 deletions(-)
> > >> >> > +
> > >> >> > +diff --git a/daemon/Makefile b/daemon/Makefile
> > >> >> > +index ba5f29cfeb10..6807948310f9 100644
> > >> >> > +--- a/daemon/Makefile
> > >> >> > ++++ b/daemon/Makefile
> > >> >> > +@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1 -d.` \>= 5),1)
> > >> >> > +       CXXFLAGS += -fno-sized-deallocation
> > >> >> > + endif
> > >> >> > +
> > >> >> > +-# -s strips the binary of debug info
> > >> >> > +-LDFLAGS     += -s
> > >> >> > + LDLIBS      += -lrt -lm -pthread
> > >> >> > + TARGET      := $(OBJ_DIR)gatord
> > >> >> > + ESCAPE_EXE  := $(OBJ_DIR)escape/escape
> > >> >> > +--
> > >> >> > +2.25.1
> > >> >> > diff --git a/meta-oe/recipes-devtools/gator/gator_7.5.0.bb b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> > >> >> > new file mode 100644
> > >> >> > index 000000000000..8e15b1ca5fc5
> > >> >> > --- /dev/null
> > >> >> > +++ b/meta-oe/recipes-devtools/gator/gator_7.5.0.bb
> > >> >> > @@ -0,0 +1,22 @@
> > >> >> > +SUMMARY = "DS-5 Streamine Gator daemon"
> > >> >> > +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline Performance Analyzer."
> > >> >> > +
> > >> >> > +LICENSE = "GPL-2.0-only"
> > >> >> > +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> > >> >> > +LICENSE_libsensors = "LGPL-2.1-or-later"
> > >> >>
> > >> >> Gator git specifies that:
> > >> >>
> > >> >> -libsensors source code in daemon/libsensors licensed under LGPL-2.1-or-later
> > >> >> -mxml source code in daemon/mxml licensed under APACHE-2.0 WITH
> > >> >> Mini-XML-exception
> > >> >> -perf_event.h from Linux userspace kernel headers in daemon/k licensed
> > >> >> under GPL-2.0-only WITH Linux-syscall-note.
> > >> >>
> > >> >> I'm not sure how to properly reflect this in the recipe.
> > >> >>
> > >> >> Thanks for your help,
> > >> >> Clement
> > >> >>
> > >> >> > +
> > >> >> > +SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
> > >> >> > +SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
> > >> >> > +          file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
> > >> >> > +         "
> > >> >> > +
> > >> >> > +S = "${WORKDIR}/git/daemon"
> > >> >> > +
> > >> >> > +EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
> > >> >> > +    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}' 'CROSS_COMPILE=${TARGET_PREFIX}' \
> > >> >> > +    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}' CXX='${CXX}'"
> > >> >> > +
> > >> >> > +do_install() {
> > >> >> > +       install -d ${D}${sbindir}
> > >> >> > +       install -m 0755 ${S}/gatord ${D}${sbindir}/gatord
> > >> >> > +}
> > >> >> > --
> > >> >> > 2.25.1
> > >> >> >
> > >> >>
> > >> >>
> > >> >>
> > >
> > >
> > >
> > >
> >
> > 
> >

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [oe] [PATCH] [RFC] gator: Add new package
  2021-04-24 22:11           ` Khem Raj
  2021-04-25 15:57             ` Clément Péron
@ 2021-04-26 11:18             ` Ross Burton
  2021-04-26 15:42               ` Khem Raj
  1 sibling, 1 reply; 11+ messages in thread
From: Ross Burton @ 2021-04-26 11:18 UTC (permalink / raw)
  To: Khem Raj; +Cc: Martin Jansa, Clément Péron, openembeded-devel

On Sat, 24 Apr 2021 at 23:12, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Sat, Apr 24, 2021 at 2:48 PM Ross Burton <ross@burtonini.com> wrote:
> >
> > To be honest, as this is Arm-specific I'd encourage adding it to
> > meta-arm instead of meta-oe.
>
> I would tend to agree, although there is something to consider it also
> means all arm SOCs will have to depend on meta-arm for this recipe
> which may not be a bad thing but some BSP layers for ARM based SOCs
> are independent

The meta-arm layer itself doesn't have any machine-specific recipes
and is simply a repository of common recipes.  There should be no
barriers to an Arm BSP using meta-arm.

Ross

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [oe] [PATCH] [RFC] gator: Add new package
  2021-04-26 11:18             ` Ross Burton
@ 2021-04-26 15:42               ` Khem Raj
  0 siblings, 0 replies; 11+ messages in thread
From: Khem Raj @ 2021-04-26 15:42 UTC (permalink / raw)
  To: Ross Burton; +Cc: Martin Jansa, Clément Péron, openembeded-devel



On 4/26/21 4:18 AM, Ross Burton wrote:
> On Sat, 24 Apr 2021 at 23:12, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Sat, Apr 24, 2021 at 2:48 PM Ross Burton <ross@burtonini.com> wrote:
>>>
>>> To be honest, as this is Arm-specific I'd encourage adding it to
>>> meta-arm instead of meta-oe.
>>
>> I would tend to agree, although there is something to consider it also
>> means all arm SOCs will have to depend on meta-arm for this recipe
>> which may not be a bad thing but some BSP layers for ARM based SOCs
>> are independent
> 
> The meta-arm layer itself doesn't have any machine-specific recipes
> and is simply a repository of common recipes.  There should be no
> barriers to an Arm BSP using meta-arm.

sounds good to me.

> 
> Ross
> 

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] [RFC] gator: Add new package
@ 2021-04-25 16:11 Clément Péron
  0 siblings, 0 replies; 11+ messages in thread
From: Clément Péron @ 2021-04-25 16:11 UTC (permalink / raw)
  To: meta-arm; +Cc: Clément Péron

To communicate with the target device, Streamline requires the
gator daemon, gatord, to be running on the device.

Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 .../gator/0001-gator-don-t-strip-debug.patch  | 24 +++++++++++++++++++
 .../recipes-devtools/gator/gator_7.5.0.bb     | 22 +++++++++++++++++
 2 files changed, 46 insertions(+)
 create mode 100644 meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
 create mode 100644 meta-arm/recipes-devtools/gator/gator_7.5.0.bb

diff --git a/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
new file mode 100644
index 000000000000..8e59fffa1fc2
--- /dev/null
+++ b/meta-arm/recipes-devtools/gator/gator/0001-gator-don-t-strip-debug.patch
@@ -0,0 +1,24 @@
+From 370e9c97f1bc07a63aa87e954823c0063058aad7 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= <cpe@outsight.tech>
+Date: Fri, 16 Apr 2021 15:27:16 +0200
+Subject: [PATCH] gator: don't strip debug
+
+---
+ daemon/Makefile | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/daemon/Makefile b/daemon/Makefile
+index ba5f29cfeb10..6807948310f9 100644
+--- a/daemon/Makefile
++++ b/daemon/Makefile
+@@ -26,8 +26,6 @@ ifeq ($(shell expr `$(CXX) -dumpversion | cut -f1 -d.` \>= 5),1)
+ 	CXXFLAGS += -fno-sized-deallocation
+ endif
+ 
+-# -s strips the binary of debug info
+-LDFLAGS     += -s
+ LDLIBS      += -lrt -lm -pthread
+ TARGET      := $(OBJ_DIR)gatord
+ ESCAPE_EXE  := $(OBJ_DIR)escape/escape
+-- 
+2.25.1
diff --git a/meta-arm/recipes-devtools/gator/gator_7.5.0.bb b/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
new file mode 100644
index 000000000000..8e15b1ca5fc5
--- /dev/null
+++ b/meta-arm/recipes-devtools/gator/gator_7.5.0.bb
@@ -0,0 +1,22 @@
+SUMMARY = "DS-5 Streamine Gator daemon"
+DESCRIPTION = "Target-side daemon gathering data for ARM Streamline Performance Analyzer."
+
+LICENSE = "GPL-2.0-only"
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+LICENSE_libsensors = "LGPL-2.1-or-later"
+
+SRCREV = "6088d3533146d7b7c9700b8e396292053240b25f"
+SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
+	   file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
+	  "
+
+S = "${WORKDIR}/git/daemon"
+
+EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
+    'LDFLAGS=${LDFLAGS} ${TARGET_CC_ARCH}' 'CROSS_COMPILE=${TARGET_PREFIX}' \
+    'CXXFLAGS=${CXXFLAGS} ${TARGET_CC_ARCH} -fno-rtti' CC='${CC}' CXX='${CXX}'"
+
+do_install() {
+	install -d ${D}${sbindir}
+	install -m 0755 ${S}/gatord ${D}${sbindir}/gatord
+}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-04-26 15:42 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-24 10:24 [PATCH] [RFC] gator: Add new package Clément Péron
2021-04-24 10:28 ` Clément Péron
2021-04-24 10:45   ` [oe] " Martin Jansa
2021-04-24 11:24     ` Clément Péron
2021-04-24 11:28       ` Martin Jansa
2021-04-24 21:47         ` Ross Burton
2021-04-24 22:11           ` Khem Raj
2021-04-25 15:57             ` Clément Péron
2021-04-26 11:18             ` Ross Burton
2021-04-26 15:42               ` Khem Raj
2021-04-25 16:11 Clément Péron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.