* [PATCH net-next] net: dsa: tag_rtl8_4: typo in modalias name
@ 2022-03-07 17:09 Luiz Angelo Daros de Luca
2022-03-07 18:02 ` Arınç ÜNAL
0 siblings, 1 reply; 3+ messages in thread
From: Luiz Angelo Daros de Luca @ 2022-03-07 17:09 UTC (permalink / raw)
To: netdev
Cc: linus.walleij, andrew, vivien.didelot, f.fainelli, olteanv,
davem, kuba, alsi, arinc.unal, Luiz Angelo Daros de Luca
DSA_TAG_PROTO_RTL8_4L is not defined. It should be
DSA_TAG_PROTO_RTL8_4T.
Reported-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
---
net/dsa/tag_rtl8_4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dsa/tag_rtl8_4.c b/net/dsa/tag_rtl8_4.c
index 71fec45fd0ea..a593ead7ff26 100644
--- a/net/dsa/tag_rtl8_4.c
+++ b/net/dsa/tag_rtl8_4.c
@@ -247,7 +247,7 @@ static const struct dsa_device_ops rtl8_4t_netdev_ops = {
DSA_TAG_DRIVER(rtl8_4t_netdev_ops);
-MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_RTL8_4L);
+MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_RTL8_4T);
static struct dsa_tag_driver *dsa_tag_drivers[] = {
&DSA_TAG_DRIVER_NAME(rtl8_4_netdev_ops),
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: tag_rtl8_4: typo in modalias name
2022-03-07 17:09 [PATCH net-next] net: dsa: tag_rtl8_4: typo in modalias name Luiz Angelo Daros de Luca
@ 2022-03-07 18:02 ` Arınç ÜNAL
2022-03-09 2:29 ` Luiz Angelo Daros de Luca
0 siblings, 1 reply; 3+ messages in thread
From: Arınç ÜNAL @ 2022-03-07 18:02 UTC (permalink / raw)
To: Luiz Angelo Daros de Luca, netdev
Cc: linus.walleij, andrew, vivien.didelot, f.fainelli, olteanv,
davem, kuba, alsi
On 07/03/2022 20:09, Luiz Angelo Daros de Luca wrote:
> DSA_TAG_PROTO_RTL8_4L is not defined. It should be
> DSA_TAG_PROTO_RTL8_4T.
>
> Reported-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> ---
> net/dsa/tag_rtl8_4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/dsa/tag_rtl8_4.c b/net/dsa/tag_rtl8_4.c
> index 71fec45fd0ea..a593ead7ff26 100644
> --- a/net/dsa/tag_rtl8_4.c
> +++ b/net/dsa/tag_rtl8_4.c
> @@ -247,7 +247,7 @@ static const struct dsa_device_ops rtl8_4t_netdev_ops = {
>
> DSA_TAG_DRIVER(rtl8_4t_netdev_ops);
>
> -MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_RTL8_4L);
> +MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_RTL8_4T);
>
> static struct dsa_tag_driver *dsa_tag_drivers[] = {
> &DSA_TAG_DRIVER_NAME(rtl8_4_netdev_ops),
Might as well add Fixes: tag since this fixes cd87fecdedd7 ("net: dsa:
tag_rtl8_4: add rtl8_4t trailing variant") and "fix typo in modalias
name" on the subject to clearly state the change.
Arınç
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: tag_rtl8_4: typo in modalias name
2022-03-07 18:02 ` Arınç ÜNAL
@ 2022-03-09 2:29 ` Luiz Angelo Daros de Luca
0 siblings, 0 replies; 3+ messages in thread
From: Luiz Angelo Daros de Luca @ 2022-03-09 2:29 UTC (permalink / raw)
To: Arınç ÜNAL
Cc: open list:NETWORKING DRIVERS, Linus Walleij, Andrew Lunn,
Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Jakub Kicinski, Alvin Šipraga
> Might as well add Fixes: tag since this fixes cd87fecdedd7 ("net: dsa:
> tag_rtl8_4: add rtl8_4t trailing variant") and "fix typo in modalias
> name" on the subject to clearly state the change.
Thanks, Arınç. I've just sent v2 with these fixes.
Regards,
Luiz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-09 2:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 17:09 [PATCH net-next] net: dsa: tag_rtl8_4: typo in modalias name Luiz Angelo Daros de Luca
2022-03-07 18:02 ` Arınç ÜNAL
2022-03-09 2:29 ` Luiz Angelo Daros de Luca
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.