All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
@ 2017-04-24  6:18 ` Caesar Wang
  0 siblings, 0 replies; 16+ messages in thread
From: Caesar Wang @ 2017-04-24  6:18 UTC (permalink / raw)
  To: heiko
  Cc: linux-rockchip, linux-kernel, linux-arm-kernel, briannorris,
	dianders, Caesar Wang

Update the cpu opp table for rk3399 op1.

Signed-off-by: Caesar Wang <wxt@rock-chips.com>
---

 arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
index dd82e16..92bd615 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
@@ -52,27 +52,27 @@
 		};
 		opp01 {
 			opp-hz = /bits/ 64 <600000000>;
-			opp-microvolt = <800000>;
+			opp-microvolt = <825000>;
 		};
 		opp02 {
 			opp-hz = /bits/ 64 <816000000>;
-			opp-microvolt = <800000>;
+			opp-microvolt = <850000>;
 		};
 		opp03 {
 			opp-hz = /bits/ 64 <1008000000>;
-			opp-microvolt = <875000>;
+			opp-microvolt = <900000>;
 		};
 		opp04 {
 			opp-hz = /bits/ 64 <1200000000>;
-			opp-microvolt = <925000>;
+			opp-microvolt = <975000>;
 		};
 		opp05 {
 			opp-hz = /bits/ 64 <1416000000>;
-			opp-microvolt = <1050000>;
+			opp-microvolt = <1100000>;
 		};
 		opp06 {
 			opp-hz = /bits/ 64 <1512000000>;
-			opp-microvolt = <1125000>;
+			opp-microvolt = <1150000>;
 		};
 	};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
@ 2017-04-24  6:18 ` Caesar Wang
  0 siblings, 0 replies; 16+ messages in thread
From: Caesar Wang @ 2017-04-24  6:18 UTC (permalink / raw)
  To: linux-arm-kernel

Update the cpu opp table for rk3399 op1.

Signed-off-by: Caesar Wang <wxt@rock-chips.com>
---

 arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
index dd82e16..92bd615 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
@@ -52,27 +52,27 @@
 		};
 		opp01 {
 			opp-hz = /bits/ 64 <600000000>;
-			opp-microvolt = <800000>;
+			opp-microvolt = <825000>;
 		};
 		opp02 {
 			opp-hz = /bits/ 64 <816000000>;
-			opp-microvolt = <800000>;
+			opp-microvolt = <850000>;
 		};
 		opp03 {
 			opp-hz = /bits/ 64 <1008000000>;
-			opp-microvolt = <875000>;
+			opp-microvolt = <900000>;
 		};
 		opp04 {
 			opp-hz = /bits/ 64 <1200000000>;
-			opp-microvolt = <925000>;
+			opp-microvolt = <975000>;
 		};
 		opp05 {
 			opp-hz = /bits/ 64 <1416000000>;
-			opp-microvolt = <1050000>;
+			opp-microvolt = <1100000>;
 		};
 		opp06 {
 			opp-hz = /bits/ 64 <1512000000>;
-			opp-microvolt = <1125000>;
+			opp-microvolt = <1150000>;
 		};
 	};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
  2017-04-24  6:18 ` Caesar Wang
@ 2017-04-24  8:26   ` Heiko Stübner
  -1 siblings, 0 replies; 16+ messages in thread
From: Heiko Stübner @ 2017-04-24  8:26 UTC (permalink / raw)
  To: Caesar Wang
  Cc: linux-rockchip, linux-kernel, linux-arm-kernel, briannorris, dianders

Hi Caesar,

Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
> Update the cpu opp table for rk3399 op1.

Ideally this should contain something about the "why".
Are these new voltage settings safer to operate under?

No need to resend, please just clarify the reason.


Thanks
Heiko

> 
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
> 
>  arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi index dd82e16..92bd615
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
> @@ -52,27 +52,27 @@
>  		};
>  		opp01 {
>  			opp-hz = /bits/ 64 <600000000>;
> -			opp-microvolt = <800000>;
> +			opp-microvolt = <825000>;
>  		};
>  		opp02 {
>  			opp-hz = /bits/ 64 <816000000>;
> -			opp-microvolt = <800000>;
> +			opp-microvolt = <850000>;
>  		};
>  		opp03 {
>  			opp-hz = /bits/ 64 <1008000000>;
> -			opp-microvolt = <875000>;
> +			opp-microvolt = <900000>;
>  		};
>  		opp04 {
>  			opp-hz = /bits/ 64 <1200000000>;
> -			opp-microvolt = <925000>;
> +			opp-microvolt = <975000>;
>  		};
>  		opp05 {
>  			opp-hz = /bits/ 64 <1416000000>;
> -			opp-microvolt = <1050000>;
> +			opp-microvolt = <1100000>;
>  		};
>  		opp06 {
>  			opp-hz = /bits/ 64 <1512000000>;
> -			opp-microvolt = <1125000>;
> +			opp-microvolt = <1150000>;
>  		};
>  	};

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
@ 2017-04-24  8:26   ` Heiko Stübner
  0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stübner @ 2017-04-24  8:26 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Caesar,

Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
> Update the cpu opp table for rk3399 op1.

Ideally this should contain something about the "why".
Are these new voltage settings safer to operate under?

No need to resend, please just clarify the reason.


Thanks
Heiko

> 
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
> 
>  arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi index dd82e16..92bd615
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
> @@ -52,27 +52,27 @@
>  		};
>  		opp01 {
>  			opp-hz = /bits/ 64 <600000000>;
> -			opp-microvolt = <800000>;
> +			opp-microvolt = <825000>;
>  		};
>  		opp02 {
>  			opp-hz = /bits/ 64 <816000000>;
> -			opp-microvolt = <800000>;
> +			opp-microvolt = <850000>;
>  		};
>  		opp03 {
>  			opp-hz = /bits/ 64 <1008000000>;
> -			opp-microvolt = <875000>;
> +			opp-microvolt = <900000>;
>  		};
>  		opp04 {
>  			opp-hz = /bits/ 64 <1200000000>;
> -			opp-microvolt = <925000>;
> +			opp-microvolt = <975000>;
>  		};
>  		opp05 {
>  			opp-hz = /bits/ 64 <1416000000>;
> -			opp-microvolt = <1050000>;
> +			opp-microvolt = <1100000>;
>  		};
>  		opp06 {
>  			opp-hz = /bits/ 64 <1512000000>;
> -			opp-microvolt = <1125000>;
> +			opp-microvolt = <1150000>;
>  		};
>  	};

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
  2017-04-24  8:26   ` Heiko Stübner
@ 2017-04-24  8:49     ` Caesar Wang
  -1 siblings, 0 replies; 16+ messages in thread
From: Caesar Wang @ 2017-04-24  8:49 UTC (permalink / raw)
  To: Heiko Stübner
  Cc: linux-rockchip, linux-kernel, linux-arm-kernel, briannorris, dianders

在 2017年04月24日 16:26, Heiko Stübner 写道:
> Hi Caesar,
>
> Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
>> Update the cpu opp table for rk3399 op1.
> Ideally this should contain something about the "why".
> Are these new voltage settings safer to operate under?

The before opp table is for earlier batch of rk3399 SoCs,  that's no 
enough for the current and
newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need 
to little voltages changed.

-Caesar

>
> No need to resend, please just clarify the reason.
>
>
> Thanks
> Heiko
>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>> ---
>>
>>   arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi index dd82e16..92bd615
>> 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
>> @@ -52,27 +52,27 @@
>>   		};
>>   		opp01 {
>>   			opp-hz = /bits/ 64 <600000000>;
>> -			opp-microvolt = <800000>;
>> +			opp-microvolt = <825000>;
>>   		};
>>   		opp02 {
>>   			opp-hz = /bits/ 64 <816000000>;
>> -			opp-microvolt = <800000>;
>> +			opp-microvolt = <850000>;
>>   		};
>>   		opp03 {
>>   			opp-hz = /bits/ 64 <1008000000>;
>> -			opp-microvolt = <875000>;
>> +			opp-microvolt = <900000>;
>>   		};
>>   		opp04 {
>>   			opp-hz = /bits/ 64 <1200000000>;
>> -			opp-microvolt = <925000>;
>> +			opp-microvolt = <975000>;
>>   		};
>>   		opp05 {
>>   			opp-hz = /bits/ 64 <1416000000>;
>> -			opp-microvolt = <1050000>;
>> +			opp-microvolt = <1100000>;
>>   		};
>>   		opp06 {
>>   			opp-hz = /bits/ 64 <1512000000>;
>> -			opp-microvolt = <1125000>;
>> +			opp-microvolt = <1150000>;
>>   		};
>>   	};
>
>
>
>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
@ 2017-04-24  8:49     ` Caesar Wang
  0 siblings, 0 replies; 16+ messages in thread
From: Caesar Wang @ 2017-04-24  8:49 UTC (permalink / raw)
  To: linux-arm-kernel

? 2017?04?24? 16:26, Heiko St?bner ??:
> Hi Caesar,
>
> Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
>> Update the cpu opp table for rk3399 op1.
> Ideally this should contain something about the "why".
> Are these new voltage settings safer to operate under?

The before opp table is for earlier batch of rk3399 SoCs,  that's no 
enough for the current and
newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need 
to little voltages changed.

-Caesar

>
> No need to resend, please just clarify the reason.
>
>
> Thanks
> Heiko
>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>> ---
>>
>>   arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi index dd82e16..92bd615
>> 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
>> @@ -52,27 +52,27 @@
>>   		};
>>   		opp01 {
>>   			opp-hz = /bits/ 64 <600000000>;
>> -			opp-microvolt = <800000>;
>> +			opp-microvolt = <825000>;
>>   		};
>>   		opp02 {
>>   			opp-hz = /bits/ 64 <816000000>;
>> -			opp-microvolt = <800000>;
>> +			opp-microvolt = <850000>;
>>   		};
>>   		opp03 {
>>   			opp-hz = /bits/ 64 <1008000000>;
>> -			opp-microvolt = <875000>;
>> +			opp-microvolt = <900000>;
>>   		};
>>   		opp04 {
>>   			opp-hz = /bits/ 64 <1200000000>;
>> -			opp-microvolt = <925000>;
>> +			opp-microvolt = <975000>;
>>   		};
>>   		opp05 {
>>   			opp-hz = /bits/ 64 <1416000000>;
>> -			opp-microvolt = <1050000>;
>> +			opp-microvolt = <1100000>;
>>   		};
>>   		opp06 {
>>   			opp-hz = /bits/ 64 <1512000000>;
>> -			opp-microvolt = <1125000>;
>> +			opp-microvolt = <1150000>;
>>   		};
>>   	};
>
>
>
>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
  2017-04-24  8:49     ` Caesar Wang
@ 2017-04-24  9:15       ` Heiko Stübner
  -1 siblings, 0 replies; 16+ messages in thread
From: Heiko Stübner @ 2017-04-24  9:15 UTC (permalink / raw)
  To: Caesar Wang
  Cc: linux-rockchip, linux-kernel, linux-arm-kernel, briannorris, dianders

Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
> 在 2017年04月24日 16:26, Heiko Stübner 写道:
> > Hi Caesar,
> > 
> > Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
> >> Update the cpu opp table for rk3399 op1.
> > 
> > Ideally this should contain something about the "why".
> > Are these new voltage settings safer to operate under?
> 
> The before opp table is for earlier batch of rk3399 SoCs,  that's no
> enough for the current and
> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
> to little voltages changed.

just to make sure, this is also safe for all the non-chromebook rk3399 socs 
(like the firefly and tv-boxes, etc), right?


Thanks
Heiko

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
@ 2017-04-24  9:15       ` Heiko Stübner
  0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stübner @ 2017-04-24  9:15 UTC (permalink / raw)
  To: linux-arm-kernel

Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
> ? 2017?04?24? 16:26, Heiko St?bner ??:
> > Hi Caesar,
> > 
> > Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
> >> Update the cpu opp table for rk3399 op1.
> > 
> > Ideally this should contain something about the "why".
> > Are these new voltage settings safer to operate under?
> 
> The before opp table is for earlier batch of rk3399 SoCs,  that's no
> enough for the current and
> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
> to little voltages changed.

just to make sure, this is also safe for all the non-chromebook rk3399 socs 
(like the firefly and tv-boxes, etc), right?


Thanks
Heiko

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
  2017-04-24  9:15       ` Heiko Stübner
@ 2017-04-24 10:29         ` Eddie Cai
  -1 siblings, 0 replies; 16+ messages in thread
From: Eddie Cai @ 2017-04-24 10:29 UTC (permalink / raw)
  To: Heiko Stübner
  Cc: Caesar Wang, linux-rockchip, briannorris, linux-kernel,
	linux-arm-kernel, dianders

Hi Heiko

2017-04-24 17:15 GMT+08:00 Heiko Stübner <heiko@sntech.de>:
> Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
>> 在 2017年04月24日 16:26, Heiko Stübner 写道:
>> > Hi Caesar,
>> >
>> > Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
>> >> Update the cpu opp table for rk3399 op1.
>> >
>> > Ideally this should contain something about the "why".
>> > Are these new voltage settings safer to operate under?
>>
>> The before opp table is for earlier batch of rk3399 SoCs,  that's no
>> enough for the current and
>> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
>> to little voltages changed.
>
> just to make sure, this is also safe for all the non-chromebook rk3399 socs
> (like the firefly and tv-boxes, etc), right?
This is only for op1. other 3399s should have a different opp table
>
>
> Thanks
> Heiko
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
@ 2017-04-24 10:29         ` Eddie Cai
  0 siblings, 0 replies; 16+ messages in thread
From: Eddie Cai @ 2017-04-24 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Heiko

2017-04-24 17:15 GMT+08:00 Heiko St?bner <heiko@sntech.de>:
> Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
>> ? 2017?04?24? 16:26, Heiko St?bner ??:
>> > Hi Caesar,
>> >
>> > Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
>> >> Update the cpu opp table for rk3399 op1.
>> >
>> > Ideally this should contain something about the "why".
>> > Are these new voltage settings safer to operate under?
>>
>> The before opp table is for earlier batch of rk3399 SoCs,  that's no
>> enough for the current and
>> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
>> to little voltages changed.
>
> just to make sure, this is also safe for all the non-chromebook rk3399 socs
> (like the firefly and tv-boxes, etc), right?
This is only for op1. other 3399s should have a different opp table
>
>
> Thanks
> Heiko
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
       [not found]       ` <9edc6ebc-8aab-03df-49b2-759ed8581a6c@163.com>
@ 2017-04-24 10:35           ` Heiko Stübner
  0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stübner @ 2017-04-24 10:35 UTC (permalink / raw)
  To: Caesar Wang
  Cc: Caesar Wang, linux-rockchip, briannorris, linux-kernel,
	linux-arm-kernel, dianders

Am Montag, 24. April 2017, 18:25:49 CEST schrieb Caesar Wang:
> 在 2017年04月24日 17:15, Heiko Stübner 写道:
> > Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
> >> 在 2017年04月24日 16:26, Heiko Stübner 写道:
> >>> Hi Caesar,
> >>> 
> >>> Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
> >>>> Update the cpu opp table for rk3399 op1.
> >>> 
> >>> Ideally this should contain something about the "why".
> >>> Are these new voltage settings safer to operate under?
> >> 
> >> The before opp table is for earlier batch of rk3399 SoCs,  that's no
> >> enough for the current and
> >> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
> >> to little voltages changed.
> > 
> > just to make sure, this is also safe for all the non-chromebook rk3399
> > socs
> > (like the firefly and tv-boxes, etc), right?
> 
> No,  just for chromebook.
> 
> Maybe, we need support two table for rk3399 SoCs.
> For chromebook supporting 2GHz frequency and others support 1.8GHz
> frequency.

Definitly. So please move the chromebook opp-table to something like a rk3399-
op1-opp.dtsi and adapt rk3399-opp.dtsi to be safe for all rk3399 variants.


Thanks
Heiko

> 
> For example:
> ....
>    opp03 {
>                opp-hz = /bits/ 64 <1008000000>;
>                opp-microvolt = <925000 925000 1350000>;
>                opp-microvolt-l0 = <925000 925000 1350000>;
>                opp-microvolt-l1 = <900000 900000 1350000>;
>            };
> ....
> 
> 
> 
> -Caesar
> 
> > Thanks
> > Heiko
> > 
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
@ 2017-04-24 10:35           ` Heiko Stübner
  0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stübner @ 2017-04-24 10:35 UTC (permalink / raw)
  To: linux-arm-kernel

Am Montag, 24. April 2017, 18:25:49 CEST schrieb Caesar Wang:
> ? 2017?04?24? 17:15, Heiko St?bner ??:
> > Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
> >> ? 2017?04?24? 16:26, Heiko St?bner ??:
> >>> Hi Caesar,
> >>> 
> >>> Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
> >>>> Update the cpu opp table for rk3399 op1.
> >>> 
> >>> Ideally this should contain something about the "why".
> >>> Are these new voltage settings safer to operate under?
> >> 
> >> The before opp table is for earlier batch of rk3399 SoCs,  that's no
> >> enough for the current and
> >> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
> >> to little voltages changed.
> > 
> > just to make sure, this is also safe for all the non-chromebook rk3399
> > socs
> > (like the firefly and tv-boxes, etc), right?
> 
> No,  just for chromebook.
> 
> Maybe, we need support two table for rk3399 SoCs.
> For chromebook supporting 2GHz frequency and others support 1.8GHz
> frequency.

Definitly. So please move the chromebook opp-table to something like a rk3399-
op1-opp.dtsi and adapt rk3399-opp.dtsi to be safe for all rk3399 variants.


Thanks
Heiko

> 
> For example:
> ....
>    opp03 {
>                opp-hz = /bits/ 64 <1008000000>;
>                opp-microvolt = <925000 925000 1350000>;
>                opp-microvolt-l0 = <925000 925000 1350000>;
>                opp-microvolt-l1 = <900000 900000 1350000>;
>            };
> ....
> 
> 
> 
> -Caesar
> 
> > Thanks
> > Heiko
> > 
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
  2017-04-24 10:29         ` Eddie Cai
@ 2017-05-22 15:02           ` Heiko Stuebner
  -1 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-05-22 15:02 UTC (permalink / raw)
  To: Eddie Cai
  Cc: Caesar Wang, linux-rockchip, briannorris, linux-kernel,
	linux-arm-kernel, dianders

Hi Eddie, Caesar,

Am Montag, 24. April 2017, 18:29:26 CEST schrieb Eddie Cai:
> Hi Heiko
> 
> 2017-04-24 17:15 GMT+08:00 Heiko Stübner <heiko@sntech.de>:
> > Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
> >> 在 2017年04月24日 16:26, Heiko Stübner 写道:
> >> > Hi Caesar,
> >> >
> >> > Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
> >> >> Update the cpu opp table for rk3399 op1.
> >> >
> >> > Ideally this should contain something about the "why".
> >> > Are these new voltage settings safer to operate under?
> >>
> >> The before opp table is for earlier batch of rk3399 SoCs,  that's no
> >> enough for the current and
> >> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
> >> to little voltages changed.
> >
> > just to make sure, this is also safe for all the non-chromebook rk3399 socs
> > (like the firefly and tv-boxes, etc), right?
> This is only for op1. other 3399s should have a different opp table

digging this up, as I'm right now working on a rk3399-firefly, could you
provide the correct opp tables for the available rk3399 variants please?

I.e. generally safe opps for boards like the firefly and the special ones
for op1-based devices?


Thanks
Heiko

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
@ 2017-05-22 15:02           ` Heiko Stuebner
  0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-05-22 15:02 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Eddie, Caesar,

Am Montag, 24. April 2017, 18:29:26 CEST schrieb Eddie Cai:
> Hi Heiko
> 
> 2017-04-24 17:15 GMT+08:00 Heiko St?bner <heiko@sntech.de>:
> > Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
> >> ? 2017?04?24? 16:26, Heiko St?bner ??:
> >> > Hi Caesar,
> >> >
> >> > Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
> >> >> Update the cpu opp table for rk3399 op1.
> >> >
> >> > Ideally this should contain something about the "why".
> >> > Are these new voltage settings safer to operate under?
> >>
> >> The before opp table is for earlier batch of rk3399 SoCs,  that's no
> >> enough for the current and
> >> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
> >> to little voltages changed.
> >
> > just to make sure, this is also safe for all the non-chromebook rk3399 socs
> > (like the firefly and tv-boxes, etc), right?
> This is only for op1. other 3399s should have a different opp table

digging this up, as I'm right now working on a rk3399-firefly, could you
provide the correct opp tables for the available rk3399 variants please?

I.e. generally safe opps for boards like the firefly and the special ones
for op1-based devices?


Thanks
Heiko

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
  2017-05-22 15:02           ` Heiko Stuebner
@ 2017-05-23  2:51             ` Eddie Cai
  -1 siblings, 0 replies; 16+ messages in thread
From: Eddie Cai @ 2017-05-23  2:51 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Caesar Wang, linux-rockchip, Brian Norris, linux-kernel,
	linux-arm-kernel, Douglas Anderson

Hi Heiko

2017-05-22 23:02 GMT+08:00 Heiko Stuebner <heiko@sntech.de>:
> Hi Eddie, Caesar,
>
> Am Montag, 24. April 2017, 18:29:26 CEST schrieb Eddie Cai:
>> Hi Heiko
>>
>> 2017-04-24 17:15 GMT+08:00 Heiko Stübner <heiko@sntech.de>:
>> > Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
>> >> 在 2017年04月24日 16:26, Heiko Stübner 写道:
>> >> > Hi Caesar,
>> >> >
>> >> > Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
>> >> >> Update the cpu opp table for rk3399 op1.
>> >> >
>> >> > Ideally this should contain something about the "why".
>> >> > Are these new voltage settings safer to operate under?
>> >>
>> >> The before opp table is for earlier batch of rk3399 SoCs,  that's no
>> >> enough for the current and
>> >> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
>> >> to little voltages changed.
>> >
>> > just to make sure, this is also safe for all the non-chromebook rk3399 socs
>> > (like the firefly and tv-boxes, etc), right?
>> This is only for op1. other 3399s should have a different opp table
>
> digging this up, as I'm right now working on a rk3399-firefly, could you
> provide the correct opp tables for the available rk3399 variants please?
>
> I.e. generally safe opps for boards like the firefly and the special ones
> for op1-based devices?
here is for 3399:
https://github.com/rockchip-linux/kernel/blob/release-4.4/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
here is for op1:
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.4/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
>
>
> Thanks
> Heiko

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
@ 2017-05-23  2:51             ` Eddie Cai
  0 siblings, 0 replies; 16+ messages in thread
From: Eddie Cai @ 2017-05-23  2:51 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Heiko

2017-05-22 23:02 GMT+08:00 Heiko Stuebner <heiko@sntech.de>:
> Hi Eddie, Caesar,
>
> Am Montag, 24. April 2017, 18:29:26 CEST schrieb Eddie Cai:
>> Hi Heiko
>>
>> 2017-04-24 17:15 GMT+08:00 Heiko St?bner <heiko@sntech.de>:
>> > Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
>> >> ? 2017?04?24? 16:26, Heiko St?bner ??:
>> >> > Hi Caesar,
>> >> >
>> >> > Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
>> >> >> Update the cpu opp table for rk3399 op1.
>> >> >
>> >> > Ideally this should contain something about the "why".
>> >> > Are these new voltage settings safer to operate under?
>> >>
>> >> The before opp table is for earlier batch of rk3399 SoCs,  that's no
>> >> enough for the current and
>> >> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
>> >> to little voltages changed.
>> >
>> > just to make sure, this is also safe for all the non-chromebook rk3399 socs
>> > (like the firefly and tv-boxes, etc), right?
>> This is only for op1. other 3399s should have a different opp table
>
> digging this up, as I'm right now working on a rk3399-firefly, could you
> provide the correct opp tables for the available rk3399 variants please?
>
> I.e. generally safe opps for boards like the firefly and the special ones
> for op1-based devices?
here is for 3399:
https://github.com/rockchip-linux/kernel/blob/release-4.4/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
here is for op1:
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.4/arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi
>
>
> Thanks
> Heiko

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2017-05-23  2:51 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-24  6:18 [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1 Caesar Wang
2017-04-24  6:18 ` Caesar Wang
2017-04-24  8:26 ` Heiko Stübner
2017-04-24  8:26   ` Heiko Stübner
2017-04-24  8:49   ` Caesar Wang
2017-04-24  8:49     ` Caesar Wang
2017-04-24  9:15     ` Heiko Stübner
2017-04-24  9:15       ` Heiko Stübner
2017-04-24 10:29       ` Eddie Cai
2017-04-24 10:29         ` Eddie Cai
2017-05-22 15:02         ` Heiko Stuebner
2017-05-22 15:02           ` Heiko Stuebner
2017-05-23  2:51           ` Eddie Cai
2017-05-23  2:51             ` Eddie Cai
     [not found]       ` <9edc6ebc-8aab-03df-49b2-759ed8581a6c@163.com>
2017-04-24 10:35         ` Heiko Stübner
2017-04-24 10:35           ` Heiko Stübner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.