All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuanhong Guo <gch981213@gmail.com>
To: "Limonciello, Mario" <Mario.Limonciello@amd.com>
Cc: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
	"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	Tighe Donnelly <tighe.donnelly@protonmail.com>,
	Fridrich Strba <fstrba@suse.com>
Subject: Re: [PATCH 1/2] ACPI: resource: do IRQ override on LENOVO IdeaPad
Date: Wed, 5 Oct 2022 12:02:08 +0800	[thread overview]
Message-ID: <CAJsYDVJsuYvAyFWwoW9=K_9otJR9Y61Wfk_w2e_K7WiyWf3Xjw@mail.gmail.com> (raw)
In-Reply-To: <MN0PR12MB610136EC41E0D00F0BA7280FE25A9@MN0PR12MB6101.namprd12.prod.outlook.com>

Hi!

On Wed, Oct 5, 2022 at 5:02 AM Limonciello, Mario
<Mario.Limonciello@amd.com> wrote:
> [...]
> >
> > White-list this specific model in the override_table.
> >
> > For this to work, the ZEN test needs to be put below the table walk.
>
> Unfortunately this is the second case that popped up very recently.
> Another one is listed here:
> https://bugzilla.kernel.org/show_bug.cgi?id=216552

Now I'm really curious how Windows is able to handle all these vendor crap...

> I don't think we have a good solution to cover the intersection of these bugs.  The
> existing heuristic to look at legacy syntax and the IOAPIC doesn't work properly
> on all the Lenovo and ASUS Ryzen 6000 systems, but it does on these other two.

These legacy IRQ declarations are obsolete, but they aren't really wrong.
Meanwhile the two devices popped up until now both got IRQ declarations which
don't match the actual device configuration.

> We're going to be adding more to this table either way.  I /suspect/ the better solution
> is to revert 37c81d9f1d1b and add to the table all those that are broken.

I think we should have a list of only the wrong IRQ declaration and
apply the fix
just for them, instead of applying the fix to all devices and skip it
for selected
devices the fix breaks.

-- 
Regards,
Chuanhong Guo

  reply	other threads:[~2022-10-05  4:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 10:33 [PATCH 1/2] ACPI: resource: do IRQ override on LENOVO IdeaPad Jiri Slaby (SUSE)
2022-10-04 10:33 ` [PATCH 2/2] ACPI: resource: note more about IRQ override Jiri Slaby (SUSE)
2022-10-04 21:02 ` [PATCH 1/2] ACPI: resource: do IRQ override on LENOVO IdeaPad Limonciello, Mario
2022-10-05  4:02   ` Chuanhong Guo [this message]
2022-10-05 16:34     ` Limonciello, Mario
2022-10-13 18:51 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJsYDVJsuYvAyFWwoW9=K_9otJR9Y61Wfk_w2e_K7WiyWf3Xjw@mail.gmail.com' \
    --to=gch981213@gmail.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=fstrba@suse.com \
    --cc=jirislaby@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rafael@kernel.org \
    --cc=tighe.donnelly@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.