* [Buildroot] [PATCH] package/erlang-p1-xmpp: fix host build
@ 2020-01-22 10:34 Johan Oudinet
2020-02-02 8:56 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Johan Oudinet @ 2020-01-22 10:34 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/3e594350131994df53b20d5113fefbba2e747836
Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
---
package/erlang-p1-xmpp/erlang-p1-xmpp.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/erlang-p1-xmpp/erlang-p1-xmpp.mk b/package/erlang-p1-xmpp/erlang-p1-xmpp.mk
index ced058731b..2f74c60df2 100644
--- a/package/erlang-p1-xmpp/erlang-p1-xmpp.mk
+++ b/package/erlang-p1-xmpp/erlang-p1-xmpp.mk
@@ -11,6 +11,7 @@ ERLANG_P1_XMPP_LICENSE_FILES = LICENSE.txt
ERLANG_P1_XMPP_INSTALL_STAGING = YES
ERLANG_P1_XMPP_DEPENDENCIES = erlang-p1-xml erlang-p1-stringprep \
erlang-p1-tls erlang-p1-utils erlang-p1-zlib host-erlang-p1-xml
+HOST_ERLANG_P1_XMPP_DEPENDENCIES = host-erlang-p1-xml
$(eval $(rebar-package))
$(eval $(host-rebar-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/erlang-p1-xmpp: fix host build
2020-01-22 10:34 [Buildroot] [PATCH] package/erlang-p1-xmpp: fix host build Johan Oudinet
@ 2020-02-02 8:56 ` Thomas Petazzoni
2020-02-10 10:40 ` Johan Oudinet
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2020-02-02 8:56 UTC (permalink / raw)
To: buildroot
On Wed, 22 Jan 2020 11:34:01 +0100
Johan Oudinet <johan.oudinet@gmail.com> wrote:
> Fixes:
> http://autobuild.buildroot.net/results/3e594350131994df53b20d5113fefbba2e747836
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
Thanks, I've applied, but I have a question below.
> ERLANG_P1_XMPP_DEPENDENCIES = erlang-p1-xml erlang-p1-stringprep \
> erlang-p1-tls erlang-p1-utils erlang-p1-zlib host-erlang-p1-xml
> +HOST_ERLANG_P1_XMPP_DEPENDENCIES = host-erlang-p1-xml
It is weird that there is no symmetry between the target dependencies
and host dependencies. Why don't we have the same set of packages ?
Also, it is really normal/correct for the target variant to depend on
host-erlang-p1-xml ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/erlang-p1-xmpp: fix host build
2020-02-02 8:56 ` Thomas Petazzoni
@ 2020-02-10 10:40 ` Johan Oudinet
0 siblings, 0 replies; 3+ messages in thread
From: Johan Oudinet @ 2020-02-10 10:40 UTC (permalink / raw)
To: buildroot
On Sun, Feb 2, 2020 at 9:57 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Wed, 22 Jan 2020 11:34:01 +0100
> Johan Oudinet <johan.oudinet@gmail.com> wrote:
>
> > ERLANG_P1_XMPP_DEPENDENCIES = erlang-p1-xml erlang-p1-stringprep \
> > erlang-p1-tls erlang-p1-utils erlang-p1-zlib host-erlang-p1-xml
> > +HOST_ERLANG_P1_XMPP_DEPENDENCIES = host-erlang-p1-xml
>
> It is weird that there is no symmetry between the target dependencies
> and host dependencies. Why don't we have the same set of packages ?
I honestly don't know. I use this package only as a dependency of
ejabberd. So I just check it compiles and ejabberd works correctly
afterwards. This is far from perfect to test if the list of
dependencies is correct.
> Also, it is really normal/correct for the target variant to depend on
> host-erlang-p1-xml ?
I remember I had to add this host dependency to make the target
variant compiles. I also think this is weird. I haven't tested
recently to remove such dependency but I'll try to simplify the
dependencies next time I bump the version of this package.
--
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-10 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 10:34 [Buildroot] [PATCH] package/erlang-p1-xmpp: fix host build Johan Oudinet
2020-02-02 8:56 ` Thomas Petazzoni
2020-02-10 10:40 ` Johan Oudinet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.