From: Suren Baghdasaryan <surenb@google.com> To: Minchan Kim <minchan@kernel.org> Cc: "Sumit Semwal" <sumit.semwal@linaro.org>, "Andrew Morton" <akpm@linux-foundation.org>, "Christoph Hellwig" <hch@infradead.org>, "Liam Mark" <lmark@codeaurora.org>, labbott@redhat.com, "Brian Starkey" <Brian.Starkey@arm.com>, "John Stultz" <john.stultz@linaro.org>, "Christian König" <christian.koenig@amd.com>, "Chris Goldsworthy" <cgoldswo@codeaurora.org>, "Ørjan Eide" <orjan.eide@arm.com>, "Robin Murphy" <robin.murphy@arm.com>, "James Jones" <jajones@nvidia.com>, "Hridya Valsaraju" <hridya@google.com>, "Sandeep Patil" <sspatil@google.com>, linux-media <linux-media@vger.kernel.org>, "DRI mailing list" <dri-devel@lists.freedesktop.org>, "moderated list:DMA BUFFER SHARING FRAMEWORK" <linaro-mm-sig@lists.linaro.org>, linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, kernel-team <kernel-team@android.com> Subject: Re: [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error Date: Tue, 2 Feb 2021 17:55:50 -0800 [thread overview] Message-ID: <CAJuCfpEirOiisM-xouZB7JRBDpERdvWb2gfaq003+rs0b4M83Q@mail.gmail.com> (raw) In-Reply-To: <YBn81xAeCqHgudYb@google.com> On Tue, Feb 2, 2021 at 5:31 PM Minchan Kim <minchan@kernel.org> wrote: > > On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote: > > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > > WARN_ON_ONCE and returning an error. This is to ensure users of the > > vm_insert_page that set VM_PFNMAP are notified of the wrong flag usage > > and get an indication of an error without panicing the kernel. > > This will help identifying drivers that need to clear VM_PFNMAP before > > using dmabuf system heap which is moving to use vm_insert_page. > > > > Suggested-by: Christoph Hellwig <hch@infradead.org> > > Signed-off-by: Suren Baghdasaryan <surenb@google.com> > > --- > > mm/memory.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index feff48e1465a..e503c9801cd9 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -1827,7 +1827,8 @@ int vm_insert_page(struct vm_area_struct *vma, unsigned long addr, > > return -EINVAL; > > if (!(vma->vm_flags & VM_MIXEDMAP)) { > > BUG_ON(mmap_read_trylock(vma->vm_mm)); > > Better to replace above BUG_ON with WARN_ON_ONCE, too? If nobody objects I'll do that in the next respin. Thanks! > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >
WARNING: multiple messages have this Message-ID (diff)
From: Suren Baghdasaryan <surenb@google.com> To: Minchan Kim <minchan@kernel.org> Cc: "moderated list:DMA BUFFER SHARING FRAMEWORK" <linaro-mm-sig@lists.linaro.org>, "Ørjan Eide" <orjan.eide@arm.com>, "Sandeep Patil" <sspatil@google.com>, "Christian König" <christian.koenig@amd.com>, kernel-team <kernel-team@android.com>, "James Jones" <jajones@nvidia.com>, LKML <linux-kernel@vger.kernel.org>, "Liam Mark" <lmark@codeaurora.org>, "Christoph Hellwig" <hch@infradead.org>, linux-mm <linux-mm@kvack.org>, "DRI mailing list" <dri-devel@lists.freedesktop.org>, "Chris Goldsworthy" <cgoldswo@codeaurora.org>, "Hridya Valsaraju" <hridya@google.com>, "Andrew Morton" <akpm@linux-foundation.org>, labbott@redhat.com, "Robin Murphy" <robin.murphy@arm.com>, linux-media <linux-media@vger.kernel.org> Subject: Re: [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error Date: Tue, 2 Feb 2021 17:55:50 -0800 [thread overview] Message-ID: <CAJuCfpEirOiisM-xouZB7JRBDpERdvWb2gfaq003+rs0b4M83Q@mail.gmail.com> (raw) In-Reply-To: <YBn81xAeCqHgudYb@google.com> On Tue, Feb 2, 2021 at 5:31 PM Minchan Kim <minchan@kernel.org> wrote: > > On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote: > > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > > WARN_ON_ONCE and returning an error. This is to ensure users of the > > vm_insert_page that set VM_PFNMAP are notified of the wrong flag usage > > and get an indication of an error without panicing the kernel. > > This will help identifying drivers that need to clear VM_PFNMAP before > > using dmabuf system heap which is moving to use vm_insert_page. > > > > Suggested-by: Christoph Hellwig <hch@infradead.org> > > Signed-off-by: Suren Baghdasaryan <surenb@google.com> > > --- > > mm/memory.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index feff48e1465a..e503c9801cd9 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -1827,7 +1827,8 @@ int vm_insert_page(struct vm_area_struct *vma, unsigned long addr, > > return -EINVAL; > > if (!(vma->vm_flags & VM_MIXEDMAP)) { > > BUG_ON(mmap_read_trylock(vma->vm_mm)); > > Better to replace above BUG_ON with WARN_ON_ONCE, too? If nobody objects I'll do that in the next respin. Thanks! > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-03 1:56 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-03 0:31 [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error Suren Baghdasaryan 2021-02-03 0:31 ` Suren Baghdasaryan 2021-02-03 0:31 ` Suren Baghdasaryan 2021-02-03 0:31 ` [PATCH v2 2/2] dma-buf: heaps: Map system heap pages as managed by linux vm Suren Baghdasaryan 2021-02-03 0:31 ` Suren Baghdasaryan 2021-02-03 0:31 ` Suren Baghdasaryan 2021-02-03 1:39 ` Minchan Kim 2021-02-03 1:39 ` Minchan Kim 2021-02-03 2:02 ` Suren Baghdasaryan 2021-02-03 2:02 ` Suren Baghdasaryan 2021-02-03 8:05 ` Christian König 2021-02-03 8:05 ` Christian König 2021-02-03 19:53 ` Suren Baghdasaryan 2021-02-03 19:53 ` Suren Baghdasaryan 2021-02-03 2:07 ` John Stultz 2021-02-03 2:07 ` John Stultz 2021-02-03 2:13 ` Suren Baghdasaryan 2021-02-03 2:13 ` Suren Baghdasaryan 2021-02-03 1:27 ` [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error Miaohe Lin 2021-02-03 1:27 ` Miaohe Lin 2021-02-03 1:31 ` Minchan Kim 2021-02-03 1:31 ` Minchan Kim 2021-02-03 1:55 ` Suren Baghdasaryan [this message] 2021-02-03 1:55 ` Suren Baghdasaryan 2021-02-03 1:55 ` Matthew Wilcox 2021-02-03 1:55 ` Matthew Wilcox 2021-02-03 2:26 ` Suren Baghdasaryan 2021-02-03 2:26 ` Suren Baghdasaryan 2021-02-03 8:52 ` [Linaro-mm-sig] " Daniel Vetter 2021-02-03 8:52 ` Daniel Vetter 2021-02-03 20:20 ` Suren Baghdasaryan 2021-02-03 20:20 ` Suren Baghdasaryan 2021-02-03 20:29 ` Daniel Vetter 2021-02-03 20:29 ` Daniel Vetter 2021-02-03 21:25 ` Daniel Vetter 2021-02-03 21:25 ` Daniel Vetter 2021-02-03 21:41 ` Suren Baghdasaryan 2021-02-03 21:41 ` Suren Baghdasaryan 2021-02-04 8:16 ` Christian König 2021-02-04 8:16 ` Christian König 2021-02-04 8:16 ` Christian König 2021-02-04 15:22 ` Daniel Vetter 2021-02-04 15:22 ` Daniel Vetter 2021-02-04 15:22 ` Daniel Vetter 2021-02-04 15:54 ` Alex Deucher 2021-02-04 15:54 ` Alex Deucher 2021-02-04 15:54 ` Alex Deucher 2021-02-05 3:39 ` Suren Baghdasaryan 2021-02-05 3:39 ` Suren Baghdasaryan 2021-02-04 7:53 ` Christian König 2021-02-04 7:53 ` Christian König
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJuCfpEirOiisM-xouZB7JRBDpERdvWb2gfaq003+rs0b4M83Q@mail.gmail.com \ --to=surenb@google.com \ --cc=Brian.Starkey@arm.com \ --cc=akpm@linux-foundation.org \ --cc=cgoldswo@codeaurora.org \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=hch@infradead.org \ --cc=hridya@google.com \ --cc=jajones@nvidia.com \ --cc=john.stultz@linaro.org \ --cc=kernel-team@android.com \ --cc=labbott@redhat.com \ --cc=linaro-mm-sig@lists.linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lmark@codeaurora.org \ --cc=minchan@kernel.org \ --cc=orjan.eide@arm.com \ --cc=robin.murphy@arm.com \ --cc=sspatil@google.com \ --cc=sumit.semwal@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.