[PATCH linux-next] sched/psi: avoid unnecessary resetting min update period when destroy trigger

* [PATCH linux-next] sched/psi: avoid unnecessary resetting min update period when destroy trigger
@ 2023-04-17  8:11 yang.yang29
  2023-04-17 19:04 ` Suren Baghdasaryan
  0 siblings, 1 reply; 6+ messages in thread
From: yang.yang29 @ 2023-04-17  8:11 UTC (permalink / raw)
  To: hannes, surenb; +Cc: mingo, linux-kernel, juri.lelli

From: Yang Yang <yang.yang19@zte.com.cn>

Psi_group's poll_min_period is determined by the min window size of
psi_trigger when creating new triggers. While destroying a psi_trigger,
there is no need to reset poll_min_period if the destroying psi_trigger
not had the min windows size, since in this condition poll_min_period
will keep the same as before.

Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
---
 kernel/sched/psi.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 02e011cabe91..12869585cf89 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -1359,11 +1359,16 @@ void psi_trigger_destroy(struct psi_trigger *t)
 		group->nr_triggers[t->state]--;
 		if (!group->nr_triggers[t->state])
 			group->poll_states &= ~(1 << t->state);
-		/* reset min update period for the remaining triggers */
-		list_for_each_entry(tmp, &group->triggers, node)
-			period = min(period, div_u64(tmp->win.size,
-					UPDATES_PER_WINDOW));
-		group->poll_min_period = period;
+		/*
+		 * Reset min update period for the remaining triggers iff the destroying
+		 * trigger had the min window size.
+		 */
+		if (group->poll_min_period == div_u64(t->win.size, UPDATES_PER_WINDOW)) {
+			list_for_each_entry(tmp, &group->triggers, node)
+				period = min(period, div_u64(tmp->win.size,
+						UPDATES_PER_WINDOW));
+			group->poll_min_period = period;
+		}
 		/* Destroy poll_task when the last trigger is destroyed */
 		if (group->poll_states == 0) {
 			group->polling_until = 0;
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread