All of lore.kernel.org
 help / color / mirror / Atom feed
* [peterz-queue:sched/core 16/18] kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2
@ 2022-10-26  1:58 kernel test robot
  2022-10-26  9:21 ` Peter Zijlstra
  0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2022-10-26  1:58 UTC (permalink / raw)
  To: Suren Baghdasaryan; +Cc: llvm, oe-kbuild-all, linux-kernel, Peter Zijlstra

[-- Attachment #1: Type: text/plain, Size: 4379 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
head:   7005e3c43be6b6297440e85cb7d8c12a94540b49
commit: 95a70934458341dc43db09be8e7b88c98fba9b89 [16/18] psi: stop relying on timer_pending for poll_work rescheduling
config: i386-randconfig-a004-20221024 (attached as .config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=95a70934458341dc43db09be8e7b88c98fba9b89
        git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
        git fetch --no-tags peterz-queue sched/core
        git checkout 95a70934458341dc43db09be8e7b88c98fba9b89
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from kernel/sched/build_utility.c:97:
>> kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2
                           psi_schedule_poll_work(group, 1);
                           ~~~~~~~~~~~~~~~~~~~~~~         ^
   kernel/sched/psi.c:568:13: note: 'psi_schedule_poll_work' declared here
   static void psi_schedule_poll_work(struct psi_group *group, unsigned long delay,
               ^
   1 error generated.


vim +983 kernel/sched/psi.c

eb414681d5a07d Johannes Weiner 2018-10-26  954  
52b1364ba0b105 Chengming Zhou  2022-08-26  955  #ifdef CONFIG_IRQ_TIME_ACCOUNTING
52b1364ba0b105 Chengming Zhou  2022-08-26  956  void psi_account_irqtime(struct task_struct *task, u32 delta)
52b1364ba0b105 Chengming Zhou  2022-08-26  957  {
52b1364ba0b105 Chengming Zhou  2022-08-26  958  	int cpu = task_cpu(task);
52b1364ba0b105 Chengming Zhou  2022-08-26  959  	struct psi_group *group;
52b1364ba0b105 Chengming Zhou  2022-08-26  960  	struct psi_group_cpu *groupc;
52b1364ba0b105 Chengming Zhou  2022-08-26  961  	u64 now;
52b1364ba0b105 Chengming Zhou  2022-08-26  962  
52b1364ba0b105 Chengming Zhou  2022-08-26  963  	if (!task->pid)
52b1364ba0b105 Chengming Zhou  2022-08-26  964  		return;
52b1364ba0b105 Chengming Zhou  2022-08-26  965  
52b1364ba0b105 Chengming Zhou  2022-08-26  966  	now = cpu_clock(cpu);
52b1364ba0b105 Chengming Zhou  2022-08-26  967  
dc86aba751e286 Chengming Zhou  2022-08-26  968  	group = task_psi_group(task);
dc86aba751e286 Chengming Zhou  2022-08-26  969  	do {
34f26a15611afb Chengming Zhou  2022-09-07  970  		if (!group->enabled)
34f26a15611afb Chengming Zhou  2022-09-07  971  			continue;
34f26a15611afb Chengming Zhou  2022-09-07  972  
52b1364ba0b105 Chengming Zhou  2022-08-26  973  		groupc = per_cpu_ptr(group->pcpu, cpu);
52b1364ba0b105 Chengming Zhou  2022-08-26  974  
52b1364ba0b105 Chengming Zhou  2022-08-26  975  		write_seqcount_begin(&groupc->seq);
52b1364ba0b105 Chengming Zhou  2022-08-26  976  
52b1364ba0b105 Chengming Zhou  2022-08-26  977  		record_times(groupc, now);
52b1364ba0b105 Chengming Zhou  2022-08-26  978  		groupc->times[PSI_IRQ_FULL] += delta;
52b1364ba0b105 Chengming Zhou  2022-08-26  979  
52b1364ba0b105 Chengming Zhou  2022-08-26  980  		write_seqcount_end(&groupc->seq);
52b1364ba0b105 Chengming Zhou  2022-08-26  981  
52b1364ba0b105 Chengming Zhou  2022-08-26  982  		if (group->poll_states & (1 << PSI_IRQ_FULL))
52b1364ba0b105 Chengming Zhou  2022-08-26 @983  			psi_schedule_poll_work(group, 1);
dc86aba751e286 Chengming Zhou  2022-08-26  984  	} while ((group = group->parent));
52b1364ba0b105 Chengming Zhou  2022-08-26  985  }
52b1364ba0b105 Chengming Zhou  2022-08-26  986  #endif
52b1364ba0b105 Chengming Zhou  2022-08-26  987  

:::::: The code at line 983 was first introduced by commit
:::::: 52b1364ba0b105122d6de0e719b36db705011ac1 sched/psi: Add PSI_IRQ to track IRQ/SOFTIRQ pressure

:::::: TO: Chengming Zhou <zhouchengming@bytedance.com>
:::::: CC: Peter Zijlstra <peterz@infradead.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33806 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [peterz-queue:sched/core 16/18] kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2
  2022-10-26  1:58 [peterz-queue:sched/core 16/18] kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2 kernel test robot
@ 2022-10-26  9:21 ` Peter Zijlstra
  2022-10-26 18:28   ` Suren Baghdasaryan
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Zijlstra @ 2022-10-26  9:21 UTC (permalink / raw)
  To: kernel test robot; +Cc: Suren Baghdasaryan, llvm, oe-kbuild-all, linux-kernel

On Wed, Oct 26, 2022 at 09:58:58AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
> head:   7005e3c43be6b6297440e85cb7d8c12a94540b49
> commit: 95a70934458341dc43db09be8e7b88c98fba9b89 [16/18] psi: stop relying on timer_pending for poll_work rescheduling
> config: i386-randconfig-a004-20221024 (attached as .config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=95a70934458341dc43db09be8e7b88c98fba9b89
>         git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
>         git fetch --no-tags peterz-queue sched/core
>         git checkout 95a70934458341dc43db09be8e7b88c98fba9b89
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from kernel/sched/build_utility.c:97:
> >> kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2
>                            psi_schedule_poll_work(group, 1);
>                            ~~~~~~~~~~~~~~~~~~~~~~         ^
>    kernel/sched/psi.c:568:13: note: 'psi_schedule_poll_work' declared here
>    static void psi_schedule_poll_work(struct psi_group *group, unsigned long delay,
>                ^
>    1 error generated.
> 
> 

Droping for now; Suren could you fix up and repost please?

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [peterz-queue:sched/core 16/18] kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2
  2022-10-26  9:21 ` Peter Zijlstra
@ 2022-10-26 18:28   ` Suren Baghdasaryan
  2022-10-26 23:44     ` Suren Baghdasaryan
  0 siblings, 1 reply; 4+ messages in thread
From: Suren Baghdasaryan @ 2022-10-26 18:28 UTC (permalink / raw)
  To: Peter Zijlstra; +Cc: kernel test robot, llvm, oe-kbuild-all, linux-kernel

On Wed, Oct 26, 2022 at 2:21 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Wed, Oct 26, 2022 at 09:58:58AM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
> > head:   7005e3c43be6b6297440e85cb7d8c12a94540b49
> > commit: 95a70934458341dc43db09be8e7b88c98fba9b89 [16/18] psi: stop relying on timer_pending for poll_work rescheduling
> > config: i386-randconfig-a004-20221024 (attached as .config)
> > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=95a70934458341dc43db09be8e7b88c98fba9b89
> >         git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
> >         git fetch --no-tags peterz-queue sched/core
> >         git checkout 95a70934458341dc43db09be8e7b88c98fba9b89
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >    In file included from kernel/sched/build_utility.c:97:
> > >> kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2
> >                            psi_schedule_poll_work(group, 1);
> >                            ~~~~~~~~~~~~~~~~~~~~~~         ^
> >    kernel/sched/psi.c:568:13: note: 'psi_schedule_poll_work' declared here
> >    static void psi_schedule_poll_work(struct psi_group *group, unsigned long delay,
> >                ^
> >    1 error generated.
> >
> >
>
> Droping for now; Suren could you fix up and repost please?

Sorry, I missed the report. Will post a fix by EOD. Thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [peterz-queue:sched/core 16/18] kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2
  2022-10-26 18:28   ` Suren Baghdasaryan
@ 2022-10-26 23:44     ` Suren Baghdasaryan
  0 siblings, 0 replies; 4+ messages in thread
From: Suren Baghdasaryan @ 2022-10-26 23:44 UTC (permalink / raw)
  To: Peter Zijlstra; +Cc: kernel test robot, llvm, oe-kbuild-all, linux-kernel

On Wed, Oct 26, 2022 at 11:28 AM Suren Baghdasaryan <surenb@google.com> wrote:
>
> On Wed, Oct 26, 2022 at 2:21 AM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Wed, Oct 26, 2022 at 09:58:58AM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
> > > head:   7005e3c43be6b6297440e85cb7d8c12a94540b49
> > > commit: 95a70934458341dc43db09be8e7b88c98fba9b89 [16/18] psi: stop relying on timer_pending for poll_work rescheduling
> > > config: i386-randconfig-a004-20221024 (attached as .config)
> > > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=95a70934458341dc43db09be8e7b88c98fba9b89
> > >         git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
> > >         git fetch --no-tags peterz-queue sched/core
> > >         git checkout 95a70934458341dc43db09be8e7b88c98fba9b89
> > >         # save the config file
> > >         mkdir build_dir && cp config build_dir/.config
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >    In file included from kernel/sched/build_utility.c:97:
> > > >> kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2
> > >                            psi_schedule_poll_work(group, 1);
> > >                            ~~~~~~~~~~~~~~~~~~~~~~         ^
> > >    kernel/sched/psi.c:568:13: note: 'psi_schedule_poll_work' declared here
> > >    static void psi_schedule_poll_work(struct psi_group *group, unsigned long delay,
> > >                ^
> > >    1 error generated.
> > >
> > >
> >
> > Droping for now; Suren could you fix up and repost please?
>
> Sorry, I missed the report. Will post a fix by EOD. Thanks!

Hi Peter,
I posted the new v5 patch with the one-line fix at
https://lore.kernel.org/all/20221026233839.1934419-1-surenb@google.com.
I didn't notice the issue because that path is only used when
CONFIG_IRQ_TIME_ACCOUNTING is enabled, which I haven't tested :(
Please try picking it now. I think nothing should fail this time
around (famous last words).
Thanks,
Suren.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-26 23:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26  1:58 [peterz-queue:sched/core 16/18] kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2 kernel test robot
2022-10-26  9:21 ` Peter Zijlstra
2022-10-26 18:28   ` Suren Baghdasaryan
2022-10-26 23:44     ` Suren Baghdasaryan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.