From: Thomas Abraham <thomas.abraham@linaro.org> To: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com, devicetree-discuss@lists.ozlabs.org, dh09.lee@samsung.com, grant.likely@secretlab.ca, kgene.kim@samsung.com, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option Date: Thu, 8 Sep 2011 09:16:46 +0530 [thread overview] Message-ID: <CAJuYYwQg8pMaM7Y-AQD5eDqw32rMOHggL2gWOtJH_ri8gsH-yg@mail.gmail.com> (raw) In-Reply-To: <20110907182248.GA2874@core.coreip.homeip.net> Hi Dmitry, On 7 September 2011 23:52, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > Hi Thomas, > > On Tue, Sep 06, 2011 at 07:25:16PM +0530, Thomas Abraham wrote: >> Samsung keyboard driver could be used with platforms using device tree. >> So the inclusion of samsung keyboard driver cannot be based on >> SAMSUNG_DEV_KEYPAD. A new config option HAVE_SAMSUNG_KEYPAD is added >> which device tree based platforms should use to include samsung keyboard >> driver. > > I am sorry, I do not follow... What is the difference between > SAMSUNG_DEV_KEYPAD and HAVE_SAMSUNG_KEYPAD? They look exactly the same. The inclusion of platform device instance for keypad (in arch/arm/plat-samsung/dev-keypad.c) in the build depends on SAMSUNG_DEV_KEYPAD. The samsung-keypad driver is also dependent on SAMSUNG_DEV_KEYPAD. In case of device tree based instantiation of keypad, compilation of dev-keypad.c file is not required. So SAMSUNG_DEV_KEYPAD config option will not be selected.In that case, the compilation of the keypad driver cannot be dependent on SAMSUNG_DEV_KEYPAD. There should be another option to select the keypad driver and so HAVE_SAMSUNG_KEYPAD was introduced. HAVE_SAMSUNG_KEYPAD can be selected on platforms that need the samsung-keypad driver but do no need the keypad platform device. Thanks for your review and comments. Regards, Thomas. > > Thanks, > >> >> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> >> --- >> drivers/input/keyboard/Kconfig | 9 ++++++++- >> 1 files changed, 8 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig >> index b4dee9d..370fb18 100644 >> --- a/drivers/input/keyboard/Kconfig >> +++ b/drivers/input/keyboard/Kconfig >> @@ -423,9 +423,16 @@ config KEYBOARD_PMIC8XXX >> To compile this driver as a module, choose M here: the module will >> be called pmic8xxx-keypad. >> >> +config HAVE_SAMSUNG_KEYPAD >> + bool >> + help >> + This will include Samsung Keypad controller driver support. If you >> + want to include Samsung Keypad support for any machine, kindly >> + select this in the respective mach-xxxx/Kconfig file. >> + >> config KEYBOARD_SAMSUNG >> tristate "Samsung keypad support" >> - depends on SAMSUNG_DEV_KEYPAD >> + depends on SAMSUNG_DEV_KEYPAD || HAVE_SAMSUNG_KEYPAD >> help >> Say Y here if you want to use the Samsung keypad. >> >> -- >> 1.6.6.rc2 >> > > -- > Dmitry >
WARNING: multiple messages have this Message-ID (diff)
From: thomas.abraham@linaro.org (Thomas Abraham) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option Date: Thu, 8 Sep 2011 09:16:46 +0530 [thread overview] Message-ID: <CAJuYYwQg8pMaM7Y-AQD5eDqw32rMOHggL2gWOtJH_ri8gsH-yg@mail.gmail.com> (raw) In-Reply-To: <20110907182248.GA2874@core.coreip.homeip.net> Hi Dmitry, On 7 September 2011 23:52, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > Hi Thomas, > > On Tue, Sep 06, 2011 at 07:25:16PM +0530, Thomas Abraham wrote: >> Samsung keyboard driver could be used with platforms using device tree. >> So the inclusion of samsung keyboard driver cannot be based on >> SAMSUNG_DEV_KEYPAD. A new config option HAVE_SAMSUNG_KEYPAD is added >> which device tree based platforms should use to include samsung keyboard >> driver. > > I am sorry, I do not follow... What is the difference between > SAMSUNG_DEV_KEYPAD and HAVE_SAMSUNG_KEYPAD? They look exactly the same. The inclusion of platform device instance for keypad (in arch/arm/plat-samsung/dev-keypad.c) in the build depends on SAMSUNG_DEV_KEYPAD. The samsung-keypad driver is also dependent on SAMSUNG_DEV_KEYPAD. In case of device tree based instantiation of keypad, compilation of dev-keypad.c file is not required. So SAMSUNG_DEV_KEYPAD config option will not be selected.In that case, the compilation of the keypad driver cannot be dependent on SAMSUNG_DEV_KEYPAD. There should be another option to select the keypad driver and so HAVE_SAMSUNG_KEYPAD was introduced. HAVE_SAMSUNG_KEYPAD can be selected on platforms that need the samsung-keypad driver but do no need the keypad platform device. Thanks for your review and comments. Regards, Thomas. > > Thanks, > >> >> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> >> --- >> ?drivers/input/keyboard/Kconfig | ? ?9 ++++++++- >> ?1 files changed, 8 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig >> index b4dee9d..370fb18 100644 >> --- a/drivers/input/keyboard/Kconfig >> +++ b/drivers/input/keyboard/Kconfig >> @@ -423,9 +423,16 @@ config KEYBOARD_PMIC8XXX >> ? ? ? ? To compile this driver as a module, choose M here: the module will >> ? ? ? ? be called pmic8xxx-keypad. >> >> +config HAVE_SAMSUNG_KEYPAD >> + ? ? bool >> + ? ? help >> + ? ? ? This will include Samsung Keypad controller driver support. If you >> + ? ? ? want to include Samsung Keypad support for any machine, kindly >> + ? ? ? select this in the respective mach-xxxx/Kconfig file. >> + >> ?config KEYBOARD_SAMSUNG >> ? ? ? tristate "Samsung keypad support" >> - ? ? depends on SAMSUNG_DEV_KEYPAD >> + ? ? depends on SAMSUNG_DEV_KEYPAD || HAVE_SAMSUNG_KEYPAD >> ? ? ? help >> ? ? ? ? Say Y here if you want to use the Samsung keypad. >> >> -- >> 1.6.6.rc2 >> > > -- > Dmitry >
next prev parent reply other threads:[~2011-09-08 3:46 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-09-06 13:55 [PATCH 0/2] Add device tree support for Samsung's keypad controller driver Thomas Abraham 2011-09-06 13:55 ` Thomas Abraham 2011-09-06 13:55 ` [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option Thomas Abraham 2011-09-06 13:55 ` Thomas Abraham 2011-09-06 13:55 ` [PATCH 2/2] input: samsung-keypad: Add device tree support Thomas Abraham 2011-09-06 13:55 ` Thomas Abraham 2011-09-07 20:50 ` Dmitry Torokhov 2011-09-07 20:50 ` Dmitry Torokhov 2011-09-08 4:31 ` Thomas Abraham 2011-09-08 4:31 ` Thomas Abraham 2011-09-07 18:22 ` [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option Dmitry Torokhov 2011-09-07 18:22 ` Dmitry Torokhov 2011-09-07 21:49 ` Dmitry Torokhov 2011-09-07 21:49 ` Dmitry Torokhov 2011-09-08 3:58 ` Thomas Abraham 2011-09-08 3:58 ` Thomas Abraham 2011-09-08 3:46 ` Thomas Abraham [this message] 2011-09-08 3:46 ` Thomas Abraham [not found] ` <CAJuYYwQg8pMaM7Y-AQD5eDqw32rMOHggL2gWOtJH_ri8gsH-yg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2011-09-08 16:33 ` Dmitry Torokhov 2011-09-08 16:33 ` Dmitry Torokhov 2011-09-12 11:19 ` Thomas Abraham 2011-09-12 11:19 ` Thomas Abraham 2011-09-13 12:26 [PATCH v2 0/2] Add device tree support for Samsung's keypad controller driver Thomas Abraham 2011-09-13 12:26 ` [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option Thomas Abraham 2011-09-13 12:26 ` Thomas Abraham
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJuYYwQg8pMaM7Y-AQD5eDqw32rMOHggL2gWOtJH_ri8gsH-yg@mail.gmail.com \ --to=thomas.abraham@linaro.org \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=dh09.lee@samsung.com \ --cc=dmitry.torokhov@gmail.com \ --cc=grant.likely@secretlab.ca \ --cc=jy0922.shim@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.