From: Thomas Abraham <thomas.abraham@linaro.org> To: Grant Likely <grant.likely@secretlab.ca> Cc: devicetree-discuss@lists.ozlabs.org, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jy0922.shim@samsung.com, dh09.lee@samsung.com Subject: Re: [PATCH 2/2] input: samsung-keypad: Add device tree support Date: Wed, 14 Sep 2011 23:39:03 +0530 [thread overview] Message-ID: <CAJuYYwRP2DGge1aHz-CWMnUrdz686s6X5Fp=LvRkM35VQS1XYw@mail.gmail.com> (raw) In-Reply-To: <20110914171318.GA24425@ponder.secretlab.ca> Hi Grant, On 14 September 2011 22:43, Grant Likely <grant.likely@secretlab.ca> wrote: > On Wed, Sep 14, 2011 at 10:19:22PM +0530, Thomas Abraham wrote: >> Hi Grant, >> >> On 14 September 2011 21:41, Grant Likely <grant.likely@secretlab.ca> wrote: >> > On Tue, Sep 13, 2011 at 05:56:19PM +0530, Thomas Abraham wrote: >> >> Add device tree based discovery support for Samsung's keypad controller. >> >> >> >> Cc: Joonyoung Shim <jy0922.shim@samsung.com> >> >> Cc: Donghwa Lee <dh09.lee@samsung.com> >> >> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> >> >> --- >> >> .../devicetree/bindings/input/samsung-keypad.txt | 88 ++++++++++ >> >> drivers/input/keyboard/samsung-keypad.c | 177 ++++++++++++++++++-- >> >> 2 files changed, 253 insertions(+), 12 deletions(-) >> >> create mode 100644 Documentation/devicetree/bindings/input/samsung-keypad.txt >> >> [...] >> >> +- Keys represented as child nodes: Each key connected to the keypad >> >> + controller is represented as a child node to the keypad controller >> >> + device node and should include the following properties. >> >> + - keypad,row: the row number to which the key is connected. >> >> + - keypad,column: the column number to which the key is connected. >> >> + - keypad,key-code: the key-code to be reported when the key is pressed >> >> + and released. >> > >> > What defines the meanings of the key codes? >> >> The key-code could be any value which the system would want the keypad >> driver to report when that key is pressed. > > Are they linux keycodes? If so, then this property name can > probably be linux,code. There is already precedence for that > usage in Documentation/devicetree/bindings/gpio/gpio-keys.txt. (I > would personally prefer "linux,key-code", but sometimes it is better > to go with existing precidence) You could also use linux,input-type as > specified in that binding. Ok. For linux, "keypad,key-code" would mean linux keycodes. The property name 'keypad,key-code' was chosen since it can be reused on non-linux platforms as well. I did have a look at Documentation/devicetree/bindings/gpio/gpio-keys.txt while doing this, but preferred using 'keypad,key-code' since it would be generic. Given a choice, I would like to retain this. > >> >> > >> >> + >> >> +Optional Properties specific to linux: >> >> +- linux,keypad-no-autorepeat: do no enable autorepeat feature. >> >> +- linux,keypad-wakeup: use any event on keypad as wakeup event. >> > >> > Is this really a linux-specific feature? >> >> Yes, it is a property defined by the linux subsystems. A non-linux >> system might not have such features. > > I was specifically referring to the wakeup property, but okay, I can > see the argument that it is linux-specific because it is usage-policy > related. > > g. Thanks for your review. Regards, Thomas. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: thomas.abraham@linaro.org (Thomas Abraham) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] input: samsung-keypad: Add device tree support Date: Wed, 14 Sep 2011 23:39:03 +0530 [thread overview] Message-ID: <CAJuYYwRP2DGge1aHz-CWMnUrdz686s6X5Fp=LvRkM35VQS1XYw@mail.gmail.com> (raw) In-Reply-To: <20110914171318.GA24425@ponder.secretlab.ca> Hi Grant, On 14 September 2011 22:43, Grant Likely <grant.likely@secretlab.ca> wrote: > On Wed, Sep 14, 2011 at 10:19:22PM +0530, Thomas Abraham wrote: >> Hi Grant, >> >> On 14 September 2011 21:41, Grant Likely <grant.likely@secretlab.ca> wrote: >> > On Tue, Sep 13, 2011 at 05:56:19PM +0530, Thomas Abraham wrote: >> >> Add device tree based discovery support for Samsung's keypad controller. >> >> >> >> Cc: Joonyoung Shim <jy0922.shim@samsung.com> >> >> Cc: Donghwa Lee <dh09.lee@samsung.com> >> >> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> >> >> --- >> >> ?.../devicetree/bindings/input/samsung-keypad.txt ? | ? 88 ++++++++++ >> >> ?drivers/input/keyboard/samsung-keypad.c ? ? ? ? ? ?| ?177 ++++++++++++++++++-- >> >> ?2 files changed, 253 insertions(+), 12 deletions(-) >> >> ?create mode 100644 Documentation/devicetree/bindings/input/samsung-keypad.txt >> >> [...] >> >> +- Keys represented as child nodes: Each key connected to the keypad >> >> + ?controller is represented as a child node to the keypad controller >> >> + ?device node and should include the following properties. >> >> + ?- keypad,row: the row number to which the key is connected. >> >> + ?- keypad,column: the column number to which the key is connected. >> >> + ?- keypad,key-code: the key-code to be reported when the key is pressed >> >> + ? ?and released. >> > >> > What defines the meanings of the key codes? >> >> The key-code could be any value which the system would want the keypad >> driver to report when that key is pressed. > > Are they linux keycodes? ?If so, then this property name can > probably be linux,code. ?There is already precedence for that > usage in Documentation/devicetree/bindings/gpio/gpio-keys.txt. ?(I > would personally prefer "linux,key-code", but sometimes it is better > to go with existing precidence) You could also use linux,input-type as > specified in that binding. Ok. For linux, "keypad,key-code" would mean linux keycodes. The property name 'keypad,key-code' was chosen since it can be reused on non-linux platforms as well. I did have a look at Documentation/devicetree/bindings/gpio/gpio-keys.txt while doing this, but preferred using 'keypad,key-code' since it would be generic. Given a choice, I would like to retain this. > >> >> > >> >> + >> >> +Optional Properties specific to linux: >> >> +- linux,keypad-no-autorepeat: do no enable autorepeat feature. >> >> +- linux,keypad-wakeup: use any event on keypad as wakeup event. >> > >> > Is this really a linux-specific feature? >> >> Yes, it is a property defined by the linux subsystems. A non-linux >> system might not have such features. > > I was specifically referring to the wakeup property, but okay, I can > see the argument that it is linux-specific because it is usage-policy > related. > > g. Thanks for your review. Regards, Thomas.
next prev parent reply other threads:[~2011-09-14 18:09 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-09-13 12:26 [PATCH v2 0/2] Add device tree support for Samsung's keypad controller driver Thomas Abraham 2011-09-13 12:26 ` Thomas Abraham 2011-09-13 12:26 ` [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option Thomas Abraham 2011-09-13 12:26 ` Thomas Abraham 2011-09-13 12:26 ` [PATCH 2/2] input: samsung-keypad: Add device tree support Thomas Abraham 2011-09-13 12:26 ` Thomas Abraham [not found] ` <1315916779-21793-3-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2011-09-14 16:11 ` Grant Likely 2011-09-14 16:11 ` Grant Likely [not found] ` <20110914161144.GF3134-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org> 2011-09-14 16:49 ` Thomas Abraham 2011-09-14 16:49 ` Thomas Abraham 2011-09-14 17:13 ` Grant Likely 2011-09-14 17:13 ` Grant Likely 2011-09-14 18:09 ` Thomas Abraham [this message] 2011-09-14 18:09 ` Thomas Abraham 2011-09-14 19:10 ` Grant Likely 2011-09-14 19:10 ` Grant Likely 2011-09-15 1:07 ` Thomas Abraham 2011-09-15 1:07 ` Thomas Abraham -- strict thread matches above, loose matches on Subject: below -- 2011-09-06 13:55 [PATCH 0/2] Add device tree support for Samsung's keypad controller driver Thomas Abraham 2011-09-06 13:55 ` [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option Thomas Abraham 2011-09-06 13:55 ` [PATCH 2/2] input: samsung-keypad: Add device tree support Thomas Abraham 2011-09-06 13:55 ` Thomas Abraham 2011-09-07 20:50 ` Dmitry Torokhov 2011-09-07 20:50 ` Dmitry Torokhov 2011-09-08 4:31 ` Thomas Abraham 2011-09-08 4:31 ` Thomas Abraham
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJuYYwRP2DGge1aHz-CWMnUrdz686s6X5Fp=LvRkM35VQS1XYw@mail.gmail.com' \ --to=thomas.abraham@linaro.org \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=dh09.lee@samsung.com \ --cc=dmitry.torokhov@gmail.com \ --cc=grant.likely@secretlab.ca \ --cc=jy0922.shim@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.