All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Abraham <thomas.abraham@linaro.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: spi-devel-general@lists.sourceforge.net,
	devicetree-discuss@lists.ozlabs.org,
	linux-samsung-soc@vger.kernel.org, rob.herring@calxeda.com,
	grant.likely@secretlab.ca, jaswinder.singh@linaro.org,
	kgene.kim@samsung.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data
Date: Tue, 10 Jul 2012 22:56:26 +0530	[thread overview]
Message-ID: <CAJuYYwSi-1nBM40SWt359W0Lr2n_yVX5tvWfOS77bmLQRt_9fw@mail.gmail.com> (raw)
In-Reply-To: <20120710165716.GJ10022@opensource.wolfsonmicro.com>

On 10 July 2012 22:27, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote:
>
>> In non-dt case, the platform code supplying the gpio number (slave
>> select line) is responsible for requesting the gpio during the
>> machine_init call. So the gpio request is not called in the driver for
>> that gpio. In dt case, the 6th patch adds dt support and that patch
>> includes a gpio request call. Hence, this looks okay to me. Please
>> suggest if you still feel that there are changes required.
>
> That's not really particularly sensible given that the changes remove
> the option to use anything except GPIOs, the GPIO request should be done
> unconditionally in the driver now.

Yes, that is right. I will add the gpio request in the driver and
resubmit the patch. Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: thomas.abraham@linaro.org (Thomas Abraham)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data
Date: Tue, 10 Jul 2012 22:56:26 +0530	[thread overview]
Message-ID: <CAJuYYwSi-1nBM40SWt359W0Lr2n_yVX5tvWfOS77bmLQRt_9fw@mail.gmail.com> (raw)
In-Reply-To: <20120710165716.GJ10022@opensource.wolfsonmicro.com>

On 10 July 2012 22:27, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote:
>
>> In non-dt case, the platform code supplying the gpio number (slave
>> select line) is responsible for requesting the gpio during the
>> machine_init call. So the gpio request is not called in the driver for
>> that gpio. In dt case, the 6th patch adds dt support and that patch
>> includes a gpio request call. Hence, this looks okay to me. Please
>> suggest if you still feel that there are changes required.
>
> That's not really particularly sensible given that the changes remove
> the option to use anything except GPIOs, the GPIO request should be done
> unconditionally in the driver now.

Yes, that is right. I will add the gpio request in the driver and
resubmit the patch. Thanks.

  reply	other threads:[~2012-07-10 17:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10 14:27 [PATCH v4 0/6] spi: s3c64xx: add support for device tree Thomas Abraham
2012-07-10 14:27 ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro Thomas Abraham
2012-07-10 14:27   ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 2/6] spi: s3c64xx: move controller information into driver data Thomas Abraham
2012-07-10 14:27   ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 3/6] ARM: Samsung: Remove pdev pointer parameter from spi gpio setup functions Thomas Abraham
2012-07-10 14:27   ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function Thomas Abraham
2012-07-10 14:27   ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data Thomas Abraham
2012-07-10 14:27   ` Thomas Abraham
     [not found]   ` <1341930459-25223-6-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-07-10 14:38     ` Mark Brown
2012-07-10 14:38       ` Mark Brown
2012-07-10 16:52       ` Thomas Abraham
2012-07-10 16:52         ` Thomas Abraham
2012-07-10 16:57         ` Mark Brown
2012-07-10 16:57           ` Mark Brown
2012-07-10 17:26           ` Thomas Abraham [this message]
2012-07-10 17:26             ` Thomas Abraham
2012-07-11 11:15             ` [PATCH v5 " Thomas Abraham
2012-07-11 11:15               ` Thomas Abraham
2012-07-11 11:47               ` Mark Brown
2012-07-11 11:47                 ` Mark Brown
2012-07-11 12:21                 ` Thomas Abraham
2012-07-11 12:21                   ` Thomas Abraham
2012-07-11 13:31                   ` Mark Brown
2012-07-11 13:31                     ` Mark Brown
2012-07-11 15:29                     ` Thomas Abraham
2012-07-11 15:29                       ` Thomas Abraham
2012-07-10 14:27 ` [PATCH v4 6/6] spi: s3c64xx: add device tree support Thomas Abraham
2012-07-10 14:27   ` Thomas Abraham
2012-07-11 11:17   ` [PATCH v5 " Thomas Abraham
2012-07-11 11:17     ` Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJuYYwSi-1nBM40SWt359W0Lr2n_yVX5tvWfOS77bmLQRt_9fw@mail.gmail.com \
    --to=thomas.abraham@linaro.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jaswinder.singh@linaro.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.