All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Mori Hess <fmh6jj@gmail.com>
To: Minas Harutyunyan <minas.harutyunyan@synopsys.com>,
	linux-usb@vger.kernel.org
Subject: usb: dwc2: screaming interrupt after kexec reboot
Date: Mon, 25 May 2020 23:25:23 -0400	[thread overview]
Message-ID: <CAJz5Opc0zDQxnNp2foPEeL0=hOZ0C9-xy3T4nEO2pRy-rQmpWQ@mail.gmail.com> (raw)

Hi,

I get a screaming dwc2 interrupt after rebooting into a new kernel
with kexec.  I fixed it by modifying the dwc2_driver_shutdown function
in dwc2/platform.c so it does

dwc2_writel(hsotg, 0, GINTMSK);
dwc2_writel(hsotg, 0, HAINTMSK);
dwc2_writel(hsotg, 0, DAINTMSK);

rather than calling disable_irq().  Another reason to make this change
is disable_irq() affects other devices if the irq is shared.  I'd
really rather not submit a formal patch, hopefully the maintainer will
adopt this suggestion.

-- 
Frank

             reply	other threads:[~2020-05-26  3:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26  3:25 Frank Mori Hess [this message]
2020-05-27  6:06 ` usb: dwc2: screaming interrupt after kexec reboot Minas Harutyunyan
2020-05-28 19:16   ` Frank Mori Hess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJz5Opc0zDQxnNp2foPEeL0=hOZ0C9-xy3T4nEO2pRy-rQmpWQ@mail.gmail.com' \
    --to=fmh6jj@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=minas.harutyunyan@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.