Re: usb: dwc2: screaming interrupt after kexec reboot

[Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>]

Hi Frank,

On 5/26/2020 7:25 AM, Frank Mori Hess wrote:
> Hi,
> 
> I get a screaming dwc2 interrupt after rebooting into a new kernel
> with kexec.  I fixed it by modifying the dwc2_driver_shutdown function
> in dwc2/platform.c so it does
> 
> dwc2_writel(hsotg, 0, GINTMSK);
> dwc2_writel(hsotg, 0, HAINTMSK);
> dwc2_writel(hsotg, 0, DAINTMSK);
> 
> rather than calling disable_irq().  Another reason to make this change
> is disable_irq() affects other devices if the irq is shared.  I'd
> really rather not submit a formal patch, hopefully the maintainer will
> adopt this suggestion.
> 

Could you please test this patch instead of your suggestion. Does it 
solve issue in your case?

diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index e571c8ae65ec..ada5b66b948e 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -342,7 +342,7 @@ static void dwc2_driver_shutdown(struct 
platform_device *dev)
  {
         struct dwc2_hsotg *hsotg = platform_get_drvdata(dev);

-       disable_irq(hsotg->irq);
+       dwc2_disable_global_interrupts(hsotg);
  }

  /**


Thanks,
Minas