All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Hurley <john.hurley@netronome.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
	David Miller <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>,
	oss-drivers@netronome.com
Subject: Re: [PATCH net-next 8/8] nfp: flower: compute link aggregation action
Date: Thu, 24 May 2018 18:36:50 +0100	[thread overview]
Message-ID: <CAK+XE=nbf8r33LE-O+b+f+16g3d=DwZnyJ97_8r5v70X35N8mA@mail.gmail.com> (raw)
In-Reply-To: <CAJ3xEMiNn+k8b0ixYgL2M6X=7WLMM=i1gEoLcdEYkztjsphi=g@mail.gmail.com>

On Thu, May 24, 2018 at 6:09 PM, Or Gerlitz <gerlitz.or@gmail.com> wrote:
> On Thu, May 24, 2018 at 5:22 AM, Jakub Kicinski
> <jakub.kicinski@netronome.com> wrote:
>> From: John Hurley <john.hurley@netronome.com>
>>
>> If the egress device of an offloaded rule is a LAG port, then encode the
>> output port to the NFP with a LAG identifier and the offloaded group ID.
>>
>> A prelag action is also offloaded which must be the first action of the
>> series (although may appear after other pre-actions - e.g. tunnels). This
>> causes the FW to check that it has the necessary information to output to
>> the requested LAG port. If it does not, the packet is sent to the kernel
>> before any other actions are applied to it.
>
> Offload decision typically also looks if both devices have the same
> switchdev ID.
>
> In your case, do both reprs gets the same switchdev ID automatically when being
> put into the same team/bond instance? I wasn't sure  to see here
> changes for that matter

Hi Or,
Yes, you are correct.
We essentially substituted the switchdev ID check for a repr app check.
So an app runs per card and spawns the reprs for that card - each repr
has a backpointer to its creating app.
When deciding if we can offload a bond, we ensure that all bond ports
are reprs and belong to the same app and so same card/switchdev_id.

  reply	other threads:[~2018-05-24 17:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24  2:22 [PATCH net-next 0/8] nfp: offload LAG for tc flower egress Jakub Kicinski
2018-05-24  2:22 ` [PATCH net-next 1/8] nfp: add ndo_set_mac_address for representors Jakub Kicinski
2018-05-24  2:22 ` [PATCH net-next 2/8] nfp: nfpcore: add rtsym writing function Jakub Kicinski
2018-05-24  2:22 ` [PATCH net-next 3/8] nfp: flower: check for/turn on LAG support in firmware Jakub Kicinski
2018-05-24  2:22 ` [PATCH net-next 4/8] nfp: flower: add per repr private data for LAG offload Jakub Kicinski
2018-05-24  2:22 ` [PATCH net-next 5/8] net: include hash policy in LAG changeupper info Jakub Kicinski
2018-05-24  2:22 ` [PATCH net-next 6/8] nfp: flower: monitor and offload LAG groups Jakub Kicinski
2018-05-24  2:22 ` [PATCH net-next 7/8] nfp: flower: implement host cmsg handler for LAG Jakub Kicinski
2018-05-24  2:22 ` [PATCH net-next 8/8] nfp: flower: compute link aggregation action Jakub Kicinski
2018-05-24 17:09   ` Or Gerlitz
2018-05-24 17:36     ` John Hurley [this message]
2018-05-24 17:04 ` [PATCH net-next 0/8] nfp: offload LAG for tc flower egress Or Gerlitz
2018-05-24 18:23   ` Samudrala, Sridhar
2018-05-24 18:53     ` Jakub Kicinski
2018-05-24 18:49   ` Jakub Kicinski
2018-05-24 19:26     ` Or Gerlitz
2018-05-24 22:01       ` Jakub Kicinski
2018-05-25  3:11 ` David Miller
2018-05-25  6:48 ` Jiri Pirko
2018-05-26  2:47   ` Jakub Kicinski
2018-05-29 14:08     ` John Hurley
2018-05-29 22:09       ` Jiri Pirko
2018-05-30  9:26         ` John Hurley
2018-05-30 20:29           ` Jiri Pirko
2018-05-31 10:20             ` John Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK+XE=nbf8r33LE-O+b+f+16g3d=DwZnyJ97_8r5v70X35N8mA@mail.gmail.com' \
    --to=john.hurley@netronome.com \
    --cc=davem@davemloft.net \
    --cc=gerlitz.or@gmail.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.