[PATCH] Documentation: Update ncurses package names for menuconfig

[PATCH] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

The package name is ncurses-devel for Redhat based distros
and libncurses-devel for Debian based distros.

Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
index a10bd9d..4353e40 100755
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
+	           *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi
-- 
2.7.4

[PATCH] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

The package name is ncurses-devel for Redhat based distros
and libncurses-devel for Debian based distros.

Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
index a10bd9d..4353e40 100755
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
+	           *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi
-- 
2.7.4

Re: [PATCH] Documentation: Update ncurses package names for menuconfig

[Masahiro Yamada]

2018-02-28 15:59 GMT+09:00 Arvind Prasanna <arvindprasanna@gmail.com>:
> The package name is ncurses-devel for Redhat based distros
> and libncurses-devel for Debian based distros.
>
> Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
> ---
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index a10bd9d..4353e40 100755
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -55,7 +55,8 @@ EOF
>             echo " *** required header files."                            1>&2
>             echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
>             echo " *** "                                                  1>&2
> -           echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
> +           echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
> +                  *** depending on your distribution) and try again."    1>&2
>             echo " *** "                                                  1>&2
>             exit 1
>         fi
> --
> 2.7.4


'echo' is missing in the line you added.
So, the error message will be displayed like follows:



 *** Unable to find the ncurses libraries or the
 *** required header files.
 *** 'make menuconfig' requires the ncurses libraries.
 ***
 *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
           *** depending on your distribution) and try again.
 ***




I fixed it up locally, and applied to linux-kbuild/kconfig.
Thanks!





> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Best Regards
Masahiro Yamada

[PATCH v2] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

The package name is ncurses-devel for Redhat based distros
and libncurses-devel for Debian based distros.

Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
---

Changes in v2:
- Add a missing echo as pointed out by one of the reviewers.

 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
index a10bd9d..6c0bcd9 100755
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev " 1>&2
+	    echo " *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi
-- 
2.7.4

[PATCH v2] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

The package name is ncurses-devel for Redhat based distros
and libncurses-devel for Debian based distros.

Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
---

Changes in v2:
- Add a missing echo as pointed out by one of the reviewers.

 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
index a10bd9d..6c0bcd9 100755
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev " 1>&2
+	    echo " *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi
-- 
2.7.4

Re: [PATCH v2] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

Hi Masahiro Yamada:

I appreciate you having a look at my patch. I am still learning the ropes
contributing to open source. I have sent out version 2 of the patch with
the fix.

Thanks,

Arvind.


On Wed, Feb 28, 2018 at 11:14 AM, Arvind Prasanna <arvindprasanna@gmail.com>
wrote:

> The package name is ncurses-devel for Redhat based distros
> and libncurses-devel for Debian based distros.
>
> Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
> ---
>
> Changes in v2:
> - Add a missing echo as pointed out by one of the reviewers.
>
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh
> b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index a10bd9d..6c0bcd9 100755
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -55,7 +55,8 @@ EOF
>             echo " *** required header files."
> 1>&2
>             echo " *** 'make menuconfig' requires the ncurses libraries."
> 1>&2
>             echo " *** "
> 1>&2
> -           echo " *** Install ncurses (ncurses-devel) and try again."
> 1>&2
> +           echo " *** Install ncurses (ncurses-devel or libncurses-dev "
> 1>&2
> +           echo " *** depending on your distribution) and try again."
> 1>&2
>             echo " *** "
> 1>&2
>             exit 1
>         fi
> --
> 2.7.4
>
>

[-- Attachment #2: Type: text/html, Size: 2444 bytes --]

Re: [PATCH] Documentation: Update ncurses package names for menuconfig

[Randy Dunlap]

On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
> The package name is ncurses-devel for Redhat based distros
> and libncurses-devel for Debian based distros.

      ^^^^^^^^^^^^^^^^ That's not what the patch says. Please clarify.

> 
> Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
> ---
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index a10bd9d..4353e40 100755
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -55,7 +55,8 @@ EOF
>  	    echo " *** required header files."                            1>&2
>  	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
>  	    echo " *** "                                                  1>&2
> -	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
> +	    echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
> +	           *** depending on your distribution) and try again."    1>&2
>  	    echo " *** "                                                  1>&2
>  	    exit 1
>  	fi
> 

thanks,
-- 
~Randy

Re: [PATCH] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]

Hi Randy:

On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
> The package name is ncurses-devel for Redhat based distros
> and libncurses-devel for Debian based distros.

The above lines are part of the commit message and the patch says to
install either ncurses-devel or libncurses-dev based on the user's Linux
distribution. Would you prefer I add my commit message lines to the patch
as well?

Thanks,

Arvind.


On Wed, Feb 28, 2018 at 12:31 PM, Randy Dunlap <rdunlap@infradead.org>
wrote:

> On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
> > The package name is ncurses-devel for Redhat based distros
> > and libncurses-devel for Debian based distros.
>
>       ^^^^^^^^^^^^^^^^ That's not what the patch says. Please clarify.
>
> >
> > Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
> > ---
> >  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh
> b/scripts/kconfig/lxdialog/check-lxdialog.sh
> > index a10bd9d..4353e40 100755
> > --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> > +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> > @@ -55,7 +55,8 @@ EOF
> >           echo " *** required header files."
> 1>&2
> >           echo " *** 'make menuconfig' requires the ncurses libraries."
> 1>&2
> >           echo " *** "
> 1>&2
> > -         echo " *** Install ncurses (ncurses-devel) and try again."
> 1>&2
> > +         echo " *** Install ncurses (ncurses-devel or libncurses-dev
>  1>&2
> > +                *** depending on your distribution) and try again."
> 1>&2
> >           echo " *** "
> 1>&2
> >           exit 1
> >       fi
> >
>
> thanks,
> --
> ~Randy
>

[-- Attachment #2: Type: text/html, Size: 2848 bytes --]

Re: [PATCH] Documentation: Update ncurses package names for menuconfig

[Randy Dunlap]

On 02/28/2018 09:39 AM, Arvind Prasanna wrote:
> Hi Randy:
> 
> On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
>> The package name is ncurses-devel for Redhat based distros
>> and libncurses-devel for Debian based distros.
> 
> The above lines are part of the commit message and the patch says to install either ncurses-devel or libncurses-dev based on the user's Linux distribution. Would you prefer I add my commit message lines to the patch as well?
> 
> Thanks,
> 
> Arvind.
> 
> 
> On Wed, Feb 28, 2018 at 12:31 PM, Randy Dunlap <rdunlap@infradead.org <mailto:rdunlap@infradead.org>> wrote:
> 
>     On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
>     > The package name is ncurses-devel for Redhat based distros
>     > and libncurses-devel for Debian based distros.
> 
>           ^^^^^^^^^^^^^^^^ That's not what the patch says. Please clarify.

For Debian-based distros, is it libncurses-devel (above) or is it
libncurses-dev (as below)?  [latter is without the ending "el"]


And what about the other few hundred distros?  (rhetorical)


>     >
>     > Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com <mailto:arvindprasanna@gmail.com>>
>     > ---
>     >  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>     >  1 file changed, 2 insertions(+), 1 deletion(-)
>     >
>     > diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
>     > index a10bd9d..4353e40 100755
>     > --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
>     > +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
>     > @@ -55,7 +55,8 @@ EOF
>     >           echo " *** required header files."                            1>&2
>     >           echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
>     >           echo " *** "                                                  1>&2
>     > -         echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
>     > +         echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
>     > +                *** depending on your distribution) and try again."    1>&2
>     >           echo " *** "                                                  1>&2
>     >           exit 1
>     >       fi


-- 
~Randy

Re: [PATCH] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

[-- Attachment #1: Type: text/plain, Size: 3947 bytes --]

If a Linux distribution is RPM based, the package name is libncurses-dev
and if it is Debian based, it is ncurses-devel. Here are some examples:

# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
# apt-cache search libncurses-dev
libncurses5-dev - developer's libraries for ncurses

# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="Ubuntu 16.04.3 LTS"
# apt-cache search libncurses-dev
libncurses5-dev - developer's libraries for ncurses


# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="CentOS Linux 7 (Core)"
# yum search ncurses-devel
====================================================================== N/S
matched: ncurses-devel
=======================================================================
ncurses-devel.i686 : Development files for the ncurses library
ncurses-devel.x86_64 : Development files for the ncurses library

# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="Fedora 27 (Twenty Seven)"
# yum search ncurses-devel
Last metadata expiration check: 0:05:07 ago on Wed Feb 28 19:20:24 2018.
================================================================== Name
Exactly Matched: ncurses-devel
==================================================================
ncurses-devel.i686 : Development files for the ncurses library
ncurses-devel.x86_64 : Development files for the ncurses library


I have tried RPM based and Debian based linux distros as they are
extensively used and widely distributed. For other (independent) Linux
distributions, it is possible they have their own names for the ncurses
development package.

Thanks,

- Arvind.

On Wed, Feb 28, 2018 at 1:59 PM, Randy Dunlap <rdunlap@infradead.org> wrote:

> On 02/28/2018 09:39 AM, Arvind Prasanna wrote:
> > Hi Randy:
> >
> > On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
> >> The package name is ncurses-devel for Redhat based distros
> >> and libncurses-devel for Debian based distros.
> >
> > The above lines are part of the commit message and the patch says to
> install either ncurses-devel or libncurses-dev based on the user's Linux
> distribution. Would you prefer I add my commit message lines to the patch
> as well?
> >
> > Thanks,
> >
> > Arvind.
> >
> >
> > On Wed, Feb 28, 2018 at 12:31 PM, Randy Dunlap <rdunlap@infradead.org
> <mailto:rdunlap@infradead.org>> wrote:
> >
> >     On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
> >     > The package name is ncurses-devel for Redhat based distros
> >     > and libncurses-devel for Debian based distros.
> >
> >           ^^^^^^^^^^^^^^^^ That's not what the patch says. Please
> clarify.
>
> For Debian-based distros, is it libncurses-devel (above) or is it
> libncurses-dev (as below)?  [latter is without the ending "el"]
>
>
> And what about the other few hundred distros?  (rhetorical)
>
>
> >     >
> >     > Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com <mailto:
> arvindprasanna@gmail.com>>
> >     > ---
> >     >  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
> >     >  1 file changed, 2 insertions(+), 1 deletion(-)
> >     >
> >     > diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh
> b/scripts/kconfig/lxdialog/check-lxdialog.sh
> >     > index a10bd9d..4353e40 100755
> >     > --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> >     > +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> >     > @@ -55,7 +55,8 @@ EOF
> >     >           echo " *** required header files."
>       1>&2
> >     >           echo " *** 'make menuconfig' requires the ncurses
> libraries." 1>&2
> >     >           echo " *** "
>       1>&2
> >     > -         echo " *** Install ncurses (ncurses-devel) and try
> again."    1>&2
> >     > +         echo " *** Install ncurses (ncurses-devel or
> libncurses-dev   1>&2
> >     > +                *** depending on your distribution) and try
> again."    1>&2
> >     >           echo " *** "
>       1>&2
> >     >           exit 1
> >     >       fi
>
>
> --
> ~Randy
>

[-- Attachment #2: Type: text/html, Size: 5880 bytes --]

Re: [PATCH] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

[-- Attachment #1: Type: text/plain, Size: 4499 bytes --]

If it is not possible or difficult to identify the ncurses development
package name for all existing and future Linux distributions, one
possibility is that we can change the message to say "Please install the
ncurses library development package and try again". This way we don't have
to specify a package name.

On Wed, Feb 28, 2018 at 2:59 PM, Arvind Prasanna <arvindprasanna@gmail.com>
wrote:

> If a Linux distribution is RPM based, the package name is libncurses-dev
> and if it is Debian based, it is ncurses-devel. Here are some examples:
>
> # cat /etc/os-release | grep "PRETTY_NAME"
> PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
> # apt-cache search libncurses-dev
> libncurses5-dev - developer's libraries for ncurses
>
> # cat /etc/os-release | grep "PRETTY_NAME"
> PRETTY_NAME="Ubuntu 16.04.3 LTS"
> # apt-cache search libncurses-dev
> libncurses5-dev - developer's libraries for ncurses
>
>
> # cat /etc/os-release | grep "PRETTY_NAME"
> PRETTY_NAME="CentOS Linux 7 (Core)"
> # yum search ncurses-devel
> ======================================================================
> N/S matched: ncurses-devel ==============================
> =========================================
> ncurses-devel.i686 : Development files for the ncurses library
> ncurses-devel.x86_64 : Development files for the ncurses library
>
> # cat /etc/os-release | grep "PRETTY_NAME"
> PRETTY_NAME="Fedora 27 (Twenty Seven)"
> # yum search ncurses-devel
> Last metadata expiration check: 0:05:07 ago on Wed Feb 28 19:20:24 2018.
> ================================================================== Name
> Exactly Matched: ncurses-devel ==============================
> ====================================
> ncurses-devel.i686 : Development files for the ncurses library
> ncurses-devel.x86_64 : Development files for the ncurses library
>
>
> I have tried RPM based and Debian based linux distros as they are
> extensively used and widely distributed. For other (independent) Linux
> distributions, it is possible they have their own names for the ncurses
> development package.
>
> Thanks,
>
> - Arvind.
>
> On Wed, Feb 28, 2018 at 1:59 PM, Randy Dunlap <rdunlap@infradead.org>
> wrote:
>
>> On 02/28/2018 09:39 AM, Arvind Prasanna wrote:
>> > Hi Randy:
>> >
>> > On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
>> >> The package name is ncurses-devel for Redhat based distros
>> >> and libncurses-devel for Debian based distros.
>> >
>> > The above lines are part of the commit message and the patch says to
>> install either ncurses-devel or libncurses-dev based on the user's Linux
>> distribution. Would you prefer I add my commit message lines to the patch
>> as well?
>> >
>> > Thanks,
>> >
>> > Arvind.
>> >
>> >
>> > On Wed, Feb 28, 2018 at 12:31 PM, Randy Dunlap <rdunlap@infradead.org
>> <mailto:rdunlap@infradead.org>> wrote:
>> >
>> >     On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
>> >     > The package name is ncurses-devel for Redhat based distros
>> >     > and libncurses-devel for Debian based distros.
>> >
>> >           ^^^^^^^^^^^^^^^^ That's not what the patch says. Please
>> clarify.
>>
>> For Debian-based distros, is it libncurses-devel (above) or is it
>> libncurses-dev (as below)?  [latter is without the ending "el"]
>>
>>
>> And what about the other few hundred distros?  (rhetorical)
>>
>>
>> >     >
>> >     > Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com <mailto:
>> arvindprasanna@gmail.com>>
>> >     > ---
>> >     >  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>> >     >  1 file changed, 2 insertions(+), 1 deletion(-)
>> >     >
>> >     > diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh
>> b/scripts/kconfig/lxdialog/check-lxdialog.sh
>> >     > index a10bd9d..4353e40 100755
>> >     > --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
>> >     > +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
>> >     > @@ -55,7 +55,8 @@ EOF
>> >     >           echo " *** required header files."
>>       1>&2
>> >     >           echo " *** 'make menuconfig' requires the ncurses
>> libraries." 1>&2
>> >     >           echo " *** "
>>       1>&2
>> >     > -         echo " *** Install ncurses (ncurses-devel) and try
>> again."    1>&2
>> >     > +         echo " *** Install ncurses (ncurses-devel or
>> libncurses-dev   1>&2
>> >     > +                *** depending on your distribution) and try
>> again."    1>&2
>> >     >           echo " *** "
>>       1>&2
>> >     >           exit 1
>> >     >       fi
>>
>>
>> --
>> ~Randy
>>
>
>

[-- Attachment #2: Type: text/html, Size: 6792 bytes --]

Re: [PATCH] Documentation: Update ncurses package names for menuconfig

[Randy Dunlap]

Hi,

I think that you are missing my point, so let me start over and try to
clarify it.

In the patch description, it says "libncurses-devel" (not libncurses-dev).

In the patch itself, it says libncurses-dev (not libncurses-devel).

I suspect that one of these is incorrect.  Which one is it?

Thanks.
~~~~~~~~~~~~~~

The package name is ncurses-devel for Redhat based distros
and libncurses-devel for Debian based distros.

Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
index a10bd9d..4353e40 100755
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
+	           *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi


-- 
~Randy

Re: [PATCH] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

[-- Attachment #1: Type: text/plain, Size: 1715 bytes --]

Hi Randy:

Apologies. I now understand what you are referring to. My commit message is
incorrect. The correct package names are ncurses-devel and libncurses-dev.
Thank you for pointing this out. I will send a patch for this.

Thanks,

Arvind.



On Wed, Feb 28, 2018 at 3:53 PM, Randy Dunlap <rdunlap@infradead.org> wrote:

> Hi,
>
> I think that you are missing my point, so let me start over and try to
> clarify it.
>
> In the patch description, it says "libncurses-devel" (not libncurses-dev).
>
> In the patch itself, it says libncurses-dev (not libncurses-devel).
>
> I suspect that one of these is incorrect.  Which one is it?
>
> Thanks.
> ~~~~~~~~~~~~~~
>
> The package name is ncurses-devel for Redhat based distros
> and libncurses-devel for Debian based distros.
>
> Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
> ---
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh
> b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index a10bd9d..4353e40 100755
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -55,7 +55,8 @@ EOF
>             echo " *** required header files."
> 1>&2
>             echo " *** 'make menuconfig' requires the ncurses libraries."
> 1>&2
>             echo " *** "
> 1>&2
> -           echo " *** Install ncurses (ncurses-devel) and try again."
> 1>&2
> +           echo " *** Install ncurses (ncurses-devel or libncurses-dev
>  1>&2
> +                  *** depending on your distribution) and try again."
> 1>&2
>             echo " *** "
> 1>&2
>             exit 1
>         fi
>
>
> --
> ~Randy
>

[-- Attachment #2: Type: text/html, Size: 2759 bytes --]

[PATCH v3] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

The package name is ncurses-devel for Redhat based distros
and libncurses-dev for Debian based distros.

Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
---

Changes in v3:
- Fix a package name in the commit message.

Changes in v2:
- Add a missing echo as pointed out by one of the reviewers.

 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
index a10bd9d..6c0bcd9 100755
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev " 1>&2
+	    echo " *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi
-- 
2.7.4

[PATCH v3] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

The package name is ncurses-devel for Redhat based distros
and libncurses-dev for Debian based distros.

Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
---

Changes in v3:
- Fix a package name in the commit message.

Changes in v2:
- Add a missing echo as pointed out by one of the reviewers.

 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
index a10bd9d..6c0bcd9 100755
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev " 1>&2
+	    echo " *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi
-- 
2.7.4

Re: [PATCH v3] Documentation: Update ncurses package names for menuconfig

[Randy Dunlap]

On 02/28/2018 01:32 PM, Arvind Prasanna wrote:
> The package name is ncurses-devel for Redhat based distros
> and libncurses-dev for Debian based distros.
> 
> Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>

Thanks. Looks good to me.

Acked-by: Randy Dunlap <rdunlap@infradead.org>


> ---
> 
> Changes in v3:
> - Fix a package name in the commit message.
> 
> Changes in v2:
> - Add a missing echo as pointed out by one of the reviewers.
> 
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index a10bd9d..6c0bcd9 100755
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -55,7 +55,8 @@ EOF
>  	    echo " *** required header files."                            1>&2
>  	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
>  	    echo " *** "                                                  1>&2
> -	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
> +	    echo " *** Install ncurses (ncurses-devel or libncurses-dev " 1>&2
> +	    echo " *** depending on your distribution) and try again."    1>&2
>  	    echo " *** "                                                  1>&2
>  	    exit 1
>  	fi
> 


-- 
~Randy

Re: [PATCH v3] Documentation: Update ncurses package names for menuconfig

[Arvind Prasanna]

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

Thank you very much!

Regards,

Arvind.


On Wed, Feb 28, 2018 at 4:47 PM, Randy Dunlap <rdunlap@infradead.org> wrote:

> On 02/28/2018 01:32 PM, Arvind Prasanna wrote:
> > The package name is ncurses-devel for Redhat based distros
> > and libncurses-dev for Debian based distros.
> >
> > Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
>
> Thanks. Looks good to me.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
>
> > ---
> >
> > Changes in v3:
> > - Fix a package name in the commit message.
> >
> > Changes in v2:
> > - Add a missing echo as pointed out by one of the reviewers.
> >
> >  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh
> b/scripts/kconfig/lxdialog/check-lxdialog.sh
> > index a10bd9d..6c0bcd9 100755
> > --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> > +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> > @@ -55,7 +55,8 @@ EOF
> >           echo " *** required header files."
> 1>&2
> >           echo " *** 'make menuconfig' requires the ncurses libraries."
> 1>&2
> >           echo " *** "
> 1>&2
> > -         echo " *** Install ncurses (ncurses-devel) and try again."
> 1>&2
> > +         echo " *** Install ncurses (ncurses-devel or libncurses-dev "
> 1>&2
> > +         echo " *** depending on your distribution) and try again."
> 1>&2
> >           echo " *** "
> 1>&2
> >           exit 1
> >       fi
> >
>
>
> --
> ~Randy
>

[-- Attachment #2: Type: text/html, Size: 2811 bytes --]

Re: [PATCH v3] Documentation: Update ncurses package names for menuconfig

[Masahiro Yamada]

2018-03-01 6:47 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
> On 02/28/2018 01:32 PM, Arvind Prasanna wrote:
>> The package name is ncurses-devel for Redhat based distros
>> and libncurses-dev for Debian based distros.
>>
>> Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com>
>
> Thanks. Looks good to me.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>


Randy, thanks!  Eagle eyes!

I will replace it with v3.



-- 
Best Regards
Masahiro Yamada