* [PATCH] staging: ks7010: Fixed unnecessary typecasting to int. Issue found with checkpatch. Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
@ 2018-02-27 13:07 Nishka Dasgupta
2018-02-27 13:10 ` [Outreachy kernel] " Vaishali Thakkar
0 siblings, 1 reply; 6+ messages in thread
From: Nishka Dasgupta @ 2018-02-27 13:07 UTC (permalink / raw)
To: outreachy-kernel, gregkh; +Cc: Nishka Dasgupta
Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
drivers/staging/ks7010/ks_wlan_net.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index e48c557..69cd8347 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -201,6 +201,8 @@ static int ks_wlan_set_freq(struct net_device *dev,
{
struct ks_wlan_private *priv = netdev_priv(dev);
int channel;
+ int a2412 = 2.412e8;
+ int b2487 = 2.487e8;
if (priv->sleep_mode == SLP_SLEEP)
return -EPERM;
@@ -208,7 +210,7 @@ static int ks_wlan_set_freq(struct net_device *dev,
/* for SLEEP MODE */
/* If setting by frequency, convert to a channel */
if ((fwrq->e == 1) &&
- (fwrq->m >= (int)2.412e8) && (fwrq->m <= (int)2.487e8)) {
+ (fwrq->m >= a2412) && (fwrq->m <= b2487)) {
int f = fwrq->m / 100000;
int c = 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: ks7010: Fixed unnecessary typecasting to int. Issue found with checkpatch. Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
2018-02-27 13:07 [PATCH] staging: ks7010: Fixed unnecessary typecasting to int. Issue found with checkpatch. Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in> Nishka Dasgupta
@ 2018-02-27 13:10 ` Vaishali Thakkar
2018-02-27 13:47 ` Difficulty with git email Nishka Dasgupta
0 siblings, 1 reply; 6+ messages in thread
From: Vaishali Thakkar @ 2018-02-27 13:10 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: outreachy-kernel, Greg KH
On Tue, Feb 27, 2018 at 6:37 PM, Nishka Dasgupta
<nishka.dasgupta_ug18@ashoka.edu.in> wrote:
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> ---
Hi Nishka,
Something wrong happened here. Your commit log is added in the
subject itself. You may need to check your git/mutt setting.
> drivers/staging/ks7010/ks_wlan_net.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
> index e48c557..69cd8347 100644
> --- a/drivers/staging/ks7010/ks_wlan_net.c
> +++ b/drivers/staging/ks7010/ks_wlan_net.c
> @@ -201,6 +201,8 @@ static int ks_wlan_set_freq(struct net_device *dev,
> {
> struct ks_wlan_private *priv = netdev_priv(dev);
> int channel;
> + int a2412 = 2.412e8;
> + int b2487 = 2.487e8;
>
> if (priv->sleep_mode == SLP_SLEEP)
> return -EPERM;
> @@ -208,7 +210,7 @@ static int ks_wlan_set_freq(struct net_device *dev,
> /* for SLEEP MODE */
> /* If setting by frequency, convert to a channel */
> if ((fwrq->e == 1) &&
> - (fwrq->m >= (int)2.412e8) && (fwrq->m <= (int)2.487e8)) {
> + (fwrq->m >= a2412) && (fwrq->m <= b2487)) {
> int f = fwrq->m / 100000;
> int c = 0;
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519736829-4672-1-git-send-email-nishka.dasgupta_ug18%40ashoka.edu.in.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Difficulty with git email
2018-02-27 13:10 ` [Outreachy kernel] " Vaishali Thakkar
@ 2018-02-27 13:47 ` Nishka Dasgupta
2018-02-27 18:39 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Nishka Dasgupta @ 2018-02-27 13:47 UTC (permalink / raw)
To: outreachy-kernel
Hi,
I am still having trouble with sending patches through git send-email (which is what I'm using instead of mutt). As you can see, I appear to have figured it out with regards to regular text replies to messages, but I still don't understand how to do it in a patch. How can I separate the message from the commit title in a patch submission?
Thanking you,
Nishka Dasgupta
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Difficulty with git email
2018-02-27 13:47 ` Difficulty with git email Nishka Dasgupta
@ 2018-02-27 18:39 ` Greg KH
2018-02-28 11:57 ` Re: [Outreachy kernel] Dificulty " Nishka Dasgupta
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2018-02-27 18:39 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: outreachy-kernel
On Tue, Feb 27, 2018 at 07:17:24PM +0530, Nishka Dasgupta wrote:
> Hi,
> I am still having trouble with sending patches through git send-email (which is what I'm using instead of mutt). As you can see, I appear to have figured it out with regards to regular text replies to messages, but I still don't understand how to do it in a patch. How can I separate the message from the commit title in a patch submission?
You should have a blank line from the first line of the commit message
(the short summary), and the larger changelog text. That will cause the
patch to be converted into the first line being the subject of the
email, and the rest of the text to be the body.
Look at any of the commits in the kernel tree already for examples of
how to do this.
Hope this helps,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re: [Outreachy kernel] Dificulty with git email
2018-02-27 18:39 ` [Outreachy kernel] " Greg KH
@ 2018-02-28 11:57 ` Nishka Dasgupta
2018-02-28 12:05 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Nishka Dasgupta @ 2018-02-28 11:57 UTC (permalink / raw)
To: outreachy-kernel
Thank you for the advice! I think I know how to do it now. Should I resubmit my patches (as version 2) with the correctly formatted commit messages?
Thanking you,
Nishka Dasgupta
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re: [Outreachy kernel] Dificulty with git email
2018-02-28 11:57 ` Re: [Outreachy kernel] Dificulty " Nishka Dasgupta
@ 2018-02-28 12:05 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2018-02-28 12:05 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: outreachy-kernel
On Wed, 28 Feb 2018, Nishka Dasgupta wrote:
> Thank you for the advice! I think I know how to do it now. Should I resubmit my patches (as version 2) with the correctly formatted commit messages?
That would be good.
julia
>
> Thanking you,
> Nishka Dasgupta
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519819051-124-1-git-send-email-nishka.dasgupta_ug18%40ashoka.edu.in.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-28 12:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-27 13:07 [PATCH] staging: ks7010: Fixed unnecessary typecasting to int. Issue found with checkpatch. Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in> Nishka Dasgupta
2018-02-27 13:10 ` [Outreachy kernel] " Vaishali Thakkar
2018-02-27 13:47 ` Difficulty with git email Nishka Dasgupta
2018-02-27 18:39 ` [Outreachy kernel] " Greg KH
2018-02-28 11:57 ` Re: [Outreachy kernel] Dificulty " Nishka Dasgupta
2018-02-28 12:05 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.