* [Qemu-devel] [PATCH] net/filter-rewirter.c: Fix coverity static analysis issue
@ 2018-10-30 3:50 Zhang Chen
2018-10-30 16:18 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Zhang Chen @ 2018-10-30 3:50 UTC (permalink / raw)
To: qemu-devel, Peter Maydell, Jason Wang; +Cc: Zhang Chen, Zhang Chen
The original code just follow the TCP state diagram,
but in this case, we can skip the TCPS_TIME_WAIT state to simplify
the implementation.
Signed-off-by: Zhang Chen <zhangckid@gmail.com>
---
net/filter-rewriter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
index bb8f4d93b1..2e26839bc2 100644
--- a/net/filter-rewriter.c
+++ b/net/filter-rewriter.c
@@ -155,12 +155,13 @@ static int handle_primary_tcp_pkt(RewriterState *rf,
* Active close step 2.
*/
if (conn->tcp_state == TCPS_FIN_WAIT_1) {
- conn->tcp_state = TCPS_TIME_WAIT;
/*
* For simplify implementation, we needn't wait 2MSL time
* in filter rewriter. Because guest kernel will track the
* TCP status and wait 2MSL time, if client resend the FIN
* packet, guest will apply the last ACK too.
+ * So, we skip the TCPS_TIME_WAIT state here and go straight
+ * to TCPS_CLOSED state.
*/
conn->tcp_state = TCPS_CLOSED;
g_hash_table_remove(rf->connection_track_table, key);
--
2.17.GIT
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] net/filter-rewirter.c: Fix coverity static analysis issue
2018-10-30 3:50 [Qemu-devel] [PATCH] net/filter-rewirter.c: Fix coverity static analysis issue Zhang Chen
@ 2018-10-30 16:18 ` Peter Maydell
2018-10-31 0:47 ` Zhang Chen
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2018-10-30 16:18 UTC (permalink / raw)
To: Zhang Chen; +Cc: QEMU Developers, Jason Wang, Zhang Chen
On 30 October 2018 at 03:50, Zhang Chen <zhangckid@gmail.com> wrote:
> The original code just follow the TCP state diagram,
> but in this case, we can skip the TCPS_TIME_WAIT state to simplify
> the implementation.
>
> Signed-off-by: Zhang Chen <zhangckid@gmail.com>
> ---
> net/filter-rewriter.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
NB: typo in Subject: s/rewirter/rewriter/
Hopefully whoever commits this patch can fix that up for you.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] net/filter-rewirter.c: Fix coverity static analysis issue
2018-10-30 16:18 ` Peter Maydell
@ 2018-10-31 0:47 ` Zhang Chen
0 siblings, 0 replies; 3+ messages in thread
From: Zhang Chen @ 2018-10-31 0:47 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, jasowang, Zhang Chen
Oh, Sorry.
I will send the V2 patch.
Thank
Zhang Chen
On Wed, Oct 31, 2018 at 12:18 AM Peter Maydell <peter.maydell@linaro.org>
wrote:
> On 30 October 2018 at 03:50, Zhang Chen <zhangckid@gmail.com> wrote:
> > The original code just follow the TCP state diagram,
> > but in this case, we can skip the TCPS_TIME_WAIT state to simplify
> > the implementation.
> >
> > Signed-off-by: Zhang Chen <zhangckid@gmail.com>
> > ---
> > net/filter-rewriter.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> NB: typo in Subject: s/rewirter/rewriter/
>
> Hopefully whoever commits this patch can fix that up for you.
>
> thanks
> -- PMM
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-31 0:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30 3:50 [Qemu-devel] [PATCH] net/filter-rewirter.c: Fix coverity static analysis issue Zhang Chen
2018-10-30 16:18 ` Peter Maydell
2018-10-31 0:47 ` Zhang Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.