* [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS
@ 2020-08-12 15:53 Thomas Huth
2020-08-13 15:07 ` no-reply
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Thomas Huth @ 2020-08-12 15:53 UTC (permalink / raw)
To: qemu-devel, Michael Rolnik, Philippe Mathieu-Daudé
Cc: qemu-trivial, Sarah Harris
The examples look nicer when using "::" code blocks.
Also mention that "-d in_asm" only outputs instructions that have not
been translated by the JIT layer yet.
And while we're at it, also add the AVR doc file to the MAINTAINERS file.
Signed-off-by: Thomas Huth <huth@tuxfamily.org>
---
MAINTAINERS | 1 +
docs/system/target-avr.rst | 47 +++++++++++++++++++++++---------------
2 files changed, 30 insertions(+), 18 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0886eb3d2b..5b21962bc6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -171,6 +171,7 @@ AVR TCG CPUs
M: Michael Rolnik <mrolnik@gmail.com>
R: Sarah Harris <S.E.Harris@kent.ac.uk>
S: Maintained
+F: docs/system/target-avr.rst
F: gdb-xml/avr-cpu.xml
F: target/avr/
F: tests/acceptance/machine_avr6.py
diff --git a/docs/system/target-avr.rst b/docs/system/target-avr.rst
index dc99afc895..1410031f5e 100644
--- a/docs/system/target-avr.rst
+++ b/docs/system/target-avr.rst
@@ -17,21 +17,32 @@ https://github.com/seharris/qemu-avr-tests/blob/master/free-rtos/Demo/AVR_ATMega
Following are examples of possible usages, assuming demo.elf is compiled for
AVR cpu
- - Continuous non interrupted execution:
- ``qemu-system-avr -machine mega2560 -bios demo.elf``
-
- - Continuous non interrupted execution with serial output into telnet window:
- ``qemu-system-avr -machine mega2560 -bios demo.elf -serial
- tcp::5678,server,nowait -nographic``
- and then in another shell
- ``telnet localhost 5678``
-
- - Debugging wit GDB debugger:
- ``qemu-system-avr -machine mega2560 -bios demo.elf -s -S``
- and then in another shell
- ``avr-gdb demo.elf``
- and then within GDB shell
- ``target remote :1234``
-
- - Print out executed instructions:
- ``qemu-system-avr -machine mega2560 -bios demo.elf -d in_asm``
+- Continuous non interrupted execution::
+
+ qemu-system-avr -machine mega2560 -bios demo.elf
+
+- Continuous non interrupted execution with serial output into telnet window::
+
+ qemu-system-avr -M mega2560 -bios demo.elf -nographic \
+ -serial tcp::5678,server,nowait
+
+ and then in another shell::
+
+ telnet localhost 5678
+
+- Debugging wit GDB debugger::
+
+ qemu-system-avr -machine mega2560 -bios demo.elf -s -S
+
+ and then in another shell::
+
+ avr-gdb demo.elf
+
+ and then within GDB shell::
+
+ target remote :1234
+
+- Print out executed instructions (that have not been translated by the JIT
+ compiler yet)::
+
+ qemu-system-avr -machine mega2560 -bios demo.elf -d in_asm
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS
2020-08-12 15:53 [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS Thomas Huth
@ 2020-08-13 15:07 ` no-reply
2020-08-13 16:50 ` Richard Henderson
2020-09-01 9:15 ` Laurent Vivier
2 siblings, 0 replies; 6+ messages in thread
From: no-reply @ 2020-08-13 15:07 UTC (permalink / raw)
To: huth; +Cc: qemu-trivial, S.E.Harris, mrolnik, qemu-devel, f4bug
Patchew URL: https://patchew.org/QEMU/20200812155304.18016-1-huth@tuxfamily.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200812155304.18016-1-huth@tuxfamily.org
Subject: [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
22fbf8b docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS
=== OUTPUT BEGIN ===
ERROR: trailing whitespace
#57: FILE: docs/system/target-avr.rst:27:
+ -serial tcp::5678,server,nowait $
total: 1 errors, 0 warnings, 54 lines checked
Commit 22fbf8be9919 (docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200812155304.18016-1-huth@tuxfamily.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS
2020-08-12 15:53 [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS Thomas Huth
2020-08-13 15:07 ` no-reply
@ 2020-08-13 16:50 ` Richard Henderson
2020-08-13 19:44 ` Michael Rolnik
2020-09-01 9:15 ` Laurent Vivier
2 siblings, 1 reply; 6+ messages in thread
From: Richard Henderson @ 2020-08-13 16:50 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Michael Rolnik, Philippe Mathieu-Daudé
Cc: qemu-trivial, Sarah Harris
On 8/12/20 8:53 AM, Thomas Huth wrote:
> The examples look nicer when using "::" code blocks.
> Also mention that "-d in_asm" only outputs instructions that have not
> been translated by the JIT layer yet.
> And while we're at it, also add the AVR doc file to the MAINTAINERS file.
>
> Signed-off-by: Thomas Huth <huth@tuxfamily.org>
> ---
> MAINTAINERS | 1 +
> docs/system/target-avr.rst | 47 +++++++++++++++++++++++---------------
> 2 files changed, 30 insertions(+), 18 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS
2020-08-13 16:50 ` Richard Henderson
@ 2020-08-13 19:44 ` Michael Rolnik
0 siblings, 0 replies; 6+ messages in thread
From: Michael Rolnik @ 2020-08-13 19:44 UTC (permalink / raw)
To: Richard Henderson
Cc: Thomas Huth, qemu-trivial, Sarah Harris, QEMU Developers,
Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
On Thu, Aug 13, 2020 at 7:50 PM Richard Henderson <
richard.henderson@linaro.org> wrote:
> On 8/12/20 8:53 AM, Thomas Huth wrote:
> > The examples look nicer when using "::" code blocks.
> > Also mention that "-d in_asm" only outputs instructions that have not
> > been translated by the JIT layer yet.
> > And while we're at it, also add the AVR doc file to the MAINTAINERS file.
> >
> > Signed-off-by: Thomas Huth <huth@tuxfamily.org>
> > ---
> > MAINTAINERS | 1 +
> > docs/system/target-avr.rst | 47 +++++++++++++++++++++++---------------
> > 2 files changed, 30 insertions(+), 18 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> r~
>
--
Best Regards,
Michael Rolnik
[-- Attachment #2: Type: text/html, Size: 1437 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS
2020-08-12 15:53 [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS Thomas Huth
2020-08-13 15:07 ` no-reply
2020-08-13 16:50 ` Richard Henderson
@ 2020-09-01 9:15 ` Laurent Vivier
2020-09-01 10:05 ` Thomas Huth
2 siblings, 1 reply; 6+ messages in thread
From: Laurent Vivier @ 2020-09-01 9:15 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Michael Rolnik, Philippe Mathieu-Daudé
Cc: qemu-trivial, Sarah Harris
Le 12/08/2020 à 17:53, Thomas Huth a écrit :
> The examples look nicer when using "::" code blocks.
> Also mention that "-d in_asm" only outputs instructions that have not
> been translated by the JIT layer yet.
> And while we're at it, also add the AVR doc file to the MAINTAINERS file.
>
> Signed-off-by: Thomas Huth <huth@tuxfamily.org>
> ---
> MAINTAINERS | 1 +
> docs/system/target-avr.rst | 47 +++++++++++++++++++++++---------------
> 2 files changed, 30 insertions(+), 18 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0886eb3d2b..5b21962bc6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -171,6 +171,7 @@ AVR TCG CPUs
> M: Michael Rolnik <mrolnik@gmail.com>
> R: Sarah Harris <S.E.Harris@kent.ac.uk>
> S: Maintained
> +F: docs/system/target-avr.rst
> F: gdb-xml/avr-cpu.xml
> F: target/avr/
> F: tests/acceptance/machine_avr6.py
> diff --git a/docs/system/target-avr.rst b/docs/system/target-avr.rst
> index dc99afc895..1410031f5e 100644
> --- a/docs/system/target-avr.rst
> +++ b/docs/system/target-avr.rst
> @@ -17,21 +17,32 @@ https://github.com/seharris/qemu-avr-tests/blob/master/free-rtos/Demo/AVR_ATMega
> Following are examples of possible usages, assuming demo.elf is compiled for
> AVR cpu
>
> - - Continuous non interrupted execution:
> - ``qemu-system-avr -machine mega2560 -bios demo.elf``
> -
> - - Continuous non interrupted execution with serial output into telnet window:
> - ``qemu-system-avr -machine mega2560 -bios demo.elf -serial
> - tcp::5678,server,nowait -nographic``
> - and then in another shell
> - ``telnet localhost 5678``
> -
> - - Debugging wit GDB debugger:
> - ``qemu-system-avr -machine mega2560 -bios demo.elf -s -S``
> - and then in another shell
> - ``avr-gdb demo.elf``
> - and then within GDB shell
> - ``target remote :1234``
> -
> - - Print out executed instructions:
> - ``qemu-system-avr -machine mega2560 -bios demo.elf -d in_asm``
> +- Continuous non interrupted execution::
> +
> + qemu-system-avr -machine mega2560 -bios demo.elf
> +
> +- Continuous non interrupted execution with serial output into telnet window::
> +
> + qemu-system-avr -M mega2560 -bios demo.elf -nographic \
> + -serial tcp::5678,server,nowait
> +
> + and then in another shell::
> +
> + telnet localhost 5678
> +
> +- Debugging wit GDB debugger::
> +
> + qemu-system-avr -machine mega2560 -bios demo.elf -s -S
> +
> + and then in another shell::
> +
> + avr-gdb demo.elf
> +
> + and then within GDB shell::
> +
> + target remote :1234
> +
> +- Print out executed instructions (that have not been translated by the JIT
> + compiler yet)::
> +
> + qemu-system-avr -machine mega2560 -bios demo.elf -d in_asm
>
Applied to my trivial-patches branch.
(I have removed the trailing whitespace)
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS
2020-09-01 9:15 ` Laurent Vivier
@ 2020-09-01 10:05 ` Thomas Huth
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2020-09-01 10:05 UTC (permalink / raw)
To: Laurent Vivier, Thomas Huth, qemu-devel, Michael Rolnik,
Philippe Mathieu-Daudé
Cc: qemu-trivial, Sarah Harris
On 01/09/2020 11.15, Laurent Vivier wrote:
> Le 12/08/2020 à 17:53, Thomas Huth a écrit :
>> The examples look nicer when using "::" code blocks.
>> Also mention that "-d in_asm" only outputs instructions that have not
>> been translated by the JIT layer yet.
>> And while we're at it, also add the AVR doc file to the MAINTAINERS file.
>>
>> Signed-off-by: Thomas Huth <huth@tuxfamily.org>
>> ---
>> MAINTAINERS | 1 +
>> docs/system/target-avr.rst | 47 +++++++++++++++++++++++---------------
>> 2 files changed, 30 insertions(+), 18 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 0886eb3d2b..5b21962bc6 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -171,6 +171,7 @@ AVR TCG CPUs
>> M: Michael Rolnik <mrolnik@gmail.com>
>> R: Sarah Harris <S.E.Harris@kent.ac.uk>
>> S: Maintained
>> +F: docs/system/target-avr.rst
>> F: gdb-xml/avr-cpu.xml
>> F: target/avr/
>> F: tests/acceptance/machine_avr6.py
>> diff --git a/docs/system/target-avr.rst b/docs/system/target-avr.rst
>> index dc99afc895..1410031f5e 100644
>> --- a/docs/system/target-avr.rst
>> +++ b/docs/system/target-avr.rst
>> @@ -17,21 +17,32 @@ https://github.com/seharris/qemu-avr-tests/blob/master/free-rtos/Demo/AVR_ATMega
>> Following are examples of possible usages, assuming demo.elf is compiled for
>> AVR cpu
>>
>> - - Continuous non interrupted execution:
>> - ``qemu-system-avr -machine mega2560 -bios demo.elf``
>> -
>> - - Continuous non interrupted execution with serial output into telnet window:
>> - ``qemu-system-avr -machine mega2560 -bios demo.elf -serial
>> - tcp::5678,server,nowait -nographic``
>> - and then in another shell
>> - ``telnet localhost 5678``
>> -
>> - - Debugging wit GDB debugger:
>> - ``qemu-system-avr -machine mega2560 -bios demo.elf -s -S``
>> - and then in another shell
>> - ``avr-gdb demo.elf``
>> - and then within GDB shell
>> - ``target remote :1234``
>> -
>> - - Print out executed instructions:
>> - ``qemu-system-avr -machine mega2560 -bios demo.elf -d in_asm``
>> +- Continuous non interrupted execution::
>> +
>> + qemu-system-avr -machine mega2560 -bios demo.elf
>> +
>> +- Continuous non interrupted execution with serial output into telnet window::
>> +
>> + qemu-system-avr -M mega2560 -bios demo.elf -nographic \
>> + -serial tcp::5678,server,nowait
>> +
>> + and then in another shell::
>> +
>> + telnet localhost 5678
>> +
>> +- Debugging wit GDB debugger::
>> +
>> + qemu-system-avr -machine mega2560 -bios demo.elf -s -S
>> +
>> + and then in another shell::
>> +
>> + avr-gdb demo.elf
>> +
>> + and then within GDB shell::
>> +
>> + target remote :1234
>> +
>> +- Print out executed instructions (that have not been translated by the JIT
>> + compiler yet)::
>> +
>> + qemu-system-avr -machine mega2560 -bios demo.elf -d in_asm
>>
>
> Applied to my trivial-patches branch.
> (I have removed the trailing whitespace)
Great, thanks! I saw the mail from patchew, but never got around to send
a v2 with the space removed...
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-01 10:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-12 15:53 [PATCH] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS Thomas Huth
2020-08-13 15:07 ` no-reply
2020-08-13 16:50 ` Richard Henderson
2020-08-13 19:44 ` Michael Rolnik
2020-09-01 9:15 ` Laurent Vivier
2020-09-01 10:05 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.