All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/1] acpica: new package
@ 2016-07-03 10:45 Erico Nunes
  2016-07-03 13:45 ` Romain Naour
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Erico Nunes @ 2016-07-03 10:45 UTC (permalink / raw)
  To: buildroot

The ACPI Component Architecture (ACPICA) project provides an operating
system (OS)-independent reference implementation of the Advanced
Configuration and Power Interface Specification (ACPI).

It contains tools such as acpidump, iasl, acpixtract, etc.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Cc: Romain Naour <romain.naour@gmail.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
---

Romain had added a (conditional) Reviewed-by and Tested-by to v1 which I
hope to have solved in this v2, but I decided to not add it here from
the start as this v2 contains some other small fixes and includes a
version bump.
If you think that it is still appliable, please add it before applying
this patch. Thanks

Changes v1 -> v2:
  - Fixed license which is not only GPLv2 but dual BSD-3c or GPLv2
  (pointed out by Romain Naour)
  - Changed TARGET_MAKE_ENV to TARGET_CONFIGURE_OPTS (pointed out by
  Romain Naour). CC still has to be set as a make argument, otherwise it
  gets set back again by the Makefile.
  - TARGET_ARCH was wrong, should have been BR2_ARCH.
  - Got rid of the sed hack for 'uname' by passing HARDWARE_NAME as a
  make argument variable.
  - Fixed installing in architectures different than host, by removing
  the -s argument from 'install' to avoid running 'strip' from host.
  - Bumped up to 20160527 which has been released since patch v1
  submission.
---
 package/Config.in          |  1 +
 package/acpica/Config.in   |  9 +++++++++
 package/acpica/acpica.hash |  2 ++
 package/acpica/acpica.mk   | 26 ++++++++++++++++++++++++++
 4 files changed, 38 insertions(+)
 create mode 100644 package/acpica/Config.in
 create mode 100644 package/acpica/acpica.hash
 create mode 100644 package/acpica/acpica.mk

diff --git a/package/Config.in b/package/Config.in
index 3fddf8e..3c8910d 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -352,6 +352,7 @@ menu "Firmware"
 	source "package/zd1211-firmware/Config.in"
 endmenu
 	source "package/a10disp/Config.in"
+	source "package/acpica/Config.in"
 	source "package/acpid/Config.in"
 	source "package/acpitool/Config.in"
 	source "package/aer-inject/Config.in"
diff --git a/package/acpica/Config.in b/package/acpica/Config.in
new file mode 100644
index 0000000..8c33d0f
--- /dev/null
+++ b/package/acpica/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_ACPICA
+	bool "acpica"
+	help
+	  The ACPI Component Architecture (ACPICA) project provides an
+	  operating system (OS)-independent reference implementation of
+	  the Advanced Configuration and Power Interface Specification
+	  (ACPI).
+
+	  https://www.acpica.org
diff --git a/package/acpica/acpica.hash b/package/acpica/acpica.hash
new file mode 100644
index 0000000..8d5257f
--- /dev/null
+++ b/package/acpica/acpica.hash
@@ -0,0 +1,2 @@
+# locally computed hash
+sha256 4ac73a5887b643dcca483f0241cbb808a53326846928edad9a2f86cffcde5850 acpica-unix2-20160527.tar.gz
diff --git a/package/acpica/acpica.mk b/package/acpica/acpica.mk
new file mode 100644
index 0000000..9b32099
--- /dev/null
+++ b/package/acpica/acpica.mk
@@ -0,0 +1,26 @@
+################################################################################
+#
+# acpica
+#
+################################################################################
+
+ACPICA_VERSION = 20160527
+ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
+ACPICA_SITE = https://acpica.org/sites/acpica/files
+ACPICA_LICENSE = BSD-3c or GPLv2
+ACPICA_LICENSE_FILES = source/include/acpi.h
+ACPICA_DEPENDENCIES = host-bison host-flex
+
+define ACPICA_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \
+		all
+endef
+
+define ACPICA_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
+		INSTALLFLAGS=-m555 install
+endef
+
+$(eval $(generic-package))
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/1] acpica: new package
  2016-07-03 10:45 [Buildroot] [PATCH v2 1/1] acpica: new package Erico Nunes
@ 2016-07-03 13:45 ` Romain Naour
  2016-07-04  7:33   ` Arnout Vandecappelle
  2016-07-04 13:45   ` Erico Nunes
  2016-07-04 13:33 ` Andy Shevchenko
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 10+ messages in thread
From: Romain Naour @ 2016-07-03 13:45 UTC (permalink / raw)
  To: buildroot

Hi Erico,

Le 03/07/2016 ? 12:45, Erico Nunes a ?crit :
> The ACPI Component Architecture (ACPICA) project provides an operating
> system (OS)-independent reference implementation of the Advanced
> Configuration and Power Interface Specification (ACPI).
> 
> It contains tools such as acpidump, iasl, acpixtract, etc.
> 
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> ---
> 
> Romain had added a (conditional) Reviewed-by and Tested-by to v1 which I
> hope to have solved in this v2, but I decided to not add it here from
> the start as this v2 contains some other small fixes and includes a
> version bump.
> If you think that it is still appliable, please add it before applying
> this patch. Thanks

Thanks, I'll review this new version :)

> 
> Changes v1 -> v2:
>   - Fixed license which is not only GPLv2 but dual BSD-3c or GPLv2
>   (pointed out by Romain Naour)
>   - Changed TARGET_MAKE_ENV to TARGET_CONFIGURE_OPTS (pointed out by
>   Romain Naour). CC still has to be set as a make argument, otherwise it
>   gets set back again by the Makefile.
>   - TARGET_ARCH was wrong, should have been BR2_ARCH.
>   - Got rid of the sed hack for 'uname' by passing HARDWARE_NAME as a
>   make argument variable.
>   - Fixed installing in architectures different than host, by removing
>   the -s argument from 'install' to avoid running 'strip' from host.
>   - Bumped up to 20160527 which has been released since patch v1
>   submission.
> ---
>  package/Config.in          |  1 +
>  package/acpica/Config.in   |  9 +++++++++
>  package/acpica/acpica.hash |  2 ++
>  package/acpica/acpica.mk   | 26 ++++++++++++++++++++++++++
>  4 files changed, 38 insertions(+)
>  create mode 100644 package/acpica/Config.in
>  create mode 100644 package/acpica/acpica.hash
>  create mode 100644 package/acpica/acpica.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 3fddf8e..3c8910d 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -352,6 +352,7 @@ menu "Firmware"
>  	source "package/zd1211-firmware/Config.in"
>  endmenu
>  	source "package/a10disp/Config.in"
> +	source "package/acpica/Config.in"
>  	source "package/acpid/Config.in"
>  	source "package/acpitool/Config.in"
>  	source "package/aer-inject/Config.in"
> diff --git a/package/acpica/Config.in b/package/acpica/Config.in
> new file mode 100644
> index 0000000..8c33d0f
> --- /dev/null
> +++ b/package/acpica/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_ACPICA
> +	bool "acpica"
> +	help
> +	  The ACPI Component Architecture (ACPICA) project provides an
> +	  operating system (OS)-independent reference implementation of
> +	  the Advanced Configuration and Power Interface Specification
> +	  (ACPI).
> +
> +	  https://www.acpica.org
> diff --git a/package/acpica/acpica.hash b/package/acpica/acpica.hash
> new file mode 100644
> index 0000000..8d5257f
> --- /dev/null
> +++ b/package/acpica/acpica.hash
> @@ -0,0 +1,2 @@
> +# locally computed hash
> +sha256 4ac73a5887b643dcca483f0241cbb808a53326846928edad9a2f86cffcde5850 acpica-unix2-20160527.tar.gz
> diff --git a/package/acpica/acpica.mk b/package/acpica/acpica.mk
> new file mode 100644
> index 0000000..9b32099
> --- /dev/null
> +++ b/package/acpica/acpica.mk
> @@ -0,0 +1,26 @@
> +################################################################################
> +#
> +# acpica
> +#
> +################################################################################
> +
> +ACPICA_VERSION = 20160527
> +ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
> +ACPICA_SITE = https://acpica.org/sites/acpica/files
> +ACPICA_LICENSE = BSD-3c or GPLv2
> +ACPICA_LICENSE_FILES = source/include/acpi.h
> +ACPICA_DEPENDENCIES = host-bison host-flex
> +
> +define ACPICA_BUILD_CMDS
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \

Thanks to TARGET_CONFIGURE_OPTS, CC="$(TARGET_CC) should be removed...
But indeed if we do that it will use host compiler.

To fix that we need to patch generate/unix/Makefile.config
-CC =    gcc
+CC ?=    gcc

Can you try with that ?

Thanks,

Best regards,
Romain

> +		all
> +endef
> +
> +define ACPICA_INSTALL_TARGET_CMDS
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
> +		INSTALLFLAGS=-m555 install
> +endef
> +
> +$(eval $(generic-package))
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/1] acpica: new package
  2016-07-03 13:45 ` Romain Naour
@ 2016-07-04  7:33   ` Arnout Vandecappelle
  2016-07-04 13:45   ` Erico Nunes
  1 sibling, 0 replies; 10+ messages in thread
From: Arnout Vandecappelle @ 2016-07-04  7:33 UTC (permalink / raw)
  To: buildroot

On 03-07-16 15:45, Romain Naour wrote:
> Hi Erico,
> 
> Le 03/07/2016 ? 12:45, Erico Nunes a ?crit :
>> The ACPI Component Architecture (ACPICA) project provides an operating
>> system (OS)-independent reference implementation of the Advanced
>> Configuration and Power Interface Specification (ACPI).
>>
>> It contains tools such as acpidump, iasl, acpixtract, etc.
>>
>> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
>> Cc: Romain Naour <romain.naour@gmail.com>
>> Cc: Peter Korsgaard <peter@korsgaard.com>
>> ---
>>
>> Romain had added a (conditional) Reviewed-by and Tested-by to v1 which I
>> hope to have solved in this v2, but I decided to not add it here from
>> the start as this v2 contains some other small fixes and includes a
>> version bump.
>> If you think that it is still appliable, please add it before applying
>> this patch. Thanks
> 
> Thanks, I'll review this new version :)
> 
>>
>> Changes v1 -> v2:
>>   - Fixed license which is not only GPLv2 but dual BSD-3c or GPLv2
>>   (pointed out by Romain Naour)
>>   - Changed TARGET_MAKE_ENV to TARGET_CONFIGURE_OPTS (pointed out by
>>   Romain Naour). CC still has to be set as a make argument, otherwise it
>>   gets set back again by the Makefile.
>>   - TARGET_ARCH was wrong, should have been BR2_ARCH.
>>   - Got rid of the sed hack for 'uname' by passing HARDWARE_NAME as a
>>   make argument variable.
>>   - Fixed installing in architectures different than host, by removing
>>   the -s argument from 'install' to avoid running 'strip' from host.
>>   - Bumped up to 20160527 which has been released since patch v1
>>   submission.
>> ---
>>  package/Config.in          |  1 +
>>  package/acpica/Config.in   |  9 +++++++++
>>  package/acpica/acpica.hash |  2 ++
>>  package/acpica/acpica.mk   | 26 ++++++++++++++++++++++++++
>>  4 files changed, 38 insertions(+)
>>  create mode 100644 package/acpica/Config.in
>>  create mode 100644 package/acpica/acpica.hash
>>  create mode 100644 package/acpica/acpica.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 3fddf8e..3c8910d 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -352,6 +352,7 @@ menu "Firmware"
>>  	source "package/zd1211-firmware/Config.in"
>>  endmenu
>>  	source "package/a10disp/Config.in"
>> +	source "package/acpica/Config.in"
>>  	source "package/acpid/Config.in"
>>  	source "package/acpitool/Config.in"
>>  	source "package/aer-inject/Config.in"
>> diff --git a/package/acpica/Config.in b/package/acpica/Config.in
>> new file mode 100644
>> index 0000000..8c33d0f
>> --- /dev/null
>> +++ b/package/acpica/Config.in
>> @@ -0,0 +1,9 @@
>> +config BR2_PACKAGE_ACPICA
>> +	bool "acpica"
>> +	help
>> +	  The ACPI Component Architecture (ACPICA) project provides an
>> +	  operating system (OS)-independent reference implementation of
>> +	  the Advanced Configuration and Power Interface Specification
>> +	  (ACPI).
>> +
>> +	  https://www.acpica.org
>> diff --git a/package/acpica/acpica.hash b/package/acpica/acpica.hash
>> new file mode 100644
>> index 0000000..8d5257f
>> --- /dev/null
>> +++ b/package/acpica/acpica.hash
>> @@ -0,0 +1,2 @@
>> +# locally computed hash
>> +sha256 4ac73a5887b643dcca483f0241cbb808a53326846928edad9a2f86cffcde5850 acpica-unix2-20160527.tar.gz
>> diff --git a/package/acpica/acpica.mk b/package/acpica/acpica.mk
>> new file mode 100644
>> index 0000000..9b32099
>> --- /dev/null
>> +++ b/package/acpica/acpica.mk
>> @@ -0,0 +1,26 @@
>> +################################################################################
>> +#
>> +# acpica
>> +#
>> +################################################################################
>> +
>> +ACPICA_VERSION = 20160527
>> +ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
>> +ACPICA_SITE = https://acpica.org/sites/acpica/files
>> +ACPICA_LICENSE = BSD-3c or GPLv2
>> +ACPICA_LICENSE_FILES = source/include/acpi.h
>> +ACPICA_DEPENDENCIES = host-bison host-flex
>> +
>> +define ACPICA_BUILD_CMDS
>> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>> +		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \
> 
> Thanks to TARGET_CONFIGURE_OPTS, CC="$(TARGET_CC) should be removed...
> But indeed if we do that it will use host compiler.
> 
> To fix that we need to patch generate/unix/Makefile.config
> -CC =    gcc
> +CC ?=    gcc
> 
> Can you try with that ?

 Personally, I prefer what is there now: explicitly override CC on the command
line rather than patching the package. I hate patching the package :-)

 Regards,
 Arnout

> 
> Thanks,
> 
> Best regards,
> Romain
> 
>> +		all
>> +endef
>> +
>> +define ACPICA_INSTALL_TARGET_CMDS
>> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>> +		HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
>> +		INSTALLFLAGS=-m555 install
>> +endef
>> +
>> +$(eval $(generic-package))
>>
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/1] acpica: new package
  2016-07-03 10:45 [Buildroot] [PATCH v2 1/1] acpica: new package Erico Nunes
  2016-07-03 13:45 ` Romain Naour
@ 2016-07-04 13:33 ` Andy Shevchenko
  2016-07-04 13:41   ` Erico Nunes
  2016-07-05  8:16 ` Thomas Petazzoni
  2016-07-05 17:15 ` Thomas Petazzoni
  3 siblings, 1 reply; 10+ messages in thread
From: Andy Shevchenko @ 2016-07-04 13:33 UTC (permalink / raw)
  To: buildroot

On Sun, 2016-07-03 at 12:45 +0200, Erico Nunes wrote:
> The ACPI Component Architecture (ACPICA) project provides an operating
> system (OS)-independent reference implementation of the Advanced
> Configuration and Power Interface Specification (ACPI).
> 
> It contains tools such as acpidump, iasl, acpixtract, etc.

Thank you for doing this!
Though in our case we need this as a host tool. Can you add support into
next version of the patch?

> 
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> ---
> 
> Romain had added a (conditional) Reviewed-by and Tested-by to v1 which
> I
> hope to have solved in this v2, but I decided to not add it here from
> the start as this v2 contains some other small fixes and includes a
> version bump.
> If you think that it is still appliable, please add it before applying
> this patch. Thanks
> 
> Changes v1 -> v2:
> ? - Fixed license which is not only GPLv2 but dual BSD-3c or GPLv2
> ? (pointed out by Romain Naour)
> ? - Changed TARGET_MAKE_ENV to TARGET_CONFIGURE_OPTS (pointed out by
> ? Romain Naour). CC still has to be set as a make argument, otherwise
> it
> ? gets set back again by the Makefile.
> ? - TARGET_ARCH was wrong, should have been BR2_ARCH.
> ? - Got rid of the sed hack for 'uname' by passing HARDWARE_NAME as a
> ? make argument variable.
> ? - Fixed installing in architectures different than host, by removing
> ? the -s argument from 'install' to avoid running 'strip' from host.
> ? - Bumped up to 20160527 which has been released since patch v1
> ? submission.
> ---
> ?package/Config.in??????????|??1 +
> ?package/acpica/Config.in???|??9 +++++++++
> ?package/acpica/acpica.hash |??2 ++
> ?package/acpica/acpica.mk???| 26 ++++++++++++++++++++++++++
> ?4 files changed, 38 insertions(+)
> ?create mode 100644 package/acpica/Config.in
> ?create mode 100644 package/acpica/acpica.hash
> ?create mode 100644 package/acpica/acpica.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 3fddf8e..3c8910d 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -352,6 +352,7 @@ menu "Firmware"
> ?	source "package/zd1211-firmware/Config.in"
> ?endmenu
> ?	source "package/a10disp/Config.in"
> +	source "package/acpica/Config.in"
> ?	source "package/acpid/Config.in"
> ?	source "package/acpitool/Config.in"
> ?	source "package/aer-inject/Config.in"
> diff --git a/package/acpica/Config.in b/package/acpica/Config.in
> new file mode 100644
> index 0000000..8c33d0f
> --- /dev/null
> +++ b/package/acpica/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_ACPICA
> +	bool "acpica"
> +	help
> +	??The ACPI Component Architecture (ACPICA) project provides
> an
> +	??operating system (OS)-independent reference implementation
> of
> +	??the Advanced Configuration and Power Interface
> Specification
> +	??(ACPI).
> +
> +	??https://www.acpica.org
> diff --git a/package/acpica/acpica.hash b/package/acpica/acpica.hash
> new file mode 100644
> index 0000000..8d5257f
> --- /dev/null
> +++ b/package/acpica/acpica.hash
> @@ -0,0 +1,2 @@
> +# locally computed hash
> +sha256
> 4ac73a5887b643dcca483f0241cbb808a53326846928edad9a2f86cffcde5850
> acpica-unix2-20160527.tar.gz
> diff --git a/package/acpica/acpica.mk b/package/acpica/acpica.mk
> new file mode 100644
> index 0000000..9b32099
> --- /dev/null
> +++ b/package/acpica/acpica.mk
> @@ -0,0 +1,26 @@
> +#####################################################################
> ###########
> +#
> +# acpica
> +#
> +#####################################################################
> ###########
> +
> +ACPICA_VERSION = 20160527
> +ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
> +ACPICA_SITE = https://acpica.org/sites/acpica/files
> +ACPICA_LICENSE = BSD-3c or GPLv2
> +ACPICA_LICENSE_FILES = source/include/acpi.h
> +ACPICA_DEPENDENCIES = host-bison host-flex
> +
> +define ACPICA_BUILD_CMDS
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX
> CC="$(TARGET_CC)" \
> +		all
> +endef
> +
> +define ACPICA_INSTALL_TARGET_CMDS
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
> +		INSTALLFLAGS=-m555 install
> +endef
> +
> +$(eval $(generic-package))

-- 

Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/1] acpica: new package
  2016-07-04 13:33 ` Andy Shevchenko
@ 2016-07-04 13:41   ` Erico Nunes
  0 siblings, 0 replies; 10+ messages in thread
From: Erico Nunes @ 2016-07-04 13:41 UTC (permalink / raw)
  To: buildroot

On Mon, Jul 4, 2016 at 3:33 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Sun, 2016-07-03 at 12:45 +0200, Erico Nunes wrote:
>> The ACPI Component Architecture (ACPICA) project provides an operating
>> system (OS)-independent reference implementation of the Advanced
>> Configuration and Power Interface Specification (ACPI).
>>
>> It contains tools such as acpidump, iasl, acpixtract, etc.
>
> Thank you for doing this!
> Though in our case we need this as a host tool. Can you add support into
> next version of the patch?
>
>>
>> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
>> Cc: Romain Naour <romain.naour@gmail.com>
>> Cc: Peter Korsgaard <peter@korsgaard.com>
>> ---
>>
>> Romain had added a (conditional) Reviewed-by and Tested-by to v1 which
>> I
>> hope to have solved in this v2, but I decided to not add it here from
>> the start as this v2 contains some other small fixes and includes a
>> version bump.
>> If you think that it is still appliable, please add it before applying
>> this patch. Thanks
>>
>> Changes v1 -> v2:
>>   - Fixed license which is not only GPLv2 but dual BSD-3c or GPLv2
>>   (pointed out by Romain Naour)
>>   - Changed TARGET_MAKE_ENV to TARGET_CONFIGURE_OPTS (pointed out by
>>   Romain Naour). CC still has to be set as a make argument, otherwise
>> it
>>   gets set back again by the Makefile.
>>   - TARGET_ARCH was wrong, should have been BR2_ARCH.
>>   - Got rid of the sed hack for 'uname' by passing HARDWARE_NAME as a
>>   make argument variable.
>>   - Fixed installing in architectures different than host, by removing
>>   the -s argument from 'install' to avoid running 'strip' from host.
>>   - Bumped up to 20160527 which has been released since patch v1
>>   submission.
>> ---
>>  package/Config.in          |  1 +
>>  package/acpica/Config.in   |  9 +++++++++
>>  package/acpica/acpica.hash |  2 ++
>>  package/acpica/acpica.mk   | 26 ++++++++++++++++++++++++++
>>  4 files changed, 38 insertions(+)
>>  create mode 100644 package/acpica/Config.in
>>  create mode 100644 package/acpica/acpica.hash
>>  create mode 100644 package/acpica/acpica.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 3fddf8e..3c8910d 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -352,6 +352,7 @@ menu "Firmware"
>>       source "package/zd1211-firmware/Config.in"
>>  endmenu
>>       source "package/a10disp/Config.in"
>> +     source "package/acpica/Config.in"
>>       source "package/acpid/Config.in"
>>       source "package/acpitool/Config.in"
>>       source "package/aer-inject/Config.in"
>> diff --git a/package/acpica/Config.in b/package/acpica/Config.in
>> new file mode 100644
>> index 0000000..8c33d0f
>> --- /dev/null
>> +++ b/package/acpica/Config.in
>> @@ -0,0 +1,9 @@
>> +config BR2_PACKAGE_ACPICA
>> +     bool "acpica"
>> +     help
>> +       The ACPI Component Architecture (ACPICA) project provides
>> an
>> +       operating system (OS)-independent reference implementation
>> of
>> +       the Advanced Configuration and Power Interface
>> Specification
>> +       (ACPI).
>> +
>> +       https://www.acpica.org
>> diff --git a/package/acpica/acpica.hash b/package/acpica/acpica.hash
>> new file mode 100644
>> index 0000000..8d5257f
>> --- /dev/null
>> +++ b/package/acpica/acpica.hash
>> @@ -0,0 +1,2 @@
>> +# locally computed hash
>> +sha256
>> 4ac73a5887b643dcca483f0241cbb808a53326846928edad9a2f86cffcde5850
>> acpica-unix2-20160527.tar.gz
>> diff --git a/package/acpica/acpica.mk b/package/acpica/acpica.mk
>> new file mode 100644
>> index 0000000..9b32099
>> --- /dev/null
>> +++ b/package/acpica/acpica.mk
>> @@ -0,0 +1,26 @@
>> +#####################################################################
>> ###########
>> +#
>> +# acpica
>> +#
>> +#####################################################################
>> ###########
>> +
>> +ACPICA_VERSION = 20160527
>> +ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
>> +ACPICA_SITE = https://acpica.org/sites/acpica/files
>> +ACPICA_LICENSE = BSD-3c or GPLv2
>> +ACPICA_LICENSE_FILES = source/include/acpi.h
>> +ACPICA_DEPENDENCIES = host-bison host-flex
>> +
>> +define ACPICA_BUILD_CMDS
>> +     $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>> +             HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX
>> CC="$(TARGET_CC)" \
>> +             all
>> +endef
>> +
>> +define ACPICA_INSTALL_TARGET_CMDS
>> +     $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>> +             HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
>> +             INSTALLFLAGS=-m555 install
>> +endef
>> +
>> +$(eval $(generic-package))
>
> --
>
> Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Intel Finland Oy

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/1] acpica: new package
  2016-07-03 13:45 ` Romain Naour
  2016-07-04  7:33   ` Arnout Vandecappelle
@ 2016-07-04 13:45   ` Erico Nunes
  2016-07-04 13:52     ` Romain Naour
  2016-07-04 14:04     ` Andy Shevchenko
  1 sibling, 2 replies; 10+ messages in thread
From: Erico Nunes @ 2016-07-04 13:45 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, Jul 3, 2016 at 3:45 PM, Romain Naour <romain.naour@gmail.com> wrote:
> Thanks to TARGET_CONFIGURE_OPTS, CC="$(TARGET_CC) should be removed...
> But indeed if we do that it will use host compiler.
>
> To fix that we need to patch generate/unix/Makefile.config
> -CC =    gcc
> +CC ?=    gcc

Thanks for re-reviewing!
Yes indeed as the package resets CC in the Makefile, setting it in the
environment via TARGET_CONFIGURE_OPTS won't be enough (I tried to
explain that in the changelog after the commit message).
In my opinion (agreeing with Arnout), in this case it is less bloaty
to just pass it again in the arguments, rather than patching the
package.

On Mon, Jul 4, 2016 at 3:33 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Sun, 2016-07-03 at 12:45 +0200, Erico Nunes wrote:
>> The ACPI Component Architecture (ACPICA) project provides an operating
>> system (OS)-independent reference implementation of the Advanced
>> Configuration and Power Interface Specification (ACPI).
>>
>> It contains tools such as acpidump, iasl, acpixtract, etc.
>
> Thank you for doing this!
> Though in our case we need this as a host tool. Can you add support into
> next version of the patch?

Hi Andy.

Thank you for the feedback!
I think, though, that we would need to have some other target
Buildroot target package depending on a host version of this one, in
order to have it accepted with a host version. Otherwise it is an
orphan host package. Or do we have a strong reason to have it enabled
as a host package of its own (maybe adding a Config.in.host in this
case)?

Erico

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/1] acpica: new package
  2016-07-04 13:45   ` Erico Nunes
@ 2016-07-04 13:52     ` Romain Naour
  2016-07-04 14:04     ` Andy Shevchenko
  1 sibling, 0 replies; 10+ messages in thread
From: Romain Naour @ 2016-07-04 13:52 UTC (permalink / raw)
  To: buildroot

Hi Erico,

Le 04/07/2016 ? 15:45, Erico Nunes a ?crit :
> Hello,
> 
> On Sun, Jul 3, 2016 at 3:45 PM, Romain Naour <romain.naour@gmail.com> wrote:
>> Thanks to TARGET_CONFIGURE_OPTS, CC="$(TARGET_CC) should be removed...
>> But indeed if we do that it will use host compiler.
>>
>> To fix that we need to patch generate/unix/Makefile.config
>> -CC =    gcc
>> +CC ?=    gcc
> 
> Thanks for re-reviewing!
> Yes indeed as the package resets CC in the Makefile, setting it in the
> environment via TARGET_CONFIGURE_OPTS won't be enough (I tried to
> explain that in the changelog after the commit message).
> In my opinion (agreeing with Arnout), in this case it is less bloaty
> to just pass it again in the arguments, rather than patching the
> package.

Ok, I haven't a strong opinion on this, you can keep it as is :)

Reviewed-by: Romain Naour <romain.naour@gmail.com>

Best regards,
Romain

> 
> On Mon, Jul 4, 2016 at 3:33 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>> On Sun, 2016-07-03 at 12:45 +0200, Erico Nunes wrote:
>>> The ACPI Component Architecture (ACPICA) project provides an operating
>>> system (OS)-independent reference implementation of the Advanced
>>> Configuration and Power Interface Specification (ACPI).
>>>
>>> It contains tools such as acpidump, iasl, acpixtract, etc.
>>
>> Thank you for doing this!
>> Though in our case we need this as a host tool. Can you add support into
>> next version of the patch?
> 
> Hi Andy.
> 
> Thank you for the feedback!
> I think, though, that we would need to have some other target
> Buildroot target package depending on a host version of this one, in
> order to have it accepted with a host version. Otherwise it is an
> orphan host package. Or do we have a strong reason to have it enabled
> as a host package of its own (maybe adding a Config.in.host in this
> case)?
> 
> Erico
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/1] acpica: new package
  2016-07-04 13:45   ` Erico Nunes
  2016-07-04 13:52     ` Romain Naour
@ 2016-07-04 14:04     ` Andy Shevchenko
  1 sibling, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2016-07-04 14:04 UTC (permalink / raw)
  To: buildroot

On Mon, 2016-07-04 at 15:45 +0200, Erico Nunes wrote:
> Hello,
>?
> It contains tools such as acpidump, iasl, acpixtract, etc.
> > 
> > Thank you for doing this!
> > Though in our case we need this as a host tool. Can you add support
> > into
> > next version of the patch?
> 
> Hi Andy.
> 
> Thank you for the feedback!
> I think, though, that we would need to have some other target
> Buildroot target package depending on a host version of this one, in
> order to have it accepted with a host version. Otherwise it is an
> orphan host package. Or do we have a strong reason to have it enabled
> as a host package of its own (maybe adding a Config.in.host in this
> case)?
>?

We would like to add our ASL excerpts to initrd image which requires at
least iasl to be present on host side. We are developing the way how to
provide ASL excerpts for open connected boards such as Intel Galileo or
Minnowboard MAX.

-- 

Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/1] acpica: new package
  2016-07-03 10:45 [Buildroot] [PATCH v2 1/1] acpica: new package Erico Nunes
  2016-07-03 13:45 ` Romain Naour
  2016-07-04 13:33 ` Andy Shevchenko
@ 2016-07-05  8:16 ` Thomas Petazzoni
  2016-07-05 17:15 ` Thomas Petazzoni
  3 siblings, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2016-07-05  8:16 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun,  3 Jul 2016 12:45:35 +0200, Erico Nunes wrote:

> +ACPICA_VERSION = 20160527
> +ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
> +ACPICA_SITE = https://acpica.org/sites/acpica/files
> +ACPICA_LICENSE = BSD-3c or GPLv2
> +ACPICA_LICENSE_FILES = source/include/acpi.h
> +ACPICA_DEPENDENCIES = host-bison host-flex
> +
> +define ACPICA_BUILD_CMDS
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \

The HARDWARE_NAME variable is pretty useless, it's only used to echo
some messages. But I've kept it since it's used, and sent a patch
upstream to get rid of it (https://github.com/acpica/acpica/pull/152).

> +define ACPICA_INSTALL_TARGET_CMDS
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
> +		INSTALLFLAGS=-m555 install

555 is a bit unusual for binaries, we prefer to use 755. I've changed
it and applied your patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/1] acpica: new package
  2016-07-03 10:45 [Buildroot] [PATCH v2 1/1] acpica: new package Erico Nunes
                   ` (2 preceding siblings ...)
  2016-07-05  8:16 ` Thomas Petazzoni
@ 2016-07-05 17:15 ` Thomas Petazzoni
  3 siblings, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2016-07-05 17:15 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun,  3 Jul 2016 12:45:35 +0200, Erico Nunes wrote:
> The ACPI Component Architecture (ACPICA) project provides an operating
> system (OS)-independent reference implementation of the Advanced
> Configuration and Power Interface Specification (ACPI).
> 
> It contains tools such as acpidump, iasl, acpixtract, etc.
> 
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> ---

This package fails to build on MIPS64:

   http://autobuild.buildroot.net/results/d7a/d7adbd07c5e74f0305ac03fab615290dfa20e9b5/build-end.log

Could you have a look ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-07-05 17:15 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-03 10:45 [Buildroot] [PATCH v2 1/1] acpica: new package Erico Nunes
2016-07-03 13:45 ` Romain Naour
2016-07-04  7:33   ` Arnout Vandecappelle
2016-07-04 13:45   ` Erico Nunes
2016-07-04 13:52     ` Romain Naour
2016-07-04 14:04     ` Andy Shevchenko
2016-07-04 13:33 ` Andy Shevchenko
2016-07-04 13:41   ` Erico Nunes
2016-07-05  8:16 ` Thomas Petazzoni
2016-07-05 17:15 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.