All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ARM: dts: exynos4: fix pwm-cells in pwm node
@ 2014-06-19  2:03 ` Jaewon Kim
  0 siblings, 0 replies; 6+ messages in thread
From: Jaewon Kim @ 2014-06-19  2:03 UTC (permalink / raw)
  To: Ben Dooks, Kukjin Kim, linux-arm-kernel, linux-samsung-soc
  Cc: Tomasz Figa, Chanwoo Choi, MyungJoo Ham, Sachin Kamat, Jaewon Kim

pwm-cells should be 3. Third cell is optional PWM flags. And This flag
supported by this binding is PWM_POLARITY_INVERTED.

Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---

Changes in v2:
 - Remove unnecessary handle.

 arch/arm/boot/dts/exynos4.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index b8ece4b..e118356 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -554,7 +554,7 @@
 		interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
 		clocks = <&clock CLK_PWM>;
 		clock-names = "timers";
-		#pwm-cells = <2>;
+		#pwm-cells = <3>;
 		status = "disabled";
 	};
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2] ARM: dts: exynos4: fix pwm-cells in pwm node
@ 2014-06-19  2:03 ` Jaewon Kim
  0 siblings, 0 replies; 6+ messages in thread
From: Jaewon Kim @ 2014-06-19  2:03 UTC (permalink / raw)
  To: linux-arm-kernel

pwm-cells should be 3. Third cell is optional PWM flags. And This flag
supported by this binding is PWM_POLARITY_INVERTED.

Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---

Changes in v2:
 - Remove unnecessary handle.

 arch/arm/boot/dts/exynos4.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index b8ece4b..e118356 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -554,7 +554,7 @@
 		interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
 		clocks = <&clock CLK_PWM>;
 		clock-names = "timers";
-		#pwm-cells = <2>;
+		#pwm-cells = <3>;
 		status = "disabled";
 	};
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] ARM: dts: exynos4: fix pwm-cells in pwm node
  2014-06-19  2:03 ` Jaewon Kim
@ 2014-06-19  6:07   ` Sachin Kamat
  -1 siblings, 0 replies; 6+ messages in thread
From: Sachin Kamat @ 2014-06-19  6:07 UTC (permalink / raw)
  To: Jaewon Kim
  Cc: Ben Dooks, Kukjin Kim, linux-arm-kernel, linux-samsung-soc,
	Tomasz Figa, Chanwoo Choi, MyungJoo Ham

Hi Jaewon,

On Thu, Jun 19, 2014 at 7:33 AM, Jaewon Kim <jaewon02.kim@samsung.com> wrote:
> pwm-cells should be 3. Third cell is optional PWM flags. And This flag
> supported by this binding is PWM_POLARITY_INVERTED.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
>
> Changes in v2:
>  - Remove unnecessary handle.
>
>  arch/arm/boot/dts/exynos4.dtsi |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index b8ece4b..e118356 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -554,7 +554,7 @@
>                 interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
>                 clocks = <&clock CLK_PWM>;
>                 clock-names = "timers";
> -               #pwm-cells = <2>;
> +               #pwm-cells = <3>;
>                 status = "disabled";
>         };

I think I had already reviewed this patch. Anyway,
Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] ARM: dts: exynos4: fix pwm-cells in pwm node
@ 2014-06-19  6:07   ` Sachin Kamat
  0 siblings, 0 replies; 6+ messages in thread
From: Sachin Kamat @ 2014-06-19  6:07 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Jaewon,

On Thu, Jun 19, 2014 at 7:33 AM, Jaewon Kim <jaewon02.kim@samsung.com> wrote:
> pwm-cells should be 3. Third cell is optional PWM flags. And This flag
> supported by this binding is PWM_POLARITY_INVERTED.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
>
> Changes in v2:
>  - Remove unnecessary handle.
>
>  arch/arm/boot/dts/exynos4.dtsi |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index b8ece4b..e118356 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -554,7 +554,7 @@
>                 interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
>                 clocks = <&clock CLK_PWM>;
>                 clock-names = "timers";
> -               #pwm-cells = <2>;
> +               #pwm-cells = <3>;
>                 status = "disabled";
>         };

I think I had already reviewed this patch. Anyway,
Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH v2] ARM: dts: exynos4: fix pwm-cells in pwm node
  2014-06-19  6:07   ` Sachin Kamat
@ 2014-06-23  0:48     ` Kukjin Kim
  -1 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2014-06-23  0:48 UTC (permalink / raw)
  To: 'Sachin Kamat', 'Jaewon Kim'
  Cc: 'Ben Dooks',
	linux-arm-kernel, 'linux-samsung-soc',
	'Tomasz Figa', 'Chanwoo Choi',
	'MyungJoo Ham'

Sachin Kamat wrote:
> 
> Hi Jaewon,
> 
> On Thu, Jun 19, 2014 at 7:33 AM, Jaewon Kim <jaewon02.kim@samsung.com> wrote:
> > pwm-cells should be 3. Third cell is optional PWM flags. And This flag
> > supported by this binding is PWM_POLARITY_INVERTED.
> >
> > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> > ---
> >
> > Changes in v2:
> >  - Remove unnecessary handle.
> >
> >  arch/arm/boot/dts/exynos4.dtsi |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> > index b8ece4b..e118356 100644
> > --- a/arch/arm/boot/dts/exynos4.dtsi
> > +++ b/arch/arm/boot/dts/exynos4.dtsi
> > @@ -554,7 +554,7 @@
> >                 interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
> >                 clocks = <&clock CLK_PWM>;
> >                 clock-names = "timers";
> > -               #pwm-cells = <2>;
> > +               #pwm-cells = <3>;
> >                 status = "disabled";
> >         };
> 
> I think I had already reviewed this patch. Anyway,
> Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com>

Applied, thanks.

- Kukjin

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] ARM: dts: exynos4: fix pwm-cells in pwm node
@ 2014-06-23  0:48     ` Kukjin Kim
  0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2014-06-23  0:48 UTC (permalink / raw)
  To: linux-arm-kernel

Sachin Kamat wrote:
> 
> Hi Jaewon,
> 
> On Thu, Jun 19, 2014 at 7:33 AM, Jaewon Kim <jaewon02.kim@samsung.com> wrote:
> > pwm-cells should be 3. Third cell is optional PWM flags. And This flag
> > supported by this binding is PWM_POLARITY_INVERTED.
> >
> > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> > ---
> >
> > Changes in v2:
> >  - Remove unnecessary handle.
> >
> >  arch/arm/boot/dts/exynos4.dtsi |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> > index b8ece4b..e118356 100644
> > --- a/arch/arm/boot/dts/exynos4.dtsi
> > +++ b/arch/arm/boot/dts/exynos4.dtsi
> > @@ -554,7 +554,7 @@
> >                 interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
> >                 clocks = <&clock CLK_PWM>;
> >                 clock-names = "timers";
> > -               #pwm-cells = <2>;
> > +               #pwm-cells = <3>;
> >                 status = "disabled";
> >         };
> 
> I think I had already reviewed this patch. Anyway,
> Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com>

Applied, thanks.

- Kukjin

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-06-23  0:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-19  2:03 [PATCH v2] ARM: dts: exynos4: fix pwm-cells in pwm node Jaewon Kim
2014-06-19  2:03 ` Jaewon Kim
2014-06-19  6:07 ` Sachin Kamat
2014-06-19  6:07   ` Sachin Kamat
2014-06-23  0:48   ` Kukjin Kim
2014-06-23  0:48     ` Kukjin Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.