* [PATCH v2] leds-lp5521/3: use '%zu' for formatting 'size_t'
@ 2013-01-23 23:43 Kim, Milo
2013-01-23 23:46 ` Bryan Wu
0 siblings, 1 reply; 2+ messages in thread
From: Kim, Milo @ 2013-01-23 23:43 UTC (permalink / raw)
To: Bryan Wu; +Cc: Nathan Lynch, linux-leds, linux-kernel
The printk format of type 'size_t' is not '%d' but '%zu' or '%zx'.
This patch fixes build warnings below.
drivers/leds/leds-lp5521.c: In function lp5521_firmware_loaded:
drivers/leds/leds-lp5521.c:257:4: warning: format %d expects argument of
type int, but argument 3 has type size_t [-Wformat]
drivers/leds/leds-lp5523.c: In function lp5523_firmware_loaded:
drivers/leds/leds-lp5523.c:283:4: warning: format %d expects argument of
type int, but argument 3 has type size_t [-Wformat]
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
drivers/leds/leds-lp5521.c | 2 +-
drivers/leds/leds-lp5523.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
index 80adfb4..1001347 100644
--- a/drivers/leds/leds-lp5521.c
+++ b/drivers/leds/leds-lp5521.c
@@ -253,7 +253,7 @@ static void lp5521_firmware_loaded(struct lp55xx_chip *chip)
const struct firmware *fw = chip->fw;
if (fw->size > LP5521_PROGRAM_LENGTH) {
- dev_err(&chip->cl->dev, "firmware data size overflow: %d\n",
+ dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
fw->size);
return;
}
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index 4ac7061..229f734 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -279,7 +279,7 @@ static void lp5523_firmware_loaded(struct lp55xx_chip *chip)
const struct firmware *fw = chip->fw;
if (fw->size > LP5523_PROGRAM_LENGTH) {
- dev_err(&chip->cl->dev, "firmware data size overflow: %d\n",
+ dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
fw->size);
return;
}
--
1.7.9.5
Best Regards,
Milo
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] leds-lp5521/3: use '%zu' for formatting 'size_t'
2013-01-23 23:43 [PATCH v2] leds-lp5521/3: use '%zu' for formatting 'size_t' Kim, Milo
@ 2013-01-23 23:46 ` Bryan Wu
0 siblings, 0 replies; 2+ messages in thread
From: Bryan Wu @ 2013-01-23 23:46 UTC (permalink / raw)
To: Kim, Milo; +Cc: Nathan Lynch, linux-leds, linux-kernel
On Wed, Jan 23, 2013 at 3:43 PM, Kim, Milo <Milo.Kim@ti.com> wrote:
> The printk format of type 'size_t' is not '%d' but '%zu' or '%zx'.
> This patch fixes build warnings below.
>
> drivers/leds/leds-lp5521.c: In function lp5521_firmware_loaded:
> drivers/leds/leds-lp5521.c:257:4: warning: format %d expects argument of
> type int, but argument 3 has type size_t [-Wformat]
>
> drivers/leds/leds-lp5523.c: In function lp5523_firmware_loaded:
> drivers/leds/leds-lp5523.c:283:4: warning: format %d expects argument of
> type int, but argument 3 has type size_t [-Wformat]
>
OK, applied.
Thanks,
-Bryan
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
> drivers/leds/leds-lp5521.c | 2 +-
> drivers/leds/leds-lp5523.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
> index 80adfb4..1001347 100644
> --- a/drivers/leds/leds-lp5521.c
> +++ b/drivers/leds/leds-lp5521.c
> @@ -253,7 +253,7 @@ static void lp5521_firmware_loaded(struct lp55xx_chip *chip)
> const struct firmware *fw = chip->fw;
>
> if (fw->size > LP5521_PROGRAM_LENGTH) {
> - dev_err(&chip->cl->dev, "firmware data size overflow: %d\n",
> + dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
> fw->size);
> return;
> }
> diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
> index 4ac7061..229f734 100644
> --- a/drivers/leds/leds-lp5523.c
> +++ b/drivers/leds/leds-lp5523.c
> @@ -279,7 +279,7 @@ static void lp5523_firmware_loaded(struct lp55xx_chip *chip)
> const struct firmware *fw = chip->fw;
>
> if (fw->size > LP5523_PROGRAM_LENGTH) {
> - dev_err(&chip->cl->dev, "firmware data size overflow: %d\n",
> + dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
> fw->size);
> return;
> }
> --
> 1.7.9.5
>
>
> Best Regards,
> Milo
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-23 23:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-23 23:43 [PATCH v2] leds-lp5521/3: use '%zu' for formatting 'size_t' Kim, Milo
2013-01-23 23:46 ` Bryan Wu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.