[PATCH] leds-mc13783: set platform data to NULL at mc13783_led_remove

[PATCH] leds-mc13783: set platform data to NULL at mc13783_led_remove

[Devendra Naga]

the platform_set_drvdata (pdev, NULL) to be set at the remove of the
driver, as we have set the platform data to led at probe.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
 drivers/leds/leds-mc13783.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
index 4cc6a2e..6515c11 100644
--- a/drivers/leds/leds-mc13783.c
+++ b/drivers/leds/leds-mc13783.c
@@ -372,6 +372,7 @@ static int __devexit mc13783_led_remove(struct platform_device *pdev)
 
 	mc13xxx_unlock(dev);
 
+	platform_set_drvdata(pdev, NULL);
 	kfree(led);
 	return 0;
 }
-- 
1.7.9.5

Re: [PATCH] leds-mc13783: set platform data to NULL at mc13783_led_remove

[Bryan Wu]

On Mon, Jul 2, 2012 at 4:40 PM, Devendra Naga <devendra.aaru@gmail.com> wrote:
> the platform_set_drvdata (pdev, NULL) to be set at the remove of the
> driver, as we have set the platform data to led at probe.
>
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>

Nice catch. I applied this patch in my for-next branch.

But I also find the same issue in other LED drivers, are you
interested in fixing them?

Thanks,
-Bryan

> ---
>  drivers/leds/leds-mc13783.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
> index 4cc6a2e..6515c11 100644
> --- a/drivers/leds/leds-mc13783.c
> +++ b/drivers/leds/leds-mc13783.c
> @@ -372,6 +372,7 @@ static int __devexit mc13783_led_remove(struct platform_device *pdev)
>
>         mc13xxx_unlock(dev);
>
> +       platform_set_drvdata(pdev, NULL);
>         kfree(led);
>         return 0;
>  }
> --
> 1.7.9.5
>



-- 
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com

Re: [PATCH] leds-mc13783: set platform data to NULL at mc13783_led_remove

[devendra.aaru]

On Mon, Jul 2, 2012 at 7:23 PM, Bryan Wu <bryan.wu@canonical.com> wrote:
> On Mon, Jul 2, 2012 at 4:40 PM, Devendra Naga <devendra.aaru@gmail.com> wrote:
>> the platform_set_drvdata (pdev, NULL) to be set at the remove of the
>> driver, as we have set the platform data to led at probe.
>>
>> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
>
> Nice catch. I applied this patch in my for-next branch.
>
> But I also find the same issue in other LED drivers, are you
> interested in fixing them?
>
Yes, i will do those.
I will send out changes...
> Thanks,
> -Bryan
>

Thanks
>> ---
>>  drivers/leds/leds-mc13783.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
>> index 4cc6a2e..6515c11 100644
>> --- a/drivers/leds/leds-mc13783.c
>> +++ b/drivers/leds/leds-mc13783.c
>> @@ -372,6 +372,7 @@ static int __devexit mc13783_led_remove(struct platform_device *pdev)
>>
>>         mc13xxx_unlock(dev);
>>
>> +       platform_set_drvdata(pdev, NULL);
>>         kfree(led);
>>         return 0;
>>  }
>> --
>> 1.7.9.5
>>
>
>
>
> --
> Bryan Wu <bryan.wu@canonical.com>
> Kernel Developer    +86.186-168-78255 Mobile
> Canonical Ltd.      www.canonical.com
> Ubuntu - Linux for human beings | www.ubuntu.com

Re: [PATCH] leds-mc13783: set platform data to NULL at mc13783_led_remove

[devendra.aaru]

Hi Bryan,

I Made all the necessary changes, and it touched 21 drivers overall,
and i compile tested all except leds-sunfire as i dont have a
cross-toolchain for that.
all patches are compile tested with

gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3, ( my machine's)
arm-linux-gnueabihf-gcc (crosstool-NG linaro-1.13.1-2012.05-20120523 -
Linaro GCC 2012.05) 4.7.1 20120514 (prerelease) (ARM toolchain's)

at each cross-compile of a driver i selected the defconfig of each
machine, fox ex. for leds-netxbig i chose kirkwood-defconfig, and for
leds-s3c24xx i chose s3c2410_defconfig.

Now i have only 1 question in mind :).

do i need to submit all in a single patch? or patch per driver?

Thanks,
Devendra.

Re: [PATCH] leds-mc13783: set platform data to NULL at mc13783_led_remove

[Bryan Wu]

On Tue, Jul 3, 2012 at 2:10 AM, devendra.aaru <devendra.aaru@gmail.com> wrote:
> Hi Bryan,
>
> I Made all the necessary changes, and it touched 21 drivers overall,
> and i compile tested all except leds-sunfire as i dont have a
> cross-toolchain for that.
> all patches are compile tested with
>
> gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3, ( my machine's)
> arm-linux-gnueabihf-gcc (crosstool-NG linaro-1.13.1-2012.05-20120523 -
> Linaro GCC 2012.05) 4.7.1 20120514 (prerelease) (ARM toolchain's)
>
> at each cross-compile of a driver i selected the defconfig of each
> machine, fox ex. for leds-netxbig i chose kirkwood-defconfig, and for
> leds-s3c24xx i chose s3c2410_defconfig.
>

Very good, thanks a lot.

> Now i have only 1 question in mind :).
>
> do i need to submit all in a single patch? or patch per driver?
>

I prefer to one patch per driver and please add the driver maintainers
in you Cc list of each patch.

-Bryan