* [PATCH v2] scripts/checkstack.pl: Fix arm64 wrong or unknown architecture
@ 2019-06-03 14:30 ` George G. Davis
0 siblings, 0 replies; 5+ messages in thread
From: George G. Davis @ 2019-06-03 14:30 UTC (permalink / raw)
To: Masahiro Yamada, Andy Whitcroft, Joe Perches, Catalin Marinas,
Will Deacon, linux-arm-kernel, Michal Marek, linux-kbuild,
Qian Cai, Andrew Morton, George G. Davis, Breno Leitao,
Michael Ellerman, open list
The following error occurs for the `make ARCH=arm64 checkstack` case:
aarch64-linux-gnu-objdump -d vmlinux $(find . -name '*.ko') | \
perl ./scripts/checkstack.pl arm64
wrong or unknown architecture "arm64"
As suggested by Masahiro Yamada, fix the above error using regular
expressions in the same way it was fixed for the `ARCH=x86` case via
commit fda9f9903be6 ("scripts/checkstack.pl: automatically handle
32-bit and 64-bit mode for ARCH=x86").
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: George G. Davis <george_davis@mentor.com>
---
v1:
- https://patchwork.kernel.org/patch/10970393/
v2:
- Updates as Suggested-by: Masahiro Yamada
- Update commit subject due to moving the fix from Makefile to
checkstack.pl
---
scripts/checkstack.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
index 122aef5e4e14..371bd17a4983 100755
--- a/scripts/checkstack.pl
+++ b/scripts/checkstack.pl
@@ -46,7 +46,7 @@ my (@stack, $re, $dre, $x, $xs, $funcre);
$x = "[0-9a-f]"; # hex character
$xs = "[0-9a-f ]"; # hex character or space
$funcre = qr/^$x* <(.*)>:$/;
- if ($arch eq 'aarch64') {
+ if ($arch =~ '^(aarch|arm)64$') {
#ffffffc0006325cc: a9bb7bfd stp x29, x30, [sp, #-80]!
#a110: d11643ff sub sp, sp, #0x590
$re = qr/^.*stp.*sp, \#-([0-9]{1,8})\]\!/o;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] scripts/checkstack.pl: Fix arm64 wrong or unknown architecture
@ 2019-06-03 14:30 ` George G. Davis
0 siblings, 0 replies; 5+ messages in thread
From: George G. Davis @ 2019-06-03 14:30 UTC (permalink / raw)
To: Masahiro Yamada, Andy Whitcroft, Joe Perches, Catalin Marinas,
Will Deacon, linux-arm-kernel, Michal Marek, linux-kbuild,
Qian Cai, Andrew Morton, George G. Davis, Breno Leitao,
Michael Ellerman, open list
The following error occurs for the `make ARCH=arm64 checkstack` case:
aarch64-linux-gnu-objdump -d vmlinux $(find . -name '*.ko') | \
perl ./scripts/checkstack.pl arm64
wrong or unknown architecture "arm64"
As suggested by Masahiro Yamada, fix the above error using regular
expressions in the same way it was fixed for the `ARCH=x86` case via
commit fda9f9903be6 ("scripts/checkstack.pl: automatically handle
32-bit and 64-bit mode for ARCH=x86").
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: George G. Davis <george_davis@mentor.com>
---
v1:
- https://patchwork.kernel.org/patch/10970393/
v2:
- Updates as Suggested-by: Masahiro Yamada
- Update commit subject due to moving the fix from Makefile to
checkstack.pl
---
scripts/checkstack.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
index 122aef5e4e14..371bd17a4983 100755
--- a/scripts/checkstack.pl
+++ b/scripts/checkstack.pl
@@ -46,7 +46,7 @@ my (@stack, $re, $dre, $x, $xs, $funcre);
$x = "[0-9a-f]"; # hex character
$xs = "[0-9a-f ]"; # hex character or space
$funcre = qr/^$x* <(.*)>:$/;
- if ($arch eq 'aarch64') {
+ if ($arch =~ '^(aarch|arm)64$') {
#ffffffc0006325cc: a9bb7bfd stp x29, x30, [sp, #-80]!
#a110: d11643ff sub sp, sp, #0x590
$re = qr/^.*stp.*sp, \#-([0-9]{1,8})\]\!/o;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] scripts/checkstack.pl: Fix arm64 wrong or unknown architecture
@ 2019-06-03 14:30 ` George G. Davis
0 siblings, 0 replies; 5+ messages in thread
From: George G. Davis @ 2019-06-03 14:30 UTC (permalink / raw)
To: Masahiro Yamada, Andy Whitcroft, Joe Perches, Catalin Marinas,
Will Deacon, linux-arm-kernel, Michal Marek, linux-kbuild,
Qian Cai, Andrew Morton, George G. Davis, Breno Leitao,
Michael Ellerman, open list
The following error occurs for the `make ARCH=arm64 checkstack` case:
aarch64-linux-gnu-objdump -d vmlinux $(find . -name '*.ko') | \
perl ./scripts/checkstack.pl arm64
wrong or unknown architecture "arm64"
As suggested by Masahiro Yamada, fix the above error using regular
expressions in the same way it was fixed for the `ARCH=x86` case via
commit fda9f9903be6 ("scripts/checkstack.pl: automatically handle
32-bit and 64-bit mode for ARCH=x86").
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: George G. Davis <george_davis@mentor.com>
---
v1:
- https://patchwork.kernel.org/patch/10970393/
v2:
- Updates as Suggested-by: Masahiro Yamada
- Update commit subject due to moving the fix from Makefile to
checkstack.pl
---
scripts/checkstack.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
index 122aef5e4e14..371bd17a4983 100755
--- a/scripts/checkstack.pl
+++ b/scripts/checkstack.pl
@@ -46,7 +46,7 @@ my (@stack, $re, $dre, $x, $xs, $funcre);
$x = "[0-9a-f]"; # hex character
$xs = "[0-9a-f ]"; # hex character or space
$funcre = qr/^$x* <(.*)>:$/;
- if ($arch eq 'aarch64') {
+ if ($arch =~ '^(aarch|arm)64$') {
#ffffffc0006325cc: a9bb7bfd stp x29, x30, [sp, #-80]!
#a110: d11643ff sub sp, sp, #0x590
$re = qr/^.*stp.*sp, \#-([0-9]{1,8})\]\!/o;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] scripts/checkstack.pl: Fix arm64 wrong or unknown architecture
2019-06-03 14:30 ` George G. Davis
@ 2019-06-04 0:21 ` Masahiro Yamada
-1 siblings, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2019-06-04 0:21 UTC (permalink / raw)
To: George G. Davis
Cc: Andy Whitcroft, Joe Perches, Catalin Marinas, Will Deacon,
linux-arm-kernel, Michal Marek, Linux Kbuild mailing list,
Qian Cai, Andrew Morton, Breno Leitao, Michael Ellerman,
open list
On Mon, Jun 3, 2019 at 11:31 PM George G. Davis <george_davis@mentor.com> wrote:
>
> The following error occurs for the `make ARCH=arm64 checkstack` case:
>
> aarch64-linux-gnu-objdump -d vmlinux $(find . -name '*.ko') | \
> perl ./scripts/checkstack.pl arm64
> wrong or unknown architecture "arm64"
>
> As suggested by Masahiro Yamada, fix the above error using regular
> expressions in the same way it was fixed for the `ARCH=x86` case via
> commit fda9f9903be6 ("scripts/checkstack.pl: automatically handle
> 32-bit and 64-bit mode for ARCH=x86").
>
> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: George G. Davis <george_davis@mentor.com>
> ---
Applied to linux-kbuild/fixes. Thanks.
> v1:
> - https://patchwork.kernel.org/patch/10970393/
> v2:
> - Updates as Suggested-by: Masahiro Yamada
> - Update commit subject due to moving the fix from Makefile to
> checkstack.pl
> ---
> scripts/checkstack.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
> index 122aef5e4e14..371bd17a4983 100755
> --- a/scripts/checkstack.pl
> +++ b/scripts/checkstack.pl
> @@ -46,7 +46,7 @@ my (@stack, $re, $dre, $x, $xs, $funcre);
> $x = "[0-9a-f]"; # hex character
> $xs = "[0-9a-f ]"; # hex character or space
> $funcre = qr/^$x* <(.*)>:$/;
> - if ($arch eq 'aarch64') {
> + if ($arch =~ '^(aarch|arm)64$') {
> #ffffffc0006325cc: a9bb7bfd stp x29, x30, [sp, #-80]!
> #a110: d11643ff sub sp, sp, #0x590
> $re = qr/^.*stp.*sp, \#-([0-9]{1,8})\]\!/o;
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] scripts/checkstack.pl: Fix arm64 wrong or unknown architecture
@ 2019-06-04 0:21 ` Masahiro Yamada
0 siblings, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2019-06-04 0:21 UTC (permalink / raw)
To: George G. Davis
Cc: Michal Marek, Linux Kbuild mailing list, Catalin Marinas,
Will Deacon, open list, Breno Leitao, Joe Perches, Qian Cai,
Michael Ellerman, Andy Whitcroft, Andrew Morton,
linux-arm-kernel
On Mon, Jun 3, 2019 at 11:31 PM George G. Davis <george_davis@mentor.com> wrote:
>
> The following error occurs for the `make ARCH=arm64 checkstack` case:
>
> aarch64-linux-gnu-objdump -d vmlinux $(find . -name '*.ko') | \
> perl ./scripts/checkstack.pl arm64
> wrong or unknown architecture "arm64"
>
> As suggested by Masahiro Yamada, fix the above error using regular
> expressions in the same way it was fixed for the `ARCH=x86` case via
> commit fda9f9903be6 ("scripts/checkstack.pl: automatically handle
> 32-bit and 64-bit mode for ARCH=x86").
>
> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: George G. Davis <george_davis@mentor.com>
> ---
Applied to linux-kbuild/fixes. Thanks.
> v1:
> - https://patchwork.kernel.org/patch/10970393/
> v2:
> - Updates as Suggested-by: Masahiro Yamada
> - Update commit subject due to moving the fix from Makefile to
> checkstack.pl
> ---
> scripts/checkstack.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
> index 122aef5e4e14..371bd17a4983 100755
> --- a/scripts/checkstack.pl
> +++ b/scripts/checkstack.pl
> @@ -46,7 +46,7 @@ my (@stack, $re, $dre, $x, $xs, $funcre);
> $x = "[0-9a-f]"; # hex character
> $xs = "[0-9a-f ]"; # hex character or space
> $funcre = qr/^$x* <(.*)>:$/;
> - if ($arch eq 'aarch64') {
> + if ($arch =~ '^(aarch|arm)64$') {
> #ffffffc0006325cc: a9bb7bfd stp x29, x30, [sp, #-80]!
> #a110: d11643ff sub sp, sp, #0x590
> $re = qr/^.*stp.*sp, \#-([0-9]{1,8})\]\!/o;
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-04 0:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 14:30 [PATCH v2] scripts/checkstack.pl: Fix arm64 wrong or unknown architecture George G. Davis
2019-06-03 14:30 ` George G. Davis
2019-06-03 14:30 ` George G. Davis
2019-06-04 0:21 ` Masahiro Yamada
2019-06-04 0:21 ` Masahiro Yamada
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.