From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andreas Faerber <afaerber@suse.com>
Subject: Re: [PATCH] Makefile: disable PIE before testing asm goto
Date: Thu, 17 May 2018 22:34:12 +0900 [thread overview]
Message-ID: <CAK7LNAQB_J1WwaV-8a66KyCfG3bNqNwA9zb08Vph=zn73A-i9Q@mail.gmail.com> (raw)
In-Reply-To: <20180516055136.6F4EAA095A@unicorn.suse.cz>
2018-05-16 14:51 GMT+09:00 Michal Kubecek <mkubecek@suse.cz>:
> Since commit e501ce957a78 ("x86: Force asm-goto"), aarch64 build on
> distributions which enable PIE by default (e.g. openSUSE Tumbleweed) does
> not detect support for asm goto correctly. The problem is that ARM specific
> part of scripts/gcc-goto.sh fails with PIE even with recent gcc versions.
> Moving the asm goto detection up in Makefile put it before the place where
> we disable PIE. As a result, kernel is built without jump label support.
>
> Move the lines disabling PIE before the asm goto test to make it work.
>
> Fixes: e501ce957a78 ("x86: Force asm-goto")
> Reported-by: Andreas Faerber <afaerber@suse.com>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> ---
Applied to linux-kbuild/fixes. Thanks!
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2018-05-17 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 5:51 [PATCH] Makefile: disable PIE before testing asm goto Michal Kubecek
2018-05-16 8:16 ` Peter Zijlstra
2018-05-17 13:34 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAQB_J1WwaV-8a66KyCfG3bNqNwA9zb08Vph=zn73A-i9Q@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=afaerber@suse.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mkubecek@suse.cz \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.