From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: "Luis R . Rodriguez" <mcgrof@kernel.org>,
kernel-janitors@vger.kernel.org,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>,
cocci@systeme.lip6.fr,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful
Date: Thu, 26 Oct 2017 10:49:28 +0900 [thread overview]
Message-ID: <CAK7LNAQMTptVYLu10uF+85OsuANbC7Fo0heD4t1ybpUE6Yh-gQ@mail.gmail.com> (raw)
In-Reply-To: <1508061353-24744-1-git-send-email-Julia.Lawall@lip6.fr>
Hi Julia,
2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> patch, and bailed if it already existed. This meant that DEBUG_FILE was
> useless for checking more than one semantic patch at a time. Now the check
> is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> append to the file on each semantic patch. Furthermore, the spatch command
> that is run for each semantic patch is also added to the DEBUG_FILE, to
> make clear what each stdout trace corresponds to.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
I think this is a good improvement,
and looks almost good to me.
Just one nit.
>
> }
>
> +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> + if [ -f $DEBUG_FILE ]; then
> + echo "Debug file $DEBUG_FILE exists, bailing"
> + exit
> + fi
> + touch $DEBUG_FILE
I think this "touch" is redundant.
If the DEBUG_FILE does not exist, 2>> will automatically create it.
> +else
> + DEBUG_FILE="/dev/null"
> +fi
> +
> if [ "$COCCI" = "" ] ; then
> for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> coccinelle $f
>
--
Best Regards
Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: cocci@systeme.lip6.fr
Subject: Re: [PATCH] Coccinelle: make DEBUG_FILE option more useful
Date: Thu, 26 Oct 2017 01:49:28 +0000 [thread overview]
Message-ID: <CAK7LNAQMTptVYLu10uF+85OsuANbC7Fo0heD4t1ybpUE6Yh-gQ@mail.gmail.com> (raw)
In-Reply-To: <1508061353-24744-1-git-send-email-Julia.Lawall@lip6.fr>
Hi Julia,
2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> patch, and bailed if it already existed. This meant that DEBUG_FILE was
> useless for checking more than one semantic patch at a time. Now the check
> is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> append to the file on each semantic patch. Furthermore, the spatch command
> that is run for each semantic patch is also added to the DEBUG_FILE, to
> make clear what each stdout trace corresponds to.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
I think this is a good improvement,
and looks almost good to me.
Just one nit.
>
> }
>
> +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> + if [ -f $DEBUG_FILE ]; then
> + echo "Debug file $DEBUG_FILE exists, bailing"
> + exit
> + fi
> + touch $DEBUG_FILE
I think this "touch" is redundant.
If the DEBUG_FILE does not exist, 2>> will automatically create it.
> +else
> + DEBUG_FILE="/dev/null"
> +fi
> +
> if [ "$COCCI" = "" ] ; then
> for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> coccinelle $f
>
--
Best Regards
Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: yamada.masahiro@socionext.com (Masahiro Yamada)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH] Coccinelle: make DEBUG_FILE option more useful
Date: Thu, 26 Oct 2017 10:49:28 +0900 [thread overview]
Message-ID: <CAK7LNAQMTptVYLu10uF+85OsuANbC7Fo0heD4t1ybpUE6Yh-gQ@mail.gmail.com> (raw)
In-Reply-To: <1508061353-24744-1-git-send-email-Julia.Lawall@lip6.fr>
Hi Julia,
2017-10-15 18:55 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> Make coccicheck checked for the existence of DEBUG_FILE on each semantic
> patch, and bailed if it already existed. This meant that DEBUG_FILE was
> useless for checking more than one semantic patch at a time. Now the check
> is moved to the start of make coccicheck, and the 2> is changed to a 2>> to
> append to the file on each semantic patch. Furthermore, the spatch command
> that is run for each semantic patch is also added to the DEBUG_FILE, to
> make clear what each stdout trace corresponds to.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
I think this is a good improvement,
and looks almost good to me.
Just one nit.
>
> }
>
> +if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> + if [ -f $DEBUG_FILE ]; then
> + echo "Debug file $DEBUG_FILE exists, bailing"
> + exit
> + fi
> + touch $DEBUG_FILE
I think this "touch" is redundant.
If the DEBUG_FILE does not exist, 2>> will automatically create it.
> +else
> + DEBUG_FILE="/dev/null"
> +fi
> +
> if [ "$COCCI" = "" ] ; then
> for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> coccinelle $f
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2017-10-26 1:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 9:55 [PATCH] Coccinelle: make DEBUG_FILE option more useful Julia Lawall
2017-10-15 9:55 ` [Cocci] " Julia Lawall
2017-10-15 9:55 ` Julia Lawall
2017-10-26 1:49 ` Masahiro Yamada [this message]
2017-10-26 1:49 ` [Cocci] " Masahiro Yamada
2017-10-26 1:49 ` Masahiro Yamada
2017-10-26 4:02 ` Julia Lawall
2017-10-26 4:02 ` [Cocci] " Julia Lawall
2017-10-26 4:02 ` Julia Lawall
2017-11-07 0:24 ` Masahiro Yamada
2017-11-07 0:24 ` [Cocci] " Masahiro Yamada
2017-11-07 0:24 ` Masahiro Yamada
2017-11-08 13:02 ` Julia Lawall
2017-11-08 13:02 ` [Cocci] " Julia Lawall
2017-11-08 13:02 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQMTptVYLu10uF+85OsuANbC7Fo0heD4t1ybpUE6Yh-gQ@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.