* [PATCH] Top Makefile: tiny correction on `make help`
@ 2017-05-29 3:21 ` Cao jin
0 siblings, 0 replies; 4+ messages in thread
From: Cao jin @ 2017-05-29 3:21 UTC (permalink / raw)
To: yamada.masahiro, mmarek; +Cc: linux-kbuild, linux-kernel
The help info of `make -C=1` is little confusing, make it clear.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index efa267a..b34a34d 100644
--- a/Makefile
+++ b/Makefile
@@ -1417,7 +1417,7 @@ help:
@echo ' make V=0|1 [targets] 0 => quiet build (default), 1 => verbose build'
@echo ' make V=2 [targets] 2 => give reason for rebuild of target'
@echo ' make O=dir [targets] Locate all output files in "dir", including .config'
- @echo ' make C=1 [targets] Check all c source with $$CHECK (sparse by default)'
+ @echo ' make C=1 [targets] Check re-compiled c source only with $$CHECK (sparse by default)'
@echo ' make C=2 [targets] Force check of all c source with $$CHECK'
@echo ' make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections'
@echo ' make W=n [targets] Enable extra gcc checks, n=1,2,3 where'
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Top Makefile: tiny correction on `make help`
@ 2017-05-29 3:21 ` Cao jin
0 siblings, 0 replies; 4+ messages in thread
From: Cao jin @ 2017-05-29 3:21 UTC (permalink / raw)
To: yamada.masahiro, mmarek; +Cc: linux-kbuild, linux-kernel
The help info of `make -C=1` is little confusing, make it clear.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index efa267a..b34a34d 100644
--- a/Makefile
+++ b/Makefile
@@ -1417,7 +1417,7 @@ help:
@echo ' make V=0|1 [targets] 0 => quiet build (default), 1 => verbose build'
@echo ' make V=2 [targets] 2 => give reason for rebuild of target'
@echo ' make O=dir [targets] Locate all output files in "dir", including .config'
- @echo ' make C=1 [targets] Check all c source with $$CHECK (sparse by default)'
+ @echo ' make C=1 [targets] Check re-compiled c source only with $$CHECK (sparse by default)'
@echo ' make C=2 [targets] Force check of all c source with $$CHECK'
@echo ' make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections'
@echo ' make W=n [targets] Enable extra gcc checks, n=1,2,3 where'
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Top Makefile: tiny correction on `make help`
2017-05-29 3:21 ` Cao jin
(?)
@ 2017-06-06 1:47 ` Masahiro Yamada
2017-06-06 8:51 ` Cao jin
-1 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2017-06-06 1:47 UTC (permalink / raw)
To: Cao jin
Cc: Michal Marek, Linux Kbuild mailing list, Linux Kernel Mailing List
Hi Cao,
2017-05-29 12:21 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
> The help info of `make -C=1` is little confusing, make it clear.
`make C=1` instead of `make -C=1`
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index efa267a..b34a34d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1417,7 +1417,7 @@ help:
> @echo ' make V=0|1 [targets] 0 => quiet build (default), 1 => verbose build'
> @echo ' make V=2 [targets] 2 => give reason for rebuild of target'
> @echo ' make O=dir [targets] Locate all output files in "dir", including .config'
> - @echo ' make C=1 [targets] Check all c source with $$CHECK (sparse by default)'
> + @echo ' make C=1 [targets] Check re-compiled c source only with $$CHECK (sparse by default)'
> @echo ' make C=2 [targets] Force check of all c source with $$CHECK'
> @echo ' make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections'
> @echo ' make W=n [targets] Enable extra gcc checks, n=1,2,3 where'
Which phrase is qualified by "only"?
[1] re-compiled c source only
[2] only with $$CHECK
I know [1] is what you mean (sorry for my nitpicking).
Perhaps, "Check only re-compiled c source with $$CHECK" is even clearer?
(or, just drop "only" because "re-compiled c source" is understandable enough ?)
Could you use "kbuild: " instead of "Top Makefile" in the subject?
Thanks.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Top Makefile: tiny correction on `make help`
2017-06-06 1:47 ` Masahiro Yamada
@ 2017-06-06 8:51 ` Cao jin
0 siblings, 0 replies; 4+ messages in thread
From: Cao jin @ 2017-06-06 8:51 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Michal Marek, Linux Kbuild mailing list, Linux Kernel Mailing List
Mr Masahiro,
On 06/06/2017 09:47 AM, Masahiro Yamada wrote:
> Hi Cao,
>
>
> 2017-05-29 12:21 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
>> The help info of `make -C=1` is little confusing, make it clear.
>
> `make C=1` instead of `make -C=1`
>
>
>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>> ---
>> Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index efa267a..b34a34d 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1417,7 +1417,7 @@ help:
>> @echo ' make V=0|1 [targets] 0 => quiet build (default), 1 => verbose build'
>> @echo ' make V=2 [targets] 2 => give reason for rebuild of target'
>> @echo ' make O=dir [targets] Locate all output files in "dir", including .config'
>> - @echo ' make C=1 [targets] Check all c source with $$CHECK (sparse by default)'
>> + @echo ' make C=1 [targets] Check re-compiled c source only with $$CHECK (sparse by default)'
>> @echo ' make C=2 [targets] Force check of all c source with $$CHECK'
>> @echo ' make RECORDMCOUNT_WARN=1 [targets] Warn about ignored mcount sections'
>> @echo ' make W=n [targets] Enable extra gcc checks, n=1,2,3 where'
>
> Which phrase is qualified by "only"?
>
> [1] re-compiled c source only
> [2] only with $$CHECK
>
> I know [1] is what you mean (sorry for my nitpicking).
>
You are right, after reading it again, I myself have the same feeling as
you...
>
> Perhaps, "Check only re-compiled c source with $$CHECK" is even clearer?
>
> (or, just drop "only" because "re-compiled c source" is understandable enough ?)
I prefer the latter one.
>
>
> Could you use "kbuild: " instead of "Top Makefile" in the subject?
>
Sure.
Thanks very much for your suggestion:)
--
Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-06 8:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-29 3:21 [PATCH] Top Makefile: tiny correction on `make help` Cao jin
2017-05-29 3:21 ` Cao jin
2017-06-06 1:47 ` Masahiro Yamada
2017-06-06 8:51 ` Cao jin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.